From nobody Wed Apr 8 04:57:18 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39E1B35AC26 for ; Tue, 10 Mar 2026 21:22:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773177772; cv=none; b=ALkkM0yA4QMwW7uLXe/iNfrO8EIxJjOPGohFuPd3lS6ZT27mvIOLjQbLxJ0l2mAKxLneY4M8HZwKpOhhIDkkLR3U6D5bmjD6byHlTamQCGNHj9pewemdM1XCy2VYr0h2ZTpl0kiCpkQlpC69zqMIxhjYmjmpxJF9smPdLtlweBg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773177772; c=relaxed/simple; bh=IvGII0Yt/19qZKnIYpWtvpz5Dtp/omOYGCRq7UkCRbA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bukJLirWAdo4uMJeJI+DxQs2h4XkdMd5lcKW4vtn4tZiLNrokNE7AqHTwGb67Qwg7QZVMTTjFZrsLuUg/Nk8AItS9RAQMFDwBany5i5rFieHucya9qRBkhnYXkpBL4SUhQue7LokBnrntmdqfgfKVQJBtZ6vVFdeKey50b5gkyE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=rqK1drnd; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="rqK1drnd" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2ae5636ab04so100454805ad.3 for ; Tue, 10 Mar 2026 14:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1773177769; x=1773782569; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mgBw4DlbHXB4kGfTTmSAa0HOfHAq4IWmv5ZPrMQMbQQ=; b=rqK1drndQjQBW9XCLRKZ+QwP2OHdoTNisYOZTYA0uDK9yGzsn4jFJ2hf58gmqhOLSL pLRWtLqstqH6poY6i9xb/EI4CGc4ZkeIkGSbkoDz/1c7T0Vr8noVgjhqXafpzgc4Wu91 SSabt37VQgz7xoxgRzosO6Pw+/UG2k7FQM6wEkvdsIIHoJsQV5QU07WxVNfsxQZgqU6Q B5oMrTt9dyRdiDpG0QELYJXd+12bahpEgv7gFAjEUIczPlRfCYRdSb4uqTnDL4oDhCFD 3H1ORrw6tNWfaoq1MnJ6kdxsrWIwe18/cfS49lv0EkGz1EEB1WA/t3v2xR+cUsSTKnrm Kj1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773177769; x=1773782569; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mgBw4DlbHXB4kGfTTmSAa0HOfHAq4IWmv5ZPrMQMbQQ=; b=MV+pk2FjC+NcIbQT6HJRe2S8ppfHlXMbH6wbscwtc026uwalCJ7j+iuxN5ftKMg135 IHRHUJWbhWkbhGafd80aVCDxufoNp9fFnPtlLE11GNk1uScMpjlNsnoVKfIsiqq8884m AsWtWUBWZeQPjqh7xnPqUJZj2diwNYLwU7+ZOqXn/tXrNHgsJaKwHcBad4ZmesBxMu8F vEh4yp6bkGU6xCOnP4T+fd4hFKATCfYBo8Q7WIQxbRjFgL8LjISv17PJnOIyTFszl939 QED4ZypCbRHsEMxBvCje4uOxlhFhtDpj/nqA/1Cphx5pqDPNxouDfEcZaCiZNTQVWRk8 6peA== X-Gm-Message-State: AOJu0Yxl11iUL2UVDYRQ1cX2qfiRjEAQiEaNLbdnJtaP37G8mZiDUnjs K97rQpwMYwQUrnSa6qJEbBTdr90JuSNv9eN44Ske332BhcHcLnMpiudEBmwzvIVB7JA= X-Gm-Gg: ATEYQzwKje8LyoJLI5kBz/tnn2xp3iCoq4twRg+sw3N+dCbnFYCyexOw/boPtHHYlc+ kBvY1aVIpvhKx1OwOIuOoXVfZ0yP1542HtkEZOrtwQzI/VSFLkQ3CusLJVQfS6bFS1AnQfc3rhg o88a6dzj7SZdNfcDSXtWmNrPGHpLnmPYjO4v6CDavnsbb6ELzP6HWlcB1PXesu8GiO5i6d2/bKe hqh4UmePy8+xeTWbPE7pluQUjeFEu31LK3G0Y27dA3yOpyH4t5TK4KRWLZVWW2t6/drTKM2RC4E 8AbiX3AcmyE487/6yz6Mxja9rYTmJD/Km3iea9aYGHLdJSb65gihzGVNEd/xwY9wHPTccXSAml9 5ODo2mGfYq2psBvBGjFsfsztoBva8Xc70W2cYF5F8CSzS5nuXGQyOqWmADQboVncbDfDsmPAjAn IHvcOt X-Received: by 2002:a17:903:41d0:b0:2ae:4a74:abdf with SMTP id d9443c01a7336-2aeae767fa3mr2410195ad.9.1773177769437; Tue, 10 Mar 2026 14:22:49 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:74::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae34de20sm1774285ad.60.2026.03.10.14.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 14:22:49 -0700 (PDT) From: Joe Damato To: netdev@vger.kernel.org, Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-kernel@vger.kernel.org, Joe Damato Subject: [RFC net-next 04/10] net: bnxt: Add a helper for tx_bd_ext Date: Tue, 10 Mar 2026 14:21:52 -0700 Message-ID: <20260310212209.2263939-5-joe@dama.to> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260310212209.2263939-1-joe@dama.to> References: <20260310212209.2263939-1-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Factor out some code to setup tx_bd_exts into a helper function. This helper will be used by SW USO implementation in the following commits. Suggested-by: Jakub Kicinski Signed-off-by: Joe Damato --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 ++------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethern= et/broadcom/bnxt/bnxt.c index 5033aab2d3a6..c52db7135ded 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -664,10 +664,9 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb= , struct net_device *dev) txbd->tx_bd_opaque =3D SET_TX_OPAQUE(bp, txr, prod, 2 + last_frag); =20 prod =3D NEXT_TX(prod); - txbd1 =3D (struct tx_bd_ext *) - &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1 =3D bnxt_init_ext_bd(bp, txr, prod, lflags, vlan_tag_flags, + cfa_action); =20 - txbd1->tx_bd_hsize_lflags =3D lflags; if (skb_is_gso(skb)) { bool udp_gso =3D !!(skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4); u32 hdr_len; @@ -694,7 +693,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) } else if (skb->ip_summed =3D=3D CHECKSUM_PARTIAL) { txbd1->tx_bd_hsize_lflags |=3D cpu_to_le32(TX_BD_FLAGS_TCP_UDP_CHKSUM); - txbd1->tx_bd_mss =3D 0; } =20 length >>=3D 9; @@ -707,9 +705,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) flags |=3D bnxt_lhint_arr[length]; txbd->tx_bd_len_flags_type =3D cpu_to_le32(flags); =20 - txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); - txbd1->tx_bd_cfa_action =3D - cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); txbd0 =3D txbd; for (i =3D 0; i < last_frag; i++) { frag =3D &skb_shinfo(skb)->frags[i]; diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethern= et/broadcom/bnxt/bnxt.h index 48c91cdf1975..c5dd341e7d95 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h @@ -2820,6 +2820,24 @@ static inline u32 bnxt_tx_avail(struct bnxt *bp, return bp->tx_ring_size - (used & bp->tx_ring_mask); } =20 +static inline struct tx_bd_ext * +bnxt_init_ext_bd(struct bnxt *bp, struct bnxt_tx_ring_info *txr, + u16 prod, __le32 lflags, u32 vlan_tag_flags, + u32 cfa_action) +{ + struct tx_bd_ext *txbd1; + + txbd1 =3D (struct tx_bd_ext *) + &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1->tx_bd_hsize_lflags =3D lflags; + txbd1->tx_bd_mss =3D 0; + txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); + txbd1->tx_bd_cfa_action =3D + cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); + + return txbd1; +} + static inline void bnxt_writeq(struct bnxt *bp, u64 val, volatile void __iomem *addr) { --=20 2.52.0