From nobody Wed Apr 8 03:07:41 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C527368272 for ; Tue, 10 Mar 2026 20:36:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773174987; cv=none; b=pk8Fe6frJ9aFBx/03HvpEBiOiqlguq4c3lAmG95WH6kS/JX4hCH7JQ2wuNYkJPczQB8GVKtva69MMaC4VHV76d0kshClbfl+pWfVu2x/WOGvSiTKAwcvXNK0MncFMPV+yJJTD69RUM9SEWNvMP+Td26H9pqjfarx0DR1rTtZlJI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773174987; c=relaxed/simple; bh=UxKU/c+6UtfxgiXtYB9CIvu6YNjRUy0H34f8efaNJiA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nn+2cBS7uOSH4g1Ee5nlDH0eQT91JDyfkVzCrJX9kdHWcuXu0eTES1sC9AeyzlvUbwz9Q3oWuyC6IaKSjIzN45Wo6lc2BBiiafZbzt01x0dcY3pD1MOVpZEOI2d6APWhv/NEEcbL5UlhL5Y/4lQM4t2nqT0JEi4+dpUtLREnP90= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ApFSVtlX; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ApFSVtlX" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-48374014a77so158548665e9.3 for ; Tue, 10 Mar 2026 13:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773174984; x=1773779784; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YWC89SNBP14Ak3zMdsjrEcAqrqhx0MSOXRT5kJJSs2w=; b=ApFSVtlXYwA/qlgT4bALmslYxlxt8LNSYXM2xDUG7fhLpE4H2Rj/22Jr65FsbArQw+ t9KPJSjeKJfytlDpbUl1D1BbKTRs1IGgZgULhI+O3KkHXIYFPD9CJwrqbD+osLJrx8Vp Sl83DPTceJPogiY4s0+kZ8kXBkBEkaJJ0U7VPNHzkFjxRQ02mPEBsMKzj9ewTB/icMQv A1Gqbpf23YEgvFkD+eDT7iwvOf2+Alp4+uSEfh9hXrBfuK3+IDt+eCuQCtmOnfd5JgR2 DEe1IVimuFSiqnxOm4BodrKDGtik0HJIhYEXeYsBB6ZnES/rI6zofOvEiyDuAjpHed2l bUvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773174984; x=1773779784; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YWC89SNBP14Ak3zMdsjrEcAqrqhx0MSOXRT5kJJSs2w=; b=c4IqZjnDJ54ht9hz7DMZYdjEaV6xp5zelk6dPjo+/FciQDI9FIPjx5A7kSabpv88Vi 7eVoO1eHKUM3ms7ApVRTpTSy6EbDOZph+rp9c6HgvXa6hlxCeGaErCCsL17cfXj4Ebja JGRdX9IiCz0Hy3Aae2KLmvwt753/NA+B0WdFfb22gNyonTbzHHxsgheVFy41pdIGXjIk MZYr5q+DYlUEs0S6UwwY/k+hvwVXMnrnYBDzFLWZ+WLG3Cfn3IpPCp3IkLZFjqIG3Dj5 7vtbF04lUyQsHGVNyQRmWXdsi44aBsznpt9cqvNhQ/QYbKpbi5iGUbQpR6Vxp4I13qYb dkiQ== X-Forwarded-Encrypted: i=1; AJvYcCUzrVef5wRULRphe8f0C9X+j9dcxCOSgyzQO7+g456ZBLMROyk2v4eb9GS36vt5oAYAKcbB2ePhPCSn/Ww=@vger.kernel.org X-Gm-Message-State: AOJu0Yx53oD+qP2i4Agb+LxfGSPjQP2i4TG/fj9hDzakCbArWu6Wg19S V24ST005Ufk6jcR0ga4iquAW+3z1lfQlZ5NQKApM4aJ9ooAwFHbNQfvH X-Gm-Gg: ATEYQzy5tOkT7eq1Qm1jRlDTu7BPv2L9S7Ii7wgMHRCYMXFgWSxs7Sm8ekqQJHgONo0 bKT32IRVB3S0u9jIo2AzI+jAriR4quwh5jaXxmePhgHLsHyeUeCRmvynyxzU9M/3fIfbyKLb3lE AVvFXwyN93jpxqmOX9g2+OO6P/MyAQQ6Znfud9aC13JfncE3Yv9T3s3MrlWGew/t+1aZRdYkF+e Yv+whJ2oxMTaoql99QS4TX+8pwtCrzOHu+2owUuRtixaTffymBSW7benbUJAtWNWhwIyobNY9g8 i6UeTdjkLN6+wVCOl1U1T7olrlt8CmPz0bRvKsKpi1iMJLOS93PyH+L05jWkOBFhhaaVH7gYKPo rIAQHyC4EYWDk+I0d4yme040NsIqok4A3LDAyZhRK84qfSKBNRtg2SGw0NauObSs1SOF/qU4NE8 PMvwauHF7m5+lqeO6CUWOoRu4dWw== X-Received: by 2002:a05:600c:314d:b0:480:1d0b:2d32 with SMTP id 5b1f17b1804b1-4854b0e8111mr2819035e9.12.1773174983720; Tue, 10 Mar 2026 13:36:23 -0700 (PDT) Received: from localhost ([37.228.227.224]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48541b7f3cdsm117372275e9.14.2026.03.10.13.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 13:36:23 -0700 (PDT) From: Jaime Saguillo Revilla To: linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Jaime Saguillo Revilla Subject: [PATCH] hwmon: ibmpex: check ibmpex_send_message() return value Date: Tue, 10 Mar 2026 20:35:55 +0000 Message-Id: <20260310203555.33896-1-jaime.saguillo@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Several ibmpex request helpers ignore the return value of ibmpex_send_message() and then unconditionally wait for read_complete. If transmit fails, no response will arrive and the code may wait indefinitely. Check ibmpex_send_message() return values and propagate errors to callers instead of continuing. Also propagate reset command failures through ibmpex_high_low_store(). Signed-off-by: Jaime Saguillo Revilla --- drivers/hwmon/ibmpex.c | 35 +++++++++++++++++++++++++++++------ 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c index dec730798d58..92cda205e57c 100644 --- a/drivers/hwmon/ibmpex.c +++ b/drivers/hwmon/ibmpex.c @@ -133,9 +133,13 @@ static int ibmpex_send_message(struct ibmpex_bmc_data = *data) =20 static int ibmpex_ver_check(struct ibmpex_bmc_data *data) { + int err; + data->tx_msg_data[0] =3D PEX_GET_VERSION; data->tx_message.data_len =3D 1; - ibmpex_send_message(data); + err =3D ibmpex_send_message(data); + if (err) + return err; =20 wait_for_completion(&data->read_complete); =20 @@ -159,9 +163,13 @@ static int ibmpex_ver_check(struct ibmpex_bmc_data *da= ta) =20 static int ibmpex_query_sensor_count(struct ibmpex_bmc_data *data) { + int err; + data->tx_msg_data[0] =3D PEX_GET_SENSOR_COUNT; data->tx_message.data_len =3D 1; - ibmpex_send_message(data); + err =3D ibmpex_send_message(data); + if (err) + return err; =20 wait_for_completion(&data->read_complete); =20 @@ -173,10 +181,14 @@ static int ibmpex_query_sensor_count(struct ibmpex_bm= c_data *data) =20 static int ibmpex_query_sensor_name(struct ibmpex_bmc_data *data, int sens= or) { + int err; + data->tx_msg_data[0] =3D PEX_GET_SENSOR_NAME; data->tx_msg_data[1] =3D sensor; data->tx_message.data_len =3D 2; - ibmpex_send_message(data); + err =3D ibmpex_send_message(data); + if (err) + return err; =20 wait_for_completion(&data->read_complete); =20 @@ -188,10 +200,14 @@ static int ibmpex_query_sensor_name(struct ibmpex_bmc= _data *data, int sensor) =20 static int ibmpex_query_sensor_data(struct ibmpex_bmc_data *data, int sens= or) { + int err; + data->tx_msg_data[0] =3D PEX_GET_SENSOR_DATA; data->tx_msg_data[1] =3D sensor; data->tx_message.data_len =3D 2; - ibmpex_send_message(data); + err =3D ibmpex_send_message(data); + if (err) + return err; =20 wait_for_completion(&data->read_complete); =20 @@ -206,9 +222,13 @@ static int ibmpex_query_sensor_data(struct ibmpex_bmc_= data *data, int sensor) =20 static int ibmpex_reset_high_low_data(struct ibmpex_bmc_data *data) { + int err; + data->tx_msg_data[0] =3D PEX_RESET_HIGH_LOW; data->tx_message.data_len =3D 1; - ibmpex_send_message(data); + err =3D ibmpex_send_message(data); + if (err) + return err; =20 wait_for_completion(&data->read_complete); =20 @@ -276,8 +296,11 @@ static ssize_t ibmpex_high_low_store(struct device *de= v, const char *buf, size_t count) { struct ibmpex_bmc_data *data =3D dev_get_drvdata(dev); + int err; =20 - ibmpex_reset_high_low_data(data); + err =3D ibmpex_reset_high_low_data(data); + if (err) + return err; =20 return count; } --=20 2.34.1