From nobody Wed Apr 8 03:06:11 2026 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCEF42D3220 for ; Tue, 10 Mar 2026 19:47:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773172027; cv=none; b=VNTiCxoQztDT3MhbWiyxaUQPWAS7Ewt5VX9k1ty7maOTboxm9wQsmhm9B7RtcFjDT6xCRE8UH08WCIO9zqfkLI2z52xUr52eR3mDJHPyQW28XQIKRljqBjs70S618viMOM2p9GOBJN9C3WhyiiCIeu9Y2k9Yl673OvCmWiq8TzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773172027; c=relaxed/simple; bh=S6icAiA8dhguxmXeT7PZxJHaPmFV2Dg6g7dxnB9Be7Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JQP1dke3dczGyfWjih1kVefyR3HZAjT+6XSSmc/r21qPEZM3FBKAz/GaBSwuOBKXXs3NFYgyPVVNgas1Z502rCTQIaHBe5dPxXUfSOYiwzyTcGlZlBwcwtgo7whwHon4eZIzwSe2pyUsGvEWf9/oiqRjum/QtRPL+3su4eGh+j8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YLPxcCnp; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YLPxcCnp" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-78fc4425b6bso134137617b3.1 for ; Tue, 10 Mar 2026 12:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773172025; x=1773776825; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nAWNRcrPLh4NOKUzVn7/SjtpjBoGF+ow6W32XLnTmWI=; b=YLPxcCnpiZikSzEJuo0s3aFlf4vKWjKiWEbmF1I+4B7ABHyubeu1XWG5/zxcwjJDfK y5pbkXPA2OUOjhf6SH9aSt9un1jpEqBideD3O0PbT43BBkeSofjim41G6gm4KAAYvJDh GygibSoijimA779Pc2ixHsNi5qiDyMcHprBZCuTeM3qmWc2MTgADLOkM4HQefKUjznO1 w9lQ/p+mbBHDv3bU4t8qelS2EPq4Nj2o/pTLXRhzNeOfde9n/HGGhBif17kknyMimeuE 6ZWNz8U2VKceubXYvyoY6x0znBAXYsx6H5qZs7Lj6SW9N4RzRNDe/TkGW/6qHYJqw16m +mGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773172025; x=1773776825; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nAWNRcrPLh4NOKUzVn7/SjtpjBoGF+ow6W32XLnTmWI=; b=puRexYACnjdqVhhnpiUjyiyK/iTAA48j9/tY8GRQ84eTqDOMlq24NxrozPGjBJoAeZ lkoFAj1oWHuucWSmziUq+RyCz3IF7vDuhUuXIkvJkoA+/qfUY1vuv4z9aDZoy6Ujl9lj 6e8YYGXhiql8OZy1duhrNGvqWG/OgAiajeiPNdJIKt6cTrtDcIzjZVdDGQLLFHP7CM+A b+F2cpyKdWWidUwsn3gq6mysZJ4O4pzEshtMT0w2lYXRmcmtQ9Ix621AQ2s/mrDzQNr9 yrGDYpNY6E8lVAw8F/eqpXciyumepP9sK7C/4udMrmzOtiOLVzh+oH7D9lPOdNPQKwv0 liCw== X-Forwarded-Encrypted: i=1; AJvYcCWhbI2DfSy/Lso5XHQ5n2Bu4p27zrVi2b1xmmL5fIlZfRw9fYxb5Iee+Yo98VHYOhd60GqoaYvRJJ0Z7EM=@vger.kernel.org X-Gm-Message-State: AOJu0YzDu4c2PGKy0iqBmDwDQj5zHwCt8zgX6dzxyLKY/OzyOKu1PBJE 5gRK/sLTSMKIlzyhSjL/F8U/f0N2pTLuerpWvB+wIHBodTUiEKRhOf4D X-Gm-Gg: ATEYQzyBg07URj0Axc3FOn2WwT1WfiBrnwE2AgEZdSfGfdxqD+LEig35Y9BqILC2TIo 1II+aTYpHr0oPiwSOsYYiMU5ohxtRrJ0D4WbrMj4gZSb7psyAJaUOPQaLRlQ66ypmN3V+QTVITD Vw9j+HuBI/RLNb84rRAr1wFTsxVmhDpm/xklriU0KyhnXuyuF4e4ICdO260NpC4Am8mOqdWaDjt JYAkDmNaYAgCZUFDzO+yvvsa+nOeUMgSa9EWb/R9MIK0NY6E2BdRzhBGQ0C6KEr97l8v+WtKfUK 5S8bZW9m/1JCyWWsLomaQF4Ov+vkC5aCPpJGF/CUPW8wmrvaQCkHvN3b5iM6uJ3dPdaJ+G1dPNM i1wkLFyN1RYgrVwxk77v8Qci8AjjMlAPNGqpSgvD9E6le69TeZBttTpriLLrp9tU2ZVvjB/qsmR MLaGKNWUNsW89VqspqtQCjC/qrU+MhVXht0Q1gBHiWa31Rirvo7PYTow== X-Received: by 2002:a05:690c:6604:b0:796:6da9:bfa3 with SMTP id 00721157ae682-798dd6706a6mr151321247b3.7.1773172024914; Tue, 10 Mar 2026 12:47:04 -0700 (PDT) Received: from ryzen ([2601:644:8000:56f5::8bd]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7990a518c9bsm21152987b3.10.2026.03.10.12.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 12:47:04 -0700 (PDT) From: Rosen Penev To: netdev@vger.kernel.org Cc: Raju Rangoju , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv3 net-next] net: xgbe: use device_get_mac_addr Date: Tue, 10 Mar 2026 12:46:46 -0700 Message-ID: <20260310194647.3794-1-rosenp@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" device_get_mac_addr is basically device_property_read_u8_array with an is_valid_ether_addr call. Allows just checking for ret. Remove XGBE_MAC_ADDR_PROPERTY. device_get_mac_addr supports more properties than just "mac-address". Signed-off-by: Rosen Penev --- v3: remove unreachaable !ret condition. device_get_mac_address sets it to that. v2: remove XGBE_MAC_ADDR_PROPERTY drivers/net/ethernet/amd/xgbe/xgbe-platform.c | 10 +++------- drivers/net/ethernet/amd/xgbe/xgbe.h | 1 - 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-platform.c b/drivers/net/et= hernet/amd/xgbe/xgbe-platform.c index 47d53e59ccf6..0debe015073e 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-platform.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-platform.c @@ -252,13 +252,9 @@ static int xgbe_platform_probe(struct platform_device = *pdev) dev_dbg(dev, "sir1_regs =3D %p\n", pdata->sir1_regs); /* Retrieve the MAC address */ - ret =3D device_property_read_u8_array(dev, XGBE_MAC_ADDR_PROPERTY, - pdata->mac_addr, - sizeof(pdata->mac_addr)); - if (ret || !is_valid_ether_addr(pdata->mac_addr)) { - dev_err(dev, "invalid %s property\n", XGBE_MAC_ADDR_PROPERTY); - if (!ret) - ret =3D -EINVAL; + ret =3D device_get_mac_address(dev, pdata->mac_addr); + if (ret) { + dev_err(dev, "invalid MAC address property\n"); goto err_io; } diff --git a/drivers/net/ethernet/amd/xgbe/xgbe.h b/drivers/net/ethernet/am= d/xgbe/xgbe.h index 4333d269ee84..e57e416a1d5a 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe.h +++ b/drivers/net/ethernet/amd/xgbe/xgbe.h @@ -96,7 +96,6 @@ min_t(unsigned int, IEEE_8021QAZ_MAX_TCS, (_cnt)) /* Common property names */ -#define XGBE_MAC_ADDR_PROPERTY "mac-address" #define XGBE_PHY_MODE_PROPERTY "phy-mode" #define XGBE_DMA_IRQS_PROPERTY "amd,per-channel-interrupt" #define XGBE_SPEEDSET_PROPERTY "amd,speed-set" -- 2.53.0