From nobody Wed Apr 8 03:07:03 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2FAB3C9452 for ; Tue, 10 Mar 2026 17:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773164928; cv=none; b=pcUMGbNX6lTeAHvS/2nPJFfRP96ZllfxMY0MEC1aFLKA2aXC11Gn1XZDogm6jIkCeKQXtWW265nIjyv3en1zxtRqrOgbaBiA7QjQRxlkbSOGydMPyK5EQn46zjJzqm7cplVDwTdErld+JF5S16a30xOv94pBleDegSwADyMt6Go= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773164928; c=relaxed/simple; bh=VjZb4CmtSrNzb1/U1B1dWD1qOFRyAd66jrWJtqkQxBY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PQFHFRjpmO6uJg7l49ivJpfY1/CP+vK/HrOl884BCZ1H0Su2iAbujMG8XKwhzVW3n6aRgH+MbQkmw98Pifvd+L6jfMWN12XR2QF5+a2fvr/cxWrCbsxlfKTrxU5nb+WpgF+BpsJ3c5jITUNW3yh/hRh6M63VNJsFiT0zM7osp4w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IsoEibyd; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IsoEibyd" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-439afc58ac7so10470650f8f.0 for ; Tue, 10 Mar 2026 10:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773164925; x=1773769725; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xHmODBhrZ3/O5W8NLFv7PZ5NCYcz6FiT2g9bwdQa078=; b=IsoEibyd6eSYCJTRF57S9KTAT1VtbsolYEiJ9aSmQ6AajwMQ0NyJeuCWi4vwxymHgA G0a3E6BLdlPVuDDHNjjYih9s52bOyaMFRB/p1sgu04K/YClI+vwB1R6Db+PigLKgFs3M 0gbwTSQAweOVrUbqPaZstRe9DZfd/gl4hSbZnUlLDlQltfRFf+jUnEG8HJFbvQ0K4n0F D2QlJQG8kQkgXKqaxMbc3LrfHElZ3q25NW/rRsZG3FlaAC9cyVbD2oR/Re1rrP7uDPFf b8d1fm9jiDf12iZMJ7f64kHl3ZlEA+f9mfcxlWtdIqA7rQd+RFpWNN5TAK8h1Fiska+0 Yhwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773164925; x=1773769725; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xHmODBhrZ3/O5W8NLFv7PZ5NCYcz6FiT2g9bwdQa078=; b=SA0aqBgM8RBPsQua4tiTkeIVxeF7RUi53yK6m8rkG3voTUzdohu2bCx5KxJqyn1Ffo 2WwajQEHlIycQOTaX43RFb8zXHKs7NcQb7MwE1cFnyqTyor7jQke3JKi218T1btFgQFk whZ6mXaKbQZWn3v+UlXExS9tmCxQPm71OirH2j44UwVK1IemnrgjjVGQ03kaNiL6ywDn ly8S+BrR4crS1UgcBXZs3Qn0vWujw5SRkLk9c5c0+HxQjOKl7ZJm7IUtSKSQI5xSwdCD HuwVEYJu04NDrH/drzIumngIJcgrl86+YUDCV1TjQ+XX6r3JLGtFZ1SLrpo5TmM7gbIU uj2A== X-Forwarded-Encrypted: i=1; AJvYcCX27PvJLxMtnguNy6R4j9DEiGSV15q0rt65/wgq+gfr+DbYX2I8YAcLS4dQj6ks+fXTBAsJ0yzhDT/D3w0=@vger.kernel.org X-Gm-Message-State: AOJu0YxcEz1ZCpWiXzevAH/xIOEFfXkaQTnQtrGNFRhqQMm+bW6uEyjP VQ4t/RrTDMKxkeaVxa1NW6A2U0hC7bkjXYEUgD0RuJr0OuJLW9ihbqFv X-Gm-Gg: ATEYQzz4NJ2g6YEt/Bz5LLvd2lekw2X8bbej9dvMJYjYa1qzF3MpRchgIQlL3aiybJd BAmLQtJ0WS/o9lFToMwbk8C78RbOr0JiC2GMe2aE9Mg9e/0VKl5UNkeOkRUWmseQQZM3SNZyy3x oakeYYncCVudHkz3LP8M8cucSb4w9oH4XRiVlXS6WdTsOShswMqW8LLjn2726jQ4gBf2OPnNS8a /phxVZQGXQMbHLc9v6BZ4a7Q8fM/xcqDF9+7WF0wwVkrARzg48wkf8vFjc+tJsjXPBTbiI1zO4Z 4nuCWuQchXqTaVXkRN6vmKWjBIAfNENcfS+bhoOBbGxwy1PvkJh5gbAZLMgwdchyHorn1swSWIh LT0HhW8u5WPuklSuSX2Z7uFLszw7Yh/U2Q+F7509WRhWiFP/crWRfgauK6X+5C9ZVKbH3YVzjLy eTHaNAcylVn0dtQR7KFZknhTGmuFyiBDf3aZgXaczmYddwLgGTVnsMpW+PWg== X-Received: by 2002:a5d:5d02:0:b0:439:b886:20da with SMTP id ffacd0b85a97d-439da656ee9mr27128512f8f.17.1773164925101; Tue, 10 Mar 2026 10:48:45 -0700 (PDT) Received: from db07.1337.ma ([197.230.240.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae45786sm42986166f8f.32.2026.03.10.10.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 10:48:44 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, me@brighamcampbell.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com>, Krzysztof Kozlowski Subject: [PATCH v2 1/5] dt-bindings: iio: dac: ad5504: add output-range and missing gpios Date: Tue, 10 Mar 2026 17:48:31 +0000 Message-ID: <20260310174835.24209-2-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260310174835.24209-1-0rayn.dev@gmail.com> References: <20260310174835.24209-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The AD5504 output range (0-30V or 0-60V) is determined by the R_SEL pin. Use standard output-range-microvolt and range-sel-gpios properties to describe the hardware configuration of the R_SEL pin. Ensure mutual exclusivity using the not/required logic. Additionally, add missing vlogic-supply, clear-gpios, ldac-gpios and datasheet links, and provide a complete usage example. Suggested-by: David Lechner Suggested-by: Krzysztof Kozlowski Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- .../bindings/iio/dac/adi,ad5504.yaml | 40 ++++++++++++++++++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml b/Do= cumentation/devicetree/bindings/iio/dac/adi,ad5504.yaml index 9c2c038683b4..c0b2d470949a 100644 --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml @@ -10,8 +10,10 @@ maintainers: - Lars-Peter Clausen - Jonathan Cameron =20 -description: +description: | High voltage (up to 60V) DACs with temperature sensor alarm function + https://www.analog.com/media/en/technical-documentation/data-sheets/ad55= 04.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad55= 01.pdf =20 properties: compatible: @@ -27,16 +29,48 @@ properties: maxItems: 1 =20 vcc-supply: true + vlogic-supply: true + + output-range-microvolt: + description: | + Specify the channel output full scale range. The R_SEL pin + determines if the range is 0-30V or 0-60V. + items: + - const: 0 + - enum: [30000000, 60000000] + default: [0, 60000000] + + range-sel-gpios: + description: + GPIO connected to the R_SEL pin to select the output voltage range. + maxItems: 1 + + clear-gpios: + description: GPIO that controls the /CLR pin (active low). + maxItems: 1 + + ldac-gpios: + description: GPIO that controls the /LDAC pin (active low). + maxItems: 1 =20 additionalProperties: false =20 required: - compatible - reg + - vcc-supply + +allOf: + - not: + required: + - range-sel-gpios + - output-range-microvolt =20 examples: - | #include + #include + spi { #address-cells =3D <1>; #size-cells =3D <0>; @@ -45,6 +79,10 @@ examples: compatible =3D "adi,ad5504"; vcc-supply =3D <&dac_vcc>; interrupts =3D <55 IRQ_TYPE_EDGE_FALLING>; + + output-range-microvolt =3D <0 60000000>; + clear-gpios =3D <&gpio 4 GPIO_ACTIVE_LOW>; + ldac-gpios =3D <&gpio 5 GPIO_ACTIVE_LOW>; }; }; ... --=20 2.47.3 From nobody Wed Apr 8 03:07:03 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 171823D6CDF for ; Tue, 10 Mar 2026 17:48:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773164934; cv=none; b=lHFaX9SP58GuEbJWf8teptKmiwMAEgeFqfExmXeqYFGpXkJluG2jbbhqkMvlcbHSZTfS4Kfo6/iJkOqrQrEeFDdoJjL4S8OmAPAJVlcFfNhn5Zzdkq+Jisi6sEyKsMa2ux7tOktL15J3Q/nXnzcRuvIpcRADn8MeLPWHhoUf+ok= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773164934; c=relaxed/simple; bh=04UJ9uO0ADy8N6057D8nFiQ/NIMCKApqnGi41YmNbpE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YBsQlzWVKdLw1jZzBICnyhcmFzgw7yQwR7d4fYjpnFuGuqR1/8johRjPH5eec8beJyEbM51bJufiZ+/vBYJei+q83M0J4oalXPlzd7epBaPuGF+EFYNhR/G+DPGsgpSrBX+tIlgAfwaUyZp0ruRyatqhRD7X40d88iWtJmGUiWE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dYUR1/EF; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dYUR1/EF" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-439c6fc2910so5046522f8f.0 for ; Tue, 10 Mar 2026 10:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773164927; x=1773769727; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y6LuG3NPimfXkyOGf802SE8didLWs7WuYqKmvVqraAs=; b=dYUR1/EFyCSDdVdlEYqmgl8zTRuMIqWIVOQLmr75VCNXLBRmbZO1swTM1gsQRJHGSZ Eb7vBGfmEeIz1GT3w938n+mQl4TytkY6hHlVCRlK1dzCsPS4AulQtuCtCRXZIrGPWN4k 9rCQq5V54KiGrdBVQGzAClaCY3gcHsLdeZfF24uKr9ivr9Vt1JGRQk0eRVeD7RNL0nJO p85jzg+8i66oiF6zuGCveyh6poCpzfgTHAQXuIUWqS0QvxGasoerz1gPjRChTCRt6KxS 6GkpYbnwjUuaX7JUDmfT+rXTcnnZqyU8ZINJsmqaorSrErBjbpcQcshiXiHQwbe4r1jY kyyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773164927; x=1773769727; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Y6LuG3NPimfXkyOGf802SE8didLWs7WuYqKmvVqraAs=; b=oAjEL1W8Xlm/3J+r0sXedZEGXPG3j90cftWE2AIAbG+GTzawb4aYAqxPBoDoiu2tsg IqEDS0tfaePsFFxRwrEn4v3XhZ4cbg1IBCSrXKgkLxzT2kGYXHKioLF2QFXAsUyIEudr A5/+7QVdNOrPhecfhVLfEtNghX0rLcIeAwoW3bvEXt3mNiDuPDng87p6tzzEhPLfzW1G GM/i56OseBDp4R1vybD/8+V0mX3QHHm2zkcptFcqEmr5IaOjxtxhThWViO/cw7oYjSql Pe/awhTrCXU1vPjnV+GA94BSvFQXJFFzDBvhpBefSJFTpm8TcC6KKg1LZNwc0Eg/Mg+M Nb7w== X-Forwarded-Encrypted: i=1; AJvYcCWhJ9TZrv/caMvwxM+TPOdFUSJaMdDOoztz7Zd3//irO2f6AgeBROgI7y3jGQgtIj/gqMXNiBhLT44eJyo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/r8WUkYjUoyLd3Uui9X629ZNVCxgNkctCX4YMjytXvYv8pHWq QNH2Jje23+azKB4FGlQgHpu4+iY/sYOE9H0BMJycmVyXgArmzf0issJy X-Gm-Gg: ATEYQzw0kQdrSrVEJJrwcMTmpRRIazeXiB9+23xT/5uI11p0Aqitq55yynqAV/uVxut e6t+me9z0z6ZQHb4yP2XwaL/nPlz5aLbSbhgOI1cfICePurMj8xZ7Y/bFKWX72nVFyxPwzHgb4K VzY/TExYGPRTG2SD4rkVtPgdFbV9XGMYAsxobORGSbr5mBLIlOG+wG8dbp4QPfU5ZDyu1EP+fg2 IQADMe+Y3oENwHe5YvVnBdWfekdqESrH2Txb26asKWH4HHXu3pEf8dae5gHzrUgn2IL/JKd9GXa pDSvstKkekqDL/0tGSrl/j8nQmAx3jAB9C9gcLIGKW64FzHZ4FGN92VqM4aTuiuIVCul/Zry3Q+ 7Ywa04Zzlc9zFm7ZG+80ei8/kP/GNhN//7GPr29B7+m8N/iG23ntYdHylHNx3qQTVgUDoy1zcQ6 IsrMyyJwsQ49Q/XEH6iYOeGxEsn1Wyb0zcktHv+MlwFrUdBerTkAHvYql7JQ== X-Received: by 2002:a05:6000:144b:b0:439:b522:37f6 with SMTP id ffacd0b85a97d-439da6694e9mr30091410f8f.35.1773164927204; Tue, 10 Mar 2026 10:48:47 -0700 (PDT) Received: from db07.1337.ma ([197.230.240.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae45786sm42986166f8f.32.2026.03.10.10.48.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 10:48:46 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, me@brighamcampbell.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v2 2/5] iio: dac: ad5504: sort headers alphabetically Date: Tue, 10 Mar 2026 17:48:32 +0000 Message-ID: <20260310174835.24209-3-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260310174835.24209-1-0rayn.dev@gmail.com> References: <20260310174835.24209-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rearrange the include headers in alphabetical order to follow the standard kernel coding style. This is a preparatory cleanup with no functional changes. Suggested-by: Andy Shevchenko Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> Reviewed-by: Andy Shevchenko --- drivers/iio/dac/ad5504.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 355bcb6a8ba0..20a36e4a389e 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -5,16 +5,16 @@ * Copyright 2011 Analog Devices Inc. */ =20 -#include -#include +#include #include +#include +#include #include -#include +#include +#include #include +#include #include -#include -#include -#include =20 #include #include --=20 2.47.3 From nobody Wed Apr 8 03:07:03 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 056243D8128 for ; Tue, 10 Mar 2026 17:48:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773164935; cv=none; b=LyyQRE0ERxHpFAF6en6HAzyaameeRjDVw667HKTJmrRR4WRbHBcT+nQFMQgM3vMxlBHOUw1pVXdrwNkYmSGg0IABJWFlfjLA4CBsdrpNKzGwXZQGifE6Je+SHyOoUsMjhRStuY4FClEex92Q5h28fyUSgnuL0u2PqWklsHYD2Qk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773164935; c=relaxed/simple; bh=rnH1lDDijdWio4hvMnW+OzLLpzrfOxd6aREo/7Qnkbk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NhN1JN6NklCKZBR5k2d2XzTWSOqYZip3WwDCLAFVd3HCFP1lfo0gi5dpc2jY11tkX+os+5a+zHIsrmkrJkp3QIfasRELLUY/UigcedmudFLXWuvsrTW/aeUibS2YQZr9qoMyJNy7+vkGftip/sp1Z8ezq1DFfgtrk5iAyvhm0q8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ffyvomWA; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ffyvomWA" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-485410a0a8aso16476755e9.2 for ; Tue, 10 Mar 2026 10:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773164929; x=1773769729; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hG3aSGfDs+bX2W0OvTuhZZGpmjfGIX98rNhNH+D4xOM=; b=ffyvomWAqIs30b4tbEVvnBrxwwmZIUp1lpJ6FubjIWFE2TXRZsDgaVXLGrNRYAMr/Y dgYzqKE1BLhX9TuaR8p+r1Jg0L4rEcMUwAhOEiob3iUQH03y5N3G7D8E6yOd8fDruP0M GfeHb7WeFYXJKW47EYNYiVpd/gov0tL/c3eUgrWB3F0gMEefj4Rqro1LerIpSMVA9mrj CMNQJCXkW/dIk1BBMBh5Bsm4LierNVckg+/6othwisI8oxA3pHPuE1IYoY4INeSM+nSn BAVb4p6ZLOaXKfjpOYpDBwK1TlUyyH7A0/lG37MYMnZqUv/bUpTajVrZImZ+vfxiRyhS LZ3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773164929; x=1773769729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hG3aSGfDs+bX2W0OvTuhZZGpmjfGIX98rNhNH+D4xOM=; b=kfoalcQJbP+WLV5g+B3DpjIIUmgNJiAxqmFa8hliwZ0ZrfZYDXM2oAguuCBJ++hHaV uMlOeq61kycjo6c0OI6WhhlxwO0o+AABR1jllfG06iRD4blPlaFrbz2gIXLb132InUan EM5SW6QydmUmfpiDnV6Y55CF5Z3H8xne6eFhHRhVjmjxIbRwLhEG8LkV4GVik0TdB+6v yVROKy2m8BF51typ13uH3HoY9tew5xBmueTR8BJKJ3NCVSS8LcD8wo0MY3mjUIihYJJO Dix9clWCapSgd57QxRIM0ByZGxNbpEkr8IFM0IzcMnnIn4ExjymIdp3qG18K1SieGilU hTtQ== X-Forwarded-Encrypted: i=1; AJvYcCUkZgxWHjC+7C/hYLzqUOXcMepl0H9XTonpuec4jslquMPg8avBQZF9iIbinV1GVULFoY7B2yFsQt46pcw=@vger.kernel.org X-Gm-Message-State: AOJu0YyMtHzDTTkELo9nrPkFpdBxyeOdegOJ9AKnttqcfl/PqfEUJESb BajQc3z1SlnMWZebU6iKspwiW5o1Cbyv6QfE5lwrOqTgj2p812I9jwFX X-Gm-Gg: ATEYQzwx8QL+E7I+51nNZKgQF+GkBf+A+D2JbqSZ/BTXhiEu5CI9R0dtDlxHVpvHFqk 6E7cpkbujTJvTYJuqI41K5ZjIqBH1fBgrB1OOq7REPhekCJQw5S1XxYjsI023DvI8Mn7yUxr+jv CyQ49GJMAcMUUWZSuvmb1Z/stayyCG2hdlbYmjnOfcWnvSH1DbRNGiNEayvNxYG0Tr8WBkmz8IS c0StJH8MF2uSZtF7lERRTRZsjtcucUWJp6hKYawypS22Rr/tUW2ER1MfD3rGGpI76j+0TnQJGlN UNs7SsfNQatiGcdIAhaX+QzwZ5i1gPlZNKqLE+nUed16fnc9FqDA9wRJ0JxE4O/WlCr1SSQIjZT EHDxsbTllpeYydoD+WDA3KDROmKtO4FqGUcoxR/2LAPrs2Uag4yiIWBTVEQLExvYD9UgbIVe1Va cKM/BhTtDHgdy0tFAwQl8Bxa4hRMJIks5xxuSndXLeR2fUI2gtOdKaMe1Mjw== X-Received: by 2002:a05:600c:138a:b0:477:7ae0:cd6e with SMTP id 5b1f17b1804b1-485269196ffmr291701295e9.5.1773164929303; Tue, 10 Mar 2026 10:48:49 -0700 (PDT) Received: from db07.1337.ma ([197.230.240.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae45786sm42986166f8f.32.2026.03.10.10.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 10:48:48 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, me@brighamcampbell.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v2 3/5] iio: dac: ad5504: Align headers with IWYU principle Date: Tue, 10 Mar 2026 17:48:33 +0000 Message-ID: <20260310174835.24209-4-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260310174835.24209-1-0rayn.dev@gmail.com> References: <20260310174835.24209-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Update the header inclusions to follow the IWYU principle. - Remove and as they are unused. The driver relies on devm_ managed allocations, so slab is not required. - Replace with as only the BIT() and GENMASK() macros are used. - Add for struct spi_device_id. - Add and for error codes and data types. Suggested-by: Andy Shevchenko Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 20a36e4a389e..e71218c44982 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -5,16 +5,17 @@ * Copyright 2011 Analog Devices Inc. */ =20 -#include +#include #include -#include +#include #include #include +#include #include #include -#include #include #include +#include =20 #include #include --=20 2.47.3 From nobody Wed Apr 8 03:07:03 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EED93D47DE for ; Tue, 10 Mar 2026 17:48:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773164937; cv=none; b=K3eH8DZkHOYHn4UmKnCYLmxq/HTKdlB+MjzWBMLJW3CPTw1OlUuBM1VKFTNIYVX7MeF85+DJ72+oRwrs+RQTki+nFrWkcKHBduFpuT7MutcGt/pbzSnlkfP7n/3KzdyYrA5wCPag0oEaoKVboCI6qf7RWdg3Bt6kA4GAZRNvh+4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773164937; c=relaxed/simple; bh=xeXVTSZzQuuFD+lMKWTOiRIKsLFrz54VBr0660xK+CQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EhgwUBdP85L4RjXcUF3QFblJIac2jCh0NBi0mfafslti6J+zkZS/8qKmCaw2aqAPTkw8bRhcz3gaOZdbTABbaQbxNQ22ifjDtRgh60/VJPsaY9ifLBfFdpUhbNDIRc0pwvt4AiRIoRZz5eqW+hfuTrLyeeV9PkVga1itmcYTIg0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jJRk7KuO; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jJRk7KuO" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-439af00d33cso10287292f8f.1 for ; Tue, 10 Mar 2026 10:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773164932; x=1773769732; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BslQrBMKlw57se9odRgPPZj4HtuVGPf12Q60E4FhFEw=; b=jJRk7KuOfLQOtFkoENv5UgV8Bzc0kQ3GSLDG+Br+orZehGkqgCPSNzWO7QKuXvefeb S+ES0XN7v0Dv8A753dNyxGJNITsdwBKVOiV/p8b4q3KRkcGkhsUdZHn0CWKD17pAjYDI SUtkmpWLamfIGMtux/ZYafXtBdfiD8Efl7ydzlTLYVRtQzzrdor0Y7uO8BQRYiuGWE+B bLA3fG+WJGu4WkZCSX32JO/IsUcDHoFtpQhrrUg2hUskrS5jvkQqTAkHi/2t86+flRJ8 w8VXiOUE4ko/kXRwYQeTcUbGZ1rx2ApBomAjY86/wy/VOP7hk68UPR6bHBzhs104bp5h ijJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773164932; x=1773769732; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BslQrBMKlw57se9odRgPPZj4HtuVGPf12Q60E4FhFEw=; b=DHH+4cepXMAxST9k3xfHP00VQBDBAujjga9EDN+L5GcXqgfygzA6ibol9ssMZvFdev MCPrT/d9Q7Wu9R87/6uaiZHCjEUmQuDUlfCijGkdinvP2iaOkTzZe5/ENxG7kIqeCt1X craXGvDKadcxSB+p4xU/x+TPw31mNtakYUHer84aXSI5d0bsNBAHxGJGddckVA83qQLy YrbiPzLCni9PRM8FesEv4G8TO777ARf6YBBXna8hPn7b6iF2L8HQJvTYAbqQkpeZpjjX Z5rK2WcNd0XKMinDTI8EJej8LzGtpOsmxu9W0WLfpZDCN1ksaXcpGO1FsecsSUVTFcbu 5IrQ== X-Forwarded-Encrypted: i=1; AJvYcCXMrqTPLBby59xzUe21p6NHmgNC32nSmJKXYggkTrQTj/a3o5jfgoW2YZjBVXoax4Z/Gycfb/dPICXWeuc=@vger.kernel.org X-Gm-Message-State: AOJu0YxQuHk4H9L4rUEbdP3V0IPju8lybD6KNODDmsJZwJ8/tCsR/3Kf AOX4xUmWJPflRBZQtaZeg+cgU2SoSf66Ud+N7fgwyAUuWpctCjJHUrtY X-Gm-Gg: ATEYQzy/pUVavC+ecwDrGsO/B7NBfmWUtvGXGHHHsfOWcf/7hmB/EnUA7IyaflfWbgw EPW+U5J++A5xTv6Ah4aEPTuz7dUjJuuKiQSUZGpjbj7GWnApI/Lq2zhS8t26sIA1j10hquIcF7o 2xv4aHO9J66tT5vgY+enDx0ALOXob2zkP3dq0y00M2zLuebSU+0Feazv9D+LsTXPJpQIFOcpg5p SXr2FyIp0kBt4qq9/u6Let9USyTq2swUKevRP30RhZjJJ1HnZkDO+7KFhGdRk9rqCLndV6NNyXO UCYmreXfmbrnLTYAzzCb6yZBKlksgWUt5X0WCeVPMsWTEFobmpLBQx3p/OsaYSSREgKxwBIhLSe qGNeml3fNs5IJRHFjI4yMfmddCbVjSo4sU96HHiUSu8WwUnXnYCJlcSj9aaQQkK64+RrLEhnMLA EQwFm8jWVQyjvJ/3xmBmqOMqoPW6RPOl7UbGi/s37d+ByVS7h2tr11tXT3mg== X-Received: by 2002:adf:e802:0:b0:439:f61a:e005 with SMTP id ffacd0b85a97d-439f61ae05emr1742261f8f.32.1773164931625; Tue, 10 Mar 2026 10:48:51 -0700 (PDT) Received: from db07.1337.ma ([197.230.240.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae45786sm42986166f8f.32.2026.03.10.10.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 10:48:51 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, me@brighamcampbell.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v2 4/5] iio: dac: ad5504: fix scale via output-range-microvolt Date: Tue, 10 Mar 2026 17:48:34 +0000 Message-ID: <20260310174835.24209-5-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260310174835.24209-1-0rayn.dev@gmail.com> References: <20260310174835.24209-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The AD5504 full-scale range is hardware-determined by the R_SEL pin (0-30V or 0-60V). Previously, the driver incorrectly used the VCC regulator voltage to calculate the scale. Update the probe function to read the standard "output-range-microvolt" property as a two-element array to determine the correct full-scale range. Use the MILLI macro for clearer millivolt assignments and simplify the probe logic using a local device pointer. Suggested-by: David Lechner Suggested-by: Andy Shevchenko Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 43 ++++++++++++++++++++++------------------ 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index e71218c44982..cd563460fc0a 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -12,10 +12,12 @@ #include #include #include +#include #include #include #include #include +#include =20 #include #include @@ -271,28 +273,31 @@ static const struct iio_chan_spec ad5504_channels[] = =3D { =20 static int ad5504_probe(struct spi_device *spi) { - const struct ad5504_platform_data *pdata =3D dev_get_platdata(&spi->dev); + struct device *dev =3D &spi->dev; + const struct ad5504_platform_data *pdata =3D dev_get_platdata(dev); struct iio_dev *indio_dev; struct ad5504_state *st; int ret; + u32 range[2]; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 st =3D iio_priv(indio_dev); =20 - ret =3D devm_regulator_get_enable_read_voltage(&spi->dev, "vcc"); - if (ret < 0 && ret !=3D -ENODEV) + ret =3D devm_regulator_get_enable(dev, "vcc"); + if (ret) return ret; - if (ret =3D=3D -ENODEV) { - if (pdata->vref_mv) - st->vref_mv =3D pdata->vref_mv; - else - dev_warn(&spi->dev, "reference voltage unspecified\n"); - } else { - st->vref_mv =3D ret / 1000; - } + + st->vref_mv =3D 60 * MILLI; + ret =3D device_property_read_u32_array(dev, "output-range-microvolt", + range, 2); + if (!ret && range[1] =3D=3D 30 * MICRO) + st->vref_mv =3D 30 * MILLI; + + if (pdata && pdata->vref_mv) + st->vref_mv =3D pdata->vref_mv; =20 st->spi =3D spi; indio_dev->name =3D spi_get_device_id(st->spi)->name; @@ -305,17 +310,17 @@ static int ad5504_probe(struct spi_device *spi) indio_dev->modes =3D INDIO_DIRECT_MODE; =20 if (spi->irq) { - ret =3D devm_request_threaded_irq(&spi->dev, spi->irq, - NULL, - &ad5504_event_handler, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, - spi_get_device_id(st->spi)->name, - indio_dev); + ret =3D devm_request_threaded_irq(dev, spi->irq, + NULL, + &ad5504_event_handler, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + spi_get_device_id(st->spi)->name, + indio_dev); if (ret) return ret; } =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id ad5504_id[] =3D { --=20 2.47.3 From nobody Wed Apr 8 03:07:03 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AA872E9730 for ; Tue, 10 Mar 2026 17:48:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773164940; cv=none; b=ZuD47rHI/CmjanZWYFAHMsq+WWnSr66GLhUAve0E0XqGUYj0+7uyzdPnfXwAO6ceJWLUdJnz/cONALOqLJVO0ObfMcrThNV3FuzjxJqrrfzuTCQBPsBPiCtlZ71sfExT2/oAk22Aap6jnNTNdu4kapGzk44gLQjmNO508AhbIyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773164940; c=relaxed/simple; bh=RwbHXRCoVmTWoeGYZD5/ykMLkxfjTwmcVo/8jjaLucI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dlBw3YPQgiDP4h0HM4XDIKOFuKJxUst5tcnBo1lsSWjjGD18voyk0TvcziG2ubs3MgU7lZ6N0GQccVdCKnfQROe6w0P8CW3dT3MHsq0PBYVGniS2ZvFBfnoycXUwhfut4euggm04T5rxWy40CHSAiV4TZuLflO0jSeSr2sbxZcw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MP1ZjwMk; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MP1ZjwMk" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-439afc58ac7so10470764f8f.0 for ; Tue, 10 Mar 2026 10:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773164934; x=1773769734; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q3ExWVYtTjOCeiXkdLArD0AHGSvrIoXmw1MBLiE6OHE=; b=MP1ZjwMkLhpKIMrUsE5TyKhpzwzbxU83503eEVGKSuaap6BuyNhsKSkK8dwQlSf9lz DI3unISjDRHmXaBp0HqSDvM7Jdp7QG3zCXDD4331upsEMQcp1PoNbXof1yXVao80p7o1 970IiIfiwxxoYHvCCTJG/67NySbpAB45ZwHljGoaT72BM7ZLiPlsJe9tdlO4LbAIOsiT jDQUNPf695acW8LLfE79z/6JKYO5rFKpPvJVbC0t55aRqBytMmiBTM/c0TW6IoBRBAJO 5ROKZ481TRJ8+5K7eerHRgZCUJ30C8MZKICIxYD5xoBeoT82SkVHKaPx1nksXe54diTa dvng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773164934; x=1773769734; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=q3ExWVYtTjOCeiXkdLArD0AHGSvrIoXmw1MBLiE6OHE=; b=Tg6crUpW89UQx4BIFhVsLvAkoLXKtN8qMAMix9eR+4Dh7xFoQ5UP9wJgeO7Hi5f661 pthPMHeyUP+oyygw4jN8pcuWx2LlIrmBonZj9Sathv/BuuwjOEXfoUnj2GvMkEWbtFTX xZHUNMgAcUi1VEu0KlNpFFaBy+kpICNy1JuyENo/XTp3LROjijnuEi7MKddKxgldlUfj oExR0Vv4ZLvvO5OMrCJ3dmClo2OKjzQKkrc2/l4sR92JYiE2bL6LIKhCZyZKnAor/hMJ Smz8snb1fnnTU/cHAVeRqQexiqHR7RBU0fxVucBNEVlVITEQSC79T4g4qwcV+8cg3BLC 08Dg== X-Forwarded-Encrypted: i=1; AJvYcCXgbBLV5PUtvPaIesoCWl/1Ayo/3QXXjPx3qsPVij4L9KfxgGZYTpS+o41ne0zT2L/rybQBNd1cA02G7bc=@vger.kernel.org X-Gm-Message-State: AOJu0YxpC9S3QLNvyGN36SXkunxda0opYpYx8C9SB1VlLB+0e0VrekIo Hd0cCj1iGUPDkpOoZgZr7Gn9GUmuKPlzDOoH+nrqQVR826yPRilhiy3S X-Gm-Gg: ATEYQzzmmqtkbpjNqhP7UQxTt0Sm6I0FDgbpx8CVeVIpGneult2tiZPyFiWJ3nu161M P+gvZLiDgNTVyZtzoAI4pndGvOTRaJduZ4L1xWbvp80LJ2pEcv6o34EKF6IiMZOlxEGIxF1fmT7 5G3xH2mHzB2RptiTSC6f+S318aQoVz8XKYhNnKIFzyAxYTwl3Rem1ZELBG2uzB+/Z1AxmImaMcb 6KXvv5yETdzQ4/ll3+PDqTDrobEJUWzIpQQmkIfMdKG0b3s2ukciU52qzSK646mZtjCvlWsqf8h PvvSYLqJnoPjVymkC878dW9yDIgfZi1cNnLoxUP1mDqlaLg9cu6hYIP9y3AiTC1VQrh2ko4Ex+c Qo9zvm4usGuZqF5Z9G8tByyJaHIN7sy/bnSyGZiESYcc3yoAYVUhONOtYUZN+90ztxmXIuYD45k PSov+Yq5GzeTxHIt0ffOEBbW+tsN6KlRkZKGFaMlfygqd9xoC6iUgIuL5tiA== X-Received: by 2002:a05:6000:2881:b0:437:711c:8754 with SMTP id ffacd0b85a97d-439da55541cmr29415959f8f.7.1773164933500; Tue, 10 Mar 2026 10:48:53 -0700 (PDT) Received: from db07.1337.ma ([197.230.240.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae45786sm42986166f8f.32.2026.03.10.10.48.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 10:48:52 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, me@brighamcampbell.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v2 5/5] iio: dac: ad5504: add optional GPIO control for CLR and LDAC Date: Tue, 10 Mar 2026 17:48:35 +0000 Message-ID: <20260310174835.24209-6-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260310174835.24209-1-0rayn.dev@gmail.com> References: <20260310174835.24209-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support for the optional 'clear-gpios' and 'ldac-gpios' properties defined in the device tree bindings. Use devm_gpiod_get_optional() with GPIOD_OUT_LOW to ensure the pins are initialized to their inactive state. Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index cd563460fc0a..58538f5263fc 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -7,7 +7,9 @@ =20 #include #include +#include #include +#include #include #include #include @@ -48,6 +50,8 @@ * @vref_mv: actual reference voltage used * @pwr_down_mask: power down mask * @pwr_down_mode: current power down mode + * @gpio_clear: GPIO descriptor for the /CLR pin + * @gpio_ldac: GPIO descriptor for the /LDAC pin * @data: transfer buffer */ struct ad5504_state { @@ -56,6 +60,8 @@ struct ad5504_state { unsigned short vref_mv; unsigned pwr_down_mask; unsigned pwr_down_mode; + struct gpio_desc *gpio_clear; + struct gpio_desc *gpio_ldac; =20 __be16 data[2] __aligned(IIO_DMA_MINALIGN); }; @@ -299,6 +305,14 @@ static int ad5504_probe(struct spi_device *spi) if (pdata && pdata->vref_mv) st->vref_mv =3D pdata->vref_mv; =20 + st->gpio_clear =3D devm_gpiod_get_optional(dev, "clear", GPIOD_OUT_LOW); + if (IS_ERR(st->gpio_clear)) + return PTR_ERR(st->gpio_clear); + + st->gpio_ldac =3D devm_gpiod_get_optional(dev, "ldac", GPIOD_OUT_LOW); + if (IS_ERR(st->gpio_ldac)) + return PTR_ERR(st->gpio_ldac); + st->spi =3D spi; indio_dev->name =3D spi_get_device_id(st->spi)->name; indio_dev->info =3D &ad5504_info; --=20 2.47.3