From nobody Thu Apr 9 07:16:33 2026 Received: from mail-yw1-f225.google.com (mail-yw1-f225.google.com [209.85.128.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96B0330B52B for ; Tue, 10 Mar 2026 14:42:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773153748; cv=none; b=R+r5EdFIvDk4pi39SEamwpgem0GaBq5vpJ41bM5921d2NNZ2aIO6rL867dNjFjm5cfegarfsPjqIgrk9F3Gd4UKqqhiIh/3imXNk8nsuyDUdhaeuhyVUPKtYc1lRJnaVb3xnOX489bQBeIHr3s7GFnl9WTwGrBwXDbI5LI+W8EU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773153748; c=relaxed/simple; bh=2dSqv9SKAmQyIiVz6uMiFbeoTsqTWFo88VA9jUePmV4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XaDuW9hk1a66DpDRpC+SF58vsjpZdX58lOskAzr+HTOKAOL/3mX75I789vIz8G9MQjxnAvIqbhwc1ez+Som0SYEjNhNL46e5qGUKcwzIPMrBUFSOUdPZ0vLpsJSdyeTWyzBFJg1L1Zt/oyMRaJpz23/Yh+MkZam/TkL11b8Gdpg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=B+XQa83+; arc=none smtp.client-ip=209.85.128.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="B+XQa83+" Received: by mail-yw1-f225.google.com with SMTP id 00721157ae682-799001d73bdso14915777b3.0 for ; Tue, 10 Mar 2026 07:42:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773153746; x=1773758546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uLlu963kRco1uT795rjGcEctBvQz2SJy9aG5P2+yFUM=; b=UInV5ulf/w7C9nVj0tT4TmCJFOMYg4xG84dnOp8Nd9Yj9N6dsJgi1LOfy+lSns3N3Z M18HqCmS4j6Q6tJvpsVLjnoh4vskyPcqiOTocTbKAHLgjrB9FNMiCWQnC78oWsnzHloE 60tmYuCHod2CRKvZ1O9v+IhQiVkDISrsgrf1U26mjVE6VaXS2huQu2gDO4nmemEi9vnH 1sdQA1FCwD6drz27cUd9QChWF4gs0VJ4Ue6sNIAiZ9mFC9zEWdWKZLc3TNlndWjHURyl mqVo1jzk3AkGX1wQSvCi6/9MhF93L1L+R/h6g0+Ahd9mxGwUkncCl72xojdD7nRYQRkL LRQA== X-Forwarded-Encrypted: i=1; AJvYcCXCMPqOv4sNe+yxoWFBZknZsf4ly3xXqSun7IZvNGngd8A9Bnp0GdMP/pXjcGQD5jplEQ7qw+ruv34FZ7s=@vger.kernel.org X-Gm-Message-State: AOJu0YwEcH6bMifuNJgLRCiBhGLS58Gzx0RYzgGMihc4OWbqPAqCO6Rx HSez3FzwKEbT9O6MPDAaXwnD04jD7RBhBzNGcsaBT5neQ4oGfc5CW50ShK67bY33T/ssyBG6J7T eW/jK9Bt4hAwzltON/FfzhnR/RrMpNT3t77SxKzB7pDz0n9D1pjQKDKnqZyHtP7cHitY6/eqEvW 6dRmAoAJm6UhvAucC92Jpq6EHM0qx0FPgvKmqcrnWcQx0ikknvODaKWFhSoOOX5/W9pQrrxJxnc Lm42IXwV/rFKdObgUTIqw26Mw== X-Gm-Gg: ATEYQzwHkTiLBb93yqnLLy1HmYihpUPMuHAwInHjsx2TpihS4xvvLEdvLEu2j/VkOWa hl6wz8PpTAssBEUOM1gbzSmPGcgl8Q/mlKLr1LnszorkvOHAKEHVKkFXHXm8KB1NWLZuXo8u6YT uCMOG8q8zo8z35IEYLE+PnAsJt83QxJFP/ndNcHdYBRfeH1gk0OjqjPKxjohLBymaRp1GmOXOv4 PDA+AM4nWFqt4JBSC1yw3ysEv13WQsrReSXu78zPjuUy6dpoAUi/kC9gCE0l//a3a9/TTxB+3+Z erPFeiY1juuAhQlZzXHuO2wa0LIE6yJQloGHJVMIsBbbFemrZuSY0pkRtt6/wGpcZHbDnUFA2Ih hIscs0tiX4rrHWS+GTO+CXnLlQgKNnxnr+RQyh79j2SSrNn2Um9Tz9rA1dDY3iKT0X62LN9cz/U XVm190Za72ST200NWLl1dQUwmc7waAyZX3Nb9gJzkqNbkx6/tCpb7emxNGy9ICoK3pJQ== X-Received: by 2002:a05:690c:1d:b0:798:7039:eebb with SMTP id 00721157ae682-798dd7707b3mr146398007b3.45.1773153745551; Tue, 10 Mar 2026 07:42:25 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-7990a52ffe0sm2502257b3.10.2026.03.10.07.42.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2026 07:42:25 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ae405e95f5so106430565ad.2 for ; Tue, 10 Mar 2026 07:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773153744; x=1773758544; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uLlu963kRco1uT795rjGcEctBvQz2SJy9aG5P2+yFUM=; b=B+XQa83+2dMY2fBRZDuo4ztk6kBLoLo8G45tWX3ulnPmCYTU4QSQ20CaT2P3gHiRnA Qjl4yvdh5Utx0N9R6ZHrTdOZ7b9aDPF23vdIRc38ltPA10G0Mff806h5O+OfoH6WoCCl j9VDeLLWBMdcqs6xWt2cd10an+5JnLFEQX5DI= X-Forwarded-Encrypted: i=1; AJvYcCUVgTYu474ZnfiUggLFJgZ5fmpQQ/7f0btBYLpMvOcRTuVND2+QyD3ZehvGeYQuPpwv8nUIpuSRD00IURs=@vger.kernel.org X-Received: by 2002:a17:902:e808:b0:2ae:a481:2a4f with SMTP id d9443c01a7336-2aea4812ce0mr31436395ad.12.1773153744072; Tue, 10 Mar 2026 07:42:24 -0700 (PDT) X-Received: by 2002:a17:902:e808:b0:2ae:a481:2a4f with SMTP id d9443c01a7336-2aea4812ce0mr31436035ad.12.1773153743607; Tue, 10 Mar 2026 07:42:23 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f783cfsm157096515ad.56.2026.03.10.07.42.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 07:42:23 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Ajit Kumar Khaparde Subject: [PATCH net-next v6 08/10] bng_en: implement ndo_get_stats64 Date: Tue, 10 Mar 2026 20:10:42 +0530 Message-ID: <20260310144044.21672-9-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260310144044.21672-1-bhargava.marreddy@broadcom.com> References: <20260310144044.21672-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement the ndo_get_stats64 callback to report aggregate network statistics. The driver gathers these by accumulating the per-ring counters into the provided rtnl_link_stats64 structure. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 105 ++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + 2 files changed, 106 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 43446f3f5bd2..03872bde4cd0 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2911,6 +2911,102 @@ static int bnge_shutdown_nic(struct bnge_net *bn) return 0; } =20 +static void bnge_get_ring_stats(struct bnge_dev *bd, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr =3D &bnapi->nq_ring; + u64 *sw =3D nqr->stats.sw_stats; + + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + + stats->rx_missed_errors +=3D + BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + + stats->multicast +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + + stats->tx_dropped +=3D BNGE_GET_RING_STATS64(sw, tx_error_pkts); + + stats->rx_dropped +=3D + nqr->sw_stats->rx.rx_netpoll_discards + + nqr->sw_stats->rx.rx_oom_discards; + } +} + +static void bnge_add_prev_stats(struct bnge_net *bn, + struct rtnl_link_stats64 *stats) +{ + struct rtnl_link_stats64 *prev_stats =3D &bn->net_stats_prev; + + stats->rx_packets +=3D prev_stats->rx_packets; + stats->tx_packets +=3D prev_stats->tx_packets; + stats->rx_bytes +=3D prev_stats->rx_bytes; + stats->tx_bytes +=3D prev_stats->tx_bytes; + stats->rx_missed_errors +=3D prev_stats->rx_missed_errors; + stats->multicast +=3D prev_stats->multicast; + stats->rx_dropped +=3D prev_stats->rx_dropped; + stats->tx_dropped +=3D prev_stats->tx_dropped; +} + +static void bnge_get_stats64(struct net_device *dev, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_dev *bd =3D bn->bd; + + rcu_read_lock(); + if (!test_bit(BNGE_STATE_OPEN, &bd->state)) { + rcu_read_unlock(); + *stats =3D bn->net_stats_prev; + return; + } + + bnge_get_ring_stats(bd, stats); + bnge_add_prev_stats(bn, stats); + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + u64 *rx =3D bn->port_stats.sw_stats; + u64 *tx =3D bn->port_stats.sw_stats + + BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + + stats->rx_crc_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_fcs_err_frames); + stats->rx_frame_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_align_err_frames); + stats->rx_length_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_undrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_ovrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_runt_frames); + stats->rx_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_false_carrier_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_jbr_frames); + stats->collisions =3D + BNGE_GET_TX_PORT_STATS64(tx, tx_total_collisions); + stats->tx_fifo_errors =3D + BNGE_GET_TX_PORT_STATS64(tx, tx_fifo_underruns); + stats->tx_errors =3D BNGE_GET_TX_PORT_STATS64(tx, tx_err); + } + rcu_read_unlock(); +} + static void bnge_close_core(struct bnge_net *bn) { struct bnge_dev *bd =3D bn->bd; @@ -2918,10 +3014,18 @@ static void bnge_close_core(struct bnge_net *bn) bnge_tx_disable(bn); =20 clear_bit(BNGE_STATE_OPEN, &bd->state); + synchronize_rcu(); =20 timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); + + /* Save ring stats before shutdown */ + if (bn->bnapi) { + bnge_get_ring_stats(bd, &bn->net_stats_prev); + bnge_get_ring_err_stats(bn, &bn->ring_err_stats_prev); + } + bnge_free_all_rings_bufs(bn); bnge_free_irq(bn); bnge_del_napi(bn); @@ -2971,6 +3075,7 @@ static const struct net_device_ops bnge_netdev_ops = =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, .ndo_start_xmit =3D bnge_start_xmit, + .ndo_get_stats64 =3D bnge_get_stats64, .ndo_features_check =3D bnge_features_check, }; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index ca1977b58964..6be7dbe44be8 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -381,6 +381,7 @@ struct bnge_net { =20 u64 flags; =20 + struct rtnl_link_stats64 net_stats_prev; struct bnge_total_ring_err_stats ring_err_stats_prev; =20 struct bnge_stats_mem port_stats; --=20 2.47.3