From nobody Thu Apr 9 07:18:07 2026 Received: from mail-pj1-f100.google.com (mail-pj1-f100.google.com [209.85.216.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B13B42F3C1F for ; Tue, 10 Mar 2026 14:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773153743; cv=none; b=mXChtjQTkCrU/XnmGZo+Cghf+/MvRHi9I6ua8JWX2VxMQ7P8Qj8ebbOFS65Dt/ZJ/w5eva9+dGduH+MCI5kIk+ERqSxf55t3Mgwt5cSexJH7Pb7/1EO3k1Ie1MBqSqY7mFMsMp3P+HUEvDpRq2dcC6wOA0tYq0V1JRJR0zn7AKo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773153743; c=relaxed/simple; bh=IefuflICElXt+Je/MhJVI1wpKed2MkFOQ2tMDVhy794=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oZyUO537ztfDrRQtWUmqms0VWFB4wMcvOQtaIJOwQ3uj8BcUiVA+dtWVQ0xHplVXKZipIHhjnhfcNTb6PkXgVxEmfBW2EyH/h1Ox9NK+rDup6yR7KMOOnodfGWqXWLd4WEUiKVrX9UzVw67WQptvtVErId0GEoF//OWJpZWLSF4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=JonHzeZK; arc=none smtp.client-ip=209.85.216.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="JonHzeZK" Received: by mail-pj1-f100.google.com with SMTP id 98e67ed59e1d1-3598b95ad7dso7248776a91.2 for ; Tue, 10 Mar 2026 07:42:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773153741; x=1773758541; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FFhaAtyoG1qP3yVuZbSFuyoblIxRrrEm1ql3jhQTY0s=; b=s1xrBvKh9y7uOVCxUBdSLgbjO0nx+Fsvd0qS0w1xghBmnjl2L3zp8nf2LIPggJ4yuZ zFggt844BDqTaLUT4IGhZp2FER9DpqEFlxVOZKiUbjV8RNKFLdvfjzKJ3G3yiZL7JTJD /NHl4Lp2WVVdp7aafAKXwCt7z6MSsQuXrOlq/wgX3Cln9/AKCbeTVIvRL9QitFR4oUPd cXUg7JB/lu3GqY0wwgtNrqdp/Yra5rcGd5a6VC0Tvwebo7YqhFMY0uggJjuEgtoToV/r l6UB65jRLAvZNQu1x3KUNElQrN1E0lBP5qum5q0pl75i3D3l5zPgXxs46Dy3pHBu5mdP FjJw== X-Forwarded-Encrypted: i=1; AJvYcCXUHAXfspHC8H6fTPtXLNRhmT1CXzP36D8KdB29QL3Da+BM5jzItQDHqIRQlKtYyZEeBsDyydgkfP4R2Rw=@vger.kernel.org X-Gm-Message-State: AOJu0YztWf9UETwgXGnsQTMK73NbSmEKvFiaU/jE+vpDp0UcdspYcCnC KNhlTIfxm8LSnjyV9X3GabD/N61VC0ENHscToaWOjJWm5KoMmnNwXG3aN831GkIsRBUshoQgzWL jz+bYjnIrqx5uGDxM1Ji1Shlp0Gg8lnc1i2Zsfa0pQg8pM7LGCUDBh6GJueFB97C20Vkcqq7pAy J8KCxGModtXyIhkr5z2XR4JBxRs+a4auNsDEar/dhUNDyF0t9JGf64gfu4asjzY/8qlosM79U9k RPfNuay9nc8x2JgtxkAnItgfQ== X-Gm-Gg: ATEYQzxLCK0VcrSmEv3wcbIH7IY9nKvW2xlr1F09m4UXbSgaASRp4+LediFG+vEa4np MK418DNSOsKzUJSTY3+M1EaKaCodJWYVXylLI9IQh/vsjlvHcvNZzbu5DSMLxmZ5ptrNw5R5DRc BMHPGBKrlnCOUBG7Qh0erdli8MgZJGbWtUKaUT4au9emhcWLiC3y2xE2o10XGqQx0awCZdAhKhU dRJZFi1QeI605uhU6nK4RqzbQ3rkUY7kj9N128lssav5XXqbGzIWqXiWxY/jri8VhzTaoz+4/jH dZ9ZqtDsCQCwFwmcmmdLMQ3ocLcDGMtuWlzVz0z9ZHAKmkKhQgUH3xNKOhxGjmPJkJxoWS3sd2t Id+esT7IHr0YdS4iwcVhBrIlNAUxKyyVqgvnMkouhkT8/FziDw8P1vJ371//Hr95BeGY9/Q1EKw IwF79FsPyy1H2xjOKQ5dae/nikfEufn0yzBpBC+SeunRyhgH+BZrmydOnXqU3G7UcLdQ== X-Received: by 2002:a17:90a:fc45:b0:359:df9:c9f9 with SMTP id 98e67ed59e1d1-359be281d90mr15019244a91.7.1773153741209; Tue, 10 Mar 2026 07:42:21 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-359f08af47dsm317020a91.7.2026.03.10.07.42.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2026 07:42:21 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ae62c87973so389862445ad.1 for ; Tue, 10 Mar 2026 07:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773153739; x=1773758539; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FFhaAtyoG1qP3yVuZbSFuyoblIxRrrEm1ql3jhQTY0s=; b=JonHzeZK797E8e21zQlpPzA4hwzi9P7LW/Hr3K/gCh0p3Sxj5dmSp1UWcZjRMfzTXQ kptGInEaEoPziGdMdM1TXX2nTRTMIAaEWq9vQRe7tHLJAAg0TcQG5w8x6gIYRafMpySu 5FS3h6nseVJ1KX4gpcm7068FKMFT4wt6CxJ8M= X-Forwarded-Encrypted: i=1; AJvYcCWhcKINrjDmGiUSkYS3RalpIBscSoxaJi8OvsXT+FbJ7vRZWBvTF39ktq5dnxBT5ggL8w7oP+C2Y2mdoBI=@vger.kernel.org X-Received: by 2002:a17:903:2409:b0:2ae:55eb:f82d with SMTP id d9443c01a7336-2ae823681eamr163302405ad.1.1773153739144; Tue, 10 Mar 2026 07:42:19 -0700 (PDT) X-Received: by 2002:a17:903:2409:b0:2ae:55eb:f82d with SMTP id d9443c01a7336-2ae823681eamr163301995ad.1.1773153738687; Tue, 10 Mar 2026 07:42:18 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f783cfsm157096515ad.56.2026.03.10.07.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 07:42:18 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rahul Gupta , Ajit Kumar Khaparde Subject: [PATCH net-next v6 07/10] bng_en: periodically fetch and accumulate hardware statistics Date: Tue, 10 Mar 2026 20:10:41 +0530 Message-ID: <20260310144044.21672-8-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260310144044.21672-1-bhargava.marreddy@broadcom.com> References: <20260310144044.21672-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Use the timer to schedule periodic stats collection via the workqueue when the link is up. Fetch fresh counters from hardware via DMA and accumulate them into 64-bit software shadows, handling wrap-around for counters narrower than 64 bits. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rahul Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 90 +++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + 2 files changed, 91 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 0b8131d9df46..43446f3f5bd2 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -322,9 +322,93 @@ static void bnge_timer(struct timer_list *t) } } =20 + if (BNGE_LINK_IS_UP(bd) && bn->stats_coal_ticks) + bnge_queue_sp_work(bn, BNGE_PERIODIC_STATS_SP_EVENT); + mod_timer(&bn->timer, jiffies + bn->current_interval); } =20 +static void bnge_add_one_ctr(u64 hw, u64 *sw, u64 mask) +{ + u64 sw_tmp, sw_val; + + hw &=3D mask; + sw_val =3D READ_ONCE(*sw); + sw_tmp =3D (sw_val & ~mask) | hw; + if (hw < (sw_val & mask)) + sw_tmp +=3D mask + 1; + WRITE_ONCE(*sw, sw_tmp); +} + +static void __bnge_accumulate_stats(__le64 *hw_stats, u64 *sw_stats, u64 *= masks, + int count) +{ + int i; + + for (i =3D 0; i < count; i++) { + u64 hw =3D le64_to_cpu(READ_ONCE(hw_stats[i])); + + if (masks[i] =3D=3D -1ULL) + sw_stats[i] =3D hw; + else + bnge_add_one_ctr(hw, &sw_stats[i], masks[i]); + } +} + +static void bnge_accumulate_stats(struct bnge_stats_mem *stats) +{ + if (!stats->hw_stats) + return; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + stats->hw_masks, stats->len / 8); +} + +static void bnge_accumulate_all_stats(struct bnge_dev *bd) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + struct bnge_stats_mem *ring0_stats =3D NULL; + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + struct bnge_stats_mem *stats; + + nqr =3D &bnapi->nq_ring; + stats =3D &nqr->stats; + + if (!ring0_stats) + ring0_stats =3D &bn->bnapi[0]->nq_ring.stats; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + ring0_stats->hw_masks, + ring0_stats->len / 8); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + struct bnge_stats_mem *stats =3D &bn->port_stats; + __le64 *hw_stats =3D stats->hw_stats; + u64 *sw_stats =3D stats->sw_stats; + u64 *masks =3D stats->hw_masks; + u16 cnt; + + cnt =3D sizeof(struct rx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + + hw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + sw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + masks +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + cnt =3D sizeof(struct tx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS_EXT) { + bnge_accumulate_stats(&bn->rx_port_stats_ext); + bnge_accumulate_stats(&bn->tx_port_stats_ext); + } +} + static void bnge_sp_task(struct work_struct *work) { struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); @@ -336,6 +420,12 @@ static void bnge_sp_task(struct work_struct *work) return; } =20 + if (test_and_clear_bit(BNGE_PERIODIC_STATS_SP_EVENT, &bn->sp_event)) { + bnge_hwrm_port_qstats(bd, 0); + bnge_hwrm_port_qstats_ext(bd, 0); + bnge_accumulate_all_stats(bd); + } + if (test_and_clear_bit(BNGE_UPDATE_PHY_SP_EVENT, &bn->sp_event)) { int rc; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 10ecd5d64a87..ca1977b58964 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -304,6 +304,7 @@ enum bnge_sp_event { BNGE_LINK_SPEED_CHNG_SP_EVENT, BNGE_LINK_CFG_CHANGE_SP_EVENT, BNGE_UPDATE_PHY_SP_EVENT, + BNGE_PERIODIC_STATS_SP_EVENT, }; =20 struct bnge_net { --=20 2.47.3