From nobody Thu Apr 9 07:16:34 2026 Received: from mail-pl1-f227.google.com (mail-pl1-f227.google.com [209.85.214.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C5DC2F12CE for ; Tue, 10 Mar 2026 14:41:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773153711; cv=none; b=oRw7P+S9U/1SGy8DOZcRc0oHgqHT4DB7NO4NYGWqyG+0ExAObgzPW+CUcxfkotvkKybqiUveCN017mWFhsdGsSNInYFhrblObiwAbI+wf+e7GLWrkojlEg+84EJLALzkUbVPa6XcFD1Rvfvs9HBDkmQqEVOWVLj6F2bS8HwxKuI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773153711; c=relaxed/simple; bh=ySQy8CSrm4/UQYQ/rVVTsVt3TBD7/hFBFDy3F0p9YuU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cE989DlSKXbxQ/yz1Wh74vgIYUSanmEH6ew45JfQTFuymusAbGFoB25pGRX7QVPspN7tHdSJ9pszu94xZyr+wHgW3ZUR5hF8xHURaDD5RZA25PSmAmYj9JDomPNFX+fJqw97cF1suTe79fiDLWtGByUPmXoM1vhQhs6qQ+Of2MU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=I/iJSqm6; arc=none smtp.client-ip=209.85.214.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="I/iJSqm6" Received: by mail-pl1-f227.google.com with SMTP id d9443c01a7336-2ae3a2f6007so74632635ad.2 for ; Tue, 10 Mar 2026 07:41:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773153710; x=1773758510; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qRikypN/LpT75/NMboweiLacdsHYIINoiM+NXjDT2RA=; b=ivGjf2njv/42FhgfKoQZcvUpdHE98PaqkfIeVxwNkjM0GfeoIJ+46oZA62EsbfYF9T PPCdcxLUUUZLYERRIbL2k4uWPV3oS2T+roPpv00JkKM6BlEODGj2+V3+Jh/48SI+ujYJ Qa8jePV0wdYLvH3Om2b9CiuxXlS8dWGpiGMJ0c2u2BYv0bk/Om9YaK1xSmjtlNkXk4RD KCKMZ4xZtSyKzJTNedsP0MQz+x7FRqknFEPWdLt7SE2xnTAq+kTBhbpcrYWSgAY7TAfR lthuVVPLtuS/5rn+TbdTVxY3Qiqnb3GyMIt48/Ga8hCbcAnOgulspLsM9IPdfalPDghs rX0Q== X-Forwarded-Encrypted: i=1; AJvYcCW9AlY+D/hRVe/fPBucTE9A1Gs6YB/Z20jcsn/z1CUlgreRizlJKbXwWVymjdMgb0jWifhzd0gt/IXo9XA=@vger.kernel.org X-Gm-Message-State: AOJu0YyHrJ2tIBNLj38iwjCfs2SgSlj1da8/qPn/LMVZb0EpUBZbAY7U gpxI1osWc+onFibK5+6d74yG2hoA4Me7UiITCG7jP62RzBULJIyAKM9lfspJ9TQ0Mp1aqB5X1z7 skuA01LvTfZqHnQpfO8sXrVz4xjh9gNccTxsBpAMXqzzve3X8cvit+A5ZSDYZE1Clk6G9gs/s6b Rc7eAVcLnH2k0CIIXBN4V9E9HPiOT8GBD0XlaHkGDLFji5Kd+4LqQ31HrG6eLasefjFUfA46Im5 wqcoqaNodwXFvF0AFhLzJbg/Q== X-Gm-Gg: ATEYQzyimdha7EfHY0+cWQZg3YlcTFpM6Fp09NjLzdwhxh9frLqK3PsWKsFbLMBcNIi +qGzsCd0nKEQxMbpqEh3ydnGjYmprPBt9pDar/qlOYhFJCQxeVlQsSBtK+PczsJHLXAigatCS0/ SA+8RStCwYU5JybuQgItSsLPrpzhk1+gGlz+cgv2o7ca/uua/JrvHvJGRlMZKOEP7bybw76ZOHd shtEIz/KzE2Mv0Nt8yob867SO4BPtr3+svoQP28kBq6lr5BLYG1D1/LHxrcW3eiZrJpMglcSrnd Z5wm6+uQF2oxmrmeVHb7f4d3wTFuf3AWIxiR/mcqyqkLWnoXMnEC+MpxGPJR8A0mCeXXX7jztGU KEUiQEDcln9AHPj6PgCY1iJArt6G4coEtBW6PFBg1kKgE0Jvllp49MixhyoRu5zoHa6LKR7ClRs ME3Nemueo8MX1JE/eStmP1mmTWRFvU6HLL68fzR2Gb/RpNouKlCSXmkmG3QeJd/V+3cQ== X-Received: by 2002:a17:903:32cd:b0:2ae:aad7:5811 with SMTP id d9443c01a7336-2aeaad75e03mr7301045ad.11.1773153709767; Tue, 10 Mar 2026 07:41:49 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-102.dlp.protect.broadcom.com. [144.49.247.102]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2ae83e9c46bsm19052505ad.24.2026.03.10.07.41.49 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2026 07:41:49 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2aeabe9b4bbso385895ad.0 for ; Tue, 10 Mar 2026 07:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773153708; x=1773758508; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qRikypN/LpT75/NMboweiLacdsHYIINoiM+NXjDT2RA=; b=I/iJSqm6HgJT5X6rRRcffcpeWsCpQX5VaVHXQLW+yVsyX61HzZvWbPpzkxG2bFsiNL ThAKzJ3AcfcKrNm5cJng2z/pVdE6ZZ6TQSfAppeeyhenLXslRjxBeSuSp9+fmcX9hdaY WaZWWc1C1b6jMoQHTQq5QKddyqVEPwV8egP1Q= X-Forwarded-Encrypted: i=1; AJvYcCXACu3KZGnTdQIs/4/vsBs1/zvPn7bzrjQZz3zlUcXSmLZDTtf+zOtLzgmgv9YAErZ2rLNTfXsD43aQwEg=@vger.kernel.org X-Received: by 2002:a17:903:1cd:b0:2ae:62c8:771a with SMTP id d9443c01a7336-2ae8241e451mr158896315ad.5.1773153707961; Tue, 10 Mar 2026 07:41:47 -0700 (PDT) X-Received: by 2002:a17:903:1cd:b0:2ae:62c8:771a with SMTP id d9443c01a7336-2ae8241e451mr158895975ad.5.1773153707496; Tue, 10 Mar 2026 07:41:47 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f783cfsm157096515ad.56.2026.03.10.07.41.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 07:41:47 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Ajit Kumar Khaparde Subject: [PATCH net-next v6 01/10] bng_en: add per-PF workqueue, timer, and slow-path task Date: Tue, 10 Mar 2026 20:10:35 +0530 Message-ID: <20260310144044.21672-2-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260310144044.21672-1-bhargava.marreddy@broadcom.com> References: <20260310144044.21672-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Add a dedicated single-thread workqueue and a timer for each PF to drive deferred slow-path work such as link event handling and stats collection. The timer is stopped via timer_delete_sync() when interrupts are disabled and restarted on open. The open and close paths now start and drain these resources. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 74 ++++++++++++++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 12 ++- 2 files changed, 84 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index a20dc3ca640c..edbb42efb70b 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -101,6 +101,36 @@ static int bnge_alloc_ring_stats(struct bnge_net *bn) return rc; } =20 +static void bnge_timer(struct timer_list *t) +{ + struct bnge_net *bn =3D timer_container_of(bn, t, timer); + struct bnge_dev *bd =3D bn->bd; + + if (!netif_running(bn->netdev) || + !test_bit(BNGE_STATE_OPEN, &bd->state)) + return; + + /* Periodic work added by later patches */ + + mod_timer(&bn->timer, jiffies + bn->current_interval); +} + +static void bnge_sp_task(struct work_struct *work) +{ + struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); + struct bnge_dev *bd =3D bn->bd; + + netdev_lock(bn->netdev); + if (!test_bit(BNGE_STATE_OPEN, &bd->state)) { + netdev_unlock(bn->netdev); + return; + } + + /* Event handling work added by later patches */ + + netdev_unlock(bn->netdev); +} + static void bnge_free_nq_desc_arr(struct bnge_nq_ring_info *nqr) { struct bnge_ring_struct *ring =3D &nqr->ring_struct; @@ -2507,6 +2537,9 @@ static int bnge_open_core(struct bnge_net *bn) bnge_enable_int(bn); =20 bnge_tx_enable(bn); + + mod_timer(&bn->timer, jiffies + bn->current_interval); + return 0; =20 err_free_irq: @@ -2542,6 +2575,8 @@ static void bnge_close_core(struct bnge_net *bn) bnge_tx_disable(bn); =20 clear_bit(BNGE_STATE_OPEN, &bd->state); + + timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); bnge_free_all_rings_bufs(bn); @@ -2690,6 +2725,23 @@ static void bnge_init_ring_params(struct bnge_net *b= n) bn->netdev->cfg->hds_thresh =3D max(BNGE_DEFAULT_RX_COPYBREAK, rx_size); } =20 +static struct workqueue_struct * +bnge_create_workqueue_thread(struct bnge_dev *bd, const char *thread_name) +{ + struct workqueue_struct *wq; + char *wq_name; + + wq_name =3D kasprintf(GFP_KERNEL, "%s-%s", thread_name, + dev_name(bd->dev)); + if (!wq_name) + return NULL; + + wq =3D create_singlethread_workqueue(wq_name); + kfree(wq_name); + + return wq; +} + int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) { struct net_device *netdev; @@ -2774,6 +2826,17 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_i= rqs) if (bd->tso_max_segs) netif_set_tso_max_segs(netdev, bd->tso_max_segs); =20 + INIT_WORK(&bn->sp_task, bnge_sp_task); + timer_setup(&bn->timer, bnge_timer, 0); + bn->current_interval =3D BNGE_TIMER_INTERVAL; + + bn->bnge_pf_wq =3D bnge_create_workqueue_thread(bd, "bnge_pf_wq"); + if (!bn->bnge_pf_wq) { + netdev_err(netdev, "Unable to create workqueue.\n"); + rc =3D -ENOMEM; + goto err_netdev; + } + bn->rx_ring_size =3D BNGE_DEFAULT_RX_RING_SIZE; bn->tx_ring_size =3D BNGE_DEFAULT_TX_RING_SIZE; bn->rx_dir =3D DMA_FROM_DEVICE; @@ -2789,11 +2852,13 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_= irqs) rc =3D register_netdev(netdev); if (rc) { dev_err(bd->dev, "Register netdev failed rc: %d\n", rc); - goto err_netdev; + goto err_free_workq; } =20 return 0; =20 +err_free_workq: + destroy_workqueue(bn->bnge_pf_wq); err_netdev: free_netdev(netdev); return rc; @@ -2802,8 +2867,15 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_i= rqs) void bnge_netdev_free(struct bnge_dev *bd) { struct net_device *netdev =3D bd->netdev; + struct bnge_net *bn; + + bn =3D netdev_priv(netdev); =20 unregister_netdev(netdev); + + cancel_work_sync(&bn->sp_task); + destroy_workqueue(bn->bnge_pf_wq); + free_netdev(netdev); bd->netdev =3D NULL; } diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 70f1a7c24814..d2ccee725454 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -224,6 +224,12 @@ struct bnge_tpa_info { #define BNGE_NQ_HDL_TYPE(hdl) (((hdl) & BNGE_NQ_HDL_TYPE_MASK) >> \ BNGE_NQ_HDL_TYPE_SHIFT) =20 +enum bnge_net_state { + BNGE_STATE_NAPI_DISABLED, +}; + +#define BNGE_TIMER_INTERVAL HZ + struct bnge_net { struct bnge_dev *bd; struct net_device *netdev; @@ -281,13 +287,17 @@ struct bnge_net { u32 stats_coal_ticks; =20 unsigned long state; -#define BNGE_STATE_NAPI_DISABLED 0 =20 u32 msg_enable; u16 max_tpa; __be16 vxlan_port; __be16 nge_port; __be16 vxlan_gpe_port; + + unsigned int current_interval; + struct timer_list timer; + struct workqueue_struct *bnge_pf_wq; + struct work_struct sp_task; }; =20 #define BNGE_DEFAULT_RX_RING_SIZE 511 --=20 2.47.3