From nobody Thu Apr 9 07:18:07 2026 Received: from mail-oi1-f228.google.com (mail-oi1-f228.google.com [209.85.167.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3093F30F534 for ; Tue, 10 Mar 2026 14:42:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773153752; cv=none; b=m6vRzup6NHz+dkCWq/0RigisHgcTMcCmjXyNwly8icUmCOU2lnY2Tq8oSK3C0ptpj5rByvKDSNnDYn7SPEF9uX5hGvCJvTssr8uKSwxFJpSWvpGVmCCILDMXCqEcSpEjKbeowUWl+EZONZxlcEppbzVSQPuX0P3YSXTdtmxwAGo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773153752; c=relaxed/simple; bh=1hQ7wBRfyBdlvAHHMP81Lep77Jp9gTqZ4XwucfvdPCE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Pgcx/S8OU4vPBos3T+xuZDTu7uZgab63mYl82ErTbNZVXB4ah1nP0JbnMLQUFWhsuxfQMJwxwAQB2XNfOOfS0jt04ZKUmEYe3L5nJTwErViE+Zm2wi3qcpO167dLiwFXiidYBh2gUbA1ByIK8RDxtU+CknItEs1fY1uG9KWUwtA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=HY6FyQit; arc=none smtp.client-ip=209.85.167.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="HY6FyQit" Received: by mail-oi1-f228.google.com with SMTP id 5614622812f47-4638e238094so6678620b6e.3 for ; Tue, 10 Mar 2026 07:42:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773153750; x=1773758550; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YgrgpAa7weTPNe9rPKP4yGtVm6kQnpFxYyGVYn0Ky0k=; b=UPBCqatMcqNfRsO5qGLvk9tK8nofjY3CgOUIKenRfsI1AvguxMuPWvXe2x0RGnEGTH gKtsir2hT2Pd/Zy4/ov1gDsKgHUzkMN62HY1/ptUspWv1OEkHgaXmqQS/KV3+FjZateP GE32V0/Y5dxPuyzEcVvzySB7IRq6iWfmg1V6gzcsRrddRShZU1ntr9VddFP6gdfJBjLP dM7DQQH/rLJUIjw8gbc2ot3tq8xs/MxUbtXxCPJ9HXIOno69HAB8ABDhA4Y477I9Ga4v mkNaMYQyPB174fAnmBx+ENFR9CVg8tPIUYHqLVORRJFLGhPrTRrN7ByBRo9hBucdkNCC wzbg== X-Forwarded-Encrypted: i=1; AJvYcCXhnqGjHFA0A9IfKK/eKan8l/8CvHNEZAG1xSd8sFeYExDS9eXDSHmTEOkOjWjaQ/50APdI5EtuI57HGVM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxlw3Ii66v2GqPZF31i2cEFcUHmFHvgcMu7OAdmgKPWfux+aZM4 EeZTpB9DkrnYS6nPztBUgxNMRcRat3vhhLSp/4ljMgPtJltJZe7ulD1VrSLsnATswV9O6qOcr2b oOf7fs5ogwclaaulI48jcInj1CLuv4Q5+U8dwUUjymebzDNheH54xCKMe22C+pzZCOI0L9G0yeg 14TL4UYK2yvS/nkwcI7b7brv66fkh9k5JmjsS7w9cYfplOmTXoJD1rPM/AnSnXUU/CdH74elnW2 684U/FpuyU4f7vhqtQS5jcVsw== X-Gm-Gg: ATEYQzxTe+LCxM2V+hddENgZBYEuu88CLABK4yO3/IT+J9qCOmR361Fp6wgpuBwBQQa w51Jqx1blrRchQNKjKOFJtfu9kpQJwCtHwVEH4dc/0T/6O96U1BIjeXySDQ0fIqVWKX0WehyPcp JnDWF81P79paAWJgj7jw5/hIMr1Yc8OhSgwyPCCbC4O27jXz/15rUDFgIf/p7vFUiMecsLhku8V 80jF7toHirzXAu06/YKNVkxQzRy+SQhKKiiYfn8krUktHdXx+ErFGb1dDW3lwYkyWwFdBggdykL kk5Ov3nEf4xfi5Cotmr5C5oF0gHDx01c91IV9klVOKeoQ30HlXfxz4GohVDepR7OixccrfEk4Jw 5L2saGAbl9ltAdzAMGPcC5U2t2gIq6NopYuqYURMgTd1cs437h9yG9gZ0+J8mBlFU9tLdJaeDDR pFfCWcdZ6wO5r09dQxmzaFgP82CozD6lixeJqlRPHzphsdbPB4GaLz2hH6FoG6i4HClA== X-Received: by 2002:a05:6808:1b26:b0:467:1504:eb13 with SMTP id 5614622812f47-4671504ef71mr2727951b6e.36.1773153750005; Tue, 10 Mar 2026 07:42:30 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-102.dlp.protect.broadcom.com. [144.49.247.102]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-41756de11d9sm415564fac.16.2026.03.10.07.42.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2026 07:42:29 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2ae6dd98043so65063145ad.3 for ; Tue, 10 Mar 2026 07:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773153748; x=1773758548; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YgrgpAa7weTPNe9rPKP4yGtVm6kQnpFxYyGVYn0Ky0k=; b=HY6FyQitYMgxLpRUwp+JBTZLgaCZ1tkthGV9AMEeWeNd8tPZHuLB6woHbi6CJTlnbk QRzAX5b2EEFchf6w2EzO9TbrsASBRX0J86UxTz8r4ixhY5tm1LIdwPCsH/pec1eIUytP Kbveq14WQinr8ugD0+cr3QCyV7P2uEDpBuRJk= X-Forwarded-Encrypted: i=1; AJvYcCXe1dxO768/v2m+4zVJ48j98DhKjOkYk+3qc78e/4gwuVYzMYk+G7NeMfzTFGIsLTL4uOgA6dlCfn/LCk4=@vger.kernel.org X-Received: by 2002:a17:902:c943:b0:2ae:7f28:124b with SMTP id d9443c01a7336-2ae8239e4bcmr157518875ad.22.1773153748659; Tue, 10 Mar 2026 07:42:28 -0700 (PDT) X-Received: by 2002:a17:902:c943:b0:2ae:7f28:124b with SMTP id d9443c01a7336-2ae8239e4bcmr157518705ad.22.1773153748196; Tue, 10 Mar 2026 07:42:28 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f783cfsm157096515ad.56.2026.03.10.07.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 07:42:27 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy Subject: [PATCH net-next v6 09/10] bng_en: implement netdev_stat_ops Date: Tue, 10 Mar 2026 20:10:43 +0530 Message-ID: <20260310144044.21672-10-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260310144044.21672-1-bhargava.marreddy@broadcom.com> References: <20260310144044.21672-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement netdev_stat_ops to provide standardized per-queue statistics via the Netlink API. The implementation was verified using the ynl tool: $ ./cli.py --spec netlink/specs/netdev.yaml --dump \ qstats-get --json '{"ifindex":5, "scope":"queue"}' [{'ifindex': 5, 'queue-id': 0, 'queue-type': 'rx', 'rx-alloc-fail': 0, 'rx-bytes': 1024, 'rx-packets': 10}, {'ifindex': 5, 'queue-id': 1, 'queue-type': 'rx', 'rx-alloc-fail': 0, 'rx-bytes': 2048, 'rx-packets': 20}, {'ifindex': 5, 'queue-id': 0, 'queue-type': 'tx', 'tx-bytes': 512, 'tx-packets': 5}, {'ifindex': 5, 'queue-id': 1, 'queue-type': 'tx', 'tx-bytes': 1536, 'tx-packets': 15}] Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 71 +++++++++++++++++++ 1 file changed, 71 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 03872bde4cd0..4925d31fc152 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -3071,6 +3071,76 @@ void bnge_get_ring_err_stats(struct bnge_net *bn, &bn->bnapi[i]->nq_ring); } =20 +static void bnge_get_queue_stats_rx(struct net_device *dev, int i, + struct netdev_queue_stats_rx *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_nq_ring_info *nqr; + u64 *sw; + + if (!bn->bnapi) + return; + + nqr =3D &bn->bnapi[i]->nq_ring; + sw =3D nqr->stats.sw_stats; + + stats->packets =3D 0; + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + stats->bytes =3D 0; + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + stats->alloc_fail =3D nqr->sw_stats->rx.rx_oom_discards; +} + +static void bnge_get_queue_stats_tx(struct net_device *dev, int i, + struct netdev_queue_stats_tx *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_napi *bnapi; + u64 *sw; + + if (!bn->tx_ring) + return; + + bnapi =3D bn->tx_ring[bn->tx_ring_map[i]].bnapi; + sw =3D bnapi->nq_ring.stats.sw_stats; + + stats->packets =3D 0; + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + stats->bytes =3D 0; + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); +} + +static void bnge_get_base_stats(struct net_device *dev, + struct netdev_queue_stats_rx *rx, + struct netdev_queue_stats_tx *tx) +{ + struct bnge_net *bn =3D netdev_priv(dev); + + rx->packets =3D bn->net_stats_prev.rx_packets; + rx->bytes =3D bn->net_stats_prev.rx_bytes; + rx->alloc_fail =3D bn->ring_err_stats_prev.rx_total_oom_discards; + + tx->packets =3D bn->net_stats_prev.tx_packets; + tx->bytes =3D bn->net_stats_prev.tx_bytes; +} + +static const struct netdev_stat_ops bnge_stat_ops =3D { + .get_queue_stats_rx =3D bnge_get_queue_stats_rx, + .get_queue_stats_tx =3D bnge_get_queue_stats_tx, + .get_base_stats =3D bnge_get_base_stats, +}; + static const struct net_device_ops bnge_netdev_ops =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, @@ -3234,6 +3304,7 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_ir= qs) bd->netdev =3D netdev; =20 netdev->netdev_ops =3D &bnge_netdev_ops; + netdev->stat_ops =3D &bnge_stat_ops; =20 bnge_set_ethtool_ops(netdev); =20 --=20 2.47.3