From nobody Thu Apr 9 08:51:37 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4A1A43DA29 for ; Tue, 10 Mar 2026 09:19:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773134401; cv=none; b=tg5AMddQM+G7RJcs6V0MqbBs0KgAUsqmorE0nMH6nnIdzozrd7Pwnw/CNRcyru15OjnTyRfuvlO1yyjlJBmCxplwe0taBL19w2LGz3XmlwUI327L2eh1XQAtx6KTHHSVDV+J16l+7ugQhLMOiECtE9tLeEFCFvpnKOQasvUoyo8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773134401; c=relaxed/simple; bh=lkTJEg59Xh1VTRhuvYCp7e3NEDvWSHHkSPwDRKRiOJA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fy9O3/aHzObILjO/vikxovhp0QT+akkj1R1f+tYTHW1/CNtsVpNC/zfQOC9EsmyEhhQnwXWQ7fHm/IaXMUGxGA09pD40ch/0e4n0xfberFgZnDdtv2SdwVprokuQAEozsDZzf0JZxRq+cZAgY/g/3X5FPinG6/piYNBH20zIgzw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=dl3DwnRy; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dl3DwnRy" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8297e0b27e5so3411878b3a.1 for ; Tue, 10 Mar 2026 02:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1773134399; x=1773739199; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QwT2Q2k4ZVZq63ntd2xl/RXmkonC2qNh8yVsjLAAWlg=; b=dl3DwnRyGwE2MXJCMJuVNURwp5HYBmF3igd8jjy4dnS49nt0UajKK8tF247LQq8KMn EE8SXi3RA5Sr2sDfR4Pds03cJ7vOjWQxuLuuds4IdrtjQogVuJpuCT9ebhGh3VZ+Fnvk Xpu6hmSMw9MkCrVfmeOE8F6Mcg4cS9k1azMpo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773134399; x=1773739199; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QwT2Q2k4ZVZq63ntd2xl/RXmkonC2qNh8yVsjLAAWlg=; b=ruWtCMmVmdvOg/ADbA1tb7gACven0247e5yRXQSaz1jPtpM2FlltbYtR16WTn2lH44 Rm0cWDLUiXfnfJPkqwHDjAKQLj11GIjnwPgEgncShEU9Issq09vzbGsFqFHvpnu5C78m sfX3ONMugvKcOmg35GPMDeqDcnLOhvlU9y0cPQNh5KBBoW1HW+R4vNB95OXAgeIZCYwx ILmNc7+x90+BHxkyjuCqf1VaSLFXWIs4wGwGlRuATAg3xWlbM+zBQ4DSfIWrfifqqS9j rBNTGOYz28r4xdeL9w7JefiDJ5tz52fTmvGjlGD0i31q/nxITyn+2lQs4ZEd+cJ8DCkI x8UQ== X-Forwarded-Encrypted: i=1; AJvYcCWNKdtE3BJA8B1IVdLYEL24GtVpvpAud7NiltFZ3E7KzCGKGdpJZLewFTmYBSlrmDF2ugTDxkrLmuKNNuc=@vger.kernel.org X-Gm-Message-State: AOJu0YzzkFfjar5Pfyk8Qmkc/GAz4z3R06blX4H4DuLoix5FBPONbCpn Y+TQEFWKgOWE5WtPrkeEGqSfBHxVwKdVllSmoNVOnAmgr5+VmihortL9PAyxjzID1w== X-Gm-Gg: ATEYQzzIEU2M4x3Qs/+d3+AJZqwLMQz5qEqMCaF1aEMgE+BfC8njiqZVPrVYyhHH8uB jjwvysPsIJs4k5bEXsloyLsVW1Vl65UUjvhvzqvUmvzDV974bJQWzhDgSCTTCcU73/1PL29Nq8u TIsaXM6juJnyk4fE1Z079Ed/yIYWnBxj7ujHiFUB0Z755qWxr1lBNELoYgMdFQkI8NbXoXGA6aq /YEvDAtAZFPezhoRjZOXZgkKJfL2gSgf3+Ov63uUu8Qp72o19MF8QcgS1BxQ7vIeJTXOqtUevef zwDVczQRDUznHJd6Ms2jKEZxmDvwa3gEFM6PwnRS54IGriW/QIoRUx2KVXbVccVPtK6LBmQYSVB WkN2FcVgkONQfGeCz12kJALHAhjPQopJyqvqxqhJIwAednxio87kBAoP9SVIfCzsL0TfJQAPtOZ N11SPOOnyREa0/DpmQn7GcsATPs/h1xez1FqEdpm2iauzZu93iQIESsLFbVtguw8J6hnkprOr/p 9EJ48fG X-Received: by 2002:a05:6a00:aa03:b0:824:b181:f492 with SMTP id d2e1a72fcca58-829a2f9ba69mr13107253b3a.45.1773134399292; Tue, 10 Mar 2026 02:19:59 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:ee38:e01e:e888:6900]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829a48a3b74sm16965190b3a.45.2026.03.10.02.19.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 02:19:58 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Ryder Lee , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas Cc: Chen-Yu Tsai , Bartosz Golaszewski , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v4 1/7] PCI: mediatek-gen3: Clean up mtk_pcie_parse_port() with dev_err_probe() Date: Tue, 10 Mar 2026 17:19:40 +0800 Message-ID: <20260310091947.2742004-2-wenst@chromium.org> X-Mailer: git-send-email 2.53.0.473.g4a7958ca14-goog In-Reply-To: <20260310091947.2742004-1-wenst@chromium.org> References: <20260310091947.2742004-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mtk_pcie_parse_port() in the pcie-mediatek-gen driver has a bunch of if (err) { dev_err(dev, "error message\n"); return err; # or goto } patterns. Simplify these with dev_err_probe(). The system also gains proper deferred probe messages that can be seen in /sys/kernel/debug/devices_deferred Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Bartosz Golaszewski Reviewed-by: Manivannan Sadhasivam Signed-off-by: Chen-Yu Tsai --- drivers/pci/controller/pcie-mediatek-gen3.c | 36 ++++++--------------- 1 file changed, 10 insertions(+), 26 deletions(-) diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/cont= roller/pcie-mediatek-gen3.c index 75ddb8bee168..1939cac995b5 100644 --- a/drivers/pci/controller/pcie-mediatek-gen3.c +++ b/drivers/pci/controller/pcie-mediatek-gen3.c @@ -876,10 +876,8 @@ static int mtk_pcie_parse_port(struct mtk_gen3_pcie *p= cie) if (!regs) return -EINVAL; pcie->base =3D devm_ioremap_resource(dev, regs); - if (IS_ERR(pcie->base)) { - dev_err(dev, "failed to map register base\n"); - return PTR_ERR(pcie->base); - } + if (IS_ERR(pcie->base)) + return dev_err_probe(dev, PTR_ERR(pcie->base), "failed to map register b= ase\n"); =20 pcie->reg_base =3D regs->start; =20 @@ -888,34 +886,20 @@ static int mtk_pcie_parse_port(struct mtk_gen3_pcie *= pcie) =20 ret =3D devm_reset_control_bulk_get_optional_shared(dev, num_resets, pcie->phy_resets); - if (ret) { - dev_err(dev, "failed to get PHY bulk reset\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to get PHY bulk reset\n"); =20 pcie->mac_reset =3D devm_reset_control_get_optional_exclusive(dev, "mac"); - if (IS_ERR(pcie->mac_reset)) { - ret =3D PTR_ERR(pcie->mac_reset); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to get MAC reset\n"); - - return ret; - } + if (IS_ERR(pcie->mac_reset)) + return dev_err_probe(dev, PTR_ERR(pcie->mac_reset), "failed to get MAC r= eset\n"); =20 pcie->phy =3D devm_phy_optional_get(dev, "pcie-phy"); - if (IS_ERR(pcie->phy)) { - ret =3D PTR_ERR(pcie->phy); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to get PHY\n"); - - return ret; - } + if (IS_ERR(pcie->phy)) + return dev_err_probe(dev, PTR_ERR(pcie->phy), "failed to get PHY\n"); =20 pcie->num_clks =3D devm_clk_bulk_get_all(dev, &pcie->clks); - if (pcie->num_clks < 0) { - dev_err(dev, "failed to get clocks\n"); - return pcie->num_clks; - } + if (pcie->num_clks < 0) + return dev_err_probe(dev, pcie->num_clks, "failed to get clocks\n"); =20 ret =3D of_property_read_u32(dev->of_node, "num-lanes", &num_lanes); if (ret =3D=3D 0) { --=20 2.53.0.473.g4a7958ca14-goog