From nobody Thu Apr 9 07:15:59 2026 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0F2828640C for ; Tue, 10 Mar 2026 08:00:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773129635; cv=none; b=KcGiXZgxBYVuPBBgDv3xX06hP79236SA8aOex3NKNt4/sULFrmW5zpDUaJv7HGh/I/cXBgDN54C4w6YVQtr0i/eV2NaMUZKmjjjesqUXoW9EoSGZBd/gZrk7Y51VW2iU5as4L8mk1itftT9OJFwUUsAdjv7xoDzxuNdAyKBcnuA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773129635; c=relaxed/simple; bh=xVd2KkktmzKw76cEeI0oO0J3/DjTaqN/lKS7qxTDDIc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jQA87BIms2eERPBjtyq1EDjgNb2HrZMeIGLIOenISLARtoBAim2RkZgiPnaI2LQEJlhgBfg6hw3b0Qmn5LppYYDfFQaJNeE6bc9kBjjnG36mfaZBOEl+CdNdQ72hiRmifZFGkaqCZ41QkaMlquRPdeYyrUz+mkKVsEPuX+pfxFU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i7xKq1sZ; arc=none smtp.client-ip=209.85.214.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i7xKq1sZ" Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-2adff872068so60110165ad.1 for ; Tue, 10 Mar 2026 01:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773129634; x=1773734434; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TGL5zvBiqfkZiXMUWnmqLW+ywfahdDcPkg4MN2yXqeY=; b=i7xKq1sZn5lUuy9HHZLkqFYLzGOU0TTTZMN9kzR6WKc8sd8c05qZkrwvCFFMJBfL82 KeeertXIQnezkrNTyE35eXnX17PC/wDwsAXb7KRocUyJ63XsXeS0rcR3ypSuaqjy1B53 +JCYNFQ5wZIqD8nyGLNzsW1X1AdY7YYqYxtHaUdHRTQTDXeRcQX7+f5SL76+VmOh6N05 yV76NHYKHI5JA1uskneqfAp+gPHDvlUFfNk8gYNXafW+hd7C0Cufe+yu62+V8aVnQv0I oRpDlcFV1SWuHc+uw2l6j19a2VM3mDf/DYwTvp1IezsxoUyPhnaKD2krjozoOUfegvL/ 6gMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773129634; x=1773734434; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TGL5zvBiqfkZiXMUWnmqLW+ywfahdDcPkg4MN2yXqeY=; b=nckXAErwwi4xltjIor+jy2vzHxgBoWW5QLdgqKfn5FD5mMUPbJkSoiAhbNCQxVjRow exH0zfw3mtrm3TkT6zyc8yeIj4lX64WKylmPR9OFrrbCE59S+87THTqiShw7goUHtBWd BatQo1/oLzK86T5KepzBTYqLF+oYKjFCy67f0TXcw8w8JeVc/Y/yriquhr3Wcm3vQlAR 5q3I8T/MFHZNj4NLBNhha1qqGZt+62eflgtNgIOsYyGWfnJ+oR6Ik5eY+K9DBhjQRuDN U55U38hdE0v9RhqIeDTeu1qPTI9mKPY/403tmp6zWdKrfmTm69I9KDFPaglZkaTmG4+Z XAdw== X-Forwarded-Encrypted: i=1; AJvYcCWCjwkf7EHL1yxxGp4fSkGwwJeWijhEGUGoJdhemP72dheDgdrvEKWmr97dMdgu3T8GAZfZ6mMno/0M4/M=@vger.kernel.org X-Gm-Message-State: AOJu0YyQHOZtBOcJKWSsMzgnwnF3wjHLENu3flQ86L3F11uDWSLNrg2E 3Y9JX4Jyn4Ks2zPfuksBu7U9tbYQxb5s9NUguohpYT8GmZ1gqY7uxzMA X-Gm-Gg: ATEYQzwZxJavE3KOnw0ZUCEIlP6SGy0wV3LtRnPcm0b0zYp9DF8llWpfb+ocBdfiEPH QJ44AA2lpfG1R3Vn6q2pqhZv6sx7zb7RQgu1ETnqLhvMAN2NKJAM7IttC/QbBFgAEypMzkSVIrs sFGusP0aFscteCYFTtd5FMcnuC2GM2FuqCU2COZ7auiDS0Rur39fhz8oumQ2GGWyjNP56kcntHM MF4d42OXL1coG4oZUbSNUBu2ZI+mXtEw7fQ+NiVUDIDA873avUK2ndhf0J80b0hWKejlaUWhBAj VauVCw4qYleLC1PahhdsQvC23zvLHQH7tu3oRhnAy6OumAhdeJwrQWNkwPCjuZNSfkWlqeP//sP qgaB1CkAdvZ3RiNV9yTcsplsC+/qF+fy6dclIgx/bPV6RtC/uOyj8O1OyJbeNl9zpyc+8hgJtpJ Ch5gWPa2jzFw4agav5VBQ+u2JVs920Qr7c2CM2MARMTrmQIQQ= X-Received: by 2002:a17:903:3904:b0:2ad:ab2c:d258 with SMTP id d9443c01a7336-2ae82385466mr154776925ad.14.1773129633523; Tue, 10 Mar 2026 01:00:33 -0700 (PDT) Received: from mm2dtv06 (61-216-20-61.hinet-ip.hinet.net. [61.216.20.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae840b2130sm148689535ad.83.2026.03.10.01.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 01:00:33 -0700 (PDT) From: xiaoxiao_li To: hminas@synopsys.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, xiaoxiao_li Subject: [PATCH] usb: dwc2: exit clock_gating when stopping udc caused deadlock Date: Tue, 10 Mar 2026 16:00:00 +0800 Message-ID: <20260310080000.3164692-1-lxxstone@gmail.com> X-Mailer: git-send-email @GIT_VERSION@ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dwc2_gadget_exit_clock_gating invoke call_gadget to hold hsotg->lock, causing dwc2_hsotg_ep_disable_lock unable to acquire the lock, lead to a deadlock. To ensure that enabling clock gating before stopping UDC does not cause the deadlock, we lock exit_clock_gating using spin_lock_irqsave and spin_unlock_irqrestore. Signed-off-by: xiaoxiao_li --- drivers/usb/dwc2/gadget.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index d216e26c7..c8b02c27d 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -4607,7 +4607,9 @@ static int dwc2_hsotg_udc_stop(struct usb_gadget *gad= get) /* Exit clock gating when driver is stopped. */ if (hsotg->params.power_down =3D=3D DWC2_POWER_DOWN_PARAM_NONE && hsotg->bus_suspended && !hsotg->params.no_clock_gating) { + spin_lock_irqsave(&hsotg->lock, flags); dwc2_gadget_exit_clock_gating(hsotg, 0); + spin_unlock_irqrestore(&hsotg->lock, flags); } =20 /* all endpoints should be shutdown */ --=20 2.35.1