From nobody Fri Apr 3 10:54:51 2026 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2C1D426EB1 for ; Tue, 10 Mar 2026 07:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773127801; cv=none; b=eka3Hmi2tLUTkhwn5Zs8yzO7DEcEdB1YMNEbtlLArrCF++gcBPKIHWV4pmVLPSY2rU98tuLW3EdZx3zjSYSUQjXwNdEvBGLaOx/4InFimUnl06uG76adRvyhxeEB/GNV5dSJCHZiZ33jgra9giVAhc/J9dbzeK9jTI9Tcxf0Pa0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773127801; c=relaxed/simple; bh=gLmiYhsjCO2ewaSKXWLLWhUHbePsZVGcZmhlJxVefm0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jQSiI/RokeF+pARfxsJRG+tS12rTRx+97bIgECSJEd38l92wfTkA0zR/+F8G/WAuiT1SIJ67oRMh4RVKBUjrlLQJXp8zI/wvYhQRwis7QhwOJ24pATbTkph+rC7/GlbuXtjMyukp+I97apiFpcghSAvZwUwfpJ1YfR89QTFbOrM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dEdPyJSN; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dEdPyJSN" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-2ba9c484e5eso12429332eec.1 for ; Tue, 10 Mar 2026 00:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773127798; x=1773732598; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BxcExIxLmkhlT7+NSIJGyGNNqrKogJfbqsFiKHCpzZM=; b=dEdPyJSN8JWBpBxn9ZapJUfRp1bb3MzkQDwNItg5U/1d9x2kaVu2FkAwQjcwnW98Vp jr6tXFSorYv8NuK3NpFwJb82c9/hSsKx6WVv6pgY5Csgaot6gRdItei44QRnlZu37ws7 2imLReW+Khu2tbDbfRihb9W3RK2x8BzdKTnAx1TSzPGApGoop4ooGUOLY1shik8TsHqq W0W1aEY2mMDH+FhJnCmMuB0ILZXl0Y8a5HHioB+5N/hXjI/roWH6FUkmuE9+3rEbaUwX YEWaYjAFMP35Db6oWPdLGQmbjJJjNGAv+PMCAm483ZYK9/n3x0/1ORYnU7CPkfGP4WeD klfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773127798; x=1773732598; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BxcExIxLmkhlT7+NSIJGyGNNqrKogJfbqsFiKHCpzZM=; b=OVRb/0BTDeloQF1usvN0peVqXbBXoJPn6X0/hWDvJ+em3slIil8nqe91F14mCpaSMv 6On358gZ30ureM2wW9g1u68Aivwoj8oXqAtGbNWjqJCO7K4CmF9hoB5ZGE/73pbhmObZ dQpWNGC7gOKO+Z+o4ON58N3CAa3OaI7LuEGWcaoclEWWNCc2DV/8SxK4gOlbBymEZpoi hiRYuUTxc5epPeydCGayNo9WYJa4Ce4uX9heaHNdQOTo4ob+RYJq+Lay0hytfhrzAmtp RUxU1KMF/gMvo7QApCKhw2+hI3e+1UKEeuAKLIdehlcLqRTZE8ix4qEu5J+ORzf7ZJ/z DlXQ== X-Forwarded-Encrypted: i=1; AJvYcCUtP/e7MtnbUw543RUlSb/ltApfomqMi4w7fepzS49M7puF1oEsWcvoC73eZdigEbVA20DUnIWhbQk5Hn0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6j+vAB3569Y8LebP8J3TCEdhDtkP3L4VUGCSrvbODj1Yzz5tv Uj8aDW2Mpta/6EBp+nizQFdI4qgJdYwFM+8xCCltAsvUh6TN62BcaYTOe3y4LQ== X-Gm-Gg: ATEYQzy0RdzNLo8b+qOXmBmVmiZTNhq4AdU6AKKytmFtjhI3goUzp2HyEBEA1X1ehiz LrMbWbXS9gBd0btCIEoN59FuqUoUSlLG+MOZAxxbu1/80wZizPIcJ5jfKj/0HEyfVJ6+rz6GYQv IfGWriI+PydcDEnipGCK3d+XdED07hWlaWLvULu1Pmsy1AOHxdiktlm5unaadYYP80M2fdPirro LbpnWmIKci+PiXwF0L7duJZ+8bpd7Yt0CmNooUu77t2UYCOExsNxFr/jywwOTUslpezIJc2BTyH Hsl1X8YuQ2AUkK4vnZPcIZ6RZigb8piiD+70+/Pi2mQu2SeRP8XbAOTapiOTZmj7wYGdev9m0vG utrB8Np1zNLJiYyi+w34M7G5/SEMbYZTAXpV36UhCUTMkXiu1lPIX/RhrR4OBgaQL+dOgYz7dVB EIsIeKIXEsgXRYlf4FgUSRwq6myf3+DQtUFe8bT6pVb8SgsBgNJiYvAXNmw5NH09vMRPG8XRih3 KHB X-Received: by 2002:a05:7300:a887:b0:2be:198e:438 with SMTP id 5a478bee46e88-2be4e01914fmr5746231eec.16.1773127797902; Tue, 10 Mar 2026 00:29:57 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be81209142sm721925eec.12.2026.03.10.00.29.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 00:29:57 -0700 (PDT) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: Richard Hughes , Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Chen Ni Subject: [PATCH v6 18/19] HID: hid-lenovo-go: Remove unneeded semicolon Date: Tue, 10 Mar 2026 07:29:36 +0000 Message-ID: <20260310072937.3295875-19-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260310072937.3295875-1-derekjohn.clark@gmail.com> References: <20260310072937.3295875-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Ni Remove unnecessary semicolons after switch statements and function bodies. Most issues were reported by Coccinelle/coccicheck using the semantic patch at scripts/coccinelle/misc/semicolon.cocci. Additional instances found during manual code review were also fixed. Signed-off-by: Chen Ni Reviewed-by: Mark Pearson Signed-off-by: Derek J. Clark --- drivers/hid/hid-lenovo-go.c | 52 ++++++++++++++++++------------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/hid/hid-lenovo-go.c b/drivers/hid/hid-lenovo-go.c index 54861f2e04fc..d4d26c783356 100644 --- a/drivers/hid/hid-lenovo-go.c +++ b/drivers/hid/hid-lenovo-go.c @@ -455,7 +455,7 @@ static int hid_go_feature_status_event(struct command_r= eport *cmd_rep) return 0; default: return -EINVAL; - }; + } case FEATURE_IMU_BYPASS: switch (cmd_rep->device_type) { case LEFT_CONTROLLER: @@ -466,7 +466,7 @@ static int hid_go_feature_status_event(struct command_r= eport *cmd_rep) return 0; default: return -EINVAL; - }; + } break; case FEATURE_LIGHT_ENABLE: drvdata.rgb_en =3D cmd_rep->data[0]; @@ -481,7 +481,7 @@ static int hid_go_feature_status_event(struct command_r= eport *cmd_rep) return 0; default: return -EINVAL; - }; + } break; case FEATURE_TOUCHPAD_ENABLE: drvdata.tp_en =3D cmd_rep->data[0]; @@ -515,7 +515,7 @@ static int hid_go_motor_event(struct command_report *cm= d_rep) return 0; default: return -EINVAL; - }; + } break; case RUMBLE_MODE: switch (cmd_rep->device_type) { @@ -527,7 +527,7 @@ static int hid_go_motor_event(struct command_report *cm= d_rep) return 0; default: return -EINVAL; - }; + } case TP_VIBRATION_ENABLE: drvdata.tp_vibration_en =3D cmd_rep->data[0]; return 0; @@ -625,7 +625,7 @@ static int hid_go_os_mode_cfg_event(struct command_repo= rt *cmd_rep) return 0; default: return -EINVAL; - }; + } } =20 static int hid_go_set_event_return(struct command_report *cmd_rep) @@ -699,14 +699,14 @@ static int hid_go_raw_event(struct hid_device *hdev, = struct hid_report *report, default: ret =3D -EINVAL; break; - }; + } break; case OS_MODE_DATA: ret =3D hid_go_os_mode_cfg_event(cmd_rep); break; default: goto passthrough; - }; + } dev_dbg(&hdev->dev, "Rx data as raw input report: [%*ph]\n", GO_PACKET_SIZE, data); =20 @@ -925,7 +925,7 @@ static ssize_t feature_status_store(struct device *dev, break; default: return -EINVAL; - }; + } =20 if (ret < 0) return ret; @@ -1013,7 +1013,7 @@ static ssize_t feature_status_show(struct device *dev, break; default: return -EINVAL; - }; + } count =3D sysfs_emit(buf, "%u\n", i); break; case FEATURE_FPS_SWITCH_STATUS: @@ -1032,7 +1032,7 @@ static ssize_t feature_status_show(struct device *dev, break; default: return -EINVAL; - }; + } =20 return count; } @@ -1070,7 +1070,7 @@ static ssize_t feature_status_options(struct device *= dev, break; default: return -EINVAL; - }; + } =20 if (count) buf[count - 1] =3D '\n'; @@ -1111,7 +1111,7 @@ static ssize_t motor_config_store(struct device *dev, ret =3D sysfs_match_string(intensity_text, buf); val =3D ret; break; - }; + } =20 if (ret < 0) return ret; @@ -1161,7 +1161,7 @@ static ssize_t motor_config_show(struct device *dev, break; default: return -EINVAL; - }; + } if (i >=3D ARRAY_SIZE(enabled_status_text)) return -EINVAL; =20 @@ -1177,7 +1177,7 @@ static ssize_t motor_config_show(struct device *dev, break; default: return -EINVAL; - }; + } if (i >=3D ARRAY_SIZE(rumble_mode_text)) return -EINVAL; =20 @@ -1197,7 +1197,7 @@ static ssize_t motor_config_show(struct device *dev, =20 count =3D sysfs_emit(buf, "%s\n", intensity_text[i]); break; - }; + } =20 return count; } @@ -1232,7 +1232,7 @@ static ssize_t motor_config_options(struct device *de= v, enabled_status_text[i]); } break; - }; + } =20 if (count) buf[count - 1] =3D '\n'; @@ -1333,7 +1333,7 @@ static ssize_t device_status_show(struct device *dev, break; default: return -EINVAL; - }; + } =20 if (i >=3D ARRAY_SIZE(cal_status_text)) return -EINVAL; @@ -1459,7 +1459,7 @@ static int rgb_attr_show(void) index =3D drvdata.rgb_profile + 3; =20 return rgb_cfg_call(drvdata.hdev, GET_RGB_CFG, index, NULL, 0); -}; +} =20 static ssize_t rgb_effect_store(struct device *dev, struct device_attribute *attr, const char *buf, @@ -1489,7 +1489,7 @@ static ssize_t rgb_effect_store(struct device *dev, =20 drvdata.rgb_effect =3D effect; return count; -}; +} =20 static ssize_t rgb_effect_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -1555,7 +1555,7 @@ static ssize_t rgb_speed_store(struct device *dev, drvdata.rgb_speed =3D val; =20 return count; -}; +} =20 static ssize_t rgb_speed_show(struct device *dev, struct device_attribute = *attr, char *buf) @@ -1599,7 +1599,7 @@ static ssize_t rgb_mode_store(struct device *dev, str= uct device_attribute *attr, drvdata.rgb_mode =3D val; =20 return count; -}; +} =20 static ssize_t rgb_mode_show(struct device *dev, struct device_attribute *= attr, char *buf) @@ -1614,7 +1614,7 @@ static ssize_t rgb_mode_show(struct device *dev, stru= ct device_attribute *attr, return -EINVAL; =20 return sysfs_emit(buf, "%s\n", rgb_mode_text[drvdata.rgb_mode]); -}; +} =20 static ssize_t rgb_mode_index_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -1653,7 +1653,7 @@ static ssize_t rgb_profile_store(struct device *dev, drvdata.rgb_profile =3D val; =20 return count; -}; +} =20 static ssize_t rgb_profile_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -1668,7 +1668,7 @@ static ssize_t rgb_profile_show(struct device *dev, return -EINVAL; =20 return sysfs_emit(buf, "%hhu\n", drvdata.rgb_profile); -}; +} =20 static ssize_t rgb_profile_range_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -1707,7 +1707,7 @@ static void hid_go_brightness_set(struct led_classdev= *led_cdev, break; default: dev_err(led_cdev->dev, "Failed to write RGB profile: %i\n", ret); - }; + } } =20 #define LEGO_DEVICE_ATTR_RW(_name, _attrname, _dtype, _rtype, _group) = \ --=20 2.53.0