From nobody Fri Apr 3 10:55:43 2026 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D525A3E9F69 for ; Tue, 10 Mar 2026 07:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773127793; cv=none; b=uPPv1zypXxzP4Mko1JgszQm9xKPuiDDsI1vQHyMBE+1q4EWdmPYxmIFtn8s/b/JTSKWcSXiO9jMcwWorGkRwLzYScL7mOA036c8Zwu2XMd9Ffs86BW43u84wFN4zYlDeOKdgMT2XXjDwAAzHcnxrhGKDjo+U35DesiRtALM6psE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773127793; c=relaxed/simple; bh=yWkVa/Jth/oJdDOe1ihirkRp8Fbw+pPWZBYFbTWg034=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y6uP6NZ5mfDFAGt5z26Q6CgcMGU3nFXs3o/IswGvdkzuI8Au38Tvuxj1js165uWeAVE63Ci46bK7zAalMW3ZZv3k6uC2HDdTvbM06jP/ZmDVoBTRcK98vn7XLyLIQZoNKAOS0YLpsCocpJ6+s0K5Kzri4luWaJ/cMDhfDsaI73A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vy107Vtx; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vy107Vtx" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2be1c918173so14212425eec.1 for ; Tue, 10 Mar 2026 00:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773127791; x=1773732591; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UPGAxlsgnQwH8V6ZIVfcEYRPqGnb7Td9A0j4ncYAqN0=; b=Vy107Vtxq8++Xkgtbs6Y3PSL11sp7SFTvd0ZhHtQjOHezOuhN8KWTaOdpSjuRycNjL ww4FgP+sxpuxFdbDXEk2uW/seDRjbzxUWWHgg8dUMlPyGGNddVBHi9FRTVbxqUZEhsiM ekX4cjYncpsym7wbHiEFUoAJZemfmlpqYzlaCN14OAUnCAiv56GX1SzmyiTeyem2fVf8 cbYwUPh+SIBadMM2iRpRrC249yQIUFyfKEMRMK4Q9ZdGlaPeAEk3W1JOGeIAa4Mwxqyx EPrAqLFqFAaXSMfE9TX58MqMnTcuyN9cCXEGlcgPlRIC3bJhpoaX8ysgtDduHzLqflal NWJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773127791; x=1773732591; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UPGAxlsgnQwH8V6ZIVfcEYRPqGnb7Td9A0j4ncYAqN0=; b=BuVULJisOuUZtG9sOQn2sVH7DgSCA7/9TE2l1FuP1OLvLNTSm3r0KCXnW/N23+Wbsn wayUBbgVwpQkpYWOP4jAls4+KwWzOdauIhLJVD87p7yhYlL+27EJyF2t5ceWWm4E+n8X 9Y5D+ZF48gTBI0frNJrNpvF23iP8zVG32cEMlDK0Omh8zim2gbKyfpYz5TukVZf9BUaH JE1j4dRvIKiptgGnT3ZsM4CXg3VTPcDWFl5uWmcJaSuUaczesUv9zCPR8FXvKTzazyXv gE+KfPBWFJFTDx+PTSIvylLstCmrXfoQEAHkrNguIQy7ve9WRzTDsYi9aA8/HlCyMMLt 2o5A== X-Forwarded-Encrypted: i=1; AJvYcCVbZ6UQmYLJNpw5ZGzWsQ3iszw7TFI4kczeZTRnwIyBdoaAKEs1uo53cBt9iEZGQELUGPyWjv64HvjS2sE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8cMgCs+99ofLoT4qJwJHlbTQQ3CjtwXYniAU4D7Q/pLUg2rdL DYA0gKk2HHeHpTKR1A47rg/Ls1Wzmf7OCnUPcAmEK49aMJhK22POrdV1 X-Gm-Gg: ATEYQzy4tbU3SdHQlPTu3EA9ri+bvdD5YnaZb9h5UN8YYw6/B0m3pS2AGnoasIcEr+G KNI6O0EdNX4CHUH0pNfXRMaYFrgR+qJU3XA6Ty2k72r5yzbLg+d+UYjT37uBqewy0o9GgHv0m4n GnZ8Cw3BvsVsEdr4MRW58eOzXGkhx1KsiO1mFYR5NdWYVsIEgyjdlT+EibfUgC0Eln2cUc15MZ7 hTaJQmjLajzAD1UtfYaUfwld8ZQQj5ezzF9HYC4G1TWO9WjLH33kpGD/TbY7i3QkRXsOfQ5OrUj z5kIB7+0DjXBCEvVycOGxl4j0yWBhRiWkYmTiu4jFRc4AwdBW5VZ33zLGRWJMbNd8G3FLlZsGdz lrLFOneFH6hOzGNftzenwuZQuJ1qEhdq6UhCtxrKwhuYlzSUOXkIXIa07nuLdV5YN7ZnP2Ig9Ir bcI9VBSL+YQvyeCv/g+ePXd3BWSOfrIsirGJaofSIJeDB5GuH9g2Gg0dzoZuMabNSfv22ELwL96 Kh7gpluKoIqmOc= X-Received: by 2002:a05:693c:8087:b0:2be:6f30:f2f9 with SMTP id 5a478bee46e88-2be6f30fabemr2064806eec.26.1773127790942; Tue, 10 Mar 2026 00:29:50 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be81209142sm721925eec.12.2026.03.10.00.29.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 00:29:50 -0700 (PDT) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: Richard Hughes , Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 11/19] HID: hid-lenovo-go-s: Add MCU ID Attribute Date: Tue, 10 Mar 2026 07:29:29 +0000 Message-ID: <20260310072937.3295875-12-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260310072937.3295875-1-derekjohn.clark@gmail.com> References: <20260310072937.3295875-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds command to probe for the MCU ID of the Lenovo Legion Go S Controller and assign it to a device attribute. Reviewed-by: Mark Pearson Signed-off-by: Derek J. Clark --- v6: - Use NULL instead of 0 in mcu_propery_out when there is no data. --- drivers/hid/hid-lenovo-go-s.c | 56 +++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/drivers/hid/hid-lenovo-go-s.c b/drivers/hid/hid-lenovo-go-s.c index c9f57dfa145a..8ee75f724b5b 100644 --- a/drivers/hid/hid-lenovo-go-s.c +++ b/drivers/hid/hid-lenovo-go-s.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -34,8 +35,13 @@ static struct hid_gos_cfg { struct completion send_cmd_complete; struct hid_device *hdev; struct mutex cfg_mutex; /*ensure single synchronous output report*/ + u8 mcu_id[12]; } drvdata; =20 +struct gos_cfg_attr { + u8 index; +}; + struct command_report { u8 cmd; u8 sub_cmd; @@ -70,6 +76,14 @@ static int hid_gos_version_event(u8 *data) return 0; } =20 +static int hid_gos_mcu_id_event(struct command_report *cmd_rep) +{ + drvdata.mcu_id[0] =3D cmd_rep->sub_cmd; + memcpy(&drvdata.mcu_id[1], cmd_rep->data, 11); + + return 0; +} + static int get_endpoint_address(struct hid_device *hdev) { struct usb_interface *intf =3D to_usb_interface(hdev->dev.parent); @@ -103,6 +117,9 @@ static int hid_gos_raw_event(struct hid_device *hdev, s= truct hid_report *report, case GET_VERSION: ret =3D hid_gos_version_event(data); break; + case GET_MCU_ID: + ret =3D hid_gos_mcu_id_event(cmd_rep); + break; default: ret =3D -EINVAL; break; @@ -157,10 +174,41 @@ static int mcu_property_out(struct hid_device *hdev, = u8 command, u8 index, return 0; } =20 +static ssize_t mcu_id_show(struct device *dev, struct device_attribute *at= tr, + char *buf) +{ + return sysfs_emit(buf, "%*phN\n", 12, &drvdata.mcu_id); +} + +/* MCU */ +static DEVICE_ATTR_RO(mcu_id); + +static struct attribute *legos_mcu_attrs[] =3D { + &dev_attr_mcu_id.attr, + NULL, +}; + +static const struct attribute_group mcu_attr_group =3D { + .attrs =3D legos_mcu_attrs, +}; + +static const struct attribute_group *top_level_attr_groups[] =3D { + &mcu_attr_group, + NULL, +}; + static void cfg_setup(struct work_struct *work) { int ret; =20 + /* MCU */ + ret =3D mcu_property_out(drvdata.hdev, GET_MCU_ID, FEATURE_NONE, NULL, 0); + if (ret) { + dev_err(&drvdata.hdev->dev, "Failed to retrieve MCU ID: %i\n", + ret); + return; + } + ret =3D mcu_property_out(drvdata.hdev, GET_VERSION, FEATURE_NONE, NULL, 0= ); if (ret) { dev_err(&drvdata.hdev->dev, "Failed to retrieve MCU Version: %i\n", ret); @@ -177,6 +225,13 @@ static int hid_gos_cfg_probe(struct hid_device *hdev, drvdata.hdev =3D hdev; mutex_init(&drvdata.cfg_mutex); =20 + ret =3D sysfs_create_groups(&hdev->dev.kobj, top_level_attr_groups); + if (ret) { + dev_err_probe(&hdev->dev, ret, + "Failed to create gamepad configuration attributes\n"); + return ret; + } + init_completion(&drvdata.send_cmd_complete); =20 /* Executing calls prior to returning from probe will lock the MCU. Sched= ule @@ -196,6 +251,7 @@ static void hid_gos_cfg_remove(struct hid_device *hdev) { guard(mutex)(&drvdata.cfg_mutex); cancel_delayed_work_sync(&drvdata.gos_cfg_setup); + sysfs_remove_groups(&hdev->dev.kobj, top_level_attr_groups); hid_hw_close(hdev); hid_hw_stop(hdev); hid_set_drvdata(hdev, NULL); --=20 2.53.0