From nobody Thu Apr 9 09:48:36 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D67C43B9605 for ; Tue, 10 Mar 2026 03:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773113158; cv=none; b=dl0d2yTiL4+5EDqep0y2ksOgSY9i4D9KzCzpk71uJELTC2trEv54KjuincLvW95oAm8M03UFEby7+EhAWWnu+JMicj+Xn1K+YlC5n281xbx5qFkRoYHqUDNzBV+yDfDeG8PPw9xCw80RNZVd7OWy1qn7aLp+fRfOaV2bi9OdDsY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773113158; c=relaxed/simple; bh=rfD7Le/WZjv74zhcuW0yU+5NJ1RZ3lo7zccKLiSyBcI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RBwAv2GbELlOKwYYdgMwt/YUEuAOZLl2+fazjwGMZ4zKecXVAr7dRmZjzeQ0RbnJPUrjXBdL+5NhhmwYnEHD0X5xu202zoeHsslllOx/3NLru9ZT5DyRUtUc86CrpCVyc6xyop5BnM3tlyzc5uR4I5hCzATnk35gLAwpQlEsvBw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Rf8i7QoH; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Rf8i7QoH" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ae5423b02aso57663975ad.1 for ; Mon, 09 Mar 2026 20:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1773113155; x=1773717955; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y1z9EtizHwE3LeSySxAXfxT/FNlt1Ydhsh1vDf6WdY0=; b=Rf8i7QoHUxHSmckQXTHAvZqcoGW0XFuGM/WOU4fn2JEQkx3t7XB6PRBOfaansklMA0 K8fB+FJFFnYzJGloahdhhVeupPJp0gRfHlFVmIOEfkAR8QBXqXwoqF7N0hCYxVeuCjt6 FL+xq+ZJCLxI95aFtbx4i9VyDlgXU7NNr5zgg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773113155; x=1773717955; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Y1z9EtizHwE3LeSySxAXfxT/FNlt1Ydhsh1vDf6WdY0=; b=HyoDmLNmxjrIDNNLdDMbeGAmLwF3ZoIPXVM2DMOt/6iMKyoX+rXEaE+ta6HNeOdsvl Lj0z07WC32N8zkvtw7pyjswJvrA7vMVQJwPFygndnDMdvYWw4zmQBkVjbt967LV352Xv r7lUCGIel7EXcCBk/NZZsOXujjrWGG6krPcuTfxmKeZwnbX65lY0a0iOSoFfYJ9ii4qR 9qsfFuXhUw1kiZHS4PcA0mbmNHqykA+PbiKviyf35+RTvt7k4u4e8YDsTtW7CjWNNgJS MRCH4rn1Ncf+uvfHelDe4Vi7DmY+jGXRpEMBos+0UlBlsPkNQEPLFKt+bqP9htRi8msv vfZQ== X-Forwarded-Encrypted: i=1; AJvYcCXPlglM6+fAhxEWSR4Ug2uXG+9FblxCIhyjcUDalFrAM73D52NUy74G16RdoLZXWXrbmkLj/YoCBt7HEKE=@vger.kernel.org X-Gm-Message-State: AOJu0YyZEp/Lq49CUcm/CG/0iEoSaasVprjsapOJq5/Oz0i87jAID++2 kzJYir5vM8YLfHSLOztu0dU+TyquYGDgqFyYQqJL56IYGP8P2bpCwormxI6iOvfZ3g== X-Gm-Gg: ATEYQzzlkGBXnlQFmVim0WHGlF1DV3SREjXV7OY1DrrJt7zB9DX26E+58nJsxOo1yx6 /izcYN2kIcxc047Bx2ns4X+57OJ2X14ZOSbjLUh7GRZufcSsjlbcwuBrI07whBz1lLBRs9LwWgu H31FI3qw5sE47fiWv5fq8IJEm7yUqsbp/SEQ8BlfsfYlOyvXadZKggKyWRL0CIE0NhLwhPzAcAq TBRWKD2xIpzznW4W6e/8riV48uoiN5mqhKtkjiOA8mGWhmPir8XWn+s5hIIWsC9AM6ehCDlLbXc yvWBAhnf2E/pXKbyfKIailj2BdLyqlgeINJS00PGdd4UFs8qYQFpTkFyn8YANLhhO9JQpRZFBvs s4RXNtA9Acz1yOQ9/djBT8sHMn0hxPEZWfs1feIqriaIzBj6PJ4HpRbFtHKZKuq7NzVyCqFL804 3tcNrfHaulUmY9+SR+SWKMR2eUOTc+sXMw1r7ifty4GBv6DEAemNElsHMMaIN/hVjsxVqA8J4c+ 0HGBSmw X-Received: by 2002:a17:902:ec88:b0:2ae:54b2:27c7 with SMTP id d9443c01a7336-2ae82459ca5mr139254635ad.39.1773113155156; Mon, 09 Mar 2026 20:25:55 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:ee38:e01e:e888:6900]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83e575e6sm126695095ad.5.2026.03.09.20.25.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 20:25:54 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Chun-Kuang Hu , Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , David Airlie , Simona Vetter Cc: Chen-Yu Tsai , linux-sunxi@lists.linux.dev, Paul Kocialkowski , linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 4/4] drm/sun4i: Use backend/mixer as dedicated DMA device Date: Tue, 10 Mar 2026 11:25:09 +0800 Message-ID: <20260310032511.2545500-5-wenst@chromium.org> X-Mailer: git-send-email 2.53.0.473.g4a7958ca14-goog In-Reply-To: <20260310032511.2545500-1-wenst@chromium.org> References: <20260310032511.2545500-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The sun4i DRM driver deals with DMA constraints in a peculiar way. Instead of using the actual DMA device in various helpers, it justs reconfigures the DMA constraints of the virtual display device using the DMA device's device tree node by calling of_dma_configure(). Turns out of_dma_configure() should only be called from bus code. Lately this also triggers a big warning through of_iommu_configure() and ultimately __iommu_probe_device(): late IOMMU probe at driver bind, something fishy here! Now that the GEM DMA helpers have proper support for allocating and mapping buffers with a dedicated DMA device, switch over to it as the proper solution. The mixer change was tested on a Pine H64 model B. The backend change was only compile tested. Though I don't expect any issues, help testing on an older device would be appreciated. Signed-off-by: Chen-Yu Tsai --- drivers/gpu/drm/sun4i/sun4i_backend.c | 27 +++++++++++++++------------ drivers/gpu/drm/sun4i/sun8i_mixer.c | 27 +++++++++++++++------------ 2 files changed, 30 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/= sun4i_backend.c index 6391bdc94a5c..a57fb5151def 100644 --- a/drivers/gpu/drm/sun4i/sun4i_backend.c +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c @@ -798,18 +798,21 @@ static int sun4i_backend_bind(struct device *dev, str= uct device *master, dev_set_drvdata(dev, backend); spin_lock_init(&backend->frontend_lock); =20 - if (of_property_present(dev->of_node, "interconnects")) { - /* - * This assume we have the same DMA constraints for all our the - * devices in our pipeline (all the backends, but also the - * frontends). This sounds bad, but it has always been the case - * for us, and DRM doesn't do per-device allocation either, so - * we would need to fix DRM first... - */ - ret =3D of_dma_configure(drm->dev, dev->of_node, true); - if (ret) - return ret; - } + /* + * This assume we have the same DMA constraints for all our the + * devices in our pipeline (all the backends, but also the + * frontends). This sounds bad, but it has always been the case + * for us, and DRM doesn't do per-device allocation either, so + * we would need to fix DRM first... + * + * Always use the first bound backend as the DMA device. While + * our device trees always have all backends enabled, some in + * the wild may actually have the first one disabled. If both + * are enabled, the order in which they are bound is guaranteed + * since the driver adds components in order. + */ + if (drm_dev_dma_dev(drm) =3D=3D drm->dev) + drm_dev_set_dma_dev(drm, dev); =20 backend->engine.node =3D dev->of_node; backend->engine.ops =3D &sun4i_backend_engine_ops; diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/su= n8i_mixer.c index 02acc7cbdb97..4071ab38b4ae 100644 --- a/drivers/gpu/drm/sun4i/sun8i_mixer.c +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c @@ -536,18 +536,21 @@ static int sun8i_mixer_bind(struct device *dev, struc= t device *master, mixer->engine.ops =3D &sun8i_engine_ops; mixer->engine.node =3D dev->of_node; =20 - if (of_property_present(dev->of_node, "iommus")) { - /* - * This assume we have the same DMA constraints for - * all our the mixers in our pipeline. This sounds - * bad, but it has always been the case for us, and - * DRM doesn't do per-device allocation either, so we - * would need to fix DRM first... - */ - ret =3D of_dma_configure(drm->dev, dev->of_node, true); - if (ret) - return ret; - } + /* + * This assume we have the same DMA constraints for all our the + * devices in our pipeline (all the backends, but also the + * frontends). This sounds bad, but it has always been the case + * for us, and DRM doesn't do per-device allocation either, so + * we would need to fix DRM first... + * + * Always use the first bound backend as the DMA device. While + * our device trees always have all backends enabled, some in + * the wild may actually have the first one disabled. If both + * are enabled, the order in which they are bound is guaranteed + * since the driver adds components in order. + */ + if (drm_dev_dma_dev(drm) =3D=3D drm->dev) + drm_dev_set_dma_dev(drm, dev); =20 /* * While this function can fail, we shouldn't do anything --=20 2.53.0.473.g4a7958ca14-goog