From nobody Thu Apr 9 09:02:43 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18160175A80 for ; Tue, 10 Mar 2026 01:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773106415; cv=none; b=i9pSzT6sEqRy3GjyS7lv7Q3KbIRZtS+BbxNrR7VAHIXqzEv62+kZMNarMDrTtvb6joKGFeEO5HA8etXRx57O/q1gT03M36glPTQRmz4zirIR12Htm4+i60n3GuE1X8P6+Qz9a/NU5HVOsSkZaAWLLmivVXcmjxgLf2ZSU2+nftQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773106415; c=relaxed/simple; bh=SOBW56UKgGwsovYYsrbzT9nRDR9R41mB6VvbtvdG3FY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oAsgN7LI/MEev2Jhhw78jF/cvYCkx7IDOn2GPeKzKBtVrRw8EP0gGKsNOFCOgEEmpS0Uu4FI3fR0/sDipn+3u4OrLFqd++5acUg2tlBkZC8X3bAlJeVhSyrmpZ4WbbF9ncJJQ5fHgj4xkJd7wXc/UtIUI6rAe0nFwxucam1iFV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bUbCjOzM; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bUbCjOzM" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2ae5636ab04so89580935ad.3 for ; Mon, 09 Mar 2026 18:33:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773106413; x=1773711213; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XN19Fj8kTtTfEGaQbV98LN4KgTzseZY5nBnPQ8wB9iQ=; b=bUbCjOzMxrQJRZVsk9zQUzGfgWCZGD2BTnqBpJ4ysO+c3MQBOcgKpnvzXnUPICSYSp XsglHEXuoI+Z0QuaBNvct9oNUt8SWWQnAPxe5U11RT/UCgWWoChZDP2lAjstHnZHJ20s dsOXWCNqUbbpGhKPfryr5MC2hP20GZIVZhGOJMH3YTG+7cVyI1MepPKjpmh9ibvIwGfH 5QPe49t/lJ2Tboubm9/d+N7D0i1SQzEHP9Tp+xdY+H4thAgwiwNJT43cD1Om/dKgPkAi K5tYTtnHauA8ySCDd/qY2vb+4fBn9pjSnPCcvyjje/uqyq4vLpwS8KUqAmP33pmBpC1U zS6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773106413; x=1773711213; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XN19Fj8kTtTfEGaQbV98LN4KgTzseZY5nBnPQ8wB9iQ=; b=IhbeJQCZ1thCqAPjfbj754RNMsHyIegAaMz+sa6dnDsAoCtZNJL+hQXCbWrymMSB1d D85x04XJfYKt/7vDPnPv9NAXO5+teM5K19lS6OQqs65Qj4jdc5w4OXx4FB4DoVj/LjBn GqiIltEJWHvQYD2P8grCfKemK6KZ2pGoKr5JplAiaH2/TjXL6/H0Cn6Z7Va9Q8tgfkNR n9Rke2JzPcdz5ZmCxBiIxKq7zZN2zh7a0Z2uRATgMEqKfcepRA/TXb3nYsrbmvKbEFky s36l876tEfZvtU+ONlPGVIkhAMdz9AEE/NE2XqO0D852PlPZSWfx7qlI/WNt52Ndp56+ rRkQ== X-Forwarded-Encrypted: i=1; AJvYcCV/dftGfPVLpx8lnUlZ3a2s+ha9qfY2SHn8O7mKItIUhT1Wkgcr+0PHgK7CYPLrKolK0ahEV2CKvqzJtSc=@vger.kernel.org X-Gm-Message-State: AOJu0YwiVewCoLn9LY3uQJFueSWuZz/Jq9vsKyH9TxWs/e7aeYjfYwLr 2h1094oocpBOXFiHfrpOlH2U4SR9dBchZC+BFGp5TEDKdKs7PBQQrcIf X-Gm-Gg: ATEYQzz8T8TIrLvRofeSKqV158895WqTjxeHgyHjeSw0+UGHfp+64U31ARSHO+kdCVZ N+7v3gpLVX2yV9yUxuEbzhw3pz+1pu+uqxY1JaDL3ZZU0ApyDRmiXLQu6xDGRiwl/j9VeOeNCcI +4qxRSRjL0Imkk2Tf0EFRSXSId2BJU1kMyliSdBZKXIFW529D19RZZZqxd7ub+CaK5KsWrLPK2X BtY8hYkQgN4X+yX4AbgvRLNPAcbp1c/RhzsZsDaRElZoqYjauEjKnnIHyy58B/HpTNj9h1wmq02 qlKV8okdaydtPUrle/CDU5slId/ZGg0BuFovJjyHkuuuNoBkAurG65g/9NAhOQIPxVBlQ845G8G qGRWdIUjIVe5N4xfG3QjDxNxc7Fg9gAb4Sf3L537tD3HT75RDdITQuz0F7TqH6/FdJv+Oh2J7Pe sTYnps2ADgCV6oO/0KT5af/Bp6QLwzcgNM6eu289MUktQTEcr1MEXGN+4NBk389ow/Osg0OMadX tDEwlV+Lhw+SSCx X-Received: by 2002:a17:902:f78f:b0:2a0:e5cd:80a1 with SMTP id d9443c01a7336-2ae8247b89bmr117452575ad.41.1773106413227; Mon, 09 Mar 2026 18:33:33 -0700 (PDT) Received: from tower (c-73-37-64-97.hsd1.or.comcast.net. [73.37.64.97]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f9678fsm132483875ad.68.2026.03.09.18.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 18:33:32 -0700 (PDT) From: Mark Adamenko To: linux-staging@lists.linux.dev Cc: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Mark Adamenko Subject: [PATCH] staging: most: dim2: remove BUG_ON() calls Date: Mon, 9 Mar 2026 18:33:04 -0700 Message-ID: <20260310013304.39169-1-marusik.adamenko@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" All BUG_ON() calls in this file are redundant either because of impossible conditions or prior error handling. Remove all BUG_ON() calls. Signed-off-by: Mark Adamenko --- drivers/staging/most/dim2/dim2.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 66617e89e028..c8fdc6a52467 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -165,9 +165,6 @@ static int try_start_dim_transfer(struct hdm_channel *h= dm_ch) unsigned long flags; struct dim_ch_state st; =20 - BUG_ON(!hdm_ch); - BUG_ON(!hdm_ch->is_initialized); - spin_lock_irqsave(&dim_lock, flags); if (list_empty(head)) { spin_unlock_irqrestore(&dim_lock, flags); @@ -187,7 +184,6 @@ static int try_start_dim_transfer(struct hdm_channel *h= dm_ch) return -EAGAIN; } =20 - BUG_ON(mbo->bus_address =3D=3D 0); if (!dim_enqueue_buffer(&hdm_ch->ch, mbo->bus_address, buf_size)) { list_del(head->next); spin_unlock_irqrestore(&dim_lock, flags); @@ -268,9 +264,6 @@ static void service_done_flag(struct dim2_hdm *dev, int= ch_idx) unsigned long flags; u8 *data; =20 - BUG_ON(!hdm_ch); - BUG_ON(!hdm_ch->is_initialized); - spin_lock_irqsave(&dim_lock, flags); =20 done_buffers =3D dim_get_channel_state(&hdm_ch->ch, &st)->done_buffers; @@ -454,8 +447,6 @@ static int configure_channel(struct most_interface *mos= t_iface, int ch_idx, int const ch_addr =3D ch_idx * 2 + 2; struct hdm_channel *const hdm_ch =3D dev->hch + ch_idx; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D DMA_CHANNELS); - if (hdm_ch->is_initialized) return -EPERM; =20 @@ -566,8 +557,6 @@ static int enqueue(struct most_interface *most_iface, i= nt ch_idx, struct hdm_channel *hdm_ch =3D dev->hch + ch_idx; unsigned long flags; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D DMA_CHANNELS); - if (!hdm_ch->is_initialized) return -EPERM; =20 @@ -642,8 +631,6 @@ static int poison_channel(struct most_interface *most_i= face, int ch_idx) u8 hal_ret; int ret =3D 0; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D DMA_CHANNELS); - if (!hdm_ch->is_initialized) return -EPERM; =20 --=20 2.53.0