From nobody Thu Apr 9 10:32:07 2026 Received: from mail-m15594.qiye.163.com (mail-m15594.qiye.163.com [101.71.155.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 220A12D948D; Tue, 10 Mar 2026 01:25:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.94 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773105951; cv=none; b=c6HMval06ji5v+opo0i8otLxUE8X3L6IRbwGfKHbW3JCydht+FcWn7Dbw8/Le73oTlnC4HHrKThubL76YV5smxiydK0Rkk51RQOOdmkHj2ewqyDh/N3gTPG7L0RVFI3MgyWWk9uTv7x53rOrn5fveMgt/RIFzqEnSh4VM7Y5uI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773105951; c=relaxed/simple; bh=fYiL5xAaF9o6BilI2+Y05gJkjFe/8LqCeJiRie4+l8c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=l0DcctgYzo6wy5171aK2yO/mbunDBzdIgOwqCujQAuASBqlQJN7LQ1ydBa7T2KAHoEj3DySjkoXO6xqzn0ztVWWE/xNjS7NzJxaH+O39DCaBbs1/rWqXdTvlvvlX9ws2DNeJoDNBv+//kXk5Z9Wcr4+hrBPJcMIj6ivI+PjSjdU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=RkVLxzJx; arc=none smtp.client-ip=101.71.155.94 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="RkVLxzJx" Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 3653ae7fa; Tue, 10 Mar 2026 09:25:38 +0800 (GMT+08:00) From: Damon Ding To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, alim.akhtar@samsung.com, jingoohan1@gmail.com, p.zabel@pengutronix.de, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, dmitry.baryshkov@oss.qualcomm.com, dianders@chromium.org, m.szyprowski@samsung.com, luca.ceresoli@bootlin.com, jani.nikula@intel.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Damon Ding Subject: [PATCH v10 07/18] drm/bridge: analogix_dp: Move the color format check to .atomic_check() for Rockchip platforms Date: Tue, 10 Mar 2026 09:24:47 +0800 Message-Id: <20260310012458.169272-8-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260310012458.169272-1-damon.ding@rock-chips.com> References: <20260310012458.169272-1-damon.ding@rock-chips.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a9cd5597fb903a3kunm2771af5030df94 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGUJLTlYfGh5NSx4YTEhOSE1WFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpKQk 1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=RkVLxzJxj4fSc0Nwe5sC1m/5VeB8P2vpNem6SD9L/G2L5cvtSfjRtv7m/4bTFldNaOthk62nJhGtRjaOrt0Tfb10RPiPXGsyt9Sfk2R9IYCjmogFT3LInOOSWrvLh5tWqoTN3RCPC+fSw8HONyYzIq3Nbsspi5O3cZGGzAvIb7c=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=3rkQ8jPKQUXQ5Fcb5jzjcMRfHXjYelN4FuQCG5UEL4g=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" For Rockchip platforms, the YUV color formats are currently unsupported. This compatibility check was previously implemented in &analogix_dp_plat_data.get_modes(). Moving color format check to &drm_connector_helper_funcs.atomic_check() would get rid of &analogix_dp_plat_data.get_modes() and be more reasonable than before. Signed-off-by: Damon Ding Reviewed-by: Dmitry Baryshkov Tested-by: Marek Szyprowski Tested-by: Heiko Stuebner (on rk3588) --- Changes in v9: - Add Tested-by tag. --- .../gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +++++++++++ .../gpu/drm/rockchip/analogix_dp-rockchip.c | 18 ------------------ 2 files changed, 11 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.c index 4606ecc3f480..5bf41b364aba 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -894,8 +894,19 @@ static int analogix_dp_atomic_check(struct drm_connect= or *connector, struct drm_atomic_state *state) { struct analogix_dp_device *dp =3D to_dp(connector); + struct drm_display_info *di =3D &connector->display_info; struct drm_connector_state *conn_state; struct drm_crtc_state *crtc_state; + u32 mask =3D DRM_COLOR_FORMAT_YCBCR444 | DRM_COLOR_FORMAT_YCBCR422; + + if (is_rockchip(dp->plat_data->dev_type)) { + if ((di->color_formats & mask)) { + DRM_DEBUG_KMS("Swapping display color format from YUV to RGB\n"); + di->color_formats &=3D ~mask; + di->color_formats |=3D DRM_COLOR_FORMAT_RGB444; + di->bpc =3D 8; + } + } =20 conn_state =3D drm_atomic_get_new_connector_state(state, connector); if (WARN_ON(!conn_state)) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/= drm/rockchip/analogix_dp-rockchip.c index fdab71d51e2a..70fe5ae69e2e 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -166,23 +166,6 @@ static int rockchip_dp_powerdown(struct analogix_dp_pl= at_data *plat_data) return 0; } =20 -static int rockchip_dp_get_modes(struct analogix_dp_plat_data *plat_data, - struct drm_connector *connector) -{ - struct drm_display_info *di =3D &connector->display_info; - /* VOP couldn't output YUV video format for eDP rightly */ - u32 mask =3D DRM_COLOR_FORMAT_YCBCR444 | DRM_COLOR_FORMAT_YCBCR422; - - if ((di->color_formats & mask)) { - DRM_DEBUG_KMS("Swapping display color format from YUV to RGB\n"); - di->color_formats &=3D ~mask; - di->color_formats |=3D DRM_COLOR_FORMAT_RGB444; - di->bpc =3D 8; - } - - return 0; -} - static bool rockchip_dp_drm_encoder_mode_fixup(struct drm_encoder *encoder, const struct drm_display_mode *mode, @@ -481,7 +464,6 @@ static int rockchip_dp_probe(struct platform_device *pd= ev) dp->plat_data.dev_type =3D dp->data->chip_type; dp->plat_data.power_on =3D rockchip_dp_poweron; dp->plat_data.power_off =3D rockchip_dp_powerdown; - dp->plat_data.get_modes =3D rockchip_dp_get_modes; =20 ret =3D rockchip_dp_of_probe(dp); if (ret < 0) --=20 2.34.1