From nobody Thu Apr 9 09:02:43 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47AB61B86C7 for ; Tue, 10 Mar 2026 00:27:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773102437; cv=none; b=jZESoOVZfsy9lwugCDnA33K92zwK7cPjlhWLQzfLFGt0egRcl374G9U/6GqJ4Any8NpdvMDAzU9Sm4db28wQQI4szqG4oA67WtzP6H77+A9neSJ1oVHoBboFcpTMokEfBGlvmfOxCTsnAgSYipnBfbxiW5WvmA8cXrRlW9SBo98= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773102437; c=relaxed/simple; bh=XJlz7TAx+3J7IJ76cfvjfM28sjsC5jwU+vA9iaG8HY8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fL8Mn/fCf86lTOxcPSm/dJZ9SRhJ8ECY3G766j0WbjEnQ2sqU0CbSw+CJ5VaQZyLcjx79pjJwgUxOndG0WrCltDI8ZirA668E7lXBHOpT/DteqAwvceOVJGb7zoGm1JbmxPgjjNDpDAQcx2AjgamPv4WXTn2IwYFKIkp+m0edeI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QFhoGIOG; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QFhoGIOG" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3598b95ad7dso6638537a91.2 for ; Mon, 09 Mar 2026 17:27:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773102434; x=1773707234; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kBSFBJjMJpbjZ3yrhCcXTD3ypyojE/o7DNoxI6+C6lg=; b=QFhoGIOGYcPD8TMzi0pHkemrcNtxypLP+nY23YCzpSIFDZPZOYyJAm3mfzdGnWcT3y N5eMHcPbU4OcN83J6qw+fdaeVLnKYuv6rI439Sl6Y6/vqkEpduKargKFTvnbIVDjklZP fqRojURSGfwLU7YUAdIYeMYtuMfb/lRXaqHqi3JbBVBFve1wbvCPCF6W2bVayqM1WZRN E/W8WiKrNpGRAN5ORrghDRXjyTo+j2JhwCdcBUfJKqwPUeJIRcRODdNBKtDAVrraC4SV kOkpbhV7jX46Hbej+6RBPrm2O0WZbRxc2fhAkHonoCytZdTnIBtf1NJi8U6b2nwmenV/ 7pLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773102434; x=1773707234; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kBSFBJjMJpbjZ3yrhCcXTD3ypyojE/o7DNoxI6+C6lg=; b=F2HXKxuqg9q0qPXWWX/5mfMi8qta4waqhI2sYLFoJ/OoHbUPbKHBdUeHP/wB6it8K2 VUoujFH+3NSvf3okt5wOfOA7oCzOcCmUErXWqqvkkaufjlasHAh1M8yRd41sp7QURZiT ucy7wXG/pJE/b0BAaSkC1Lz1n4f876+0dtsf6BIQu41uv6i9mB7G5EYcgFL/YvpCLANT TaENLZUJ+FBdonuM02Pbs5usqn/NhXFDnb33J45ZaTmOPfLrkp35s22BW5PWnOVrRQju 7cBXTmq4IOs1C8qSU3E+eeYE5ZePgUVDGvcP+DIluluMyV+nM1Jqb7DiMBAfywfc5tND PLrw== X-Forwarded-Encrypted: i=1; AJvYcCU4WkZ+gVQYPp0gbhLG+HaqflBH9Q6nwuFYgr0tPIQKXO32BvJgzYlibNwSPAJ6HDSpsAc1lun36rFD5o0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxhg8/DtT0wQCZ9QnBJybqYNsTFMpJAfda+O1zvzBOv/8VQJNvP TmSposzuuGXYZ/QNFs0zrL0Ac70J9hjjo8s12vw8COdRJJ9QiX4KDo2g X-Gm-Gg: ATEYQzy40r2GmAKPKAG5yc31GYNxovWCR7uCu3Lp22XqdcyD8GI6diwJq0F8dtmjnSt FPAqP6FL8JZcbzMmIVv4PHyfYZOFJQ6EOXW+aXgdWzJnFY+XruIn6+K1Ix4qVKY4fTyAjug4Sed I7Rc9CCZd7t1cHJrW/Ly8xIfnKwDjtuv9cjr2Xjdud5qmmCEptu9M6gYT3tR0nPWD5smWo+voYK SmDHLBWrUzsMS27Bpg6Qlis0n5YSCumwOvK1HxcQRa7tF7Z/rYS9VWjPsLibBa1ulDPOGg0ba++ 7top1DpnTttf2v+WQyHMc6xj7bHDG14kZ8Keg3Te3ydYDItT3Q1ccP+CrbO3jD1+td8XxGSgs2t 6QCSlZC35mIlHUXBhnKnfB+vKmXa2KGpnHH7R49sy2zV69gyD0vMsRCtW/gp/mBHbfJrBVjmBcz hXdumqXqBQ/PtJZw5Sxr4EHCxNvxmKevIx6LeoLzcRBI56qS4qmuXR7f1TL2bF3ikuZBXZo/R1E y7M74/cIfwOE9oo X-Received: by 2002:a05:6a21:8885:b0:398:7fd2:5941 with SMTP id adf61e73a8af0-3987fd25c81mr5602489637.44.1773102434555; Mon, 09 Mar 2026 17:27:14 -0700 (PDT) Received: from tower (c-73-37-64-97.hsd1.or.comcast.net. [73.37.64.97]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e183596sm10245803a12.27.2026.03.09.17.27.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 17:27:14 -0700 (PDT) From: Mark Adamenko To: linux-staging@lists.linux.dev Cc: slongerbeam@gmail.com, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, imx@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Adamenko Subject: [PATCH v3] staging: media: imx: fix parenthesis ending checks Date: Mon, 9 Mar 2026 17:26:43 -0700 Message-ID: <20260310002643.27465-1-marusik.adamenko@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove 4 checks for ending with a parenthesis by removing unnecessary line breaks, and forward declare a variable for a function call that would otherwise remain over 80 columns. Signed-off-by: Mark Adamenko Reviewed-by: Frank Li --- v3: fix commit message --- --- drivers/staging/media/imx/imx-ic-prpencvf.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/= media/imx/imx-ic-prpencvf.c index 77360bfe081a..2339b59af7b0 100644 --- a/drivers/staging/media/imx/imx-ic-prpencvf.c +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c @@ -315,8 +315,7 @@ static void prp_setup_vb2_buf(struct prp_priv *priv, dm= a_addr_t *phys) buf =3D imx_media_capture_device_next_buf(vdev); if (buf) { priv->active_vb2_buf[i] =3D buf; - phys[i] =3D vb2_dma_contig_plane_dma_addr( - &buf->vbuf.vb2_buf, 0); + phys[i] =3D vb2_dma_contig_plane_dma_addr(&buf->vbuf.vb2_buf, 0); } else { priv->active_vb2_buf[i] =3D NULL; phys[i] =3D priv->underrun_buf.phys; @@ -704,11 +703,9 @@ static int prp_start(struct prp_priv *priv) } =20 if (ipu_rot_mode_is_irt(priv->rot_mode)) - priv->eof_irq =3D ipu_idmac_channel_irq( - ic_priv->ipu, priv->rot_out_ch, IPU_IRQ_EOF); + priv->eof_irq =3D ipu_idmac_channel_irq(ic_priv->ipu, priv->rot_out_ch, = IPU_IRQ_EOF); else - priv->eof_irq =3D ipu_idmac_channel_irq( - ic_priv->ipu, priv->out_ch, IPU_IRQ_EOF); + priv->eof_irq =3D ipu_idmac_channel_irq(ic_priv->ipu, priv->out_ch, IPU_= IRQ_EOF); =20 ret =3D devm_request_irq(ic_priv->ipu_dev, priv->eof_irq, prp_eof_interrupt, 0, @@ -750,7 +747,7 @@ static int prp_start(struct prp_priv *priv) static void prp_stop(struct prp_priv *priv) { struct imx_ic_priv *ic_priv =3D priv->ic_priv; - unsigned long flags; + unsigned long flags, timeout_in_jiffies; int ret; =20 /* mark next EOF interrupt as the last before stream off */ @@ -761,9 +758,8 @@ static void prp_stop(struct prp_priv *priv) /* * and then wait for interrupt handler to mark completion. */ - ret =3D wait_for_completion_timeout( - &priv->last_eof_comp, - msecs_to_jiffies(IMX_MEDIA_EOF_TIMEOUT)); + timeout_in_jiffies =3D msecs_to_jiffies(IMX_MEDIA_EOF_TIMEOUT); + ret =3D wait_for_completion_timeout(&priv->last_eof_comp, timeout_in_jiff= ies); if (ret =3D=3D 0) v4l2_warn(&ic_priv->sd, "wait last EOF timeout\n"); =20 --=20 2.53.0