From nobody Wed Apr 8 04:48:03 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6594F317144 for ; Wed, 11 Mar 2026 00:19:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773188391; cv=none; b=l6ssiAxllwOQqdfnMo82bnpXT20mW1Iu+kx6ULx39tEW6SzB9GrGKmkNd/mZejwtH/IPdmL5EDgvm1xFnmrpbxjyzWqwnMUr6zm4kiwALJF5GTXrBWLDDiQ9/NB25eB1xU3Tfh84FWAz12okHnMGk2Ac3HQPoGirnjifRgWq4uc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773188391; c=relaxed/simple; bh=4oxBL1nK08FLRbDWU9wkPzZS7L2lwxUdKpRD7zqmMz8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Z+nhBSYt1Auy9/q+k+Jz34GL3oWSiEwk8CreZmTvTb5rYuGsPxHV0oW4cdS1F1t96t8qP5l8GTLqcfXoZS/CYs2ArmWZqPcESyK00Acwe7FmnJiLSkJ9qLBGw2Q72lyDtSKQyxmnJrYg2+e4jVVS4N9eg3R3a9bCGgaNsSOfBuQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=dOL4rnkl; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="dOL4rnkl" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-82987437624so233845b3a.1 for ; Tue, 10 Mar 2026 17:19:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1773188390; x=1773793190; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=h5wwOswllCgTCDAs+LOmWhWVxDwPfzx7ibhefMJUOMU=; b=dOL4rnkl6NmtWAD6thVIaUNnv6TlhKIORo6vMKokB6m2tyujFypiteS901BdhPORo8 IQQFK1r7r18mfSBJHsgJ7DVfbd/xwFam/iP4QtD2g75Oa9osF63KP74KJdkdkEJzR865 uBWiUIlGq2c1NbLN9ZUbuNqkXfS4lXv3sGIdpuIWeTd4X8WPoJoEWVHBkmM/KHCTfQ0E 05haAO1lS1onodDAGp/1LGVlvxJ9KYDiJUESIrhHtt88ia9wUB4ZqxMVPWKNmTXffO5g CrBGDrVOn+vn0wRVu4lkl0ehg7oTqrwf0DwBX78vEG8QN2kCx4ftzAcvP7iul6seJd87 IYJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773188390; x=1773793190; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=h5wwOswllCgTCDAs+LOmWhWVxDwPfzx7ibhefMJUOMU=; b=S69CvCB6ktmXintW+16lVohyusntvnzF3F0zK3OaoJAhXDYnZFo9KwZqCb4dLF8ZXL dX5bgnlLvYbctjYb5VdNx0lNqsCoYcNOXPdcWdEqOf8UIalZY4VHengyb3rE4bAeJRFo 0lJf7Vgh1tdG1tu2thYOZVrCKTp1FE+0Zq2pA1R9cz7s7a2mAR9ND5g+PG42FVkBB5xh CCZqXbe4XEzvsIVam9NZU85xxxeicP7/U/ZVDmoP5T8I0PWBySi8XTO73K602tV0jFB3 BUvmlr6zakSrMtHmd5y60Cr4BvnjKPlRZA9caH2TiFzB6rE0gzB9zoj1IqclHAl7jibA mKCw== X-Forwarded-Encrypted: i=1; AJvYcCVvf58XtKKkhykdWmNqov2L4LGK07yU1URPOfa0EiIv8tJ6/RrV8YF7wnI1KcC/zEiVsR+UTWSunRK+a+8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy03aNmtAP1E7ISPyFxiWxrrBjH+xEaEhN3u2Rrd3t2urAYCzRL fBP9gS5aUMECuCTqvAkHi7N76TiUTCSO0T4T16GErrsp/79sHzqI4tLNqS7RIy4J02w= X-Gm-Gg: ATEYQzzWJUKX8TaLBSWLlk/pvB4Oj+9k36gv+ogF55/wXulYYMPFbD7O8pDMvz1Rikx THDU6jQZEt/Z6t6P/UiETPSFKqJXItoZzuMPyPbVl2SQinCm4Ufjd0nt+mP4bO7ONlixWUmfhEl lsL8mycVek74yta7itsVfPRfKFj16eOujx8TYJxjzpkijVSXVSbaqTN0+VW1ONhjjhE09SgIdWn WFZyyVRXUgXDuLUUdb2XwSWrhOUSifxlpvlENU2BNklxyFR3EfYK/YNC3wgtiRL9sug0XXyl6wt 0pzbxQQkLZUxzQIakrsFLQXO5c2GVPQMhaTqqrYWRUszVB+TMxA+K4CMyLwhUnqHw/VDiEcjEuo zaXLXAKt2xru4T08nfgpfLxUdZ0noodIT+phtQZT4Wtbf2HYuLRRRAQqBdrgVSl68HIq1kJdHsG NWvy4AR8kLlHgp8DK9JTHn X-Received: by 2002:a05:6a00:178e:b0:827:2d7b:5038 with SMTP id d2e1a72fcca58-829e3ef8fafmr4682544b3a.5.1773188389865; Tue, 10 Mar 2026 17:19:49 -0700 (PDT) Received: from localhost ([71.212.200.220]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829f6dc2b34sm453256b3a.3.2026.03.10.17.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 17:19:49 -0700 (PDT) From: "Kevin Hilman (TI)" Date: Tue, 10 Mar 2026 17:19:24 -0700 Subject: [PATCH 2/3] pmdomain: core: add support for power-domains-child-ids Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-topic-lpm-pmdomain-child-ids-v1-2-5361687a18ff@baylibre.com> References: <20260310-topic-lpm-pmdomain-child-ids-v1-0-5361687a18ff@baylibre.com> In-Reply-To: <20260310-topic-lpm-pmdomain-child-ids-v1-0-5361687a18ff@baylibre.com> To: Ulf Hansson , Rob Herring Cc: Geert Uytterhoeven , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.15-dev-53144 X-Developer-Signature: v=1; a=openpgp-sha256; l=8594; i=khilman@baylibre.com; h=from:subject:message-id; bh=4oxBL1nK08FLRbDWU9wkPzZS7L2lwxUdKpRD7zqmMz8=; b=owEBbQKS/ZANAwAIAVk3GJrT+8ZlAcsmYgBpsLUikF1gdU810zlXWY9fnICiVhRRew4IHekny 2mQCGxcelOJAjMEAAEIAB0WIQR7h0YOFpJ/qfW/8QxZNxia0/vGZQUCabC1IgAKCRBZNxia0/vG ZZsGD/98WdtRS+muBkrIKU7WHUSnXWWHnZeDc3sa3d/QxmaOm/ov9aV2HTC1k/92hxjDTzBIu9O PYNpPjFQqxreSDudc/LBVRq7AwGDtwSWvAzY2xujxXwm+KZOCcanpZL5JAIbVE0HFQmDVjKh4xC 1WXSneL6l1z+nvlJqu20HjRRMgp6TOrYH5cZkPujJnJ/EIXqqt6OIGeZrgZvFCoiVoYTVksv5Gy qfNURfnvExrScPbg9NnFYPW37IDCcs/Kwy/k/9vaUkRZKMk9wZSR02mI5DXEX4V+nxQ9S4Id5sm XICVhlHhzwvyJ3zUqHtfqsPOTewIoMH6EGgTK97SVVu4AL3wEolO25He1ZlIv4tkiJpB84nfFmf rA7gJUXddX4APrOzZcUk9o7zFjk3URR7nvnu0l/MgcqhGkdKjGitG5/6hvSZ/2OvDoZjuSZts48 06FyydDM5bSyuFEFhob+tC6toxLJVccN27xtwb+JwcIXXJkk1H7+cewpMomtztWjwGfimaEnLp0 1Ay3HYpla6FTUctSTMmnKsVc6D4vBkPpI3JklZKTWu4RdHKAUoo+QMCe7eGUqEpkQRSzXTnW/0H DxP6Uk2bYi8fk0rmRVIFQudPXMbDq32zYA5liIglgZ6TDJ87QZqB92C2pDeSiyqg6bG4voLTu6M U5oe+I0yp4rrJbA== X-Developer-Key: i=khilman@baylibre.com; a=openpgp; fpr=7B87460E16927FA9F5BFF10C5937189AD3FBC665 Currently, PM domains can only support hierarchy for simple providers (e.g. ones with #power-domain-cells =3D 0). Add support for oncell providers as well by adding a new property `power-domains-child-ids` to describe the parent/child relationship. For example, an SCMI PM domain provider has multiple domains, each of which might be a child of diffeent parent domains. In this example, the parent domains are MAIN_PD and WKUP_PD: scmi_pds: protocol@11 { reg =3D <0x11>; #power-domain-cells =3D <1>; power-domains =3D <&MAIN_PD>, <&WKUP_PD>; power-domains-child-ids =3D <15>, <19>; }; With this example using the new property, SCMI PM domain 15 becomes a child domain of MAIN_PD, and SCMI domain 19 becomes a child domain of WKUP_PD. To support this feature, add two new core functions - of_genpd_add_child_ids() - of_genpd_remove_child_ids() which can be called by pmdomain providers to add/remove child domains if they support the new property power-domains-child-ids. Signed-off-by: Kevin Hilman (TI) Tested-by: Dhruva Gole --- drivers/pmdomain/core.c | 169 ++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++++++++++++++++++++++ include/linux/pm_domain.h | 16 ++++++++++++++++ 2 files changed, 185 insertions(+) diff --git a/drivers/pmdomain/core.c b/drivers/pmdomain/core.c index 61c2277c9ce3..acb45dd540b7 100644 --- a/drivers/pmdomain/core.c +++ b/drivers/pmdomain/core.c @@ -2909,6 +2909,175 @@ static struct generic_pm_domain *genpd_get_from_pro= vider( return genpd; } =20 +/** + * of_genpd_add_child_ids() - Parse power-domains-child-ids property + * @np: Device node pointer associated with the PM domain provider. + * @data: Pointer to the onecell data associated with the PM domain provid= er. + * + * Parse the power-domains and power-domains-child-ids properties to estab= lish + * parent-child relationships for PM domains. The power-domains property l= ists + * parent domains, and power-domains-child-ids lists which child domain IDs + * should be associated with each parent. + * + * Returns 0 on success, -ENOENT if properties don't exist, or negative er= ror code. + */ +int of_genpd_add_child_ids(struct device_node *np, + struct genpd_onecell_data *data) +{ + struct of_phandle_args parent_args; + struct generic_pm_domain *parent_genpd, *child_genpd; + struct of_phandle_iterator it; + const struct property *prop; + const __be32 *item; + u32 child_id; + int ret; + + /* Check if both properties exist */ + if (of_count_phandle_with_args(np, "power-domains", "#power-domain-cells"= ) <=3D 0) + return -ENOENT; + + prop =3D of_find_property(np, "power-domains-child-ids", NULL); + if (!prop) + return -ENOENT; + + item =3D of_prop_next_u32(prop, NULL, &child_id); + + /* Iterate over power-domains phandles and power-domains-child-ids in loc= kstep */ + of_for_each_phandle(&it, ret, np, "power-domains", "#power-domain-cells",= 0) { + if (!item) { + pr_err("power-domains-child-ids shorter than power-domains for %pOF\n",= np); + ret =3D -EINVAL; + goto err_put_node; + } + + /* + * Fill parent_args from the iterator. it.node is released by + * the next of_phandle_iterator_next() call at the top of the + * loop, or by the of_node_put() on the error path below. + */ + parent_args.np =3D it.node; + parent_args.args_count =3D of_phandle_iterator_args(&it, parent_args.arg= s, + MAX_PHANDLE_ARGS); + + /* Get the parent domain */ + parent_genpd =3D genpd_get_from_provider(&parent_args); + if (IS_ERR(parent_genpd)) { + pr_err("Failed to get parent domain for %pOF: %ld\n", + np, PTR_ERR(parent_genpd)); + ret =3D PTR_ERR(parent_genpd); + goto err_put_node; + } + + /* Validate child ID is within bounds */ + if (child_id >=3D data->num_domains) { + pr_err("Child ID %u out of bounds (max %u) for %pOF\n", + child_id, data->num_domains - 1, np); + ret =3D -EINVAL; + goto err_put_node; + } + + /* Get the child domain */ + child_genpd =3D data->domains[child_id]; + if (!child_genpd) { + pr_err("Child domain %u is NULL for %pOF\n", child_id, np); + ret =3D -EINVAL; + goto err_put_node; + } + + /* Establish parent-child relationship */ + ret =3D genpd_add_subdomain(parent_genpd, child_genpd); + if (ret) { + pr_err("Failed to add child domain %u to parent in %pOF: %d\n", + child_id, np, ret); + goto err_put_node; + } + + pr_debug("Added child domain %u (%s) to parent %s for %pOF\n", + child_id, child_genpd->name, parent_genpd->name, np); + + item =3D of_prop_next_u32(prop, item, &child_id); + } + + /* of_for_each_phandle returns -ENOENT at natural end-of-list */ + if (ret && ret !=3D -ENOENT) + return ret; + + /* All power-domains phandles were consumed; check for trailing child IDs= */ + if (item) { + pr_err("power-domains-child-ids longer than power-domains for %pOF\n", n= p); + return -EINVAL; + } + + return 0; + +err_put_node: + of_node_put(it.node); + return ret; +} +EXPORT_SYMBOL_GPL(of_genpd_add_child_ids); + +/** + * of_genpd_remove_child_ids() - Remove parent-child PM domain relationshi= ps + * @np: Device node pointer associated with the PM domain provider. + * @data: Pointer to the onecell data associated with the PM domain provid= er. + * + * Reverses the effect of of_genpd_add_child_ids() by parsing the same + * power-domains and power-domains-child-ids properties and calling + * pm_genpd_remove_subdomain() for each established relationship. + * + * Returns 0 on success, -ENOENT if properties don't exist, or negative er= ror + * code on failure. + */ +int of_genpd_remove_child_ids(struct device_node *np, + struct genpd_onecell_data *data) +{ + struct of_phandle_args parent_args; + struct generic_pm_domain *parent_genpd, *child_genpd; + struct of_phandle_iterator it; + const struct property *prop; + const __be32 *item; + u32 child_id; + int ret; + + /* Check if both properties exist */ + if (of_count_phandle_with_args(np, "power-domains", "#power-domain-cells"= ) <=3D 0) + return -ENOENT; + + prop =3D of_find_property(np, "power-domains-child-ids", NULL); + if (!prop) + return -ENOENT; + + item =3D of_prop_next_u32(prop, NULL, &child_id); + + of_for_each_phandle(&it, ret, np, "power-domains", "#power-domain-cells",= 0) { + if (!item) + break; + + parent_args.np =3D it.node; + parent_args.args_count =3D of_phandle_iterator_args(&it, parent_args.arg= s, + MAX_PHANDLE_ARGS); + + if (child_id >=3D data->num_domains || !data->domains[child_id]) { + item =3D of_prop_next_u32(prop, item, &child_id); + continue; + } + + parent_genpd =3D genpd_get_from_provider(&parent_args); + if (IS_ERR(parent_genpd)) { + item =3D of_prop_next_u32(prop, item, &child_id); + continue; + } + + child_genpd =3D data->domains[child_id]; + pm_genpd_remove_subdomain(parent_genpd, child_genpd); + + item =3D of_prop_next_u32(prop, item, &child_id); + } + + return (ret =3D=3D -ENOENT) ? 0 : ret; +} +EXPORT_SYMBOL_GPL(of_genpd_remove_child_ids); + /** * of_genpd_add_device() - Add a device to an I/O PM domain * @genpdspec: OF phandle args to use for look-up PM domain diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index f67a2cb7d781..b44615d79af6 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -465,6 +465,10 @@ struct generic_pm_domain *of_genpd_remove_last(struct = device_node *np); int of_genpd_parse_idle_states(struct device_node *dn, struct genpd_power_state **states, int *n); void of_genpd_sync_state(struct device_node *np); +int of_genpd_add_child_ids(struct device_node *np, + struct genpd_onecell_data *data); +int of_genpd_remove_child_ids(struct device_node *np, + struct genpd_onecell_data *data); =20 int genpd_dev_pm_attach(struct device *dev); struct device *genpd_dev_pm_attach_by_id(struct device *dev, @@ -534,6 +538,18 @@ struct generic_pm_domain *of_genpd_remove_last(struct = device_node *np) { return ERR_PTR(-EOPNOTSUPP); } + +static inline int of_genpd_add_child_ids(struct device_node *np, + struct genpd_onecell_data *data) +{ + return -EOPNOTSUPP; +} + +static inline int of_genpd_remove_child_ids(struct device_node *np, + struct genpd_onecell_data *data) +{ + return -EOPNOTSUPP; +} #endif /* CONFIG_PM_GENERIC_DOMAINS_OF */ =20 #ifdef CONFIG_PM --=20 2.51.0