From nobody Wed Apr 8 03:09:23 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F6903A3E8E for ; Tue, 10 Mar 2026 17:58:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773165504; cv=none; b=M6CWuW62jxkJpRx965jvfuv+xTJqoJ+mz8oAgwdnLdZvQU+377BnnL52kbI2MfZWtCA1oka2rTt6QSCKAIieUKbVSEjh+kuJ7mbMvJPpJjoJ49OHXqiQQm6W/1Xys954QdsXJG26CBYsKeY/Bik0KZZ5q7lcyhPSw7cK/p3EoXc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773165504; c=relaxed/simple; bh=oMoTCYuZFb1fOm1lw/KHx/Ut4gfjGFHilENByzx/t8Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GbHSwdtxhb9uzYogU9lw10pQ3GUL1TeI47b7CErzdkFx/sD9IfxIq9wacZ2XcjzHaBXUCP5J2ZJEFMKRxJhllCjFmewSKwqBxVMvgplacVPJsh+3rrb5DJlI9tglZwyZauBbeQ1dfIgsjOmXqzWk97awzsJWDV0DosnFMLP/k1w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=HwiXYvpW; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="HwiXYvpW" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=L+KNhzYEf7Z4qnoEfyB0FBqnVQ+fhLYoQUFp4aL3UqE=; b=HwiXYvpWdxpdbwI5HJ9b11pre4 +NDoDJOm53K24FNAinCfnf2gIk+eMe/Wy/ou3POGGIooEU7pxvdaTlCrksgaFjrupNYeeckABfa3Z B3FeTwEVy5ntcZW4SGCJAsAFUw1fyfJO4URWOXbPSiG0LyDF3MICokXdXhpccQJNu9WMlcyaSfkwH yDKssVbXjNHFBagSXd5xXoeB+4UG1U/iyE1XSl3cmj0iOx4WcRB5o/oEHZnVXGvYpvVhc1ALllxSW u3YLbjVAklqutdA0Xsq1GHIRO8jTrpyVjWyZmnVWySL04DOz/knNhZXXrtsOcfZjIiJcVunZ0jOFY /5dKr4iQ==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w01LF-003AZV-4G; Tue, 10 Mar 2026 17:58:01 +0000 From: Breno Leitao Date: Tue, 10 Mar 2026 10:57:07 -0700 Subject: [PATCH v5 1/4] mm: khugepaged: export set_recommended_min_free_kbytes() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-thp_logs-v5-1-686099175bf6@debian.org> References: <20260310-thp_logs-v5-0-686099175bf6@debian.org> In-Reply-To: <20260310-thp_logs-v5-0-686099175bf6@debian.org> To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com, "Lorenzo Stoakes (Oracle)" , Breno Leitao X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=1360; i=leitao@debian.org; h=from:subject:message-id; bh=oMoTCYuZFb1fOm1lw/KHx/Ut4gfjGFHilENByzx/t8Q=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpsFubfa0/+t5o1gsfjniqKSZmIl1lGskKQPYKo rsp8i2E69WJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCabBbmwAKCRA1o5Of/Hh3 bS2sD/9DQ4RPUfDCgzs0t0hPuxsUFuVQapY+aiPHNBci/XBsV53TnhPvX9ZBN2Uu6hmQujs7syl 9P6PshEqr9nF/c9+bRe3OlcN4P1MVTvi6sOg2JNiEIpQCyggAqnJa8VAEcgEA+ozTSk8hRxskuD 2dFFIMTQx8sVIrwwWlIZ9MhvAr/1Q7L0qgha72EwglARazkuGpjqCoKRrFZ7+IEofM3Mzyd87KP E6fbdoKm41IkJjZHZd0qsbmWNyoh3shI9OtPgZq+JqwhRGT2Hy5f0sdY831EOIZSSSmg4BjjwPB E6fXqZ13B5QM4gTURNLSaqccEfMVYpX3lABxLLaYKDVQMTVP9IYjTL+oDudvhK6evJgIuBDfXsV wYQEViNHFd9ZNbqz0qi84tpQG4uXD8h/1g0qoHx+gcLpHeV9M4b72nVFV3SjjFsjwVB3ODJ7/1B at1ffDTThmtSc3Q1p5EyoeHz6ZFUXLU/bVMDnQzc7VnEXBqLd5Fvte0hudP5vJnybS7cJrDlKl6 G2YdYBBkdMyItjvBX5tFXqXK1UKJGzWHwEp2Gi3zbsO9rUoYoRUoy2+LXtvwVaqfiUG5QheHX2S fXy3AAQRJCypzxmgerTnxg18m3cLiK3gtzR6GKPo6VGG7H7mLWaqlHoheIR2G3vUS06lQY0hDTl Wvre2iBFY9NiCmA== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao Make set_recommended_min_free_kbytes() callable from outside khugepaged.c by removing the static qualifier and adding a declaration in mm/internal.h. This allows callers that change THP settings to recalculate watermarks without going through start_stop_khugepaged(). Suggested-by: Lorenzo Stoakes (Oracle) Reviewed-by: Lorenzo Stoakes (Oracle) Acked-by: David Hildenbrand (Arm) Signed-off-by: Breno Leitao Reviewed-by: Zi Yan --- mm/internal.h | 5 +++++ mm/khugepaged.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/mm/internal.h b/mm/internal.h index cb0af847d7d99..7bd768e367793 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -623,6 +623,11 @@ int user_proactive_reclaim(char *buf, */ pmd_t *mm_find_pmd(struct mm_struct *mm, unsigned long address); =20 +/* + * in mm/khugepaged.c + */ +void set_recommended_min_free_kbytes(void); + /* * in mm/page_alloc.c */ diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 1dd3cfca610db..56a41c21b44c9 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -2630,7 +2630,7 @@ static int khugepaged(void *none) return 0; } =20 -static void set_recommended_min_free_kbytes(void) +void set_recommended_min_free_kbytes(void) { struct zone *zone; int nr_zones =3D 0; --=20 2.52.0 From nobody Wed Apr 8 03:09:23 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAA573B7B61 for ; Tue, 10 Mar 2026 17:58:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773165502; cv=none; b=cqtb7VX7EFTPEbNRdTcHphn9VfwvFIHGY6937GyMjpvYVv53mrPSwQhXUzW1Xtk5o2AVmFwZIIQro9zi9BpN6hqxDETNEhDQmmaVIz60bA7BXyfd23OmF+8jMuOS+7znhb5TxDYwEJudyhibHtAKov7X/8IlVOtJrLaJZ8YPECo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773165502; c=relaxed/simple; bh=W0pmwY7DpMzVDcPqXGmH/VcJ1h6MSXt/labrb03moRc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JYuqzReUnNkNLBlhLPOO81oRHXr+FUCY2DLW7ob/19umNKKeYdWFok8OTh2Ue0JbgokBxm8xr8/rGXGuOUjC/7mjYgAFdMzRi7HY7p7nQ9eU7apl1hd1lbpDmBo0j6Qtr/G+P+5Na4gCsSNITs3Y7iye8TjsKR7TrnT7uyXqTEw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=qHUYXrdG; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="qHUYXrdG" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=wuDf6OJ8QUnJ8gfCrD1Pap3z37T2KxqK0+T2vb4JLZk=; b=qHUYXrdGbS8JLo9Z2odggADZmV Qh23xRIiiavV7kgPHSRVV6T5NzCiWjqEf7Xalfj+D8A1p6jSuxZPLG9YVwaocYoeOiu9WKIRqgyIC 61QYgR0vGFjx/i92vfztDJO1hysO+kRAfVY52j+XC39tazR/x1VwbZBYhTZDExCQzOM7RnWKJA3HL WKu3gPS+Dhz1mUTtNqIXUEMiEvKCXRF39ODy/QOGSs6XsEMVSzgWVy1OoLZWux/PG/KPhanyZGPfI IsvoK3/4vN9gjL5ENAFkAYUGs3GsHz464pNAWi1sERBgCqU+x3VZIZcDfmsIiZT8VPWG9zlJPy8An 10PyWNGQ==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w01LK-003AZX-M2; Tue, 10 Mar 2026 17:58:06 +0000 From: Breno Leitao Date: Tue, 10 Mar 2026 10:57:08 -0700 Subject: [PATCH v5 2/4] mm: huge_memory: refactor anon_enabled_store() with change_anon_orders() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-thp_logs-v5-2-686099175bf6@debian.org> References: <20260310-thp_logs-v5-0-686099175bf6@debian.org> In-Reply-To: <20260310-thp_logs-v5-0-686099175bf6@debian.org> To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com, Breno Leitao , "Lorenzo Stoakes (Oracle)" X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=4470; i=leitao@debian.org; h=from:subject:message-id; bh=W0pmwY7DpMzVDcPqXGmH/VcJ1h6MSXt/labrb03moRc=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpsFubY8Fq8JCtehLEcWZp56AKZ24T+7XEXQM24 7Vo9qImBG2JAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCabBbmwAKCRA1o5Of/Hh3 bd0XEACvvOzGt+2EHXj4MyyuyZzPvTkSZ+Z9cKHtKT6+fOAAsVPpRzLX0pe1j+k7sNoxoMsogkv 591ZDzPfcUd14WHhuF8RJk6Y0utn5b9WlDNFduTUzaeroOF1oasvUqJ/3tQgJf/vmZR1ivwqDcZ gM/J/zabonqKwI4wXwWCzF9sgZhEsXFE+Jty15ip5o6KnOzBFZp1LvwheVLB+pNKP7NDrcKF4Rc XbB9Gr6zK0oont2/PRMslOr7aeYJUlFFqn/nqZ1BdFNly83uGKgPg2OISVaKZ24yIyiC4yZdrtA qMM9pUbZqkyHVPmSalm0Z/NtdxIxTVk3M2YIcRBG5Vyisqh4NGZWSwc24pz/Hd9zRurAGOKdmUt 2RugkypRkI6j2ZtzEI5TdvJe9AhXjqsHIZQGv4mlMx/gXAZ11Ihlhdvn4W3xvy7L7/Z5Bvpyqur lo2WBj/tl8IwVz5jdca5JxU3ejm1P7zB37Ixvgu9iaaJGodfVklbJiI6XqttzkHvQJWqF26wk1g susxa1pX/st3V+K2yaf5ZN+vRysBMIoyWuqTMHO6xqdMYPx/QKE962oapmrfckhthgAr4rVcUmn sh7h0YQRwL50dc3WYfYOWGM++hFvnnTFFg0roi+zarn5a6AhAvw7caaQYdmLEU5qdr1JOY+9tS4 YQQh0wVY5S6BZ6A== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao Consolidate the repeated spin_lock/set_bit/clear_bit pattern in anon_enabled_store() into a new change_anon_orders() helper that loops over an orders[] array, setting the bit for the selected mode and clearing the others. Introduce enum anon_enabled_mode and anon_enabled_mode_strings[] for the per-order anon THP setting. Use sysfs_match_string() with the anon_enabled_mode_strings[] table to replace the if/else chain of sysfs_streq() calls. The helper uses test_and_set_bit()/test_and_clear_bit() to track whether the state actually changed, so start_stop_khugepaged() is only called when needed. When the mode is unchanged, set_recommended_min_free_kbytes() is called directly to preserve the watermark recalculation behavior of the original code. Signed-off-by: Breno Leitao Reviewed-by: Lorenzo Stoakes (Oracle) Reviewed-by: Baolin Wang Reviewed-by: Lance Yang Reviewed-by: Wei Yang Reviewed-by: Zi Yan --- mm/huge_memory.c | 84 +++++++++++++++++++++++++++++++++++-----------------= ---- 1 file changed, 52 insertions(+), 32 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 8e2746ea74adf..e19dda5aaf195 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -316,6 +316,20 @@ static ssize_t enabled_show(struct kobject *kobj, return sysfs_emit(buf, "%s\n", output); } =20 +enum anon_enabled_mode { + ANON_ENABLED_ALWAYS =3D 0, + ANON_ENABLED_MADVISE =3D 1, + ANON_ENABLED_INHERIT =3D 2, + ANON_ENABLED_NEVER =3D 3, +}; + +static const char * const anon_enabled_mode_strings[] =3D { + [ANON_ENABLED_ALWAYS] =3D "always", + [ANON_ENABLED_MADVISE] =3D "madvise", + [ANON_ENABLED_INHERIT] =3D "inherit", + [ANON_ENABLED_NEVER] =3D "never", +}; + static ssize_t enabled_store(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t count) @@ -515,48 +529,54 @@ static ssize_t anon_enabled_show(struct kobject *kobj, return sysfs_emit(buf, "%s\n", output); } =20 +static bool set_anon_enabled_mode(int order, enum anon_enabled_mode mode) +{ + static unsigned long *enabled_orders[] =3D { + &huge_anon_orders_always, + &huge_anon_orders_madvise, + &huge_anon_orders_inherit, + }; + enum anon_enabled_mode m; + bool changed =3D false; + + spin_lock(&huge_anon_orders_lock); + for (m =3D 0; m < ARRAY_SIZE(enabled_orders); m++) { + if (m =3D=3D mode) + changed |=3D !__test_and_set_bit(order, enabled_orders[m]); + else + changed |=3D __test_and_clear_bit(order, enabled_orders[m]); + } + spin_unlock(&huge_anon_orders_lock); + + return changed; +} + static ssize_t anon_enabled_store(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t count) { int order =3D to_thpsize(kobj)->order; - ssize_t ret =3D count; + int mode; =20 - if (sysfs_streq(buf, "always")) { - spin_lock(&huge_anon_orders_lock); - clear_bit(order, &huge_anon_orders_inherit); - clear_bit(order, &huge_anon_orders_madvise); - set_bit(order, &huge_anon_orders_always); - spin_unlock(&huge_anon_orders_lock); - } else if (sysfs_streq(buf, "inherit")) { - spin_lock(&huge_anon_orders_lock); - clear_bit(order, &huge_anon_orders_always); - clear_bit(order, &huge_anon_orders_madvise); - set_bit(order, &huge_anon_orders_inherit); - spin_unlock(&huge_anon_orders_lock); - } else if (sysfs_streq(buf, "madvise")) { - spin_lock(&huge_anon_orders_lock); - clear_bit(order, &huge_anon_orders_always); - clear_bit(order, &huge_anon_orders_inherit); - set_bit(order, &huge_anon_orders_madvise); - spin_unlock(&huge_anon_orders_lock); - } else if (sysfs_streq(buf, "never")) { - spin_lock(&huge_anon_orders_lock); - clear_bit(order, &huge_anon_orders_always); - clear_bit(order, &huge_anon_orders_inherit); - clear_bit(order, &huge_anon_orders_madvise); - spin_unlock(&huge_anon_orders_lock); - } else - ret =3D -EINVAL; + mode =3D sysfs_match_string(anon_enabled_mode_strings, buf); + if (mode < 0) + return -EINVAL; =20 - if (ret > 0) { - int err; + if (set_anon_enabled_mode(order, mode)) { + int err =3D start_stop_khugepaged(); =20 - err =3D start_stop_khugepaged(); if (err) - ret =3D err; + return err; + } else { + /* + * Recalculate watermarks even when the mode didn't + * change, as the previous code always called + * start_stop_khugepaged() which does this internally. + */ + set_recommended_min_free_kbytes(); } - return ret; + + return count; } =20 static struct kobj_attribute anon_enabled_attr =3D --=20 2.52.0 From nobody Wed Apr 8 03:09:23 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEDEE3B2FCF for ; Tue, 10 Mar 2026 17:58:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773165509; cv=none; b=ryzTmMtnldctHSVCer/ZmOP03Ck7LHJQsWU0lxeCdrWHS5YMwQ+gC3fzZi51f4sF+2oW0/FPcFzJj5vj6w+hlPLczKqKe/Qn3acDcBEnyMSoMYq2OmKBu0UTqwxrX8z2ybJFpguNqSmUlDC/ucMUfBwQjPADxW9y3h7Qs95yt3o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773165509; c=relaxed/simple; bh=54S5CSIQXghjorDUhiNPNrDbTvMVQVjcEp0k9HQNOlw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QJK+3vWDJ2erw9GFsJTuVgC944hZPyzc+PNXLRBzus4QHrnoUlp3q2jEaVfVNlE8jHIdaQv1DI6WomOlOrbHskvo8nyWCl0nWnotqBMmZe0JLCtvTcfdsXBKQ3EIXHLgNlLYQ8XWNFgUiKywqm2A4VvEdWC8gUftTkBALB4jEAk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=K/jkfCPZ; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="K/jkfCPZ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=Adafq0Gul2Zbse7gcvbdTyGVQp6wWAvKLR/NocJiy5c=; b=K/jkfCPZkHSQw+rmes0kZY6pXk XzYISbxzCJfLWh7pwm5wu7MEjrPCRkxRHpg1CSsJDQuefRDXam3sTwTJnFg3/YeHEv/9+xON0YN6H 8iB8fJtrFdqXg8wjkUTykHi6wtUjPCJzuSJNMeWxbgHxdr9SyKpGGZVdEnAAc7z2kTasy/vKFCjK1 uu1LNuTgs8Pw9yyoCXNjAthjPELCR27LQxT/A2PrJeXZT8Pzl2d60bitIiUEGyVInU37a+mEGpefw yz1So2plRYKYIX9JZHiQD+q0kZoNfXEc7V5MYl6OHGFNqwuUYhimkKOQ7zChigYWXf7u9X90oBQdc KHWsshxQ==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w01LQ-003AZs-5p; Tue, 10 Mar 2026 17:58:12 +0000 From: Breno Leitao Date: Tue, 10 Mar 2026 10:57:09 -0700 Subject: [PATCH v5 3/4] mm: huge_memory: refactor enabled_store() with change_enabled() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-thp_logs-v5-3-686099175bf6@debian.org> References: <20260310-thp_logs-v5-0-686099175bf6@debian.org> In-Reply-To: <20260310-thp_logs-v5-0-686099175bf6@debian.org> To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com, Breno Leitao , "Lorenzo Stoakes (Oracle)" X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=3491; i=leitao@debian.org; h=from:subject:message-id; bh=54S5CSIQXghjorDUhiNPNrDbTvMVQVjcEp0k9HQNOlw=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpsFubiT+Qbo4tOy2dfd3/EQB8Y5nRx/2MGduNa 1bgNh6kaO+JAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCabBbmwAKCRA1o5Of/Hh3 bUjOD/9B/LZbAZOE2fDBsLYWZL1iT/JfGNb0nfLhkmiSxOMAwEAF3rT1cVFeGwFqQuDCs9J3u0h +roIyfnWayPnjsn3A0RAnA7QF6IXXdulHteRH+F2iw7XeNd1snH4UqB87wJ8xPuJ4DZJ1pJwsw7 O5EX+bkrLJs9w58Q5+oautp03Bt+/9ZOWRQLCtxkDWSGP/LBWCNP47LZMhlqMNscH0JgFqmBdqM SDm7Fr9gdy7/2ec4UADAqxhEFozM/dp5EtavS4fBi1/Na94NCXG2j+C9vwHhUvvdbDZe11XdnFS wN8/uDhIzUGnGGEfVHHylRTaViU/OagZO1bGSnK3Igks5QWi9FfyxgH49MXR6WqoNJwp1tBUS9V u6qYEhtVJeqtr05uzC7zDWX/cMdBkFMZh6SpRKC/68P087GQGzY9L9xUGjz77cKbyOGbLkO+vgE vIpcpPKdwTZ+VTQTQPuCTIXHzXm/do2Qi516dVINL2XRewDF9OGdyacIUUvWDs50sToZxWx6RPq 19sLGHkyowDEwE8+4fpOTnDCNXo1D35OUflNkiar2NgZbxmuK7+Sl1Qo5AbVy7rC8OrQDHxr3/8 f+pp36PSSqAwYSyTV3CFiqHCwY6u9LGgZQwiH2gzslgiqmFBSLVfQPyRjXpwQN+Yxl9ciEwRWGG lGj0eoXX0Daghbg== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao Refactor enabled_store() to use a new change_enabled() helper. Introduce a separate enum global_enabled_mode and global_enabled_mode_strings[], mirroring the anon_enabled_mode pattern from the previous commit. A separate enum is necessary because the global THP setting does not support "inherit", only "always", "madvise", and "never". Reusing anon_enabled_mode would leave a NULL gap in the string array, causing sysfs_match_string() to stop early and fail to match entries after the gap. The helper uses the same loop pattern as set_anon_enabled_mode(), iterating over an array of flag bit positions and using __test_and_set_bit()/__test_and_clear_bit() to track whether the state actually changed. Signed-off-by: Breno Leitao Reviewed-by: Lorenzo Stoakes (Oracle) Reviewed-by: Baolin Wang Reviewed-by: Wei Yang Reviewed-by: Zi Yan --- mm/huge_memory.c | 63 ++++++++++++++++++++++++++++++++++++++++++----------= ---- 1 file changed, 48 insertions(+), 15 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index e19dda5aaf195..cc98a3b8bc247 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -330,30 +330,63 @@ static const char * const anon_enabled_mode_strings[]= =3D { [ANON_ENABLED_NEVER] =3D "never", }; =20 +enum global_enabled_mode { + GLOBAL_ENABLED_ALWAYS =3D 0, + GLOBAL_ENABLED_MADVISE =3D 1, + GLOBAL_ENABLED_NEVER =3D 2, +}; + +static const char * const global_enabled_mode_strings[] =3D { + [GLOBAL_ENABLED_ALWAYS] =3D "always", + [GLOBAL_ENABLED_MADVISE] =3D "madvise", + [GLOBAL_ENABLED_NEVER] =3D "never", +}; + +static bool set_global_enabled_mode(enum global_enabled_mode mode) +{ + static const unsigned long thp_flags[] =3D { + TRANSPARENT_HUGEPAGE_FLAG, + TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, + }; + enum global_enabled_mode m; + bool changed =3D false; + + for (m =3D 0; m < ARRAY_SIZE(thp_flags); m++) { + if (m =3D=3D mode) + changed |=3D !__test_and_set_bit(thp_flags[m], + &transparent_hugepage_flags); + else + changed |=3D __test_and_clear_bit(thp_flags[m], + &transparent_hugepage_flags); + } + + return changed; +} + static ssize_t enabled_store(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t count) { - ssize_t ret =3D count; + int mode; =20 - if (sysfs_streq(buf, "always")) { - clear_bit(TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, &transparent_hugepage_flag= s); - set_bit(TRANSPARENT_HUGEPAGE_FLAG, &transparent_hugepage_flags); - } else if (sysfs_streq(buf, "madvise")) { - clear_bit(TRANSPARENT_HUGEPAGE_FLAG, &transparent_hugepage_flags); - set_bit(TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, &transparent_hugepage_flags); - } else if (sysfs_streq(buf, "never")) { - clear_bit(TRANSPARENT_HUGEPAGE_FLAG, &transparent_hugepage_flags); - clear_bit(TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, &transparent_hugepage_flag= s); - } else - ret =3D -EINVAL; + mode =3D sysfs_match_string(global_enabled_mode_strings, buf); + if (mode < 0) + return -EINVAL; =20 - if (ret > 0) { + if (set_global_enabled_mode(mode)) { int err =3D start_stop_khugepaged(); + if (err) - ret =3D err; + return err; + } else { + /* + * Recalculate watermarks even when the mode didn't + * change, as the previous code always called + * start_stop_khugepaged() which does this internally. + */ + set_recommended_min_free_kbytes(); } - return ret; + return count; } =20 static struct kobj_attribute enabled_attr =3D __ATTR_RW(enabled); --=20 2.52.0 From nobody Wed Apr 8 03:09:23 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE0173D812A for ; Tue, 10 Mar 2026 17:58:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773165512; cv=none; b=TK9yIEwqd7ZSnN1fOR59DbHwXkndxBMDX9EkdnWgpYWZ6orxSFJnAvh557Vpj+9pALlDFGmzVbErcJUc8AWWdwZ4aXx1f0GZjr1usWTS9FvhnFnUUTu6qHxDX8BGfi8EcgaGu55PoomcHmhmxJrc+CDgTKTB2b6+EmtgBWyDDbc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773165512; c=relaxed/simple; bh=sxlnEBDqD6VQeD4cL31JhJmkqEbifkft9mLh3RNg8k0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=g491OYdp41BeXNB4nwPmF+XvUkKiaYjOnpVk/0V8V5l9UkUJJSuqHJjSwlRq+0UpgY+BezCgRnXRqh5aZQvju7CUBNICvqATWJWQzlidjhso50PAmwxokj/Ng+x4y0NelbhG+CMLpWlhXMlU9Qd9qMqHwSjuFXxRdZyW/5MKGvQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=SypbMMah; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="SypbMMah" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=JH1sSMbaLUKQaR2U26oi38QcPA7kc27iYlwkovTchi0=; b=SypbMMahWgaPD75kxHLjIX8ci7 d2LjiyIDOJ+6eCWDEaECO5Jb7xdW1PAMwU1p/2TfrYW/UBcNCbJC03H7pG6BNDHc23zsLtYI5fOJz CCWKFUmG9AfT18DmZJREXZZ90voyrAGWZ3bNqoInvNGSv3+jmlLHl86NiQM4lZfWb4UBJGZzGfSgK KZNba0dAXYzRWQgwcXvvc6scv856hV4qt8+Q8J2bO9ojclbbKgIwXMGX7jIBl8godrSljZ2kmMjvB ZSwoH1LNRL5TGdDLLsGsl14UV6NW4GnBPEjce+2bZ7N6PKbWidLgouStNagzSRln3zwslCJffbahB fKJq+PwQ==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w01LV-003AaG-Oa; Tue, 10 Mar 2026 17:58:18 +0000 From: Breno Leitao Date: Tue, 10 Mar 2026 10:57:10 -0700 Subject: [PATCH v5 4/4] mm: ratelimit min_free_kbytes adjustment messages Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-thp_logs-v5-4-686099175bf6@debian.org> References: <20260310-thp_logs-v5-0-686099175bf6@debian.org> In-Reply-To: <20260310-thp_logs-v5-0-686099175bf6@debian.org> To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com, "Lorenzo Stoakes (Oracle)" , Breno Leitao X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=2011; i=leitao@debian.org; h=from:subject:message-id; bh=sxlnEBDqD6VQeD4cL31JhJmkqEbifkft9mLh3RNg8k0=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpsFubDKOpPMxvzzpIp0J36faXVRPCTVU9M4var adKffMbgAKJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCabBbmwAKCRA1o5Of/Hh3 bXV3D/9nAY2XOL03ruLBHgzp6klnCndqIoao42Xif994eIwg43qlkJbkAW+lIg2NzU4e2+EWyit wip+POZAZbWl3ABecbIgGYcwL6MPOhwOwaSWfKgAy+Vn5tOPs8CwiFt1WFTtuNA63/tLIu5uRM7 1kOevZZ5LyJM7thCB3mvjxPm/Qc83sBJzpGx0AJk/l7Fncs6p5xwiughbE9LqUo339vkF1MUnHu 1wlScHaOvYtKmLH3Oj+9uj3/YeTNsBBSbj5RVqNURmvpHHcAfpdFoVMksoOOUDFzkEPz5kDQdOI LtAjgkPJh8oN9MTkrqkywjxkBVQNBUrQo9SH/q3bmyzW64TS+9ty1GSsxov9sVdAsUn8guMRrDy hU7L9PT7woGTR0/GuH/Ugg+ZP6AHM+4r0D5HEhkMj4nE+He2pbYOK1yRpLu7ZYNexnFT3zCRE4d NU00Oi2ajRjvzXCZ94Wa6ZDTrcKWNKluIuLiFTntc/nuahW/lu53D7SwPNM3JCZAruMBV3KCo2D /XAwrnr2rpILc7Udr+hV7xmGwol4DS6dm6hMpB3CgQOITomUzZ+wA59oDO7kRjLTEYLjypiwbza mLHfNTh9goK7a1Ot2ui2LOAreDqFctxaesxEtnbyfP32uYPF70lKKVXgjwVIkJYJNZ4/Vc/Od9g SFd1PZcWpkjmfNQ== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao The "raising min_free_kbytes" pr_info message in set_recommended_min_free_kbytes() and the "min_free_kbytes is not updated to" pr_warn in calculate_min_free_kbytes() can spam the kernel log when called repeatedly. Switch the pr_info in set_recommended_min_free_kbytes() and the pr_warn in calculate_min_free_kbytes() to their _ratelimited variants to prevent the log spam for this message. Reviewed-by: Lorenzo Stoakes (Oracle) Acked-by: David Hildenbrand (Arm) Reviewed-by: Baolin Wang Signed-off-by: Breno Leitao Acked-by: Zi Yan min_free_kbytes) { if (user_min_free_kbytes >=3D 0) - pr_info("raising min_free_kbytes from %d to %lu to help transparent hug= epage allocations\n", - min_free_kbytes, recommended_min); + pr_info_ratelimited("raising min_free_kbytes from %d to %lu to help tra= nsparent hugepage allocations\n", + min_free_kbytes, recommended_min); =20 min_free_kbytes =3D recommended_min; } diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 2d4b6f1a554ed..c840c886807bf 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6553,8 +6553,8 @@ void calculate_min_free_kbytes(void) if (new_min_free_kbytes > user_min_free_kbytes) min_free_kbytes =3D clamp(new_min_free_kbytes, 128, 262144); else - pr_warn("min_free_kbytes is not updated to %d because user defined value= %d is preferred\n", - new_min_free_kbytes, user_min_free_kbytes); + pr_warn_ratelimited("min_free_kbytes is not updated to %d because user d= efined value %d is preferred\n", + new_min_free_kbytes, user_min_free_kbytes); =20 } =20 --=20 2.52.0