From nobody Thu Apr 9 10:36:23 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DEF73A9D8A for ; Mon, 9 Mar 2026 16:25:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773073535; cv=none; b=c5BmGiq8ZZIhf6ozCCiHxD0JXtBXy9MfHkblZAqU8AonltMa5j4dSYC+/VKNCS9dyNNinZ2mbNwdCoxwkY8HrWcyFzjkEMRrrHTCm8eOsuGR2CZ2ikUblx6QzWgHK8jsbiJs/VGIlZf12GWythJf4UAkCLqnAugewmZmBqQsFiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773073535; c=relaxed/simple; bh=f/RO7d/NYBpPJNaikZKFHoe0PWI37oNS5SAvFGmT8u8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=qEf6aB36GEn/ktS/uZtg5Kjfh2XGaS2JDANFrkcTqqVeqwFfOPYPs2aV3PeYElVB+yJcrK+gtM5FcwKwjFgEsUhv7SX7g4C1CnK6d/D9w4HhiYmeIo8fjliErhccFvfDWNtMqV7S5SIvmi6vg4DFZEdgrwpDXn1F7HJIDpbWeyU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Srh7phnM; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Srh7phnM" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-3597b474cbdso5095024a91.1 for ; Mon, 09 Mar 2026 09:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773073534; x=1773678334; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=amj6Vi3JmO2oRqniQL19eS7V9c7NrB8GmPrszxzYH5Q=; b=Srh7phnMQ1MBFzIgfU8N98BFeyJdKyidQZ7oRhCj0qGy3w0p441mmQeZky13m3Bgvp 08vn4Jb8qrOaN26yuzjuzANoK0wEnaVJqK8sWM8o04KFp4md04WkKKG5vvpV/d3LOUl4 11dRaJEvR37XBVtww7XjfVU3PXgYDuqnP+hn4GskjeQugbLACuW014Z6sPhDeIc4j+Kn 4TsgptSGBEf52kYbkb+IME7KHHaDCCFHnzJ/xUUBxblsTgUVuc9wGDo4k6N/lo1bXGBD ht6C140o2IEnIl6ihQPgj6ToK5nK3ENPBjMUX/JXQMhMfv0t6asDFyg4WeuidtJ94qmF 98nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773073534; x=1773678334; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=amj6Vi3JmO2oRqniQL19eS7V9c7NrB8GmPrszxzYH5Q=; b=AhSEVEekcFdTSxDez3LHdymBVvV7rmAIY0McNBUCGu4dZf2oHTU/cSjGr2KJDwgnlX RFsjg6GExaRvJcv+yyiW503zRHiUW83pOXIA56vtjUD1bmkvbnYZ4Oz+6MTRUkIsRurS ek3ivRUhHQUkDG9LaCCiE4ACsOUQkX7P3lvjmFPR5BwWTG2VjP6zvGEF52CoSttagaCw JPfsuslBRtwZ4+i4O2QNxYEN9fbddaawKF6KimZDXiqWRtI7pfN9cg4LcdYl7wvGsuhj AzG3y/tc9AnQU4qAj0I6sw7RarZkX06nD3uRKTiZh2zIf3kgsZvRg1INclbIh25OBBPN KRzQ== X-Forwarded-Encrypted: i=1; AJvYcCWPNtvHRD4CR1kf171CueS3SkUdBd9r4LstknBHFYzwJCabaB17EZzX9/bXKmpkI42pFCjM3IXxvwTRU+I=@vger.kernel.org X-Gm-Message-State: AOJu0YwQbp+2j/nDMmnG8n7i73pqvUqUOifTMRdzFxnRrW8YzuC/mA2x KOdJ4VG3PbXCyy0oChR57u6DSTPmqlN652mLinshAvus9BF9ydLodJgW X-Gm-Gg: ATEYQzyipNwXOXaHocZZPOpzFngPhvcnesyMp+tiS1e2dfa+uLwR3CcM2ZAGZiCwyMk 63Zmxh+4M2RfaZf5alWAdmMnCuwenSXhXa6ApRfqMsyc7EhS11iG7rqFu1xQTElhe8C0p6tqzKg aI7ZEYDjLlNRjzaP+j/2VV/QTqzKskLLUkQ7T1kmKZ3y87cJXSIQ7HI8xFL2l2Z+XNY8/mjMadX ePtbPSIRdmUDtn5h5y/cQ0cwgUz2Z01+ZIfSmAHHkv3rsJ3MhR3LdScD12JJpAjRtOj8M3/TIyx tN0AS0E2aisVsIFup4sG6RXJtQArAIhuAVvyFwrGhrA+j1baYZr4EVqGotzpwevpxDTy/uYOeZK Zf2BCBegPslVq/LB+DDYErYpTRAfD0MHf7Md0l4yuJ0ESyfGwGieRmFhUNSZiWP+XlTu8TcVRif +YDgXz0KUBNJujRsAbJeOldRS86iJ5qxy5854+ X-Received: by 2002:a17:90b:184c:b0:336:b60f:3936 with SMTP id 98e67ed59e1d1-359be2bfbfdmr10994814a91.12.1773073533488; Mon, 09 Mar 2026 09:25:33 -0700 (PDT) Received: from junjungu-PC.localdomain ([2408:820c:9009:3f2:a816:d74a:dc19:1ab8]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359f05ee51csm93198a91.1.2026.03.09.09.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 09:25:33 -0700 (PDT) From: Felix Gu Date: Tue, 10 Mar 2026 00:25:30 +0800 Subject: [PATCH] soc: fsl: qe_ports_ic: Add missing cleanup on device removal Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-qe_ports_ic-v1-1-608293026561@gmail.com> X-B4-Tracking: v=1; b=H4sIAHn0rmkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDY0MD3cLU+IL8opLi+Mxk3eREk2RLi6QUw2STNCWgjoKi1LTMCrBp0bG 1tQBw1Lw+XQAAAA== X-Change-ID: 20260310-qe_ports_ic-ca4c98bd1c4f To: Qiang Zhao , "Christophe Leroy (CS GROUP)" Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773073531; l=2073; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=f/RO7d/NYBpPJNaikZKFHoe0PWI37oNS5SAvFGmT8u8=; b=rQOMzyC4PngOHoIqO/7Df48MEyWpk4Oq7n+UJMoMvx/yCaEy1QVE4QxtLf/8M0dTWTRlNeTre OBK6HibNoz9BSdq5rxEWpjidNyO7PJHufEyodw+dTqpnS22U+VATvl+ X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= Add a devm action handler to properly clean up the irq_domain and chained handler when the device is removed. Fixes: f0bcd784e1b7 ("soc: fsl: qe: Add an interrupt controller for QUICC E= ngine Ports") Signed-off-by: Felix Gu --- drivers/soc/fsl/qe/qe_ports_ic.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/soc/fsl/qe/qe_ports_ic.c b/drivers/soc/fsl/qe/qe_ports= _ic.c index 8e2107e2cde5..5e3fae19f314 100644 --- a/drivers/soc/fsl/qe/qe_ports_ic.c +++ b/drivers/soc/fsl/qe/qe_ports_ic.c @@ -17,6 +17,7 @@ struct qepic_data { void __iomem *reg; struct irq_domain *host; + int irq; }; =20 static void qepic_mask(struct irq_data *d) @@ -92,11 +93,18 @@ static const struct irq_domain_ops qepic_host_ops =3D { .map =3D qepic_host_map, }; =20 +static void qepic_remove(void *res) +{ + struct qepic_data *data =3D res; + + irq_set_chained_handler_and_data(data->irq, NULL, NULL); + irq_domain_remove(data->host); +} + static int qepic_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; struct qepic_data *data; - int irq; =20 data =3D devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); if (!data) @@ -106,17 +114,18 @@ static int qepic_probe(struct platform_device *pdev) if (IS_ERR(data->reg)) return PTR_ERR(data->reg); =20 - irq =3D platform_get_irq(pdev, 0); - if (irq < 0) - return irq; + data->irq =3D platform_get_irq(pdev, 0); + if (data->irq < 0) + return data->irq; =20 data->host =3D irq_domain_add_linear(dev->of_node, 32, &qepic_host_ops, d= ata); if (!data->host) return -ENODEV; =20 - irq_set_chained_handler_and_data(irq, qepic_cascade, data); + irq_set_chained_handler_and_data(data->irq, qepic_cascade, data); + + return devm_add_action_or_reset(dev, qepic_remove, data); =20 - return 0; } =20 static const struct of_device_id qepic_match[] =3D { --- base-commit: a0ae2a256046c0c5d3778d1a194ff2e171f16e5f change-id: 20260310-qe_ports_ic-ca4c98bd1c4f Best regards, --=20 Felix Gu