From nobody Thu Apr 9 07:22:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD0EB3D6CBA for ; Tue, 10 Mar 2026 08:06:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130018; cv=none; b=pcKvEN7sThtBjIJh9WOi4BlVQfW9uVkpUu/0xka2zTQljVdWI1npPNdx+huz86heR+g3SkegjESDr7i2cmAi5SJCUmNdxYCloOu2BEpFyG4GNm8wySEvkN0kY9Z35N/GiviU6Hu7IIcJor95lVxws0fxGq6bq8jkrCvkZM2l7fY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130018; c=relaxed/simple; bh=Lnqx9aNGInN2dRJmGZpQf0PRaaOxvX3KhhTXbK0GgTM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hgSmhP5/zxwps4uKpFzZFAiROPk3U8yTDitp06IRrh8SOuvw60nQ93cNPv6T1d4sfNkM3KdgMQTIJ0u+3o6Q9a3Q7w2lXXzd+tmGdPyxv5OaKAoF+Nd6MM7Qij5q2HHPH+drL0xj8N/h4pCIBQqwTaCujqMKbSRAbL3vxHRdHQw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ay0LGaz3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d9SCkwtb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ay0LGaz3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d9SCkwtb" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A2EKCU3754749 for ; Tue, 10 Mar 2026 08:06:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= m0pGDZTp4WihSPiCeJZx7i+DZ6ZfB6hNJXG0xF6Zo5c=; b=ay0LGaz31eWUlN9z JU/eIjq4edPMWNsDiBoVCzs4CzK9TmkCc6detdPyAtYJwroy1E41JZw1BISxO62C xTeH8XT0gQ9Nad8Bxh+csNBoQGTxkpEoNr28v5fth1g6il9tahpTs50D5ODJ6SIN gWqNOV4vbvi3HyUSVxyA6P5JqdrVzaruU4mqcEWOogDyT293NjoFEPz9ysy+fPaA wakEi53xk0bScLIuGU6wJHwk5JJK3MEvntbpxG7X0nJ217i+sPjdIOaAp3sa0uRC 9+iKih1k8rk9a1C1ABMyBlKBueTz6mV7UPXIkFjDJzxy5aGV8/6enZCjktPlnWvc 96pDhw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ct477j51t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 08:06:55 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c70dd30025fso47404454a12.2 for ; Tue, 10 Mar 2026 01:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773130015; x=1773734815; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=m0pGDZTp4WihSPiCeJZx7i+DZ6ZfB6hNJXG0xF6Zo5c=; b=d9SCkwtb4dLTwCEWDUZVnWm2aPGl0NSI6qBeGngYbXn3MOPKk4BAZh8jn8XrKq7qy2 G87U4EhYfMpnhr5tdgO2BZaJhjVhoZar3FeP3sJuokxysO27NJrFEboonIpWDxkmu0IB ogRgZ5lzDfhvrZ87AlVxfU7jR7oJWOS3QAysKz2wY235e3noURXTjDTVCKcQQeIhKkeC sp5D0BIzeaXPpFIUk9Y0G3DeQ0Rkk2qVjjF+4okZ65k8EPtf97cVEI4FTwpSDcMdEKIH QK63PPnN+31pQlfDOANLLQC19b3z8xuHeUpBqs6qrWWtwDzHI4+8U2V6KCkM4H9NoaRa D9zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773130015; x=1773734815; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=m0pGDZTp4WihSPiCeJZx7i+DZ6ZfB6hNJXG0xF6Zo5c=; b=rcUfCmFquTYxbOlpf/Gsw/OdKHAinpIJgYW0D6VWcJWh024EnDQGIF1yv7rO1Q5MtW jfYQTkNp0fRkLdqcSvxrPiKuyv2bB0j4ZCzpfGsMKmA+iRS+O0IYvy8WCeN5WbbgJXYN N5Wy+CeaSuf+piiBhaSXvxL+O1+3S1L9Gz53NRtvJaFDlPjXJ6UEbitUFse/438gfZ3B OOmAMqZtm8t3jrwM9duzF9P5PKnmcBbDT6YFm1qHf3DWWL4kwDitzpd8o3JuBsa7l8xc Jhkn0R0Rd44IMT3BzCbsKX2azoxBuWvkQwCq6ceXTxQC2V1coRw3cOs8fX9AlIV0dsvn 4ApA== X-Forwarded-Encrypted: i=1; AJvYcCUHSc64+9EnI4085YwVZBNCCD4z8xNuyytw3JO9JjJI4hwRHHHWPrvxGhz2OnB2b2NfxG1mVyD7oRhwor0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxey8UZA/fhZCccdBe3brFilYrm3XZtnKej5GRhkX1PPJupuvXe PDSbQcUfHJGUrPyZiJGJuKgrMCNNovaywOSdG7LQ4HqI68Kg3SLGgPSneioj30HuW5DaU9LXwzF 7RBoVYCfwODyhHAUeqxLtMjccZ9HiQIN760tknK5toDelrzI+jaypcoqiPqfckPpeA4c= X-Gm-Gg: ATEYQzxdCr0przcpNnREDK5M4eQNtOoxVSwKyXw2R2OfJo+ottCdJ3/9MTkIkeKfYYS +rEGsF31xmNGhlwyf+rbOzbPLBQvm5w/pVhpZedoI/KSpmqnOVDOZns0UMMKAnLccwIwfk9xMIA ayuYt6pXB6S5XsTe1W7iqHqJb9/aF+YcyvsRZLpLCwkLTOQEml0x5+VsXQgcs6mFhfFotXRjgxk R+J1LOc9Y05f04hc+B/6GaLJQB1Xc0HUhp/khmmjhxmydCTyIWqVHry1RpMGdTuziywFAI8q1Kd eN4mayFqTEwE3N9OKG3OkgbSaUKFzNxaDKLzoHRCkABD6N7Eed90uNZNeIo+Yq3d3nue9o/QJ6r cJ/cQeHYJ3AOBTiYIQ9neRtGjVw0IrcVwxUCluBLgejZCtQ4= X-Received: by 2002:a05:6a20:3d8b:b0:398:95b7:c409 with SMTP id adf61e73a8af0-39895b80d85mr6429293637.25.1773130014722; Tue, 10 Mar 2026 01:06:54 -0700 (PDT) X-Received: by 2002:a05:6a20:3d8b:b0:398:95b7:c409 with SMTP id adf61e73a8af0-39895b80d85mr6429246637.25.1773130014138; Tue, 10 Mar 2026 01:06:54 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e195c40sm11121969a12.31.2026.03.10.01.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 01:06:53 -0700 (PDT) From: Harshal Dev Date: Tue, 10 Mar 2026 13:36:27 +0530 Subject: [PATCH v2 01/11] dt-bindings: crypto: qcom,ice: Allow power-domain and iface clk Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-qcom_ice_power_and_clk_vote-v2-1-b9c2a5471d9e@oss.qualcomm.com> References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773129997; l=2173; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=Lnqx9aNGInN2dRJmGZpQf0PRaaOxvX3KhhTXbK0GgTM=; b=zB8v6AEKKRzJnSbCHN+ZFKKVEp3mSGm7eQ+1lFMrA5Mxnhz9gY0/fUSSZ5IF0IneoEOHAUHb1 n5JxF6wQ984AOw5p+uFgtseY34FaWxhVVJ4giaKNk+DPxYeLJM6b/6H X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA2NyBTYWx0ZWRfXyn2Vc4K5Iow4 Ek07dYuzGL8+JZ24Iv/SF4UA+Oc/d35COSQkXBzbb2NzY65xVZkpnD4ET6WA504+beLOtHOFIvN q6bCk6r3bOf1LSOBQP8QfJs625BLGpemRpevkk+u34IVUkAl8JTFOEjUpjhy76Z+Il9VAX6IV3Q O1ju07BmMOBoxMfhpYx0E77xyckKpp9cw074v+mja9Gy8jXwNPFrHDh7ZrKmvS+EC8fnJohOOA4 Ko6JSSYQloCJwYdbY40622pvpeQQFnTFbkkKDOp5qSOIFecHkBr8x60Ynw/6B+LrvC5xSeTwmc9 YE2HZ8Lzyrxw1WXbe4pWprrVI4ZZvcG1k0ddq+U7WB0pzet8fFSvB0lO4Mkbt9e9pISUaPx5DCn 3nFUnAqzdy0pg75DuSCzyE+JPUSNtLtPx+5hh+m+mJHM2l/n97Bvu3jsHkrQT7Q/yL4gVXVNvtS wAsdzDBc1Ue7xUboqqg== X-Proofpoint-GUID: YpWu5__XzDxj6FMj4Nx6H4KEbqqKoYjZ X-Authority-Analysis: v=2.4 cv=KLxXzVFo c=1 sm=1 tr=0 ts=69afd11f cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=k5GuLpEFyUPj9kim_VUA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-ORIG-GUID: YpWu5__XzDxj6FMj4Nx6H4KEbqqKoYjZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 bulkscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100067 Update the inline-crypto engine DT binding to allow specifying up to two clocks along with their names and associated power-domain. When the 'clk_ignore_unused' flag is not passed on the kernel command line occasional unclocked ICE hardware register access are observed during ICE driver probe based on the relative timing between the probe and the kernel disabling the unused clocks. On the other hand, when the 'pd_ignore_unused' flag is not passed on the command line, clock 'stuck' issues are observed if the power-domain required by ICE hardware is unused and thus disabled before ICE probe. To avoid these scenarios, the 'iface' clock and the associated power-domain should be specified in the ICE device tree node and the 'iface' clock should be voted on by the ICE driver during probe. Fixes: f6ff91a47ac57 ("dt-bindings: crypto: Add Qualcomm Inline Crypto Engi= ne") Signed-off-by: Harshal Dev --- .../bindings/crypto/qcom,inline-crypto-engine.yaml | 16 ++++++++++++= +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-en= gine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-eng= ine.yaml index c3408dcf5d20..d9a0a8adf645 100644 --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.ya= ml +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.ya= ml @@ -28,6 +28,16 @@ properties: maxItems: 1 =20 clocks: + minItems: 1 + maxItems: 2 + + clock-names: + minItems: 1 + items: + - const: ice_core_clk + - const: iface_clk + + power-domains: maxItems: 1 =20 required: @@ -45,6 +55,10 @@ examples: compatible =3D "qcom,sm8550-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0x01d88000 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "ice_core_clk", + "iface_clk"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; ... --=20 2.34.1 From nobody Thu Apr 9 07:22:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B00973D5259 for ; Tue, 10 Mar 2026 08:07:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130025; cv=none; b=sHOn8ih31AkS/DyQi/zS+WHXBebbKDrDO8ikMey+4ZCWLk+YUn7Ya8h7OuTeZU27untxTWx0phs5EJm3Db28yW32tff2oXAE30pAOkDpUxnP09CB9UDD3MtMTM6azqNm3EJVpUJlqIpc+vrXasU7NnUsYxG6xSVMtrcug5iZKIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130025; c=relaxed/simple; bh=XBioX6kliz8hg3/RQUZ1PwtNPhssAHTKLszF8epseYs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dMMJmLsllc4zYDtTIwuHmbpz8BDR/wHMCL270emW2cWXySYFT936mvPy+9EWHi8KLR2c/IsbFhqcOoeypAe4GYbIMtIIo2LZuEbVTkw1f3BEozsqdvLRDLKfBMAL/3c1cycyJlqLlLRY2dmoqJfID6bh9uy+GlKr+jTjlhTfT14= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fpoPGjMI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EsD6vodH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fpoPGjMI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EsD6vodH" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A2EhqT3087381 for ; Tue, 10 Mar 2026 08:07:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Wu+HsZDrvVopogRyY+pV7lzjsw3u6yHcs+egaFtXJbs=; b=fpoPGjMIEjtboHRZ sLWje+AtqwGu2i0D11Xrg0D+4yzrniHzGxJiStuzjxI8hbHg1YtVF/nktH7xDxOu e9Y16nWxScksbBuBgsJiQrlztROdAXI5fICt33V4ePrThldreZKC0z8YYpEPfz5N fu6y1pk+FdbUUoOMjhl01VdCnIySaembtWM5YpUxrVLTXRsReCspJ43bvR3bVNmt vhJLvy6Ime3uJ26H+ZpX+vcnYry3Blc02hkBTasZlke9qcbtJhbXaSZTDfpFjWKG yOoXhIOXJ1y4ACBiceT9HcXKAXUzwf9orYQk4sSdlOpHIx7Hp8vtOSNRG9qvhlS6 4MrAOw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csxy83e5t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 08:07:03 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-359f31809a0so3151999a91.2 for ; Tue, 10 Mar 2026 01:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773130023; x=1773734823; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Wu+HsZDrvVopogRyY+pV7lzjsw3u6yHcs+egaFtXJbs=; b=EsD6vodHDcfzJHTFtgB/RKGEOk8VxoZaj/Ox3EK8bZSbodGCNKCXDoUQgmFOoJNoow 5ORal7EQ8Rt8+jYY8/RDt8tz3Pbs20RMsvzUGkTyNizWEcA/970EWWXYR2cmevISCYGV sVjUUPzMTEGAiAa6kaQ/SOnjcLEehyHdX1I4H2elBLPGILNfcCL8ZSC3DKRpIXgih3l5 RS2SAcuurpi4H5MjP6T2Eun6Ssw6uYoazEPrPFMiFkukVVOFDtlUa3LfPtYIAyS4JGKo pFSgoZzwym9rrT0sez58TJmGfAl+pL+DFuIGRlgb8DlbQjIds864GkEvBxt2ra26+KWW H84Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773130023; x=1773734823; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Wu+HsZDrvVopogRyY+pV7lzjsw3u6yHcs+egaFtXJbs=; b=Mi51l0VAoQ75xyi5wr2WCeeT6wL1o2Abi0X8oqPj0Od+GmiPlnk+lcBatbQlY1VSYJ txB9d7XiBkcuCRopr94VD0BBAvKRn/cDka83kOSei+Hvajbqk7JS2iV/qQTyqOuSS739 BnTbRTfeyYQGt+ywEiyt79LCPrNk2ufwpNshLaIwW7E654QYLoe6aqPrNOBlxYkxZrXH RKCXhM5d6nFh1fJcydmL4r/yiT7VwjtQVRD3wN/SkXM0iyyW/LEFYKD9OhtbzGR0J6Pq nhiidtrCLmlpYOgAyunxkyx6ABWikqk1WH4EsbhkWJwzaCZhhoifCjSzQuRE0kePm2r6 wffA== X-Forwarded-Encrypted: i=1; AJvYcCVqHj8cNXCL+W/8jriBXXxBn8GvSbaq3kpvC9naKQGP5t+e18O78d9qQr/mB/LjlO0dh0fmAxdGTgVIwoM=@vger.kernel.org X-Gm-Message-State: AOJu0YzrNl4IOhXbIqLUEFJpehDFdYTMt1K5p3sWZP1jKJJ9uBHarKNj /LdGgRX5xYOIeD4uAn8TIl7xWpCQnyMsaCbyk369jWj9sMhtRtGmMsAERap9TPSO+NZRe6gVXai zlIBqNmox6PHgxTZSiMGLiCPK8EHfbqHP+FyfYD0VyWa9FZrXdvm7YGbnkPDQIFJCVHM= X-Gm-Gg: ATEYQzz86c075/4cfb/vlcA7VIynHMOdN02EivX1zHi7ncxy502OM+dBuwyU+51qNwW eS7M/hjgcjjk8XAMF2JJt302udNhkA64Tgo4SpRo6OOIulDbkdOYJkKCH0UVv8fUCG2++ilvnaW pzdewwJhGYQczaBM7UtXm2FC4Jg2sUrSSWu3JkTZ6hh3m5HqdT+bAkhoRYehVNe33CLvqFuCIcW XJH2dtehsX2IqJSiD8P2vIdrcvEEvLsdIiAxmrf9gdVxvcQSXko4j+K2LvGN8EplToo5vpuHKvD TNNcvm8T88Ech+CKvcDrFHHQUqzUS5LzWeQUItnttfpN5t3o0V07VVrvGXgr108EmpTdA52vLjI M7lhwBfalry4BPb3v2wRLZo3NNObJrFpONismFMA3JSR5VgA= X-Received: by 2002:a05:6a20:a104:b0:398:72b7:ec8f with SMTP id adf61e73a8af0-39872b7f22cmr10560177637.18.1773130023117; Tue, 10 Mar 2026 01:07:03 -0700 (PDT) X-Received: by 2002:a05:6a20:a104:b0:398:72b7:ec8f with SMTP id adf61e73a8af0-39872b7f22cmr10560120637.18.1773130022567; Tue, 10 Mar 2026 01:07:02 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e195c40sm11121969a12.31.2026.03.10.01.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 01:07:02 -0700 (PDT) From: Harshal Dev Date: Tue, 10 Mar 2026 13:36:28 +0530 Subject: [PATCH v2 02/11] arm64: dts: qcom: kaanapali: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-qcom_ice_power_and_clk_vote-v2-2-b9c2a5471d9e@oss.qualcomm.com> References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773129997; l=1418; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=XBioX6kliz8hg3/RQUZ1PwtNPhssAHTKLszF8epseYs=; b=z9eA6tU4+OoTJGvUrw/e7wqUQ1WjL06ZBWf7eblkuT6ek651NddIZ/UesOu2TL5lRTs0QC/ay 3nZwKaCGZEICCSui56M8qzt56oJ7XrfDT/00VRxoncRL4JnV4rGPU+y X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=SvmdKfO0 c=1 sm=1 tr=0 ts=69afd127 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: dJiliuR-gGhRokQCfblKbaiG25eH3b0J X-Proofpoint-ORIG-GUID: dJiliuR-gGhRokQCfblKbaiG25eH3b0J X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA2NyBTYWx0ZWRfX+AneVA43Cdwl 7Su9RGT+rQwcc0rzFR3xaZanxNNuuEN/qEtBh//kKeF1N+8Gd6Skx4K285IHBwHb+i8L50NBwGh qEcZA0rlilP0aXUyEdneWX2m8JVN5Ztp7AbMGHxu8YZNPrySqoRx64SVA3qJ3Z7T7pgnhpppRgp AFStqlbyCMNY/y1Esf6S1ToEjNdxTjTWtejZuKmboIxOWPpIEPS2B+yfKxMsh0KRI5TbBp+wd38 djRLjmdf2w21kb4TSQ43I9PiyVIxgiPkSyS5Dt7COGahBoqXSC1VCCDmMH2UfiHE23yK480F+W3 deYQvBJ65UoFsllBqLgHAFiHWw9smtz6ghaC5N034yZZSXuUCZuWIasAF4NPqkgA8iToEFYfzUO YbMdM8KVfJuffGLlBitssLA+YcZG/Zj9GMjGKLvIv0uokARM5axD7TEKTl4zx/JsXC9pg6NTwYA 18El/lwp3iapqtgeplg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 spamscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 adultscore=0 bulkscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100067 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for kaanapali. Fixes: 2eeb5767d53f4 ("arm64: dts: qcom: Introduce Kaanapali SoC") Signed-off-by: Harshal Dev Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/kaanapali.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/= qcom/kaanapali.dtsi index 9ef57ad0ca71..7dea93d80636 100644 --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi @@ -868,7 +868,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "ice_core_clk", + "iface_clk"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 tcsr_mutex: hwlock@1f40000 { --=20 2.34.1 From nobody Thu Apr 9 07:22:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2D0C363C5A for ; Tue, 10 Mar 2026 08:07:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130034; cv=none; b=c05TUzflQxsdE4tC12CcvQhwTsGkDbXgGi5BAvYpQ+h9dTKHzu/1WBEnAXbQe1FrZMUGlG7gfo8Gc89yGShHkomhhPt9cJh4UTgdOS8eXQUNddt411BtGQviJ64muasgjEfceQNA7UthHAgoXAu7KqbZApdOufgWirDjkv6UrYE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130034; c=relaxed/simple; bh=eBc/tZwYk+Z7AphVW8f7WhN/S3F9nVUOBnpnGU+WVlc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DO+vq7PyGS8fCzAb7Bk4y1FNoTDpLGnAg88GkYwZMcWi1sUBQcPhrVxB6fNbS75ywDPaNuyc0wbOBl9moTKTmyiZ2+p7zt2oxZ5P2RUXq48kXNkN/gRgV5NSFKdgYknrrHEHbSrmBZN1jpcwr3GZDSQH22EQAhNhXCCpWU6N9SE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aFEg2qgt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RpKdAydc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aFEg2qgt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RpKdAydc" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A2EZv41900137 for ; Tue, 10 Mar 2026 08:07:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zo28n/Z/OC59k3+VeK8QF7/lPzfhkKamJ3iorOSmEmg=; b=aFEg2qgtc70VhB31 wh69BrmZCv3sg5ELq1KRjwuv+gV6R13Yp0m5BfMHN7aSkJdvFGySqRTciHwK1W+X S6hvtIinFIZPIQuC8uZV2nZdllu8PfFEupVlcUOdbUkOTWVm12rw09AdE8fP7ii/ 1tdVM9XlOZ+Ou1jvvTzr1U6o1ML2hXqScowyAv9fgJ2lzwpZditN3xYrJveZQG8G 5ZeObGqEYFvekn9jiZxVhIgAwlRvIZQ35b5KUR17h9euoUYFGmT+IBEtH3RdWWrq SdGmT0eZ9ZcHqaDfVlxboTgjmwoElutH2UdpyvOZN3mg1W1g5CyOnZlyp7V1Lucb XIaylg== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cstsacan0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 08:07:12 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c73939e0314so2614838a12.1 for ; Tue, 10 Mar 2026 01:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773130031; x=1773734831; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zo28n/Z/OC59k3+VeK8QF7/lPzfhkKamJ3iorOSmEmg=; b=RpKdAydcd37e1xdGdFrYTwQi2MHYoLvIMc8tTgd+gFrrVedAQYO1qbJ1fGX4YBFGHn Og0yyVqBZ0qhigGVArUxiFvt0UrhJSam3P6cF/I16OKUSCEu7FrCTrQb1B6h48+H64zJ pbuwWdklPJVXDusYU7NoeJdD9Nq+bCTG0TmlBeLFBZNOvPpDUt79j+9QWh6ITyf2lz7B rSaFvBQvLWNO7ocQxrBWRffHCStiNMrfWVfhTJLHhCJR1hmZcMiRzdchj+fqj4ow7i6a TW/gvCwsZhjzPaxFgGrE8/w//FOsrzCDbE6zPWpAY/lIWGBXJ2XJu2mNLYG4CNfzjXrY BSVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773130031; x=1773734831; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zo28n/Z/OC59k3+VeK8QF7/lPzfhkKamJ3iorOSmEmg=; b=Nk7qUtlcoWSHagJl6akxScKej+VT3xUQvZQ3lYcTOmx3PJ7dg9xCXjjGIhquvSsK/T y/u7A+HffXTvJK9wQ2dOnhz099+rTZzuq0vruBJuFwrj6QPkMQpdf5qiZb5i/dWIrbef 07hQYrrirAFouJfbVMZXZcHm1p9I8TnAN27fEdcx0jK6rpxbNUJNsXhBC97S0W9v1OAZ VdFQNC/N1FlVPsVb+uwDYunhcY7xFJWtMzf3x5JfWl6d1PTmEYfQcWnU36ncCc0zYyuP hRUaQT6XWb0iQUTVCbKdsHJfoyU9YC2JQ4T4HcXM/DaSuCx1zJeitsr0/wxBiB0kxeDc eR+g== X-Forwarded-Encrypted: i=1; AJvYcCVveLy+pGGQryoAfeZo5bk3wS2G9bkKXtkfnIx9VcdNDy4O3XyDdQIBfwJE9VQ4kSUR/Go7iq7NDoklckw=@vger.kernel.org X-Gm-Message-State: AOJu0YxhOisklrONt40u0VuwjJyVsEHufLXokCG8kwQpnvj68Q2/h/xW ibOVV6SldB4Pnkhj0xe9zLZ8t1I1EdR+sQMZ6dpqe6v5ClAJQLTIZyxf3FHJwRkOTq+DX/+iTMq fh5QKbfy5C+nyIhqjNMTiEAC7ZeMBBBrNOUffbsznvkQFCM3b2N/xnV/dQnScuLSbYss= X-Gm-Gg: ATEYQzza/IlG3KBqZpr3wowFMCeTfRA4KD2r7/Ep+gE88iuTIq1k8C493BoaHDFv3Vn L6ozW3cm0I6R6i4+nzwW5zCGOMGMjeF0omSGFqAZnVO5bj6V4AFSe/ZVtNIW+4gqHa2vT+YUZJn Heg8TCOu0iIy7PkyBdqcKUtboUad55Q5GJ0PWExKoiIeWDhDdCEiBxbUafBy1dMLKhUdPh1pO4A bNcrotokEL3KkLPQrdeU5FmjL56ntWvbEfm1cdMwjmucLMGe4H/trohpfMVVw1tPr/5dWYsSont ZRrG8cVDeGM2tEDFCxND8ga89OmASn4mYGOlQhgtSGjXcCJVoyL1KhyiHWG8fhjqnsTbudxWDnl lknqRBhQtK1/4TqJqiY629GtaomfN5H+2E8GhOBndMT+FCHk= X-Received: by 2002:a05:6a21:1f89:b0:398:b748:b571 with SMTP id adf61e73a8af0-398b748c49amr179919637.45.1773130031462; Tue, 10 Mar 2026 01:07:11 -0700 (PDT) X-Received: by 2002:a05:6a21:1f89:b0:398:b748:b571 with SMTP id adf61e73a8af0-398b748c49amr179871637.45.1773130030944; Tue, 10 Mar 2026 01:07:10 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e195c40sm11121969a12.31.2026.03.10.01.07.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 01:07:10 -0700 (PDT) From: Harshal Dev Date: Tue, 10 Mar 2026 13:36:29 +0530 Subject: [PATCH v2 03/11] arm64: dts: qcom: lemans: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-qcom_ice_power_and_clk_vote-v2-3-b9c2a5471d9e@oss.qualcomm.com> References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773129997; l=1465; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=eBc/tZwYk+Z7AphVW8f7WhN/S3F9nVUOBnpnGU+WVlc=; b=BABY7pgd16anVLRoM+eELOrI2+1ajg/UoVcu7W4wDva+HetlpdONBveDoz+5MiAsOGfop3x8i vu/Uo8AoJ3pA81LXCzO9DZxsJ8Pm5DVXlmFmXYtHY62rGQaaEsrvRSh X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-GUID: EfxNy3SG8STEDnQyU98j8TRJbH23arcd X-Authority-Analysis: v=2.4 cv=I+Vohdgg c=1 sm=1 tr=0 ts=69afd130 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA2NyBTYWx0ZWRfX1uQebKbBPxhr NAKmp8OZ1IY+v6R4hjas0UotfHW8u3By1ADscN7QJ2Rl8dvGlCN+qfXJ5/4cFwMxibov0+SOpTC eQSSgmVlxKg1LOf7p/PzOAj8HBQUVQk9A9CnJoMG/xyhJQsjaBlKMwsfgolFbjZaIFrrA3Kx4B8 L15SO/bEkTbP6z8TesClkpV9YL9X73h3f6E/qqrbn3+YNG4oAIDXzOW94HOxyOlsE/ZrTVSifm3 CVRbvthAMpQMbpgV621tHvoObfaqO1EtvDYeDsAa+Um/OI6SZZ6AIom84W3SoeItXcGmcvSYHde xXh2o8oxLuJkaCNvQtgvnohFpgMd45Sz48Pdg9zf/ct9HTs0+IdYbX+v1o4Sn4pJxHcRlfkr2SI k8Id9yuCOvHU3xWdMX7lK6k4NV6e2lEEyfQZOwP3DVd/CVc4We09lCvOQmWidCxaV7BbkX9rfpi m9yJlkbncxvol01rSNQ== X-Proofpoint-ORIG-GUID: EfxNy3SG8STEDnQyU98j8TRJbH23arcd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 spamscore=0 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100067 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for lemans. Fixes: 96272ba7103d4 ("arm64: dts: qcom: sa8775p: enable the inline crypto = engine") Signed-off-by: Harshal Dev Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/lemans.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qco= m/lemans.dtsi index 7c46f493300c..0312702020d5 100644 --- a/arch/arm64/boot/dts/qcom/lemans.dtsi +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi @@ -2774,7 +2774,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,sa8775p-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "ice_core_clk", + "iface_clk"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Thu Apr 9 07:22:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 245C13659FF for ; Tue, 10 Mar 2026 08:07:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130043; cv=none; b=TW9DAB7+mKszKhe4gsRJ31ULgtNVFk3OH7tap4/8NDcp/Pfp34CTkhCy9/GPbyJoxN5OffPW77mcpkB5PIe79o4o05pT7ROmOa+XVfHxnh1LMapCMRsAaut6HemM6AFGCwPksjabvbDXCuapdqwpNb0vLDJLVERQSgnYHYKp+Us= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130043; c=relaxed/simple; bh=X+9qvaez/wKuQJXXpN5o7PpR/bLl9AJdUe0o1Nd3CW4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CWD9XnbT6d/fmeqjq9ZQYvFfj0znVqh+6LOFyz4uQ0qwSdGYEZBReH7mboZTJFUHPkRxzj4MrU0sJsS+J2XDT+VqFx07Q7O8rRhxF+BHm5WfxOUeFfUQUr2ZszlAk6b6oiYEf7YpX9XLJErO3eaBifuQHmGNe1RSsc9NWgk5VYQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YIremGOt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IMP70Kbg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YIremGOt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IMP70Kbg" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A2EGxT246776 for ; Tue, 10 Mar 2026 08:07:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +wy0NK7XwvpVIYG3doeXTDM2mVaJoSz3R0NLL5vkbXo=; b=YIremGOtkeXvixLu ObAPl5LCrsExRFkQBMGUF4jT4Ls7m9p7AY5leX67TZT8q2JKLmJav1YFMFeH9oQd NjoryobWuihM1IR1bHGH+DoW16OOSSJsq7LTwdw7OqTHiG3kV69iwBGvG9SZMpQD OFXn/CrOgjLBU7G6rrcjOwKELumDD6afDJeqnrLlr0tYetwRwKa36k1uLD47X2au zrLbaVlvqIs6LL6kqHRGpUnkVmWjhzDqNU/icaoOgtZ/lMkAWiiFGBMT4ta0odYf WfJZlHSDwYgD7MtaWI/l0XzZW2+H0qkLkI7G1Bj1NLHK9QA7hi8VZYifHukLjuuM b2lA+w== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ct8801eta-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 08:07:20 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c73935acff2so2420142a12.2 for ; Tue, 10 Mar 2026 01:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773130040; x=1773734840; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+wy0NK7XwvpVIYG3doeXTDM2mVaJoSz3R0NLL5vkbXo=; b=IMP70KbgOv5VSMF7IjlsNW6I5mmyX6eAeCpHQ4OwdE55Joc5HSbBg1bGr9EPKggr1+ iwBus8P+vJeGoH37CJnVPw17WFoeWZQwWjQTj98iCqBTVn00Um6reENe4c0Zw/QOoSyU DFIRcY4ja70uRxI55Gcjve9KlZGF6QM25ncu1h+sVJpsNiOCTzQAufzPqNLgyaP8BSdG mnEKr19/E9a3Or5m+StyhDisszW2jeBdaLsQr7XQtnm1zzhR39ZcWnI0VYUjPSXKTEHV yaMNhGF3gXRPSxYFW5VXxhvI85kjjIpYsU0c8eZROVYTKkdWnjvCmXYgFeyZmIPX1Vwt NkmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773130040; x=1773734840; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+wy0NK7XwvpVIYG3doeXTDM2mVaJoSz3R0NLL5vkbXo=; b=CnsEAMa8oGoahwF405I3pHvR7vFNdGq2nXtUNlTHjdQPbY2VLGFz2CwC0I631xKzCP yW+tQEPfshcreoMwwhvUtqIsDwX+/4vUUmcVcdOWaSTLpR8WyIGG10x/mc+ROviHRPCT t9W0t1CLzYpM3XObVX+ENu37JPcGiafkmI7G78fW8pxS97MpqwbUfyiO81uCG3xz5Ddb TwamPIIrX7jIuqi6CT6ALFuWdZniqRQOyEYZbqRJdCbpQUFh6cYGpAOcjPuGlwdcFkP9 3W746DRAyqo4HGry1BYL0iwGiiGAPxmbXXncnxaR+8f688T+zP/h1X7bXSuPrrsnwJBw pAvw== X-Forwarded-Encrypted: i=1; AJvYcCW1C/MztrdyFICP+2OosjCVvcDUikQ0bMyynsZScOW4pp0KkUItGf7PtKiUlyz2RSTGa8oHjlN/iYHLOFo=@vger.kernel.org X-Gm-Message-State: AOJu0YyPHm7lw5d2tnvIGJgPr71Xbe1A3CqV/31+grQsz2+myxLq+rvr RioCyA31nqucMdkPcuZlxP2tN4dl163J57Z9jx5n4cK/x9vZ+OapgRvvVmIAJkp2JRFpncxqDvT f8YHZmS73Vc2ug59hp97VXnDKNHb9GNOMpnyH+jcIuMZeIAczC8Fswey0pUCpHNJMHw0= X-Gm-Gg: ATEYQzzJXCPQfXrkgV3P1kwEmsdZNPmIB3ICxbbOTFs7Fh5y+J7ciikKrUOTMkA9+cV RDs92IYWzcCHOXcLaFMNteC24dgHTtBYiJi7BgSY7zvrRmK6NotOqQnpzjn8jKu5TmtvAmcWtuC aAZLd8Quu11s2Z+/fzraSyU/3j7gpD+888jxzZvEdx/hoWj3KdDeTXJEjEU5FPYC4dIWDc2lfqh 5i+yk4rpguoBGMYfbULIjspTTq4Utl0kSTzfdIDga0dPeNIyAI9803YnVUZhTG0yiLf3tjadgrG Qf4qgewIgOhXYEh8WnIJNbuILywumfw2CFGY/NFsiXoAXuI/VVjVKqLO4WVQOjtEbbvatusVY8j o7g3LyWLXJ45AljkUcnz3nurDcQCi4aPAyJm9kMFijMA8SY4= X-Received: by 2002:a05:6a21:35c9:b0:398:6461:6872 with SMTP id adf61e73a8af0-3986461cbbdmr10167459637.61.1773130039735; Tue, 10 Mar 2026 01:07:19 -0700 (PDT) X-Received: by 2002:a05:6a21:35c9:b0:398:6461:6872 with SMTP id adf61e73a8af0-3986461cbbdmr10167425637.61.1773130039270; Tue, 10 Mar 2026 01:07:19 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e195c40sm11121969a12.31.2026.03.10.01.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 01:07:18 -0700 (PDT) From: Harshal Dev Date: Tue, 10 Mar 2026 13:36:30 +0530 Subject: [PATCH v2 04/11] arm64: dts: qcom: monaco: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-qcom_ice_power_and_clk_vote-v2-4-b9c2a5471d9e@oss.qualcomm.com> References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773129997; l=1467; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=X+9qvaez/wKuQJXXpN5o7PpR/bLl9AJdUe0o1Nd3CW4=; b=3RZvw+FuTUzKWHTutZFpoLgdeE4niluTBpLlRRbKcE+KRA/LMtUu7QuT5YidI5nNS2nVfsl9p ZeQjwoTuBs7AwfO2R4RFaY8HaiBp7XwHQokDP/c3LeFH/rbjGv6L0Xk X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA2OCBTYWx0ZWRfXwyIaN4k8WYV0 3Jg5I1s2XrtbZzXtj/gT4RbqKHw0Qxw5HeEOjocSBpz2UfWhWWHXQ8qAX+J+o5Z/+cvSFiHvTmB eeFrDCEzKLMyCYITmX7wCvkx4oKlIWHaBQdQbJiFiL/FKSzieb1T/EmokMxpI1Ti621Vj2kcR87 zzF7q/EVdWiqQWnJIXeuufpXCnCVkeTxQK7IHf2vmEvirDsaCVfn9vmIe5kgzlV/pauR8Kp+QEV 0bIcvttOdRjqSV6EhOFsf7RywEhLRdZl2opwBEjyvbYu6zEOGRSjzNF8o4MGJEyUlv1DB3NIvmQ 0wVolo2RDjm1Mryt9oGp8Sft1h5O5WXNNxDDMJmfIp0N1ewXzU215m5tRPMPCRj6rxVuNOE/Uss dNctuV5pgnpZJJUzaIfbg52wTwa1LxlVk8xKEMYsMtDV3c4Sh+xC66Nsby8UVEUUgvRCXyBVRoV OeqmdmhXQHel+U7+LTg== X-Proofpoint-GUID: FFVra_7QivclheKYC4_IfmoDtgzbzi0A X-Authority-Analysis: v=2.4 cv=Jtf8bc4C c=1 sm=1 tr=0 ts=69afd138 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: FFVra_7QivclheKYC4_IfmoDtgzbzi0A X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100068 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for monaco. Fixes: cc9d29aad876d ("arm64: dts: qcom: qcs8300: enable the inline crypto = engine") Signed-off-by: Harshal Dev Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/monaco.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qco= m/monaco.dtsi index 83780cd3dc8a..b97a35ef7d6d 100644 --- a/arch/arm64/boot/dts/qcom/monaco.dtsi +++ b/arch/arm64/boot/dts/qcom/monaco.dtsi @@ -2725,7 +2725,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,qcs8300-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "ice_core_clk", + "iface_clk"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 crypto: crypto@1dfa000 { --=20 2.34.1 From nobody Thu Apr 9 07:22:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90DB33644BE for ; Tue, 10 Mar 2026 08:07:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130050; cv=none; b=DCZy1HiBmS6k5xaKWTRN2aHdwcJwfYLb8MNrPAc5TDcMg5V9TOFW8q3cPoh+VgPayUO0jjogzkmZezJgViSxq13MF6djt0RxeFZoRmuZgQs7MP5BKjrXbkXJS2Lqb8hpQ/TnBVUBHjKBXlSylGTN6xj6LJtnO/UaqHSM/UQA7mk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130050; c=relaxed/simple; bh=HOoqM0stJCW2c4G9tttLgaEou8MsibFmsrt2EZEKvo8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=io+Z/2tzsucR7kPZtd3+cOvBrE2Cqde65o+1oXl0xj6azNOjTqiIyP3VWsMwdkCV8HG4soGcnapFq2zrlkymsEergnOS6gTlY4fNtte4FE2OCo//IibNR+nK0T2xd+ZGDQZAB4fvduSsC+i4JbXKjmIjXy3V4v3zEQo1k1Qk1D0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OuakfDXB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R4YB+LT4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OuakfDXB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R4YB+LT4" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A2EJv3247053 for ; Tue, 10 Mar 2026 08:07:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= S5L/dcs6o/BZsBRbs0bi8Fp4smn6ZIz0rRdMGZ/M0Vs=; b=OuakfDXB4K2QYoXb h1qESqHBJkEpnmLCLjPBYnSHZcbZqip2vEF0De9ctw1RnG2bGi7IRpDHQlgbGsc0 CUubPk+S3YNMXl83GQPD97VR++TT3pfj3H86XXoFth2sc36lYTTJtaEVGMEZlzNm xtlTKzDtfIm3yIkcztgfy4jfWNvhzzWoKEZ+XFUyL40T4zb2VH2cfUuPFKW2X5X8 //xcx0nqMZxKbJDrwJvaTP4/2ZBt8/DY12CI5rtYkacxdiBShCeYlR5MbJauGCbO qxdJqMYoKJuYQzygUopV56AcGXf2Uc0cx9cjk0C5OP6ZR6kEbR3azvxlOoOMRrQS dOuBfQ== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ct8801eu1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 08:07:29 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c738563e61eso3731981a12.2 for ; Tue, 10 Mar 2026 01:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773130048; x=1773734848; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=S5L/dcs6o/BZsBRbs0bi8Fp4smn6ZIz0rRdMGZ/M0Vs=; b=R4YB+LT42Krol125x5F8alf+NwuXBfn/xhsJiJxW97sVMoWCQMjyIeITqgQOLXyA9N W4uDMeHeJROEstJOnH2fQfbyYQGRiL7uNkDXGfXYFTuHbQ+pKB5BmQl+9ksjLvosI2nT st/xYyV/mB7wY3hws512Y4+6qANkL/dWTzbviCfGMB6gLuFVGeCcTaVjDa1I9LAxYY7b tMLgddkQjqz3GULGNLQfoevvZu0SQKNQbxw7DJ76Syh4F3SyNlSW0ddMh8zKTOlHPyf8 MaM3G+xL/wkaEamQn4gq92Th0HauRwPs4EqIjRwafxm/jyL8IM9MATA5oa+u1sZxIjWx bi5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773130048; x=1773734848; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=S5L/dcs6o/BZsBRbs0bi8Fp4smn6ZIz0rRdMGZ/M0Vs=; b=j0DZUiKsc0ArYSV0BZU6m/jCDcdLyHg2EcS5d1GqoiwLOwdnlaSD0mKaafOrv7o6Kl FwvCn4txGreVhlEg9FWiki+iWqgKdzr9WC8b1WIov31AMdsZSy6yzx/hm0YCbJGgXC/T +hySdBMxedRH0Hn3H2UX2p9qAwKNZ76GvtVQ1JmtbEwIlUWAYVjnA1hsUbUtG7JDuLjV dhjvFu5q4p+7hQv1Ooly8odB3/gbK2bDBTJHujOjQLTFY9BtLRAPNq0FQk4MDe240b8+ UlSHUtzWg0FYDrgqlUqJWacIhkucf4+QXKQDZ39wM37gYgn3z6/47OXkpiLXo8GLY76w N+JQ== X-Forwarded-Encrypted: i=1; AJvYcCX1wBYs7EZQ17ttW5sWgDcYvJ1jcuJxDrzlwLdVeK3utoOchkawrRvuelge6spfauqLPEFowrdtqBBMlKs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8C6nSQRC5FxVdBXcIUn4Njg6XHBgfozeS1sDEk3D4ZMDwOjFH sUexQ4jHM+2COoQvIXezL3iBq1xayTrwGR1E0xXaHpvWVetQmLKIpSq1/GQiEQspjvPwuUkkSKN tQgdKDeSRs+l5Zj4X3m3h1PYZ8y1RgjK0nmzAZNH4SkgaezL6nOmyD3lvNvEjwodBsNM= X-Gm-Gg: ATEYQzzQaaLJuDxrGIsGV4QMYYVVflc766AdskVGVstmFgxwyvLUiRWQ93t3gsiXawC uW2Svn4UQfASDe+ya/ZTEzGDZK1vsSq8tsKB0r0+2k0SP/iWYApQWBIqM4YC6AnObWJHRiwLEAB 007QeL98ggQKBypxxRV/Fgp49Yo3yTGfpx+4hrz9LFKXCW3THPWCf3fyoaYUy/87tKQIeCttVnR 6TBSaZJRG6yLCHHsPE0EbdMcRkM+tnq2ITSkT+AKwhln/IO0Oo7WEcQmW7GRNiNMuyyz/J7JYYQ KZFQUOyMB6dXiLPjspnA37b2yjxgpximiXf519GkxW8hOnXpd0d7epJGaOitH6GmBdWBET4cMee hNYwj9NYh7VGkMKDv2FSit2AOmgqiWX1zDFgYtU38/Hv/WKU= X-Received: by 2002:a05:6a20:6a1f:b0:398:b178:a55b with SMTP id adf61e73a8af0-398b178cd8fmr1271915637.34.1773130048113; Tue, 10 Mar 2026 01:07:28 -0700 (PDT) X-Received: by 2002:a05:6a20:6a1f:b0:398:b178:a55b with SMTP id adf61e73a8af0-398b178cd8fmr1271891637.34.1773130047653; Tue, 10 Mar 2026 01:07:27 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e195c40sm11121969a12.31.2026.03.10.01.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 01:07:27 -0700 (PDT) From: Harshal Dev Date: Tue, 10 Mar 2026 13:36:31 +0530 Subject: [PATCH v2 05/11] arm64: dts: qcom: sc7180: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-qcom_ice_power_and_clk_vote-v2-5-b9c2a5471d9e@oss.qualcomm.com> References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773129997; l=1423; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=HOoqM0stJCW2c4G9tttLgaEou8MsibFmsrt2EZEKvo8=; b=irjZgmKQZSGJjEU3BAvw8UlyZU5zYomb9cZuB+B/kjpG2h2tcCOoIVJKuDxPFwl45po6b6LwJ I+e19T7obZNBxfBF03T3R1QpUyiMhI4+EGWHEP/Zft6R/kOmBVlexcU X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA2OCBTYWx0ZWRfX1P7QYc0e0sbw pRFHoq1GoZ5hhFlKW1tt65RQo4C/z+ngdoinZ0CLjzEWwvZIdZP9u02Dc+glf8uUu6M0maJZqAn xFjAghW+2zCsXawuT/cOGBW3oqK+qoEA/dCFJ37Iq0v0jjeOg2sDn/vvn8nH8KcKUoeBeSTTPUs RMbBlKqjw6Xc5U/ozxeZoFLCbBzQeGZGk3gGNGgcNn1VHjQipL0GmO2Xh8WCFd6O9Nn5atTOf/V ifNhkwtcCnxrMvPofMOnvp+jeBB4SSfuraNVjeYC/t0oxeapj2WlbrnRgrPZDq3X4iJ8Np8p8mU KlK0CtgXX5uwHNM/QhlcVIGstg9QLHSSouUqj9kDRjiBDd4YNgpRAlXxdbkJiXcA+kiP3vZMkdx 5KkneBgATc2LNfWL1coKKGzV2+S7lGvSwjhJShMIeKv5IVKvi0z3qxQ0usc16f0mYvgcnxwjBCK q4ukI5r+jLwco56KAyg== X-Proofpoint-GUID: a5rdV7L8Sajpc8MnoPtctyMPB0qYQV8P X-Authority-Analysis: v=2.4 cv=Jtf8bc4C c=1 sm=1 tr=0 ts=69afd141 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-ORIG-GUID: a5rdV7L8Sajpc8MnoPtctyMPB0qYQV8P X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100068 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sc7180. Fixes: 858536d9dc946 ("arm64: dts: qcom: sc7180: Add UFS nodes") Signed-off-by: Harshal Dev Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qco= m/sc7180.dtsi index 45b9864e3304..74eb895cf4da 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1605,7 +1605,11 @@ ice: crypto@1d90000 { compatible =3D "qcom,sc7180-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0 0x01d90000 0 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "ice_core_clk", + "iface_clk"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 ipa: ipa@1e40000 { --=20 2.34.1 From nobody Thu Apr 9 07:22:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2940C364050 for ; Tue, 10 Mar 2026 08:07:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130059; cv=none; b=ZjivLfbMCQta+ej4Pjk6Y33gpBqV2QDLqioaFWcrJ4g8pxvw/66isLGMqNqVizocxIQnV2d+ysxhmvgjQu0QGMF6AKGc+vZe0xIjOlD1P2hIdAWdFQ5fv2QmjBCrzqxfT3D5clBcMpuNDO6h5c2zE//AWEb/GxoqbGcX5nj8S+4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130059; c=relaxed/simple; bh=/WRo6DTYnhZj2QRCpHK+TJkXMcLRJ6f4fUiA76JshP4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Gg66L7t8jTkEkPzjl26sCIQGprswzhVWkA33R0X5Fy8OkIqhwNHAY9C+cKNgxkkQjhWPXxVfZmDnpQMNpcRXX17vUn8MNhR2Q2oY8HX3VhMkgt5zxNmGJuijC64xoQSgt1W5vyUfV3hQV16+ryyowT/XvnuNch/fO+np2a1LSj4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Gt9FqRRU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UB3d11qU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Gt9FqRRU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UB3d11qU" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A2EQdA2460666 for ; Tue, 10 Mar 2026 08:07:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SEd+HHr4h6KqnF7zSg6nnkeThUZF8EBgI0BFcLMtQI8=; b=Gt9FqRRUUkcXWWGE hazFXpAC+p+clXZbRUQWjQumkcmEyyM+okrU81Xq8gpDNkwSO0tlnPjfE3Ws3HkS MCecCQAfuFzEdwc4AIH6Lf0RFxs8B1z0RUerHrrdrvQmD9N7VShXx3IEb3Xvtb85 rs2y0h2qBKsLMT6Ccz7igaf89nOyEC2aVxzzHKZvkQ1mHFnv0ISaWkRRK/fqeb48 WeyEJCMKWzmTm37VBbLMdFwrMGTb3IWtRwGu6MPCLQAYcGmdrjb7ZWctvaGs4w2H pdDn3WGbhSS7XHoDpyyfd6gw1BiWTvLdyBMlgM6O1rnwxMFtut/G2vgM2aEknfq1 X1xbpw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csyv1b8cc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 08:07:37 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35986cc87a6so8348544a91.0 for ; Tue, 10 Mar 2026 01:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773130056; x=1773734856; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SEd+HHr4h6KqnF7zSg6nnkeThUZF8EBgI0BFcLMtQI8=; b=UB3d11qUZiF8xKwRaTKb864RW4YtLtXnCeb5EokzbK3hDB/X+Nkk9OvwApiFvHwAOB Ae/i2Y3E8c1wpXegpdLDEZIsssdtwqRbMivumnKPKSL+C5IbkY3GB7sEKJWG3nEfOH65 6Qy34Qaats9iJc1iG5vR8BtpaSPmoT3to4giore0rJKxp7Br+gMfdXtM20xEIJe8t6a2 FW5p4HKhBMYBAl/CGSePiPIzY95YV58KFv2XECQQW29z7aOv8e1NnnEGY8Gcv2eiWYqJ wclID3sK1fPfi074868Q399KmnMEvaBGyAaquwIIIJaSqBINQsIoyzsxxOD0WfVntPkq XbMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773130056; x=1773734856; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SEd+HHr4h6KqnF7zSg6nnkeThUZF8EBgI0BFcLMtQI8=; b=NUB7aBZ4c+SGLD6RvAXuiqEje0nAF0yTvkM4G3AoCVgFcirrxJ6PpEcVHld41S8waW Doidp9Ht7mgAV3GkTjog3ZF2gvQFr2bvr1ui6OE5jJ62RIq3oxdnT82XGKd1ikhiuJ6q xtrUdRYEFH+s9xoyG5b3PvXreHxkguysm1RFeGraFtgakhinWioLXPBFuL2Ilbniyp8W iE9n4oqfnEWhDySI98iQeBIU2PNGentSeYGCFNbeG+2e/8s+wqjj6KGY0QnTxO1eULjT Pb5Xs5KyA4dT1j/99HyNq9A6XMDzrroTIrvwcgmEB4afBDB3U8Ri0ItefSuaEPrpcoYd AzVA== X-Forwarded-Encrypted: i=1; AJvYcCU9W/JoKwovOBMzaxPriYf9498FGHUwOFVZ/wWwDXUW+PA8fEulb7mLgB9+LASvJYiTiFayvpNE4o7KXOw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1YVAzzUCDEh5Zls7Opc1aiha6iOdnvwOx7g3mp2S+72jkcu75 TndvrXRRXVfiojNVoAJbcXl/ninf3mkBfXZe/W/TpSvX/SDQ4kou4udd32clvsC+lI+CVgxGpfY BhUgBo3OyysuGo6l4XPo8EvOGBepD9XaxE/BL2GaB5YOPpv+/PaBMNkqGCReIL3WuE/FAF68Nfb w= X-Gm-Gg: ATEYQzy0ftCIpiFCbDaPL821OSQ9VUK1NsWl+90RGvZBS9v4C6e1H0NhOX3LwBmjUET 3ne1D+4qScVJ6u3sVQTtq6j0a2VrfbovJRZcUNrnHOU4QCRaI5Huve/eHgLDz9FdEnhHb3KzSQV ilNsSMNp0pZMus+dxe2dtrqvsCOlE4y47WP534iXqiSbvEnPUYRRjDaiuJ5S2/8xYDJaU6yIdch 3wEaPJJrm4IHB/ikBfX6Rcn+iYeIMHE/p6ayp2CJhj9bGXeZhHFocDb+X/dnF/gZz5UhKvZd8yL JcVZt60aSLWLBOOBAZRUDyAcTsXLjl4syOw4djI+nEcRVvPqwy7MSPKN81s9qybzsw3NvNGQ31i Yum840cAZrXkpthaGxnWUPESPdOEWVsLm3m88/pmH9Q2rPd8= X-Received: by 2002:a17:90b:4c50:b0:340:be44:dd0b with SMTP id 98e67ed59e1d1-359be3b9d00mr12413555a91.34.1773130056493; Tue, 10 Mar 2026 01:07:36 -0700 (PDT) X-Received: by 2002:a17:90b:4c50:b0:340:be44:dd0b with SMTP id 98e67ed59e1d1-359be3b9d00mr12413522a91.34.1773130055963; Tue, 10 Mar 2026 01:07:35 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e195c40sm11121969a12.31.2026.03.10.01.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 01:07:35 -0700 (PDT) From: Harshal Dev Date: Tue, 10 Mar 2026 13:36:32 +0530 Subject: [PATCH v2 06/11] arm64: dts: qcom: kodiak: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-qcom_ice_power_and_clk_vote-v2-6-b9c2a5471d9e@oss.qualcomm.com> References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773129997; l=1464; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=/WRo6DTYnhZj2QRCpHK+TJkXMcLRJ6f4fUiA76JshP4=; b=e8NOCiLqM8hZd0MIqtImw+zFS7P9C96NDIDVyGZ3C/Z9SIlAr+GERZwd6+IkySZen3sV0sAM3 V922DYl4WEfDjia3c9tP4bNbhIlfHUi/zOmOkMD11BD0GGtDhsnk2Jg X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-GUID: AeCzAJkM5fxpVvQbR21g3pdCvoeH8aUj X-Proofpoint-ORIG-GUID: AeCzAJkM5fxpVvQbR21g3pdCvoeH8aUj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA2OCBTYWx0ZWRfX/8StcXWzNu55 7ndrWSdysG8EgKiSz7Lh1Ym/2rhgkDc/SDH4hj+FCdDmrUnuun5b4MdeBYY9szlpb78EXXhwu5T STzEX6+ekssMYgOu/lsRoT/6yarDp/olaIqz2j0+Eo491mm7Q6BYKpxAmhSYT7aq5+vDsTHqbMQ VNf1OXTx3/bYWzukbXJctJvab2Y5Ww4BUeJlj672z/+iiZbDp/fFhBgG6kkvzVfqdCWvLB6ri4c Gp6CIx79y+tz9PIBePlPUC7xOSXHoPAnCpoOn4dbJAfFRkA7M2kDCQ4zaqa6WfWjHUmb/tN/PTD 73mxCYZJ6msXKFJBR6+Iq2z6FjK5f+wTusO0T2mRSh7rmj7VWzgSoydl4ustQ/oCS06PPrZqGgk OzZEMhl7lF+deHnYTgxJbkqUw83gPN3tI/9Xn4dVHUAGLgi5YUc24kAr3R/zwuWtBpRWe20U4zH oiXw9c2c0XWrBa9w/Gw== X-Authority-Analysis: v=2.4 cv=Cuays34D c=1 sm=1 tr=0 ts=69afd149 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 spamscore=0 adultscore=0 priorityscore=1501 phishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100068 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for kodiak. Fixes: dfd5ee7b34bb7 ("arm64: dts: qcom: sc7280: Add inline crypto engine") Signed-off-by: Harshal Dev Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/kodiak.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qco= m/kodiak.dtsi index f478c5e1d2d5..8f2bda7af74c 100644 --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi @@ -2574,7 +2574,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,sc7280-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "ice_core_clk", + "iface_clk"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Thu Apr 9 07:22:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 060EC3D5259 for ; Tue, 10 Mar 2026 08:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130068; cv=none; b=bbZFY9FhfPSY+P6QIwhbxorY8Q7WhQdovYBAca6VW7FDBaaBfvquW/uy9KRs5lJDY2CZpxVkx6h+FzbSj2ST0rE7OVUZweludvd/p61V4MvUTbMwXrTA/2Zj9VDaFG1L1jUymWNDgXpICB8uCiPFGN3LyZPs1NkRMGWkNEeLv2s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130068; c=relaxed/simple; bh=niYQmVRxD31LW0CEVaaeCQmeMe417PyBECP1mGWfg5A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GdJd7t8YJmJ2cdKhzCsyd7q4NgnNqv7pCXj/r18ctEtfMfax1/S5zZaVGo1aUsktXKVg2oOeV5juF7GrHV4myV875bkuKSeiPDQL39zQ8IxCG2prQUoP4vAHAiN2jtAhNX2uCWb9MRh1Bto2qG/QKw1ze7bEy6THqvPAnkovYuM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RfK9CWCL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q+cxD4nn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RfK9CWCL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q+cxD4nn" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A7wG8M3124207 for ; Tue, 10 Mar 2026 08:07:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qgHEgMJmGM3qOy994TlAjnMH+RNsJUgib0uSTkzmnyU=; b=RfK9CWCLQd00uMza GH2BLnhfJVCHFJQvPvlXKsRRIfG+pIi7sKJZCx8xz9hN3mzIhl0f7c6J/deHrQyR wmm4E20qINMsLNhLmQI40qgLkYAID0NbONDTSLFBpqI+xFNwaDN1lO6ZCSTriO/m TvF6qxgtn+MNuY9lsnylOrPcuC4Einz3dOHwOnThsaO29V/V2eRt8QZSp1xiAraR vxr1uV8vyqMpsgJolaRiw7cbEEw2ENbC0SMJ0R+oqn9wDPJNB4dK1hCITeiU2D+K 92+OhkYDwp836nHjPHbEUDAgTQT2uxDgvgYeiLk8OjJgT25Gv1qeubzej0C8x1bZ bk2g/A== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctfcj01bv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 08:07:45 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3568090851aso72759008a91.1 for ; Tue, 10 Mar 2026 01:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773130065; x=1773734865; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qgHEgMJmGM3qOy994TlAjnMH+RNsJUgib0uSTkzmnyU=; b=Q+cxD4nnZQN9ikAW0gebwbo/ZafV0Zu4Lty2jQA7ANId5KkiqkgmY9OqULtOTbhGe8 8K8NkAAn1CzL8R9FuKFFH2iINewHfRrqV4ou5Mv/RRxJs18iH2ff2zdsyw5z5uT3RICU VSYmb8E1UJpU6IAG2SeDwpDfC+EMZZbFYzBq98FsO5zHI/evveKu03vNn5X0DeS4b9LJ yq+7knBADw/o1wi+XqjGL+8E42Tht69yNTZY2sU/dDZcmpD6NHT4Esj5Rjk1Dw4QN4LO DWPNd/frkX23YQINEy9Ep/UPtqASjHoXiWiV+OwNWFAjbUnnzUfyncwpkmvPEdTAKXRJ Hepw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773130065; x=1773734865; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=qgHEgMJmGM3qOy994TlAjnMH+RNsJUgib0uSTkzmnyU=; b=hrwuOeZsffk1xtxHtywJSFFCi6r+42ppBJBKW3Fx7ILl1n++vcZyzBpp95Kh4Osdnu /MgGk91NgRW/OC7FUGiyRhtS2eNJY9yW0/+0wM8PSxBW2k5kZrs0WvXJyfZ3lccPzulb b/3btGeY6Jq3Cwl1iSS3msVHHt7o+2ji93NNRnwwMVRic2V3aqfJ/GNdNM4KnGE/Mtmc Ca1LNCLQM3g3a/Ko0Vt6+AAk9oIuznTSVDBk/7n87kTZ69ubXCrvgxuBseNiYHOXQI0w jhBnGrdF3HQ1F21CxH4YoZ/a7poX0bCkT3iss6VfRlnR3onJsFLX9Ak0w2Z2DSKQ94de HEgQ== X-Forwarded-Encrypted: i=1; AJvYcCWf2YJVrOb0f6bZ/zSeyhP8kgcGUqZ20jcPGJtwVbp5Pthuq05RmcoRb2WfPtjBN5TkMOgCUsoXXjSrbzM=@vger.kernel.org X-Gm-Message-State: AOJu0YyX8rcc1yws1clwN+eZlr20QpZ1aXVbZ+Kv3O2KJ4tNwVWDlZeO +X6SBURcgfNpQa4mM+/LXJb3/ViGOFbomwZ2GEc1E3ztQhPA99UcajQmncVbqL2h3Usit2e+bcr g9ga7n4oNhIZjc71uk2ApapE6+5L3BeRfq2eLoJ6PD4+6kg837WyZKykJewhpD4lm5yY= X-Gm-Gg: ATEYQzyTt757hTk9bBGys3OUQDQuBgJdTlEnXd5Piw7HdmyKJxZFDHbVn7bd89XDTRz B6/Seph4h71UmO/Wa5VuerAOBUGFfQd2u0sTZA47h8ZrcmTdjUrMuyDSPTGMvLFbZozu2vVFrO6 dHdulAsdZW+ODNZ5+cm9xLBU76DpZnzL7U8rBgoQauAUdh47sElvgahvWPr5WzT2ONkPIO7PgXh 7DylSN8rPqn5a0TmxfokMKK+ZYVogdy7BHTz38yuB+pCFFBGW6prAvcJRpV74FwjoHXSFRLKJqV GXIGSHltBpWqA/VT3VJr5vJusjqHp6v3iHLdFrBEAqAPWMsF6p+bOOMujjHon2yaGdMIE3fTkdu 4WbknP3EfOFm6iQ4sxeKfIkG1io50bEvJdzAPZfq37vRKY5A= X-Received: by 2002:a05:6a20:3d8b:b0:398:95b7:c409 with SMTP id adf61e73a8af0-39895b80d85mr6432111637.25.1773130064823; Tue, 10 Mar 2026 01:07:44 -0700 (PDT) X-Received: by 2002:a05:6a20:3d8b:b0:398:95b7:c409 with SMTP id adf61e73a8af0-39895b80d85mr6432061637.25.1773130064307; Tue, 10 Mar 2026 01:07:44 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e195c40sm11121969a12.31.2026.03.10.01.07.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 01:07:43 -0700 (PDT) From: Harshal Dev Date: Tue, 10 Mar 2026 13:36:33 +0530 Subject: [PATCH v2 07/11] arm64: dts: qcom: sm8450: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-qcom_ice_power_and_clk_vote-v2-7-b9c2a5471d9e@oss.qualcomm.com> References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773129997; l=1458; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=niYQmVRxD31LW0CEVaaeCQmeMe417PyBECP1mGWfg5A=; b=HsW15hOyG7U3r2z0bpBA9Wgpjw/nsnnipS8qpEkjX95X4JsCfBS+FE4EuL6iI6mlJ+nc4ggkD 2PrqP41BfDGDYBmancOzP/RZoRS+/cgdJcba0aCDvUhDHPSVLx8F0jw X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=H7fWAuYi c=1 sm=1 tr=0 ts=69afd151 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: a7h5WjQdvQWf4ds4bPxMmb6RUbI2jMdx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA2OCBTYWx0ZWRfX6xhn2RzuVt7v tBR74zQmFFexR1rPpAGp9yLW8QDFgNUCH+imJmBuU0pRv4pxolpPAYFTe9cUDW1QNGhuHqE+lyX V+y3rLDtoitZeMGUBm22gQ3P9KxcEV61aIuuqCLcgwPK1yjiQXidei8+9bZEuPpXa0TnMRtwc4z SJWeTpqIQWLWBMuTdK1rlWjpBBp2jFVb0rsNSGclO3em+GH0hLUGK+u3UnbkVenDx4wnfpyLp5C N4vzYpRW22N1OXewkBz7V94HTinyXxyI6aEz56Q3EgrB/o5PoEQ1LaYDv+bbgR4F10aeab5zqTB 5U75e+om8JdSgQyYi8xKV5tK80LePzWvUO0A9OvmjPyvc0LnFNnCTSIAFC6eBQWLyzD/TeE49Vl w6iOX1jW2cPWK4dJXUuGEkcDJuC5W/P3KlcAbOn0nz1bcKtjZMF8TSuHb+IjWzVNPviV/j2HgMr iTiynZk6ANSkKFYkKRQ== X-Proofpoint-ORIG-GUID: a7h5WjQdvQWf4ds4bPxMmb6RUbI2jMdx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 phishscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100068 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8450. Fixes: 86b0aef435851 ("arm64: dts: qcom: sm8450: Use standalone ICE node fo= r UFS") Signed-off-by: Harshal Dev Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qco= m/sm8450.dtsi index 920a2d1c04d0..3d243e757fa1 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -5374,7 +5374,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,sm8450-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "ice_core_clk", + "iface_clk"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Thu Apr 9 07:22:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B213E3D6CBA for ; Tue, 10 Mar 2026 08:07:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130075; cv=none; b=ejbIJq9hCt4qHW7Rb+nEbfLI1sElXUkDdZx+ApYYHjwPcKS17ZchQyue8KyWZqRWwQDnQmUkO9JU47R2avGLIUsspc6WejsF8HjBEYA2VKRgN1g/RoRAKIe0DFicl08Rz2i2vW7+vhFc3KD65CikGO0rAvl0GIjdTQBFCP9Z7yE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130075; c=relaxed/simple; bh=gYZaumYhSsIGJVNztvmwWowAICkPRsJuJxQKDEYgXm8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sDiWQAjhHVICnI0uzT0LWEpK1nu27HDZJvFDGtq8UpQGxJbWMHD3iG3j6h6/OWEbqV2YiFdsgFGzZ5G0klxT9ittNcS+0tqO+7xNF8s4cHBpvoAtThnIPS7L9bavzwQAiTHI+d8ueV32dapjl80jHaydULJ16Rm4Rr7D4S2NMMY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=a1+pfJa7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=daYL7uCM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="a1+pfJa7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="daYL7uCM" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A2EcsE3587427 for ; Tue, 10 Mar 2026 08:07:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FPDC9UVWCZT9cS8dyi8jxernVsW2wVYjaKvNbAETH9s=; b=a1+pfJa7UIaWJrd3 3nfo9Xp3u2qUiXAqApWMBtMnj3unE+zz+rhIw1VqRUs9iz3TxfYRHpcLc8YPfpAm A++IRB5bAiXVup4s/BHODRwwQUWYdXtMPkZkblXcmrpM2sva1RVeUUrNGxlBpWBP nph5u2oPya2efTz/E5nh2xSi+xVJXorilmBzUIvwL44P18yVN2WqWzG+wNoFTkdP zTnDJWbaPSvU6mu3nrhR+jRmY+XqdhqWvGtDTGhMWH2AOSUzej176/5mS5sd+JlS CeobkrJtIs307xRrvSUIUOu9A1cDU+3sWYMJGysH3acV22CKpGiWm3IAjWteajeH nn9wYA== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ct1ekturc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 08:07:53 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c629a3276e9so45663116a12.2 for ; Tue, 10 Mar 2026 01:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773130073; x=1773734873; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FPDC9UVWCZT9cS8dyi8jxernVsW2wVYjaKvNbAETH9s=; b=daYL7uCM0OehyGB7p/nqj/0DCmXb/eb403FfCOOotWL50ZR+s0wqD8MnTcb1IkOeku cCPqNwv0tjClw5vj/mwDHsAI0Dfb0cz2oo9Shgq3wN/obbF+Nbnt8eZIOaMmbLtfMGQL fYISQ4/1UvpyNj7BYKt0lIrdGnl3M1IGOC2yr9BcHjkYEcWRhOiz/EMAaPLp9sPC1zu9 w3E39R3rUrMCAmL0l7WgUiYgJ3NusRzqLxutjsckNXy4WCgMTccUnekiGXFOZ/2uaRI/ OzlyQARa6ESD1ZfZSlbHL4DCdrYyFGYYoJswySA0uLHZOQtpW2yJmDY9DulH0HWoc//k Q5LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773130073; x=1773734873; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FPDC9UVWCZT9cS8dyi8jxernVsW2wVYjaKvNbAETH9s=; b=OH8+7iy83FLELwZjSLCb3Z9PJaV9eTZozalP6d+kKUMx59WZ48PHRPLZkbEvXSVkpm TEuxDr56gArJceWyoPpdYArZy3Emgaq9Nv1AgqcLEP6ZIMXqV4A839HIW1GPqGl7m6Io beIaB3aAab2Syh12yb9yfDev+4Jmb11gabi2rzVFIWZe/vprVSHETncsVnuu5/S5C7et XtB1mQqkFi8vW9mPpRQBf3YFiw0egZ/fZWVjbvcw9h+wckIeHCTqVz8U+qHu68EX5RF+ TQbcOXV4DB9UwM7MLzBa2LRSzg5Ycr30vnqflTgDd8xQJrQPn8M099ZqwgREfxqrbAru 2ASA== X-Forwarded-Encrypted: i=1; AJvYcCWYfNwij9nnFzRhSV5yMJ1eUXjCc5ZsGOmIGI0S960n+Xw5YpHjlBprv0oj/guj5Le/+480R2uwy9l2ONc=@vger.kernel.org X-Gm-Message-State: AOJu0YwRcvYi8Wkf4EeJFpYO4bTpjvUxItKlfwtCuPYeb3qC9B/CmXJp o1OFjm/SjeOZ76Drt3xXAV5wzlj5HCeVYBftj8E58JlOZWFRfds/aFKLUtBSBQ4Mot7vMVTv7n4 uADbzUfkiKI/XMiKI4tZW1vSNhvGL1iPWmuWfxqxP98R48WKu8AGro5DIRzDm7tobCQc= X-Gm-Gg: ATEYQzzXKw1ViCzxGqrlLxAJXN16wQy9aNrk/Mi/j2HAlunDEsZHNHx0Zbn1CJ+19Sk bOG8t9hlLWCXBs3gnwPAUqu1IKqv4QdjJQum+ExrJMSd/+XLxfz7iWLB8Q2p3bNU8ySxuKzCxS3 VUyQosJfNwzA27Y5om0IBvoUf8alERdeTYJkIsxZxMmzGPAxFWxrBKXCM8sWSJB1f8XDtxCNhA5 QL8INVRDx+/Ys78X/k72v+IfMDm0xd/RSTyNqBK4y15cX3Zj43IkAAS1w6CBShkh3LpGwBES9Wx g1HafyPitXKJo8j9RJjHt6kV5IuukHTXUbf/6czfSGGbN6rAGR+Gn5WJCeAu2SQ7nKoGXfoRyhP K2Dqve33g+PvkCI9dbyWNxLOnBr2JtzWnUt1tIVuRRFrlhMs= X-Received: by 2002:a05:6a20:2593:b0:394:5dc9:9758 with SMTP id adf61e73a8af0-39858fedfeemr14302472637.28.1773130073134; Tue, 10 Mar 2026 01:07:53 -0700 (PDT) X-Received: by 2002:a05:6a20:2593:b0:394:5dc9:9758 with SMTP id adf61e73a8af0-39858fedfeemr14302435637.28.1773130072619; Tue, 10 Mar 2026 01:07:52 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e195c40sm11121969a12.31.2026.03.10.01.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 01:07:52 -0700 (PDT) From: Harshal Dev Date: Tue, 10 Mar 2026 13:36:34 +0530 Subject: [PATCH v2 08/11] arm64: dts: qcom: sm8550: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-qcom_ice_power_and_clk_vote-v2-8-b9c2a5471d9e@oss.qualcomm.com> References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773129997; l=1403; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=gYZaumYhSsIGJVNztvmwWowAICkPRsJuJxQKDEYgXm8=; b=r8k6uj5/kJCQ8zdV0eJV39dfQXzKWqmaLOeE70uG02ffT1By0BEWMp7wVTYwo5D4hTjJxUMbh RbmZVL9GRlUCnynr7bkvI3L0eychPRxgMN9MQu+o3Zyt8j87yYAtqs8 X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-GUID: JLmKcn1us7zZDyP03zf_mcCCvqzwKjqF X-Proofpoint-ORIG-GUID: JLmKcn1us7zZDyP03zf_mcCCvqzwKjqF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA2OCBTYWx0ZWRfXwIHZvjdyXyVH SL2b24lX7Fi7m1gpEBtsrV94IBnrHWlm4XRP6xhEmJKm1NQCLsuGYK86k/NI0U417mMi0+/iGGL beqcu5xA6Ev8GcvDB+3NmGYG96oUe/G8lVtv/JnY+n/+h1qPJkKbwliLPUci7MbhbT7xLvmgt2g lfdtLqiXnhmPx9urY4/FOAeONmQyJYhaXGCCzNFB1IRCHSdBIo+8N2sHk/9UIHmk8fEyDc2PM9H LbLY3MhYNhZqq+pPzXdE9eP5j6wUHxRzTU2zGgJ2v3KtDGNatwMQdi1wDeegNqEseqRYBktuLYC IFWBItE6NgoZdWwnZZReUeMzVKePuCKGeRdGd9YuxlpseP2otyGL5Ael9jtC/nfgy9v6IWgdJXr bjzzW4iiAcgVmFXpT3sIT4WXuiQxKm/gYy5QaUM2sgAj6HINA2cHuyHzuGtyJcGvOe0gFj5sKl1 OIrY+Cn3t/G9oI8ky7A== X-Authority-Analysis: v=2.4 cv=eIEeTXp1 c=1 sm=1 tr=0 ts=69afd159 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 spamscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100068 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8550. Fixes: b8630c48b43fc ("arm64: dts: qcom: sm8550: Add the Inline Crypto Engi= ne node") Signed-off-by: Harshal Dev Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qco= m/sm8550.dtsi index e3f93f4f412d..b6c8c76429ba 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -2449,7 +2449,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "ice_core_clk", + "iface_clk"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 tcsr_mutex: hwlock@1f40000 { --=20 2.34.1 From nobody Thu Apr 9 07:22:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A0CE351C12 for ; Tue, 10 Mar 2026 08:08:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130086; cv=none; b=ZXB3ve7bW/4YQJgN8YzpMehlGtzTygIX9VjF5ydfA/Oddq8D5ud0heZUuLELVlw/Z7utdvNYM0Wsc99hS7Mu6UPsk1KY8eC8Uqxgp3tBaOiaX80s+366MPIPmxlOtkQZTRWcQ78micVSR3hPt1OZdi+3GhG1CD7VaJGHtsP6D9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130086; c=relaxed/simple; bh=uwfjpukTBy7HMP4EN6kRPVs9fRDUcOji4LjyoNR6I00=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OmYV+3hLSM+Am4eiaNxDxzutSrrh/6RP3i0sF5jh5dGo9+L8o+ZeekjTp9+D27dZwX+9m/2eQwP+OEx+4WrBAyJnLO9b3epetteWDfHUxgKEJyztLjQhycGBE1sdBhEB0P+2K39A5q4ciFAEProsIXN5IFVCqpg9Tn/QxyQx6To= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WAqdac8H; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hNwKjyDn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WAqdac8H"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hNwKjyDn" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A6VUtj2021657 for ; Tue, 10 Mar 2026 08:08:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= e25Tf1W193iJMpMiA9dqaSQlYyUKRAfK4mqQFSGiy3U=; b=WAqdac8HkD17Iuu9 2E3Guz6+w/QDJTxEOilusgwARaEN2qxcwADmIT4nmlxtGkV6EUmxnG8X/D+6GKtG qcHkpNoyGYl2GBGlIihkL5vZJSCRo5U0yTHgFMREwIAeLsdwlpa4jem4ZmX++AOL QPqlMkfWONTdPPMbrS2u5wyxu81doKRS0FRSi72DVqZF4nTRM23xPSZ2++Y9JKuw VVWRnHFdAuZNgJ2Z8nnWg8hPqzTf7JjceoIsGlTPNX7rvnKHYHZPPJVqali86srr xNEUUcRAB9Humt4nsgbhtlxqHQzhtBY7pfWfx/ql6UhO5dCPVPkUnCGUlKvCZgMm hjfQhA== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cte3w8afb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 08:08:02 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c73c065dd15so573145a12.0 for ; Tue, 10 Mar 2026 01:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773130082; x=1773734882; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=e25Tf1W193iJMpMiA9dqaSQlYyUKRAfK4mqQFSGiy3U=; b=hNwKjyDnTfuZRSH5y8MZ0pV9d878bvglNkGfQIXbKJ45YIoOQRF6yMq/NM8GCHLCbd zExjt4JPw0S1eQMLpVab7Kuw0REo8S4PqBya3KR67O4VfribY4M+ehn5MFcY6TT8FTCr dgLsicsQNnYnh+lyky/98x9s/PFH3AaH6fIGUMT84J0fRc09ZaeFHOF52HKImKPUmDoY 4NkYDNRDQQffHS6qrSAtLSbokEBg9/Ls0MNObm1cpbstSvVtypTva/5D9XIc4c8dT5GG zQpvFt8WxO1D9pjAn14tTlQyl1smdj++uVJUVCvd+YNphFJMrYQNX0uLzasztENy1LB0 UpYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773130082; x=1773734882; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=e25Tf1W193iJMpMiA9dqaSQlYyUKRAfK4mqQFSGiy3U=; b=wVEjP9DVPv4oIP6qK5N0fH/oxyqy7ciZ4zFv9F7Eth8epqlAKTHaMd98YdaoNXWILg rg6ZQeyMlOhHaa+AnmCT78ma4V0k3fcG++KoIYYni4QjP4PNPWml8bTR1U/1STKWcXyJ ZqCxw84mbY+w75JMUwxvuJ5HK5KRwnSBjqo7qFPOR2xeTVZ6WxiSHYP4nd/9PBVcfisE PyD+lXLZi/rccJkmIBhBf24YgH3DdwjI/3LUoj8NoB06ahpkFGlRrPWCYYBgu95C7/UA GHCD0VBg6UEaCBaTiGypIN35LgXe2YSc2gsqi2V+BUpRTq84VeM+7uHParnrXOpR5ec+ d73w== X-Forwarded-Encrypted: i=1; AJvYcCVRX6LtdJDK+Pti2OExDLfJmh8lMRG80nA/Mob3fGiFDfpmClgzDGPWGxyV/Qk1MO3mJgMghsbM+CH7FNM=@vger.kernel.org X-Gm-Message-State: AOJu0YwEeEAFlp6H/cfaeH7ObPI53OlLnZANDiKde9BnH45+MA95XHi3 iSBZuP/WomuBwd9wvPlsBN8QKwUt9q56t3WeSGws0gdyzJLTWKdznVhvQtsF5w6vaeeNOJ5lfE/ AaaQPbBcfmMH3AKBi/kCWqW+15LiVAZrKALuVylPG19Dqpejb92IcLJMXfY/etotX4V8= X-Gm-Gg: ATEYQzyBXtmBj91NoCJs1Rl3BtQucqm73Ju2H/0mF9EJ09dsT5s3SZsXlIbrUC+uTKd 81vwTCDm96RcYdgXXRWS7xguQcMxzESzmdy2L8BYu9bN5aOC5V9YDgOPtZpSiOCjvIe90rz22oM xWL0lV4n/lse+eDt9hcxJuXF4Eo2FqoPsVJMbaNLFdzLCTBbe9SSaLyc7sMnw+9ohK8OAbQyV+K SJWhRgpyZNkWh/cPFZaSWztSXnaGipU/qRcK8Sknvnedvj0BBfI8mfQ6lzqUiGPvLmF8vuHS5O/ EnyaI7hOZe+eSzJ7EbUZkfPolECWdVUAZZoaNVG0+ub/I0AYZ5gCNC6V8fpwnI/puaMth/9s1pk wTCRaRdOgaOo+DgrA8IViCddFyhEayutzvZojE4SYj1akQyc= X-Received: by 2002:a05:6a21:104:b0:398:b499:44e9 with SMTP id adf61e73a8af0-398b49945demr699734637.64.1773130081653; Tue, 10 Mar 2026 01:08:01 -0700 (PDT) X-Received: by 2002:a05:6a21:104:b0:398:b499:44e9 with SMTP id adf61e73a8af0-398b49945demr699674637.64.1773130080935; Tue, 10 Mar 2026 01:08:00 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e195c40sm11121969a12.31.2026.03.10.01.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 01:08:00 -0700 (PDT) From: Harshal Dev Date: Tue, 10 Mar 2026 13:36:35 +0530 Subject: [PATCH v2 09/11] arm64: dts: qcom: sm8650: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-qcom_ice_power_and_clk_vote-v2-9-b9c2a5471d9e@oss.qualcomm.com> References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773129997; l=1416; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=uwfjpukTBy7HMP4EN6kRPVs9fRDUcOji4LjyoNR6I00=; b=SurLQKqOB74oMdxxqSFGMXA+XYrESMpfC2Br3d6hfne2/1y6Tikz/aBPsXj+A6o9V5Ws+c+R2 +XyiZiI8xjcBrueZEku0JfeJuhzjWMrzUJ0wnqx61o4u3AVzmjkEey1 X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA2OCBTYWx0ZWRfX4we+t4QGHoxx lVM3fc4qyu2sv+pmvCuooY3typ5tpN3e/EbmLCmJnWOIWhuDeuO5diJl8J309wn3D7y8emgdGz+ iOJUvJrnFALkYY7em9lJ+QN/CHvbaf9xEuTgWAxR9cbNiqSGNx/wxLphjoJ8bulgvICcI8OUL4y 0y6uCkQUfn1jec7TTufFfBHN30Yo+W6q6rTZGqVPjw9cfdjUcM9gsXzzt+t1HQ7e7rRKuCmsX6X u4Uwd0JksYBLRwj09A9OalmOuZI+ga2+gCpofdIBgjJ8cGHpRwXGlg6vQExpda336DT/NiV3xEE tpBvoaAHuALHxXWRnjl5woiS+jnEA24hjdr8VGpepsl+eUm1wJWMPJwRIAk+fceEe4OsZhEAkva wqbVdBPhaE3In+ve1CgRPtQwiqnBLQ7h3YhFnZJbQ/0r2CMNslwl2mbfJiFqVTJfjBz0swwqNKN TL8hymXGyrzjCpx63dQ== X-Authority-Analysis: v=2.4 cv=GtFPO01C c=1 sm=1 tr=0 ts=69afd162 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-ORIG-GUID: mO4G1kk4kArEou96qMxUEUPZgwSA2tiv X-Proofpoint-GUID: mO4G1kk4kArEou96qMxUEUPZgwSA2tiv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100068 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8650. Fixes: 10e0246712951 ("arm64: dts: qcom: sm8650: add interconnect dependent= device nodes") Signed-off-by: Harshal Dev Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qco= m/sm8650.dtsi index 357e43b90740..c32a817efdb4 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -4081,7 +4081,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "ice_core_clk", + "iface_clk"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Thu Apr 9 07:22:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B7483EDAB5 for ; Tue, 10 Mar 2026 08:08:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130092; cv=none; b=X/dC7xmgRLbMl1nyYuwmtj2CmFLGvIJ9TngkDMBASk7JGr5Yfr34M8ORterhKfiEm/XegwTV9g/fClh54PyH7jkVfGFfbZhV35S1GiQGRRDfd1LnIX43jq0imipT4t5zCr0NHfpAqJ6sy3lB5ZkG+VNVtLN+5LQwh4gygujz1UA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130092; c=relaxed/simple; bh=i/zN6630ICSGfAnaDut73crn2lpipTOIb+yAdkPL8Zk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hN/+zvYSrOMVbWSrX0NgxQDw9IzMrppSh6FWZGZirhf4X5ferdXEV4qih37muzKlutA9ZiZjf3hhly4S9TufWxW06oqUKax+BZlDuqszTsjwdKgTA/4uzosdolPtbzk6dRaqiG+9EXLcW85yFAB5+RjSvkTZ/O9UbvlPC4SE2nI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AUTEvVme; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LKYBmPJO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AUTEvVme"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LKYBmPJO" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A2EQfi2460655 for ; Tue, 10 Mar 2026 08:08:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FJtaIZqWtg5VuflBFduFh+NdHGHumImiPr+NGa6fjWQ=; b=AUTEvVmenNC9y4PX w3lyNv0NYDtIW55yEj5xXiWeOt1Mlwf6DgykMgzTOo9Pxe1VzG3uhWOFyupsnvad DUAcdSTCOS1cLNAkH+QZiwLFJ7e86xymep8dShFXd+ky/MvLVnnIyZFFEEdGU7w6 1au0EvCXifeilZw5Qakh9SH27uaKjNiNc2Rt7bbnEf+kUMmEGZs8xHjNWaTbR27z qsVFtZzWGai8IRCQjENyuMuoM2hbccldjsXOpUN5iJ7L1Paz6DIAcfHcFR7HRdlX dOWxRk0hCbNDuWwFPRy1r/x79o0ebpwgOA61oh/Yp9p9qgNOrr93Q1Mdml6WRps3 yjzQbA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csyv1b8f3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 08:08:10 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3598733bec0so49426776a91.2 for ; Tue, 10 Mar 2026 01:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773130090; x=1773734890; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FJtaIZqWtg5VuflBFduFh+NdHGHumImiPr+NGa6fjWQ=; b=LKYBmPJObZ9Jw6lq+N8WsyPJfc5zqhri270LcDVLPisdFxaaV6OBI8uj5sCMk29G29 AoTGo4orfUjdIjsjZnlDCGj3YEqYdSLB6K2pRRPjjVzoVTRWjTIrofY8wxJOn4bcbdxG 35+LJYwPfugOpR40jD2NrMr23pTi4dkJTE88/expKsU8F8KvSHndgOIKN8l/4ImBuE0e rERUTFiR7dgLnnjn4yjg2ymG/8aU6Dpno4XN/ZLUFkO44wFbVp1c7Z5MRRvVgRVp0RF1 WBj0VGyuk+3WJm/CSPjike5SCbNGu9gqYDbfhVtm8n9EKfUZ7NrDa3yJCopoDlREalka /2jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773130090; x=1773734890; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FJtaIZqWtg5VuflBFduFh+NdHGHumImiPr+NGa6fjWQ=; b=DTSnbqJTcXOy0D1Z0QiL87HYfR/yIKc2gZBft4Gerg1+cd2izZfYYPrMufxC+FHxbv UkPDnX4QH/+tqvWOc4HiS1c/TA730yMJjIsSVPvdaNMS1D3Xph2rz9oYuN7B9BXQXx2L qMIHl7rIybXrgmO35fEnK0cFm4VaO0e3DSkxvDbjdvSLhUO/Kju6U8TWdllC5ug1Jwgg uC3VqlPFyv+IY0EpadHipZ/5IRuBetsc4VHGyPJbqAK0LYJ94VTeYQdk7G1DMrgGJLcK AyVo7Egvi2ofgmWePol8ZvXW/TN0vlQ/aNG2z/23PExaFjKyAkZ1a93vDxgDosGDJCVp cMWg== X-Forwarded-Encrypted: i=1; AJvYcCVCrxNf+klgjiyKEmiUreyVWY6fhbcssGeZkvV29kbbh/SQpKH8Kye9/xeJCB2B7pYIR34ySacdQ4o5eK0=@vger.kernel.org X-Gm-Message-State: AOJu0YzwS+ZUnKtWKcktMmyY3mMMtruX8YleVlQieO4a4R1ie5/m+DAA JF2I6Cd3K4ZAA+tjQfeIeB+jhgRcSYvKAqhO5fhLKIQCSwF4krdWXUhvA2KDZIH3liIcEpVTQO5 V8v/4Iy95OZkpZnZljtDLggcT0mlrG4tYF61zzPeB56TYY2AGbY3EHUsXwDE5fPE7vqg= X-Gm-Gg: ATEYQzyrlY8BNpqckfubdSqmfHG93Ant9bP1vaVijkcDsCkc/e2XqwnGgshr7Rm1RY8 /FXoI2/RlMmgKFEXHE+5Ae+SDBg1a4XaLqqpA0eNXy3R06cpw54XjKAbjfEOZmNwKDu/ggSyDNc 0IIKg4C75EGmdA1I4J3Jk2YCafcZwWplLaYzNi5hiFv465eUlrWdQXzJKQN+xCE3NXbzc6KliVg 6a340ekOFFKySzsN109qaVu9Cyi2oRj6R1yW+rKDGoJF9TuCpu2cxdhJmyY1bvZ9DiZh81daS+Q wbtqVkQ1jYD48CkCCZbBYscGmrVI8Uza74eho8IqlykOW/LHsHHGsMvL3kON/pOE/tMhWYq0Stk oFiDFsjdr5dPnEa6H5YHbSif0J4apWCjKZ2+JIgCizRiFNxM= X-Received: by 2002:a17:90b:278c:b0:359:9a25:d758 with SMTP id 98e67ed59e1d1-359be2ecc6bmr13879961a91.16.1773130090162; Tue, 10 Mar 2026 01:08:10 -0700 (PDT) X-Received: by 2002:a17:90b:278c:b0:359:9a25:d758 with SMTP id 98e67ed59e1d1-359be2ecc6bmr13879920a91.16.1773130089412; Tue, 10 Mar 2026 01:08:09 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e195c40sm11121969a12.31.2026.03.10.01.08.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 01:08:09 -0700 (PDT) From: Harshal Dev Date: Tue, 10 Mar 2026 13:36:36 +0530 Subject: [PATCH v2 10/11] arm64: dts: qcom: sm8750: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-qcom_ice_power_and_clk_vote-v2-10-b9c2a5471d9e@oss.qualcomm.com> References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773129997; l=1407; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=i/zN6630ICSGfAnaDut73crn2lpipTOIb+yAdkPL8Zk=; b=0odt1h0ELIBKQcJkrBiiKSIBIUtJ3/NO7QdVLhQ4nmNGVv1/zfaHVj3ZywxB9jPzUeQSJ5TLm 3n+oMm2Yk/aBR+pjmKnFUnWSYzU0f10Zt+Sf0uiyyfbmLLTE0ObAA6I X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-GUID: pGvbp9Ot01wKKkYdUAZFCg-ToH2EmZ0x X-Proofpoint-ORIG-GUID: pGvbp9Ot01wKKkYdUAZFCg-ToH2EmZ0x X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA2OCBTYWx0ZWRfX2j6RGRhsezRL NaMo8DmoIznCBc6FKLXh/bHbcGtXBsFaboUZMgOYj3J5a3/tlFAyLl9ZrggqcWv7y2o//I6xU6L RKR5p19Z4ZnpwmOY4MCmukTNdsOqNssyG6bjVoBbsQ3/pz6MmSIR0LLVWiU9FzDuPnxPbTGLC33 qbYij5RhKXFK0Yu5+tn1Fc10jZRloE9DJ3dXc3QHJ9SnIxbseAf2qDBVxxSIJpASZyXi/Bnp6Dw FhSfyXqBzQG11ezirXZCerXEA8uPXYcq8UmFhLzbNT6VkDYkwkM/82P/CELz1jErl7T5h5K0WPO rJHLJ6099rhoWF86j0KqdZGAR5QglLHuQU6xCzrPQF8MmLqKrz2139N5tQvedKto3uqdSkEVtdu hbwiNZEF6gMzYEuOqDrkEYbTXWANX9m1wl7A8rqkDd/1yxEOiXYBjijlQlxNev1nrxYeBYNu9GP zxWODFxgWPfOs5jePkQ== X-Authority-Analysis: v=2.4 cv=Cuays34D c=1 sm=1 tr=0 ts=69afd16a cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 spamscore=0 adultscore=0 priorityscore=1501 phishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100068 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8750. Fixes: b1dac789c650a ("arm64: dts: qcom: sm8750: Add ICE nodes") Signed-off-by: Harshal Dev Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8750.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qco= m/sm8750.dtsi index a76bf5193a70..11352cb16baa 100644 --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi @@ -2074,7 +2074,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "ice_core_clk", + "iface_clk"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Thu Apr 9 07:22:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CD303ED111 for ; Tue, 10 Mar 2026 08:08:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130101; cv=none; b=dwFsjQB3o6/4a5UuzDmw8Uzxy7vMK9gSo+dP6fkxdWxVW8OwU91x2I9B+a44zYFoqf2FTnhWUKw1IXd1dJF5DcXhZ3NNcf2P/qwyH68a0RR/xKcXzct70S8V5wI7Ic/2LbW4UDOi9nfxMm3ed5w2ePOrTtUcSWsUWK8KtZrF40A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130101; c=relaxed/simple; bh=G9ixEOwpkM6AQ7Gv5+X9OI3maNywSVPU6yqttuFKDno=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=R2xKVB9NQDhTtr537QjenZhOCjIVXLUXwn31QqHTuCubB99W55r44+QUb7uyk+KgNktZTdQmSPOnGmhvgwWUMVbsHqv9XZp8M64k9v+0+RitZ74i8CMawS72G59U70G1BIIVeDaYnYHbcJebJvyZsUoU8qkwJ8YLmIb/F1TMYMo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RDoUPGkX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IB5o7Ms4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RDoUPGkX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IB5o7Ms4" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A2EUvr2020757 for ; Tue, 10 Mar 2026 08:08:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aLh+yiUZuoUGLqqiHdB7dyI7NuqsJNxkPrS+/r6wS+E=; b=RDoUPGkXvdLMsiJ6 ZRKPC39R/Glo+E9wnvHk5LHn5O5sAkdEbk7W+uUtjKNJTLm3jrafvcsj91ZpNFuN ZkOPewREZuVNcE4V4d0Zd+D8Of8NU8Y4zmNOZzpttVr2+YhY6e6PUexwp4KOMhXc GE1Qr906r/8OkiPw8v0lU54yjcy3QwMcjhycrXyhmb42wwg0fENn4VN6p50MzkSo 8pbWJXoVNpkvxmoSQU30d9aOVJBLIfaPra8Q1wP2oxNSqNSgAmqHCerL83MYKuUB UtXbObV3S+lwhvS8R1ac63QtdZrKMDHgAFa9mZ4UFfnsbRe3uuu8dAWfGSmD1P2U gnW7aw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csyhbu7v0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 08:08:19 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3594620fe97so64869531a91.1 for ; Tue, 10 Mar 2026 01:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773130098; x=1773734898; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aLh+yiUZuoUGLqqiHdB7dyI7NuqsJNxkPrS+/r6wS+E=; b=IB5o7Ms4nqSNGjbcsIuQIS0umzyCBFffZoPqNYJSB8s4zUNP6MrWTbgedWYFSxaWPB QXXVNmGtoYMLIgsgBMjUgg66Xb1KMzJlf1NFAEoqLTRtrhINDEiBSgz9a25wOFQ1oLs/ pUzlvT9SIBgEch/FNGuL+mytSywCO9s0PnaWj1uIkjMrVjTNvCJ9VFmuVM2gBfKamoxx O58i8zjCD5SF/w3o6wLs2fPhXJZE7GylAkOESR0a0qrF0I6k410VAApVkqG1vB0tX40W Qat5dU+VCfxhktEJ6g+vHIoFy+j1w7mJuthB2NkzPM8dajzmzG8BxHX28iIxanRSEWMi iAiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773130098; x=1773734898; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aLh+yiUZuoUGLqqiHdB7dyI7NuqsJNxkPrS+/r6wS+E=; b=reD7+OBnX0gp+hfEdWti6II2mzPNpmBfQZ+R7ABU3lluaX2ywQtTHWLXTqWoVvWI4M zfh+7nq00FtAqNpV2E4TZ5w4TYpoWEXOcX85zInay3wfCvG7yPHAXJzgk4QyuGippJNm g0YEcMoK34S2tnwbLiKYlDPedBEIuqHeKp1cK+0VVjOk8Gab/LaSF3GA/eWILB2Q7y5L dsq00SF1npT0UyQYEvCEKN9t+xQhLd6TAo4RKvX3aTQhxId56JiSMc4dHZFR9Wb7FZF+ 0d7QrQp3isrBu8UvOpywZMv4xghGbjYZcE7Ml6u8bTGUKBFNhkALeGs+UPALnh8kvWDI HaAQ== X-Forwarded-Encrypted: i=1; AJvYcCVDhbUzFop34bJ0s/6SQ/XKcCkomLdfp49XcX1UQLTYqlkqi9r9gK6XYiSuRovKF+/hxtMZ+iULNPclF60=@vger.kernel.org X-Gm-Message-State: AOJu0YyH6pkOUxQMDfvy9Ay5yc5Fe9cQhfJkvBluK81M1gzGCMO1SrWK vHsEVm2u7nDcluTcwPpjD5yy87J7W1ORzZQmNgJNopj2TaXnZzMPsFj13X9GxyUDq4p23UCcKdn 7SxUJkSbW8MnW3oRK0IeGrEeiM8QMN5dBPfG9BW9dfxr5BHdJeIb+C/EwbcZ36VGQOv0= X-Gm-Gg: ATEYQzw/d3EAcmw8ExjaohU4Zcqr9wnKuBAg2PYK+fVjJNtnXJAYuBAlboF8Cz9WNTH aKQY2bOBWD7+7wswzBtIbu+hr93PBp4FnqRxJeLrEAuh2/i6Zhu7JXgnwuTcwY6MW0wm3SUWrNy 603tcL4IHPeVZhfeQm0091FsyY9qfypqSUsCV94AIEsYHs87WG781QlkjHP7FqifaXaeuc1vcnY Fqb2Vge6QKAOuA9uEGG2oDaTXz3o+7Ll9f9bDONBnCDD0SAVmZHkmMtEF80EsgsiX+F6uynnO8L Z8Qo7xwZcetLn9S+6CFx4dVN7TljYHa66cfeF6WPlwoUMMjgWJyRe8zu+6T1jdhf4DGkf7j9Mq+ PXUR5MeLGHSFyOd/9O37U9qe+UcJa75DP3bcrYlSku6g5vyE= X-Received: by 2002:a17:90b:4d86:b0:349:2154:eef4 with SMTP id 98e67ed59e1d1-359be2339a2mr13209870a91.5.1773130098317; Tue, 10 Mar 2026 01:08:18 -0700 (PDT) X-Received: by 2002:a17:90b:4d86:b0:349:2154:eef4 with SMTP id 98e67ed59e1d1-359be2339a2mr13209823a91.5.1773130097821; Tue, 10 Mar 2026 01:08:17 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e195c40sm11121969a12.31.2026.03.10.01.08.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 01:08:17 -0700 (PDT) From: Harshal Dev Date: Tue, 10 Mar 2026 13:36:37 +0530 Subject: [PATCH v2 11/11] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-qcom_ice_power_and_clk_vote-v2-11-b9c2a5471d9e@oss.qualcomm.com> References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773129997; l=1945; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=G9ixEOwpkM6AQ7Gv5+X9OI3maNywSVPU6yqttuFKDno=; b=RlNpgKM72mbBIQq5XMGzBE6lqHa0BE2Fex6m97GZXlEgTgjQYsdPDVS9skum6BMu2Tl8ep9yG OCR2btGFZG/BMmTsZsGbDBpinmrel1g1YGy65NrX6qlxi+K2Z5fSTBk X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=Rcmdyltv c=1 sm=1 tr=0 ts=69afd173 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=mORad39sGlqzgvJT29EA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA2OCBTYWx0ZWRfX0WEOk14DvEVT WG6dgmWbOsCu+JUj6ub8W2iOcaSdbdhKqY5eRlgA5dCSA9Mry99osPIwtUDkJvCaBbCEPl/8HLL 027VqyTyLtcSTfJPsmoISZIRf8Jk3oS0p9Y3Al0XY4DkH95Y1eEsHT2Dn8hiR/tR5dBPNhCt2V2 9aVtsOsb9B7ijrXIFTkER94H3wNhuDm8WL9AwEbjFOZxD3+5f9/+U/m/siEAlnbgO5kCGGhmkzl flmopnyBzXeclc/GUlSaeINfcynaeSODY+R6CjXOClT6oVPUdFsnx4lJWw6a8erPy7LQOphvrdC DUH4XtIE+mW8YA63ogs8QTfvS6kDhjDet07f58/ApIZ19jg4mLZLVS4OP/PoF0cYHu69u43vH4K mCNuk5OTRI54QUE+sS39mTZ++M3wBMDHfisTVl0eWYEqllEWDBtCqT3fRWzkTm2whXL1/doqOTe XplAob+dM4gxYEY+RsA== X-Proofpoint-GUID: gYPhCOIsmP_xZ-lHvwIROZ7EAHXggDEh X-Proofpoint-ORIG-GUID: gYPhCOIsmP_xZ-lHvwIROZ7EAHXggDEh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 suspectscore=0 spamscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 bulkscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100068 Since Qualcomm inline-crypto engine (ICE) is now a dedicated driver de-coupled from the QCOM UFS driver, it explicitly votes for its required clocks during probe. For scenarios where the 'clk_ignore_unused' flag is not passed on the kernel command line, to avoid potential unclocked ICE hardware register access during probe the ICE driver should additionally vote on the 'iface' clock. Also update the suspend and resume callbacks to handle un-voting and voting on the 'iface' clock. Fixes: 2afbf43a4aec6 ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicate= d driver") Signed-off-by: Harshal Dev --- drivers/soc/qcom/ice.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c index b203bc685cad..e05dc7b274e0 100644 --- a/drivers/soc/qcom/ice.c +++ b/drivers/soc/qcom/ice.c @@ -108,6 +108,7 @@ struct qcom_ice { void __iomem *base; =20 struct clk *core_clk; + struct clk *iface_clk; bool use_hwkm; bool hwkm_init_complete; u8 hwkm_version; @@ -316,6 +317,13 @@ int qcom_ice_resume(struct qcom_ice *ice) err); return err; } + + err =3D clk_prepare_enable(ice->iface_clk); + if (err) { + dev_err(dev, "failed to enable iface clock (%d)\n", + err); + return err; + } qcom_ice_hwkm_init(ice); return qcom_ice_wait_bist_status(ice); } @@ -323,6 +331,7 @@ EXPORT_SYMBOL_GPL(qcom_ice_resume); =20 int qcom_ice_suspend(struct qcom_ice *ice) { + clk_disable_unprepare(ice->iface_clk); clk_disable_unprepare(ice->core_clk); ice->hwkm_init_complete =3D false; =20 @@ -584,6 +593,8 @@ static struct qcom_ice *qcom_ice_create(struct device *= dev, if (IS_ERR(engine->core_clk)) return ERR_CAST(engine->core_clk); =20 + engine->iface_clk =3D devm_clk_get_optional_enabled(dev, "iface_clk"); + if (!qcom_ice_check_supported(engine)) return ERR_PTR(-EOPNOTSUPP); =20 --=20 2.34.1