From nobody Thu Apr 9 10:32:01 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D2113CE488 for ; Mon, 9 Mar 2026 22:44:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773096281; cv=none; b=NeEpXlwyziVST1yBXOM4QQrT3OO7d0wG+uG2RonDBpnAGlVaEAXUUaDRSnRUFzoioKqBI9j5sJ2v30JIWEQf6aqFLVrOCkOaS5ZTClwHcRAnCFcDDZodvnJhdSJT7gYw31t0/hutIgCSlWFWppSgZVkmb3nxrthYAuyr7PKibcU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773096281; c=relaxed/simple; bh=/aWzPrhPaX/fvhpltlRILH+gCS9UQ9O4Q1B1Jw1D6r4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iDrBjA+EYR6t/tAlQ4Ii15dixEYrXD/s9F/k6w0NQuOlg+YUQKyMM/0EFA6hvRSZCLWPK2QIUyQyl4evCTLkuqLzeGIaJf4f8f04lbk2ejqx8Cis50Qz3E4ZsRo/mFAGEi1Yf0sY3JJaisvUIKBx8YMn3E1K2j09Cd5hPf7Lbyg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=MbVoeMbB; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="MbVoeMbB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1773096278; bh=/aWzPrhPaX/fvhpltlRILH+gCS9UQ9O4Q1B1Jw1D6r4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=MbVoeMbBw0svxz3PtZw/Xg41rg5Z9j2LZ4MRo29djyJOQeLKdTFUwRlRMb9r1haQb NuyYO18qTEGCrTyHuJDzdUQfb8OP52uqbp++1jmYF8+oq9PhXcdv5oir4i5GEyTz5Q k+x0XNem96IC9GfR/IwcIaQdmkS4VhajFPORNxgi5GMcIcA/9uDNmXrS/JcmZoS771 c5PC5LMEGLs67VMhS9fSdpWv7FzO/AhwSdkz1B2KuPP/ybNcPyubWGO5EGZjeLUV68 oUoqPv2Exwgo0AYVR/dBlTa3JtqMncO9a3IGkz1aYDQ8qhvjzE4uTrh0Lay4nKjfuW uhPMx9ToaFtaw== Received: from localhost (unknown [86.123.23.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 7199417E09AC; Mon, 9 Mar 2026 23:44:38 +0100 (CET) From: Cristian Ciocaltea Date: Tue, 10 Mar 2026 00:44:32 +0200 Subject: [PATCH v2 4/8] drm/rockchip: dw_dp: Simplify error handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-drm-rk-fixes-v2-4-645ecfb43f49@collabora.com> References: <20260310-drm-rk-fixes-v2-0-645ecfb43f49@collabora.com> In-Reply-To: <20260310-drm-rk-fixes-v2-0-645ecfb43f49@collabora.com> To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Dmitry Baryshkov , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 Make the code a bit more compact by getting rid of the superfluous assignments around PTR_ERR(). While at it, also drop dev assignment in dw_dp_probe(). Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/rockchip/dw_dp-rockchip.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c b/drivers/gpu/drm/ro= ckchip/dw_dp-rockchip.c index 8945a245398c..fafefee8370d 100644 --- a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_dp-rockchip.c @@ -104,20 +104,15 @@ static int dw_dp_rockchip_bind(struct device *dev, st= ruct device *master, void * drm_encoder_helper_add(encoder, &dw_dp_encoder_helper_funcs); =20 dp->base =3D dw_dp_bind(dev, encoder, plat_data); - if (IS_ERR(dp->base)) { - ret =3D PTR_ERR(dp->base); - return ret; - } + if (IS_ERR(dp->base)) + return PTR_ERR(dp->base); =20 connector =3D drm_bridge_connector_init(drm_dev, encoder); - if (IS_ERR(connector)) { - ret =3D PTR_ERR(connector); - return dev_err_probe(dev, ret, "Failed to init bridge connector"); - } + if (IS_ERR(connector)) + return dev_err_probe(dev, PTR_ERR(connector), + "Failed to init bridge connector"); =20 - drm_connector_attach_encoder(connector, encoder); - - return 0; + return drm_connector_attach_encoder(connector, encoder); } =20 static const struct component_ops dw_dp_rockchip_component_ops =3D { @@ -126,9 +121,7 @@ static const struct component_ops dw_dp_rockchip_compon= ent_ops =3D { =20 static int dw_dp_probe(struct platform_device *pdev) { - struct device *dev =3D &pdev->dev; - - return component_add(dev, &dw_dp_rockchip_component_ops); + return component_add(&pdev->dev, &dw_dp_rockchip_component_ops); } =20 static void dw_dp_remove(struct platform_device *pdev) --=20 2.52.0