From nobody Thu Apr 9 05:51:12 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47F603E1CED for ; Tue, 10 Mar 2026 12:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773146909; cv=none; b=GN4oWFDLKud6ZfgMnQPqKEOnT/lrGzkM7NguNXEkuG/sR8AIDO8vBVPZDPXYpusTbpX7eBdRdbtQH0sRW5Dff2JuK7XluAGoD2slDd1Up09cn68bsjff0v8HwhcvJ9JzgKnNUvaiYtB1Gy2hHDYPMl6SNVzSZk7wWMb4H8DpQsE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773146909; c=relaxed/simple; bh=hLaviU5buci/iG+3IFZ8KM5SjFs5/S+pJjyjwtRoJxo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=NNPPZOc/9k58p7yMrmi434iVivrQT4JOBn/pKYvBxIs19YcvVZ15dWLhTPkr9pvS2CXw94WAPf5tGU4vLSf2VwoZCoTZ9DNsNBHUQYten1/8Gl3Mo0BV8+l41gNSMabNkgPPIAXKqjREUr/OM/142uBnVoPy5i3FEnZbqScZkwU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vzwVa-0007Ht-AG; Tue, 10 Mar 2026 13:48:22 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vzwVY-004hN1-2E; Tue, 10 Mar 2026 13:48:22 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id C25C54FD59F; Tue, 10 Mar 2026 12:48:21 +0000 (UTC) From: Marc Kleine-Budde Date: Tue, 10 Mar 2026 13:48:03 +0100 Subject: [PATCH can] can: netlink: can_changelink(): add missing error handling to call can_ctrlmode_changelink() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260310-can_ctrlmode_changelink-add-error-handling-v1-1-0daf63d85922@pengutronix.de> X-B4-Tracking: v=1; b=H4sIAAITsGkC/yWN0QrCMAxFf2Xk2UDb6QR/RWTUJs7obCWdIoz9u 9E93sPlnBkqq3CFQzOD8luqlGzDbxpI15gHRiHbEFzoXOsdppj7NOn4KMT9ehkl3zESIasWRWN kaEC/83tyXRu2nMCET+WLfP6xI5gHTiusr/ON0/TLwLJ8AZgrizyTAAAA X-Change-ID: 20260310-can_ctrlmode_changelink-add-error-handling-1517d06324ec To: Vincent Mailhol Cc: kernel@pengutronix.de, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Marc Kleine-Budde X-Mailer: b4 0.15-dev-b6adf X-Developer-Signature: v=1; a=openpgp-sha256; l=1352; i=mkl@pengutronix.de; h=from:subject:message-id; bh=hLaviU5buci/iG+3IFZ8KM5SjFs5/S+pJjyjwtRoJxo=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcIMyhm/nX4xrHtHP5U7ee2PjmrMu3aT5/7Ffrxm9Wn +N/MG19WkcpC4MYF4OsmCLL0h8nFAUCHUp7XyZMgpnDygQyhIGLUwAmksDJ8E+17KP0vC+LFopU FQtNnPn41iNfa5NTthtdmt+E975JdLrFyLBIy3t66eSuD8f9o/NuvHgVfywtMKxc7/+KmUpRm88 6yHEBAA== X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org In commit e1a5cd9d6665 ("can: netlink: add can_ctrlmode_changelink()") the CAN Control Mode (IFLA_CAN_CTRLMODE) handling was factored out into the can_ctrlmode_changelink() function. But the call to can_ctrlmode_changelink() is missing the error handling. Add the missing error handling and propagation to the call can_ctrlmode_changelink(). Cc: stable@vger.kernel.org Fixes: e1a5cd9d6665 ("can: netlink: add can_ctrlmode_changelink()") Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/netlink.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/dev/netlink.c b/drivers/net/can/dev/netlink.c index 0498198a4696..766d455950f5 100644 --- a/drivers/net/can/dev/netlink.c +++ b/drivers/net/can/dev/netlink.c @@ -601,7 +601,9 @@ static int can_changelink(struct net_device *dev, struc= t nlattr *tb[], /* We need synchronization with dev->stop() */ ASSERT_RTNL(); =20 - can_ctrlmode_changelink(dev, data, extack); + err =3D can_ctrlmode_changelink(dev, data, extack); + if (err) + return err; =20 if (data[IFLA_CAN_BITTIMING]) { struct can_bittiming bt; --- base-commit: e3f5e0f22cfc2371e7471c9fd5b4da78f9df7c69 change-id: 20260310-can_ctrlmode_changelink-add-error-handling-1517d06324ec Best regards, -- =20 Marc Kleine-Budde