From nobody Thu Apr 9 09:10:26 2026 Received: from mail-vk1-f177.google.com (mail-vk1-f177.google.com [209.85.221.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25067392832 for ; Mon, 9 Mar 2026 23:05:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097514; cv=none; b=DcgTvvj3eq7dw/0Fk9a1S2J9o7/zZmCBrNGvCd5TxD1G5dZL/dfL/5FqE9pKM7Gh8VdgRl+pUSDc9gaHuULRv0tboqB7mXrLq8Zm0TdKJ6xFUai0IGdTDCYhzaHlPbuxx6RyzNRfHJPmO0IIF02IijIxQn1N+40vBjrombtFh8o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097514; c=relaxed/simple; bh=ca+SDyYmm1t1g2hd+ZFex/RXFFNjE6Aj694+HLupQzU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZEcmqDiL8aoj3ESsmUTjTRWQem0LFW7rEGWOFsKf9C8yFK8HpYFpEd/xSzwJh2RmfsZDf8Iwsoo9A3Z/Y+TB1KsGbyQYvycole+jHaeyP6pDRp+mdjcLjaVhbT8KQ90L1l6B0mWLIPsxOCdkwodpWXGuu6dyIy2y5L6vRvYOwGE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cctnqV3c; arc=none smtp.client-ip=209.85.221.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cctnqV3c" Received: by mail-vk1-f177.google.com with SMTP id 71dfb90a1353d-56afff51694so2015675e0c.1 for ; Mon, 09 Mar 2026 16:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773097511; x=1773702311; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EayLIqCrKmuAOgPEtBGDOmJISWy5NxhD06YKjOvpoo8=; b=cctnqV3cGCChrNZUopahxNZUgxV8rj4X36MofNeFM+AxSbWLbm6br/48/rr5cyiggW chrCvrbsid5+KTNO128HnIB7Tv8SoBIz0AbC4vwxxTML2PbDtj4IDMtJ8JxEhW0Dhu2C jZ4yyhQAHcZaQskP5xCndEtiuIOiGRD7yKSSoDOsKlPYuLj+4PCmsZeQWmBpBpLl024y vTWg0C6tEJdZPOsj/EDB5riRLvKaUpuQilX1auQMAOwB14CJXcB0uEn0LBHTtgvVEZVB i/u65TzqRYCtCCwpd8bIRwtTp/BHjn9rCDKb8dwVi+YwBh/PW4hnA0OUEAWIIpeDXXl6 GgEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773097511; x=1773702311; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EayLIqCrKmuAOgPEtBGDOmJISWy5NxhD06YKjOvpoo8=; b=X0KMLBKHce/OUhBt9F04qPt4fci55jGm2vTAoTsZQ0YxwKYNxBAmzf8I1woDR3XpQp u7C8tHSUODgIELivtxYU5JoKWvDisFiiAaI4ihZOr5M4vDI+ousAKeXAea5RiIhCzTry 1D1+SH8O4DYLBxy46AdJSMX9cDa3bJIH9MfQbouqCeytya0L5g47g1LplXr1UiB2P+2k a0UfUhjMQvHA99mMw7fg+2lntqwRGharzkfnFMFfaykxfrBJP8iJm3PEeNR1m4uw0kum 6wYiHneVndYCmWQrqGzQ6tLXc34Q7EDDkikrLbE0uOSsbW7WIK+gjwA2u/JiYBqJ2mcA uLHw== X-Forwarded-Encrypted: i=1; AJvYcCV4D1StQ8IljU54JUzTQhIdzV7tdNCz5hA0ocmN5mXaI580ke5ESnQmoJ9p4SYBGDa1EKxwqNy6w5LDY/E=@vger.kernel.org X-Gm-Message-State: AOJu0YxSlfBr9wAAYOHXezZwhUAMvaYZin0+8UzUURqyidl5R6qgD2Fi jGn+GACwE+a1GFJy/VPCsHCpiByltDxgLvT4aSgnONh9haKtMgT7McdM3daN6zS/1DY= X-Gm-Gg: ATEYQzyKFObKrZFK2YqLtIX1WZQ/uTiafnODb4ntnnKbu0kLa9XfxKCQMjfHCyMvHWA y5NomYw9WZ6w+9Wu96tykGvUMBdTj9TYBuWo8xPVGCKmMn42DT0lPj0uez8QR3DqzhB90NK/ahf BNQw+q0TDTHjm6k1DwG7nnkYqBkeFdGQR6iHv531FBVUWZgIRvKdE45NY9BUHt98AGvMeev7CsT sZh0lSFvWN7aXsPCTTC+m+XgTxA4dVNrDPQeRzv9CO9fSOeKsqmbyx3eW+OhDSdHvoGFOMx5oNG vg1BILCc+9N5YtBgfQPqpN2EWUoW6DVt8b9Na9k1vlwbHyNtjlSh3DVJkZOH3czVTWoTRvhQhmX m/ar+4+yCCrSQoRRADwIgCl7dsaMn4uPyLE4xnVWyNZIF/8F4peI7W0658qhn2FpaBKuLxWLycq PEME03HUC75JiYqg== X-Received: by 2002:a05:6123:14f:b0:55b:305b:4e45 with SMTP id 71dfb90a1353d-56b07e9d2f4mr4274311e0c.17.1773097511039; Mon, 09 Mar 2026 16:05:11 -0700 (PDT) Received: from horus ([138.97.160.237]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56b09b6ac44sm10441332e0c.19.2026.03.09.16.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 16:05:10 -0700 (PDT) From: Luis Soza Rodriguez X-Google-Original-From: Luis Soza Rodriguez To: pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luis Soza Rodriguez Subject: [PATCH v2] staging: greybus: loopback: use sysfs_emit in sysfs show functions Date: Mon, 9 Mar 2026 17:05:07 -0600 Message-ID: <20260309230507.4931-1-contact@sluisr.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the kernel's documentation, sysfs_emit() is the preferred way to format strings for sysfs attributes. It handles buffer overruns safely. Replace sprintf calls with sysfs_emit across all loopback sysfs show macros. Signed-off-by: Luis Soza Rodriguez Reviewed-by: Dan Carpenter --- v2: align backslashes in macros as requested by Dan Carpenter. drivers/staging/greybus/loopback.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/l= oopback.c index aa9c73cb0..3a502d89d 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -125,7 +125,7 @@ static ssize_t field##_show(struct device *dev, \ char *buf) \ { \ struct gb_loopback *gb =3D dev_get_drvdata(dev); \ - return sprintf(buf, "%u\n", gb->field); \ + return sysfs_emit(buf, "%u\n", gb->field); \ } \ static DEVICE_ATTR_RO(field) =20 @@ -137,8 +137,8 @@ static ssize_t name##_##field##_show(struct device *dev= , \ struct gb_loopback *gb =3D dev_get_drvdata(dev); \ /* Report 0 for min and max if no transfer succeeded */ \ if (!gb->requests_completed) \ - return sprintf(buf, "0\n"); \ - return sprintf(buf, "%" #type "\n", gb->name.field); \ + return sysfs_emit(buf, "0\n"); \ + return sysfs_emit(buf, "%" #type "\n", gb->name.field); \ } \ static DEVICE_ATTR_RO(name##_##field) =20 @@ -158,7 +158,7 @@ static ssize_t name##_avg_show(struct device *dev, \ rem =3D do_div(avg, count); \ rem *=3D 1000000; \ do_div(rem, count); \ - return sprintf(buf, "%llu.%06u\n", avg, (u32)rem); \ + return sysfs_emit(buf, "%llu.%06u\n", avg, (u32)rem); \ } \ static DEVICE_ATTR_RO(name##_avg) =20 @@ -173,7 +173,7 @@ static ssize_t field##_show(struct device *dev, \ char *buf) \ { \ struct gb_loopback *gb =3D dev_get_drvdata(dev); \ - return sprintf(buf, "%" #type "\n", gb->field); \ + return sysfs_emit(buf, "%" #type "\n", gb->field); \ } \ static ssize_t field##_store(struct device *dev, \ struct device_attribute *attr, \ @@ -199,7 +199,7 @@ static ssize_t field##_show(struct device *dev, \ char *buf) \ { \ struct gb_loopback *gb =3D dev_get_drvdata(dev); \ - return sprintf(buf, "%u\n", gb->field); \ + return sysfs_emit(buf, "%u\n", gb->field); \ } \ static DEVICE_ATTR_RO(field) =20 @@ -209,7 +209,7 @@ static ssize_t field##_show(struct device *dev, \ char *buf) \ { \ struct gb_loopback *gb =3D dev_get_drvdata(dev); \ - return sprintf(buf, "%" #type "\n", gb->field); \ + return sysfs_emit(buf, "%" #type "\n", gb->field); \ } \ static ssize_t field##_store(struct device *dev, \ struct device_attribute *attr, \ --=20 2.53.0