From nobody Thu Apr 9 09:01:36 2026 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA95D38944D for ; Mon, 9 Mar 2026 22:37:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773095870; cv=none; b=kBajNgDLWfdnNYhx5f/0Q3jdKfssyfpmlnPUIWukAhExOLzKlp5p1PtSwBqAkkBCBz1EY0vcm6avoRypNNQR1KImSd0zs5/OdOgySM1fuejJyy3TKO6Og87+B2Fcran/S90e41YKdoSAuvLSDhtGAsaJIfsRg3ddhsCp6Au7Igc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773095870; c=relaxed/simple; bh=g4x+bcmdRwtdooJ0fvg4JOjxNCGbKiz3oPfGXyLnrS4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UntomXN0GxsM68OgcmPEBjD6dXifFMeuyKlZ6I4aeE+2TyR+aoILR1FpfdUWDRUfqfFmnHLjZ4bmZS/bGUQ83NHO08YNFtNyERI/qkZ4+5cnzJJZ9Man8b/fRsVCIbx7uM9DCqdjReeD5bIfUNveszSpVtrV2blSiLMPc0w/WJk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=UgdlmlAW; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="UgdlmlAW" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1773095866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=OxaJHJk+mJVYPj9G2Y4oEC7/WaiQgq3DTKIpf22Ihuo=; b=UgdlmlAWHZahKZUalZ3gSKyMViky23+gjor3FKpxCUGSnYNMkfpHSVHtg/SJV5G4PkLxfJ Wd9G2PeOO9FsKqfWNlA90zxbyPHAqop4KOKvrvYPyGIKhUW8K2grt4GS/r1A+QLQyr4yMH nx1qQC2uXCj0GAaseNbBcRqS5BRyx6s= From: Thorsten Blum To: Parthiban Veerasooran , Christian Gromm Cc: Thorsten Blum , linux-kernel@vger.kernel.org Subject: [PATCH RESEND] most: core: Use sysfs_emit in sysfs show functions Date: Mon, 9 Mar 2026 23:37:35 +0100 Message-ID: <20260309223733.83958-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=8061; i=thorsten.blum@linux.dev; h=from:subject; bh=g4x+bcmdRwtdooJ0fvg4JOjxNCGbKiz3oPfGXyLnrS4=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDJnrvdeus1uXcHr2tx2vZBZqup9+5da65OPvHQ/P/b/wt XP9la1CFh2lLAxiXAyyYoosD2b9mOFbWlO5ySRiJ8wcViaQIQxcnAIwkcOcDH8l47ZM7Jl8cLbL AuOk869DrU+Ufm1zbNherZxs9reXoyWK4Z8p+xm2pUdOs8pPL9n1Yt9e7jKh/dKu5o/afjNWzl9 3Yhs/AA== X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Replace snprintf() with sysfs_emit() in sysfs show functions. sysfs_emit() is preferred for formatting sysfs output because it provides safer bounds checking. In components_show() and print_links(), use sysfs_emit_at() to avoid manual buffer size accounting. Signed-off-by: Thorsten Blum --- drivers/most/core.c | 87 +++++++++++++++++++++------------------------ 1 file changed, 40 insertions(+), 47 deletions(-) diff --git a/drivers/most/core.c b/drivers/most/core.c index c2616da8bceb..64766c021677 100644 --- a/drivers/most/core.c +++ b/drivers/most/core.c @@ -208,8 +208,8 @@ static ssize_t number_of_packet_buffers_show(struct dev= ice *dev, struct most_channel *c =3D to_channel(dev); unsigned int i =3D c->channel_id; =20 - return snprintf(buf, PAGE_SIZE, "%d\n", - c->iface->channel_vector[i].num_buffers_packet); + return sysfs_emit(buf, "%d\n", + c->iface->channel_vector[i].num_buffers_packet); } =20 static ssize_t number_of_stream_buffers_show(struct device *dev, @@ -219,8 +219,8 @@ static ssize_t number_of_stream_buffers_show(struct dev= ice *dev, struct most_channel *c =3D to_channel(dev); unsigned int i =3D c->channel_id; =20 - return snprintf(buf, PAGE_SIZE, "%d\n", - c->iface->channel_vector[i].num_buffers_streaming); + return sysfs_emit(buf, "%d\n", + c->iface->channel_vector[i].num_buffers_streaming); } =20 static ssize_t size_of_packet_buffer_show(struct device *dev, @@ -230,8 +230,8 @@ static ssize_t size_of_packet_buffer_show(struct device= *dev, struct most_channel *c =3D to_channel(dev); unsigned int i =3D c->channel_id; =20 - return snprintf(buf, PAGE_SIZE, "%d\n", - c->iface->channel_vector[i].buffer_size_packet); + return sysfs_emit(buf, "%d\n", + c->iface->channel_vector[i].buffer_size_packet); } =20 static ssize_t size_of_stream_buffer_show(struct device *dev, @@ -241,8 +241,8 @@ static ssize_t size_of_stream_buffer_show(struct device= *dev, struct most_channel *c =3D to_channel(dev); unsigned int i =3D c->channel_id; =20 - return snprintf(buf, PAGE_SIZE, "%d\n", - c->iface->channel_vector[i].buffer_size_streaming); + return sysfs_emit(buf, "%d\n", + c->iface->channel_vector[i].buffer_size_streaming); } =20 static ssize_t channel_starving_show(struct device *dev, @@ -251,7 +251,7 @@ static ssize_t channel_starving_show(struct device *dev, { struct most_channel *c =3D to_channel(dev); =20 - return snprintf(buf, PAGE_SIZE, "%d\n", c->is_starving); + return sysfs_emit(buf, "%d\n", c->is_starving); } =20 static ssize_t set_number_of_buffers_show(struct device *dev, @@ -260,7 +260,7 @@ static ssize_t set_number_of_buffers_show(struct device= *dev, { struct most_channel *c =3D to_channel(dev); =20 - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.num_buffers); + return sysfs_emit(buf, "%d\n", c->cfg.num_buffers); } =20 static ssize_t set_buffer_size_show(struct device *dev, @@ -269,7 +269,7 @@ static ssize_t set_buffer_size_show(struct device *dev, { struct most_channel *c =3D to_channel(dev); =20 - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.buffer_size); + return sysfs_emit(buf, "%d\n", c->cfg.buffer_size); } =20 static ssize_t set_direction_show(struct device *dev, @@ -279,10 +279,10 @@ static ssize_t set_direction_show(struct device *dev, struct most_channel *c =3D to_channel(dev); =20 if (c->cfg.direction & MOST_CH_TX) - return snprintf(buf, PAGE_SIZE, "tx\n"); + return sysfs_emit(buf, "tx\n"); else if (c->cfg.direction & MOST_CH_RX) - return snprintf(buf, PAGE_SIZE, "rx\n"); - return snprintf(buf, PAGE_SIZE, "unconfigured\n"); + return sysfs_emit(buf, "rx\n"); + return sysfs_emit(buf, "unconfigured\n"); } =20 static ssize_t set_datatype_show(struct device *dev, @@ -294,10 +294,9 @@ static ssize_t set_datatype_show(struct device *dev, =20 for (i =3D 0; i < ARRAY_SIZE(ch_data_type); i++) { if (c->cfg.data_type & ch_data_type[i].most_ch_data_type) - return snprintf(buf, PAGE_SIZE, "%s", - ch_data_type[i].name); + return sysfs_emit(buf, "%s", ch_data_type[i].name); } - return snprintf(buf, PAGE_SIZE, "unconfigured\n"); + return sysfs_emit(buf, "unconfigured\n"); } =20 static ssize_t set_subbuffer_size_show(struct device *dev, @@ -306,7 +305,7 @@ static ssize_t set_subbuffer_size_show(struct device *d= ev, { struct most_channel *c =3D to_channel(dev); =20 - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.subbuffer_size); + return sysfs_emit(buf, "%d\n", c->cfg.subbuffer_size); } =20 static ssize_t set_packets_per_xact_show(struct device *dev, @@ -315,7 +314,7 @@ static ssize_t set_packets_per_xact_show(struct device = *dev, { struct most_channel *c =3D to_channel(dev); =20 - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.packets_per_xact); + return sysfs_emit(buf, "%d\n", c->cfg.packets_per_xact); } =20 static ssize_t set_dbr_size_show(struct device *dev, @@ -323,7 +322,7 @@ static ssize_t set_dbr_size_show(struct device *dev, { struct most_channel *c =3D to_channel(dev); =20 - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.dbr_size); + return sysfs_emit(buf, "%d\n", c->cfg.dbr_size); } =20 #define to_dev_attr(a) container_of(a, struct device_attribute, attr) @@ -395,7 +394,7 @@ static ssize_t description_show(struct device *dev, { struct most_interface *iface =3D dev_get_drvdata(dev); =20 - return snprintf(buf, PAGE_SIZE, "%s\n", iface->description); + return sysfs_emit(buf, "%s\n", iface->description); } =20 static ssize_t interface_show(struct device *dev, @@ -406,25 +405,25 @@ static ssize_t interface_show(struct device *dev, =20 switch (iface->interface) { case ITYPE_LOOPBACK: - return snprintf(buf, PAGE_SIZE, "loopback\n"); + return sysfs_emit(buf, "loopback\n"); case ITYPE_I2C: - return snprintf(buf, PAGE_SIZE, "i2c\n"); + return sysfs_emit(buf, "i2c\n"); case ITYPE_I2S: - return snprintf(buf, PAGE_SIZE, "i2s\n"); + return sysfs_emit(buf, "i2s\n"); case ITYPE_TSI: - return snprintf(buf, PAGE_SIZE, "tsi\n"); + return sysfs_emit(buf, "tsi\n"); case ITYPE_HBI: - return snprintf(buf, PAGE_SIZE, "hbi\n"); + return sysfs_emit(buf, "hbi\n"); case ITYPE_MEDIALB_DIM: - return snprintf(buf, PAGE_SIZE, "mlb_dim\n"); + return sysfs_emit(buf, "mlb_dim\n"); case ITYPE_MEDIALB_DIM2: - return snprintf(buf, PAGE_SIZE, "mlb_dim2\n"); + return sysfs_emit(buf, "mlb_dim2\n"); case ITYPE_USB: - return snprintf(buf, PAGE_SIZE, "usb\n"); + return sysfs_emit(buf, "usb\n"); case ITYPE_PCIE: - return snprintf(buf, PAGE_SIZE, "pcie\n"); + return sysfs_emit(buf, "pcie\n"); } - return snprintf(buf, PAGE_SIZE, "unknown\n"); + return sysfs_emit(buf, "unknown\n"); } =20 static DEVICE_ATTR_RO(description); @@ -471,20 +470,16 @@ static int print_links(struct device *dev, void *data) =20 list_for_each_entry(c, &iface->p->channel_list, list) { if (c->pipe0.comp) { - offs +=3D scnprintf(buf + offs, - PAGE_SIZE - offs, - "%s:%s:%s\n", - c->pipe0.comp->name, - dev_name(iface->dev), - dev_name(&c->dev)); + offs +=3D sysfs_emit_at(buf, offs, "%s:%s:%s\n", + c->pipe0.comp->name, + dev_name(iface->dev), + dev_name(&c->dev)); } if (c->pipe1.comp) { - offs +=3D scnprintf(buf + offs, - PAGE_SIZE - offs, - "%s:%s:%s\n", - c->pipe1.comp->name, - dev_name(iface->dev), - dev_name(&c->dev)); + offs +=3D sysfs_emit_at(buf, offs, "%s:%s:%s\n", + c->pipe1.comp->name, + dev_name(iface->dev), + dev_name(&c->dev)); } } d->offs =3D offs; @@ -517,10 +512,8 @@ static ssize_t components_show(struct device_driver *d= rv, char *buf) struct most_component *comp; int offs =3D 0; =20 - list_for_each_entry(comp, &comp_list, list) { - offs +=3D scnprintf(buf + offs, PAGE_SIZE - offs, "%s\n", - comp->name); - } + list_for_each_entry(comp, &comp_list, list) + offs +=3D sysfs_emit_at(buf, offs, "%s\n", comp->name); return offs; }