From nobody Tue Apr 7 15:26:05 2026 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BD4E33436A for ; Mon, 9 Mar 2026 22:33:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773095601; cv=none; b=fZ8y15q9SR6vXewh2xgNiEXDn32QdCZK62HGv+A+xmoE+F7tbAiDLbqx1suUe3LowtUyeOH+6J1MPEIbNoDIdDxBu9/OUaLvVA3X8dv62xqmEo+FRdLldk2H6pcGJMt84u1uY6Dwtb2eNRbMXfaHF2S2rzZ9YNCPeYvpaSU/eL4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773095601; c=relaxed/simple; bh=1qspg5ZcUQqXNM78npbkekkxrajdvbTq3c9lyKlRDi4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uwT3MhZop+4G9+kNItYOEgnyN8DErpKvtC8u5a4k0iu1vUATg/kKmwnzUvQet063NLHS4HBhwPUvp3cIIOrnmBBu6wwDSiWJcU3eNIqDRAxdALJ7uMzIzTXS6TytksVgk3//RoiKdajfVriZ3diaSE14vu68/m16/HFp8y6+a/U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=C8FT+7kH; arc=none smtp.client-ip=95.215.58.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="C8FT+7kH" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1773095597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8hawLGkB1iAMtUgsjFEWZcjWHr2cfbJtKKAJ4n3552U=; b=C8FT+7kHnIMgu0iHLIaewy7W9VOs5Y8GHWMT6KnJKyYtUFRaC+Kuf4TonoAnK812tAFAK/ xYo0w1tRjZEwhTb+tPjFDDGbarURkA5OrVCICiL56XrJIkKsnvVEiYk/UN1RhK7+uJZSbo nTQJ2DDT6X86ctrg8Lpmsl2aquxmG0g= From: Thorsten Blum To: Parthiban Veerasooran , Christian Gromm Cc: Thorsten Blum , linux-kernel@vger.kernel.org Subject: [PATCH RESEND] most: configfs: Use sysfs_emit in sysfs show functions Date: Mon, 9 Mar 2026 23:32:49 +0100 Message-ID: <20260309223248.83314-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=5162; i=thorsten.blum@linux.dev; h=from:subject; bh=1qspg5ZcUQqXNM78npbkekkxrajdvbTq3c9lyKlRDi4=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDJnrvSZon9j2fUJR286ubrbqj/bzPXMqnYUK7s6afPjj1 Rddcx8JdpSyMIhxMciKKbI8mPVjhm9pTeUmk4idMHNYmUCGMHBxCsBEFs1j+F+5KvPy6Skm8aqq b4/MYTc68KT00aQLpc8tBd6lx/5J/buc4a8w9+pzpgXzW+fmp5tPcrv51Pd68VPzuzY/lQJTcuO c6zgA X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Replace snprintf() with sysfs_emit() in sysfs show functions, which is preferred for formatting sysfs output because it provides safer bounds checking. No functional changes. Signed-off-by: Thorsten Blum --- drivers/most/configfs.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/most/configfs.c b/drivers/most/configfs.c index 8f5158d95bc3..f2aae6874b64 100644 --- a/drivers/most/configfs.c +++ b/drivers/most/configfs.c @@ -8,6 +8,7 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include #include +#include #include #include #include @@ -159,7 +160,7 @@ static ssize_t mdev_link_destroy_link_store(struct conf= ig_item *item, =20 static ssize_t mdev_link_direction_show(struct config_item *item, char *pa= ge) { - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->direction); + return sysfs_emit(page, "%s\n", to_mdev_link(item)->direction); } =20 static ssize_t mdev_link_direction_store(struct config_item *item, @@ -177,7 +178,7 @@ static ssize_t mdev_link_direction_store(struct config_= item *item, =20 static ssize_t mdev_link_datatype_show(struct config_item *item, char *pag= e) { - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->datatype); + return sysfs_emit(page, "%s\n", to_mdev_link(item)->datatype); } =20 static ssize_t mdev_link_datatype_store(struct config_item *item, @@ -196,7 +197,7 @@ static ssize_t mdev_link_datatype_store(struct config_i= tem *item, =20 static ssize_t mdev_link_device_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->device); + return sysfs_emit(page, "%s\n", to_mdev_link(item)->device); } =20 static ssize_t mdev_link_device_store(struct config_item *item, @@ -211,7 +212,7 @@ static ssize_t mdev_link_device_store(struct config_ite= m *item, =20 static ssize_t mdev_link_channel_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->channel); + return sysfs_emit(page, "%s\n", to_mdev_link(item)->channel); } =20 static ssize_t mdev_link_channel_store(struct config_item *item, @@ -226,7 +227,7 @@ static ssize_t mdev_link_channel_store(struct config_it= em *item, =20 static ssize_t mdev_link_comp_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->comp); + return sysfs_emit(page, "%s\n", to_mdev_link(item)->comp); } =20 static ssize_t mdev_link_comp_store(struct config_item *item, @@ -241,8 +242,7 @@ static ssize_t mdev_link_comp_store(struct config_item = *item, =20 static ssize_t mdev_link_comp_params_show(struct config_item *item, char *= page) { - return snprintf(page, PAGE_SIZE, "%s\n", - to_mdev_link(item)->comp_params); + return sysfs_emit(page, "%s\n", to_mdev_link(item)->comp_params); } =20 static ssize_t mdev_link_comp_params_store(struct config_item *item, @@ -257,8 +257,7 @@ static ssize_t mdev_link_comp_params_store(struct confi= g_item *item, =20 static ssize_t mdev_link_num_buffers_show(struct config_item *item, char *= page) { - return snprintf(page, PAGE_SIZE, "%d\n", - to_mdev_link(item)->num_buffers); + return sysfs_emit(page, "%d\n", to_mdev_link(item)->num_buffers); } =20 static ssize_t mdev_link_num_buffers_store(struct config_item *item, @@ -275,8 +274,7 @@ static ssize_t mdev_link_num_buffers_store(struct confi= g_item *item, =20 static ssize_t mdev_link_buffer_size_show(struct config_item *item, char *= page) { - return snprintf(page, PAGE_SIZE, "%d\n", - to_mdev_link(item)->buffer_size); + return sysfs_emit(page, "%d\n", to_mdev_link(item)->buffer_size); } =20 static ssize_t mdev_link_buffer_size_store(struct config_item *item, @@ -294,8 +292,7 @@ static ssize_t mdev_link_buffer_size_store(struct confi= g_item *item, static ssize_t mdev_link_subbuffer_size_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%d\n", - to_mdev_link(item)->subbuffer_size); + return sysfs_emit(page, "%d\n", to_mdev_link(item)->subbuffer_size); } =20 static ssize_t mdev_link_subbuffer_size_store(struct config_item *item, @@ -313,8 +310,7 @@ static ssize_t mdev_link_subbuffer_size_store(struct co= nfig_item *item, static ssize_t mdev_link_packets_per_xact_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%d\n", - to_mdev_link(item)->packets_per_xact); + return sysfs_emit(page, "%d\n", to_mdev_link(item)->packets_per_xact); } =20 static ssize_t mdev_link_packets_per_xact_store(struct config_item *item, @@ -331,7 +327,7 @@ static ssize_t mdev_link_packets_per_xact_store(struct = config_item *item, =20 static ssize_t mdev_link_dbr_size_show(struct config_item *item, char *pag= e) { - return snprintf(page, PAGE_SIZE, "%d\n", to_mdev_link(item)->dbr_size); + return sysfs_emit(page, "%d\n", to_mdev_link(item)->dbr_size); } =20 static ssize_t mdev_link_dbr_size_store(struct config_item *item,