From nobody Sun Apr 5 13:14:54 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2EB341C2F9 for ; Mon, 9 Mar 2026 20:33:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773088431; cv=none; b=ThNWqYg45jn3rJ1ea44FdplOrW+HxH28AEI5yd4+M6EO8xNiyy/iEnQvflZ8oQmvK2+diLlQRVbLVCcgtTuL/9/n6vAGDpnnlnQ+SJHFYEmu1EQt3Ehrq0/R8iUebSXFgtW/kjPLTGqJfQsT7xWtlTuGV+3446rEG2usafiL1as= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773088431; c=relaxed/simple; bh=royapcGosrFDfN1+WyvBjef85L3TpzNsrnUe+lEHvP4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UCwRyTzD0Q5wAyS1gs9AhzAOVsRtfjqYILUoErK65MVGp5o6Zm6JqNG9845uaBT35rAKYxStEaJ4gngwEutE7tBtYo2Qxg7hu8/H0oMSnlzCxscoAk9isZqPJ0BCdqfPdfEOfv8BiN2eaJLaizxb19EBdiqO1fb1pXBjmJXWTmA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=P9LnB6cu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QdfMZC70; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="P9LnB6cu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QdfMZC70" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629HBlNd1297345 for ; Mon, 9 Mar 2026 20:33:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=ZtqMZiiTPmW H7gYvculLjfwmF7B59MpYwDHoaL2++qE=; b=P9LnB6cupDYWUrtdb5ZvZBxvD9r VpT4BxSIFQDBplw3dumBaGDw1Va5RZhmHD9jYkuV53srS6x2/1AmwoUg1keywHUK vEwltS7mJ0xwmqJZACmwuwhjjCh8WGJ5j/UPXllkQ3VJ3DRAob4OTIPAtWtcFf5Z 0PQ1Wov1apcpw78xwsiqUAm6N8ytJSEsgbyWLbelmbv5lJE8xe60TkAY1kENX2Bq rOoSsXCpfbJPRvq0Vpx1wCWAwOTxwSYiP+KkyPTBnIzAGAjkDpYYxCGIq4I3qgsW r/9i+Rk/n/CkMRfnGvjJgzTresPsV6TIhyamt+QIM9TJ3onlnvQHGG01gxw== Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csyv19afj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 20:33:46 +0000 (GMT) Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-7d74cd7b1e3so5490250a34.1 for ; Mon, 09 Mar 2026 13:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773088426; x=1773693226; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZtqMZiiTPmWH7gYvculLjfwmF7B59MpYwDHoaL2++qE=; b=QdfMZC70baH1r/X9Bhm2/TUoZP1ZCT69XqkxCUwFVklhiq/ylNI26kfOCWpNV9Egkj bRxUPJRFCWgBIs+Ksh3FXu/gn3sUcAO59K1Y1lVMh4fDnlPYpxCfovjHV9r8SkEfI82C XM4o4qkVLDOYs0U9gbdwcLdi/YagP4QfWwseLevB2zY2P4S7vVt+d9Ebn1XDQ7vaqmhy +HaDUZibTNejtDFpo5qtwzJeP3lkX8DjitdUY3fiuv50qxNfFqcBdyXSgqivw4nZUW57 pOFX797xiT2eq2AzzmO1g3Yvqn5wUt8xX4UrbTXfgeECAG+ZOJ3ODDKieX8DC6C5gGXA XGeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773088426; x=1773693226; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZtqMZiiTPmWH7gYvculLjfwmF7B59MpYwDHoaL2++qE=; b=vJYzvcnIPplZe7xcssct0iojFYT5I2XtcYO9+TlWIFpMk0YqJiXQQQdZiXs4qC6xSq pky4EbwXi1+WUBn1t39pbCR/tkPs7dlOokEBkezOMjiF63VyYDaannpYP5ygmF9muL6c a54UQBuL42nj7ExtOvvMU2Nr7CukOCJB14HWxUKGVoMU2H/jzpWDx2JZWILgKvtgsNK/ K76haeyu79TuEtGn1zKqvLVGeAm2YvBbec0OcOOKXelvEe9kskMgdTRWlvQOavJDDazU 6bVwMWe7PCVio0sMtFpf3Q9qahE+i3Gf455jpVQRng5JNs503Agtn0VJApQx6yob5khq Zbfw== X-Forwarded-Encrypted: i=1; AJvYcCUtffskVqKZ0OQzJHxqpB7bGjUDQMBkyovDDIR1oZ31zXzDzTGkYhty8nZ8CQnnm8Nisd8s06vQipXZa+c=@vger.kernel.org X-Gm-Message-State: AOJu0YyLRZ2RpPEilPaIVcP/6Iz/0zvi8r9lm1yUU1jJ1ptQz4qZGuXS NZcuz47/yQGQgrviREjb22c/FVDvEaijpVwyg/zQIgaYI37SmpWIz0o7WT6udDtUhx74qe2kfbg zS51Uqzls9OML7XG2s8Xbedrd/OwXBWEUTi3tC6q8LPk/Zt/5h03jogn9i1DOHaoj+Jc= X-Gm-Gg: ATEYQzw9QQibxZZy0xfxzwy7PL3lt+4sDEF9VDDjdn9vjQu4FnMfLq7Dwf66toceOUI wnEH2uP6jKfOKh9DXGRwYMYCcRhBs3UaLd96PfLHl2b/89gJzNkUPSSZBhZy/rjU+cnfRmkGYn5 hQVqxbvtBZ85CQulx4OdJc0RtAQFTfq3i0wDmyuUAqwKjiBm6sYkscJDqSNiseCL68a+rP8Q1Sc JLMDXP28tvoPutvmYMuohCsd1e+gi2Rzb7cCg6S05KuDs1POi3pF4UPprXld+IqO1nMlU3Xg9os TL7ZIOOj0o8RU8TeTC5sdwCEG4yEQnTUAGWmml/3laW4Iq7zbMj5fHSkrS2spQFWGvp2T0vP5HM hTdgosz13RCjaObY43I2ZX56qE4+1zgbSuZRyKZbcamJVMFPaguqxztxJaLgOSJUNzBExEYklAt I= X-Received: by 2002:a05:6830:a8f:b0:7d7:5016:7ed1 with SMTP id 46e09a7af769-7d7501680a7mr1815253a34.33.1773088426003; Mon, 09 Mar 2026 13:33:46 -0700 (PDT) X-Received: by 2002:a05:6830:a8f:b0:7d7:5016:7ed1 with SMTP id 46e09a7af769-7d7501680a7mr1815235a34.33.1773088425634; Mon, 09 Mar 2026 13:33:45 -0700 (PDT) Received: from hu-eserrao-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d74885b5a4sm3036494a34.23.2026.03.09.13.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 13:33:45 -0700 (PDT) From: Elson Serrao To: Greg Kroah-Hartman , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Souradeep Chowdhury Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RFC v3 05/10] usb: misc: qcom_eud: improve enable_store API Date: Mon, 9 Mar 2026 13:33:32 -0700 Message-Id: <20260309203337.803986-6-elson.serrao@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260309203337.803986-1-elson.serrao@oss.qualcomm.com> References: <20260309203337.803986-1-elson.serrao@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: i3kUmNIkBXQVRTGsDxKpaLqkjeAkBdxu X-Proofpoint-ORIG-GUID: i3kUmNIkBXQVRTGsDxKpaLqkjeAkBdxu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDE4MiBTYWx0ZWRfX/UmsIJSmEU58 x+EuyAGaMQfTREW8mTdqFtR/ifdfqHJw73QxTG3dASvMzKBL94TyKhF7LLAQe5xoDD2y04J5Zs8 u0yh4hYeJj6+oLtqzbNA/fJ9Rmtp27jMB0F46KEACO6M5/murU3Ka3IfX987cfVHZQInKpr/wfj CFvEqARL+cbhNWiEd+20iX7FlseFmsAW3Y+fRFGqjBOjC9ktN7KytUgd0WtdtUwWR9TpnRsi0xw 1XoNdzjeGTRF2RUlPhkORX/UGPTTNGa3uw99VXTHm8mrCCgTOD4k6EtCMiltWAr5oHSYpCetCCi v5DKioZSpE6OpnSvxQ2VgSkFsOuJTTxsifS+oV7GQ1g+xhuEVuwtP19xwpq9/0ddqzlyrikIJbA 7xwue6HzSHeNOdYkABaGqMAeqJeXpTO1lkuSg9vHJ1cA+3QsJnvaGs8zON5mm+Jj1NCmi9S2ibx SL3qObKq+OQjK5oYNhw== X-Authority-Analysis: v=2.4 cv=Cuays34D c=1 sm=1 tr=0 ts=69af2eaa cx=c_pps a=OI0sxtj7PyCX9F1bxD/puw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=iEam2xx7WbKG8qDqzoQA:9 a=Z1Yy7GAxqfX1iEi80vsk:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_05,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 spamscore=0 adultscore=0 priorityscore=1501 phishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090182 Content-Type: text/plain; charset="utf-8" Currently enable_store() allows operations irrespective of the EUD state, which can result in redundant operations. Avoid this by adding duplicate state checks to skip requests when EUD is already in the desired state. Additionally, improve error handling with explicit logging to provide better feedback. Signed-off-by: Elson Serrao --- drivers/usb/misc/qcom_eud.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/usb/misc/qcom_eud.c b/drivers/usb/misc/qcom_eud.c index 1936b45791d2..4fd08962d4fb 100644 --- a/drivers/usb/misc/qcom_eud.c +++ b/drivers/usb/misc/qcom_eud.c @@ -148,18 +148,27 @@ static ssize_t enable_store(struct device *dev, if (kstrtobool(buf, &enable)) return -EINVAL; =20 + /* Skip operation if already in desired state */ + if (chip->enabled =3D=3D enable) + return count; + if (enable) { ret =3D enable_eud(chip); - if (!ret) - chip->enabled =3D enable; - else - disable_eud(chip); - + if (ret) { + dev_err(chip->dev, "failed to enable eud\n"); + return ret; + } } else { ret =3D disable_eud(chip); + if (ret) { + dev_err(chip->dev, "failed to disable eud\n"); + return ret; + } } =20 - return ret < 0 ? ret : count; + chip->enabled =3D enable; + + return count; } =20 static DEVICE_ATTR_RW(enable); --=20 2.34.1