From nobody Thu Apr 9 09:34:31 2026 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D1363B95E9 for ; Mon, 9 Mar 2026 18:47:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773082028; cv=none; b=TYoiEkMv5SCEC7H/0Hks00jYo1FNaJU//fFvHz+cz/wHU0RziWLQ1l1s/98qKem1IKhHlTAFB6VJoBlMj8AgG4FJ3sG4dbEc2AkB+ixfcpYhgI2XF3+SA7sq5rhfYKfSHvXPf7gYeJ6ph1i3D1NzSBv0DhS6Law2iItP4EuOj/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773082028; c=relaxed/simple; bh=YUwDKVuaod6e/PKMa3LFkP3fBK1rG/UFWBdQt4zgyd8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=sRvZNLKzViy6nQFI123q8aFPYaUgX8YSdHPWGIZfJqJVakMiHYxX0JYfkg4LrJy0b/fneO8fwjTf7F90NPU/dzdmDFL34Ee6PZ4eNNvQwGatLBJ5Pm+kyGXglVO/S5hYJuljw4hwCYmxMvmwb2pp+/AqtiwcU/ln6N7WMpmUvCg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nA9qq+e1; arc=none smtp.client-ip=209.85.221.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nA9qq+e1" Received: by mail-wr1-f67.google.com with SMTP id ffacd0b85a97d-439bcec8613so6303931f8f.3 for ; Mon, 09 Mar 2026 11:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773082025; x=1773686825; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=k2c1e+cr1MK5fkAIaVFhuig+jMcTHc2i1DpO1ijKNSs=; b=nA9qq+e1MsjKhVc8/mqFXq+bITtv4KP68TM/GeVk9ph9XMRg/IjEwJLvM7Fr4BJzg1 60TrSPIY9NyiRaAHca4Pp9glm5/XlxhHsy/64RhN258bynMLiInaYJr5JkrZ8H41BDtW qVInJDmH1rECj71mZYVxm1cPKda37tcwIxYfO2R8s3UGLoXgnv8U7CJSkTMdLOKDcETG rq5K/1NX5E7DKf3VjpXY9hEwjuo92Eq2jrJ01hS5sKhHCkK60lymWuflm0YmQoMbJAf+ 6BXJ7waHKSn8AUt1C3l0agymyMP/U42JaQLN+gDHDZqW3/2IeJappSrHj15RJhmAk+2w +6jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773082025; x=1773686825; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k2c1e+cr1MK5fkAIaVFhuig+jMcTHc2i1DpO1ijKNSs=; b=aUubAMtAQYNE+ymLpNiWiSN1PtCG6oq/SiXv09/KaDi/0FdgW37HZUEVctwBtnRTVR b45Npcl2/7JyfV2tiMpOTPRGZohpODx1zfibM8iz6b5ZMS8wRiHuvEf97Pao8/EKVPas 8u3Ceb1AczGfrYedEZaiGNx3af4aZwX5yajRlg9eka2xVBIieLLJog5E6UFvazJzR1Od tgQfzF1jhVsLsgDC2q0pU+SMW1jb5rShIumnwKW/Yc+0yahz5u7uii+YwNaEMtWixk4z vfaFHuTjcRh1pC0L6gZPzmb47BKnMOUThNMPT7ZRfeyblxLKrsbTIsgO7fOGAWEpD+iX 8Aog== X-Forwarded-Encrypted: i=1; AJvYcCWCUytry/HSsAypaOt+id4gA8OeyR916Z/zTHNKf0q8Mr4MAapuqQHi37L7RxrNzXGEs7gHtfB84Zty1pY=@vger.kernel.org X-Gm-Message-State: AOJu0YybXwnz70Xg4oSqOchmoBKX85L6wS1BZeu/AjurX1K2OIHKJ4mC pgkoSypOFp49rY9kcgLqXSRWlUXWxSTYcVnMi8bUvN63FHDgnkxJ46Jf X-Gm-Gg: ATEYQzxtTW5ZIiQlIof09SyxwtUfh7wAWtbAHYTmlhiPb9DgcuLHFzgD1NAH1x1PxXS hBeMioALntpfG/YFbmho/wk5wdV27tMnu24VulGuRThLCqWNleIQr7iQ3mozGRirTbEH9tRvXJK dkZPieyx2ofwdqdNMoyO+du992FbdDMTDZ3SSh8VrGxwe66IOPkCfMLDuPJrJ/i8VYYoCcev9jH ycuQ5qTOd9P3aQ6O/QK4tJMnWqqS05Ykcg3iF6uMEHwpG25g1OgPdglmANfd7KvDdcBuF7cNTFk Nw405wAk8yOJpTxcotFpFxt6AmfsMGQ6Z2XYb611Rq7Hl1+hnTfjaHfXIJSr/z/psdu3XTdehvz yIU539KFQy2xomESmxZdRcRAsrbWhKZEKPWci5s6xzJ+bNbfPZnSEfw5ModHb1OrllJXr+GWCIf aLLDv0UpNivaeEG5PGf+COfReFCuKqyziW3ThAitqI X-Received: by 2002:a05:6000:2285:b0:432:5c34:fb32 with SMTP id ffacd0b85a97d-439da35c729mr20629123f8f.23.1773082025370; Mon, 09 Mar 2026 11:47:05 -0700 (PDT) Received: from DESKTOP-BTQF5RC.localdomain ([85.110.79.247]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae46353sm33212432f8f.33.2026.03.09.11.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 11:47:05 -0700 (PDT) From: =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, Yeking@Red54.com, hansg@kernel.org, andriy.shevchenko@linux.intel.com, ethantidmore06@gmail.com, weibu@redadmin.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= Subject: [PATCH v2] staging: rtl8723bs: change custom comparing function to strcmp() Date: Mon, 9 Mar 2026 21:45:56 +0300 Message-ID: <20260309184556.846-2-b9788213@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable eqNByte() function is a redundant reimplementation of strcmp(). Remove eqNByte() and switch its usages to strcmp(). No functional change. Reviewed-by: Andy Shevchenko Signed-off-by: Bera Y=C3=BCzl=C3=BC --- V2: Used strcmp() instead of memcmp() V1 link: https://lore.kernel.org/linux-staging/20260227200637.47130-1-b9788= 213@gmail.com/ drivers/staging/rtl8723bs/hal/hal_com.c | 12 ------------ .../staging/rtl8723bs/hal/hal_com_phycfg.c | 19 ++++++++++--------- drivers/staging/rtl8723bs/include/hal_com.h | 2 -- 3 files changed, 10 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 31b3e880a..a7720f821 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -750,18 +750,6 @@ void SetHalODMVar( } =20 =20 -bool eqNByte(u8 *str1, u8 *str2, u32 num) -{ - if (num =3D=3D 0) - return false; - while (num > 0) { - num--; - if (str1[num] !=3D str2[num]) - return false; - } - return true; -} - bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8 *pInt) { u16 i =3D 0; diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index dc2da49e6..61c6b6e10 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -8,6 +8,7 @@ #include #include #include +#include =20 u8 PHY_GetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath, enum rate_section RateSection) @@ -819,27 +820,27 @@ void PHY_SetTxPowerLimit( =20 powerLimit =3D powerLimit > MAX_POWER_INDEX ? MAX_POWER_INDEX : powerLimi= t; =20 - if (eqNByte(Regulation, (u8 *)("FCC"), 3)) + if (strcmp(Regulation, "FCC") =3D=3D 0) regulation =3D 0; - else if (eqNByte(Regulation, (u8 *)("MKK"), 3)) + else if (strcmp(Regulation, "MKK") =3D=3D 0) regulation =3D 1; - else if (eqNByte(Regulation, (u8 *)("ETSI"), 4)) + else if (strcmp(Regulation, "ETSI") =3D=3D 0) regulation =3D 2; - else if (eqNByte(Regulation, (u8 *)("WW13"), 4)) + else if (strcmp(Regulation, "WW13") =3D=3D 0) regulation =3D 3; =20 - if (eqNByte(RateSection, (u8 *)("CCK"), 3) && eqNByte(RfPath, (u8 *)("1T"= ), 2)) + if (strcmp(RateSection, "CCK") =3D=3D 0 && strcmp(RfPath, "1T") =3D=3D 0) rateSection =3D 0; - else if (eqNByte(RateSection, (u8 *)("OFDM"), 4) && eqNByte(RfPath, (u8 *= )("1T"), 2)) + else if (strcmp(RateSection, "OFDM") =3D=3D 0 && strcmp(RfPath, "1T") =3D= =3D 0) rateSection =3D 1; - else if (eqNByte(RateSection, (u8 *)("HT"), 2) && eqNByte(RfPath, (u8 *)(= "1T"), 2)) + else if (strcmp(RateSection, "HT") =3D=3D 0 && strcmp(RfPath, "1T") =3D= =3D 0) rateSection =3D 2; else return; =20 - if (eqNByte(Bandwidth, (u8 *)("20M"), 3)) + if (strcmp(Bandwidth, "20M") =3D=3D 0) bandwidth =3D 0; - else if (eqNByte(Bandwidth, (u8 *)("40M"), 3)) + else if (strcmp(Bandwidth, "40M") =3D=3D 0) bandwidth =3D 1; =20 channelIndex =3D phy_GetChannelIndexOfTxPowerLimit(channel); diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/= rtl8723bs/include/hal_com.h index 74d6c892c..483f0390a 100644 --- a/drivers/staging/rtl8723bs/include/hal_com.h +++ b/drivers/staging/rtl8723bs/include/hal_com.h @@ -141,8 +141,6 @@ void rtw_hal_check_rxfifo_full(struct adapter *adapter); u8 GetHalDefVar(struct adapter *adapter, enum hal_def_variable variable, void *value); =20 -bool eqNByte(u8 *str1, u8 *str2, u32 num); - bool GetU1ByteIntegerFromStringInDecimal(char *str, u8 *in); =20 #define HWSET_MAX_SIZE 512 --=20 2.43.0