From nobody Fri Apr 3 06:25:02 2026 Received: from mail-yx1-f42.google.com (mail-yx1-f42.google.com [74.125.224.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67263401499 for ; Mon, 9 Mar 2026 17:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773078966; cv=none; b=B5rhdsvjuGeUalWLwaQBzDUHxEER7bwbXas+g+23HUgu6zvldtlay2mIP+peHTwLsrq+KWtQeK0A0N5033OjIhA5XGl7J4o1+p2qGY40CoAvFxpiwb9tx3BRspbeo1S+mkRfdQdb6UPNPFpxEuRk73bxLRMlGIPEUwz6bjC3nbY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773078966; c=relaxed/simple; bh=Srv1ikITokT9OVyx2gFl2fZqBR0h7zamS7/rBlEZHVw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WFBHnKYVqcDDYbT6yJ0sgV30xJaropG4UqwPPYHxwGkTeOUv4YmS1et5BvKr7ikAlx4SfG+mec1TuCeblnWYiQ1BZ0zt7BstDV1pDsK9Dez66X5epmcYUpCR2Mx7aEg8iM8MGCegJzc/u4IN19SY9UqfCCgh9BhEPUvn+Lfs46c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ncsu.edu; spf=pass smtp.mailfrom=ncsu.edu; dkim=pass (2048-bit key) header.d=ncsu.edu header.i=@ncsu.edu header.b=APEpG2+K; arc=none smtp.client-ip=74.125.224.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ncsu.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ncsu.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ncsu.edu header.i=@ncsu.edu header.b="APEpG2+K" Received: by mail-yx1-f42.google.com with SMTP id 956f58d0204a3-64acd19e1dfso10050136d50.0 for ; Mon, 09 Mar 2026 10:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ncsu.edu; s=google; t=1773078961; x=1773683761; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lS3bf96XLrwY4W7aIs+xdKEyTPWgsbIOpYmGdzST5mA=; b=APEpG2+KCeYIz1dHuRl7ldzSW0xmfgd/+q82tjpX7xAWbKfR5byHIHHVYMc57MDkaz 6i6FLK5dhOkrAd4DCCN2sWwb6+LMGUe6rccILLrFRWoxE4rlTJkN6VJCbtYIhdbDnLVZ E6h5bwbPN1x7RvH61KhfO5YZk0ADlQkaxRxSf/aiP6/cfteogfaSqyEGv2+kcbMse1PQ K5YXochunxONnbPzqwyO2+CQS1gNPjbwjnaHJ1b4hiLYISxHGPbuiXT1uXYsJx2h6/zF KJJV/eR8KBX8sthup01ELzWZ1E4LmEt3CTZFgIf24QO1g/pQHYR6AA8cTElruLyjAqID KcyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773078961; x=1773683761; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lS3bf96XLrwY4W7aIs+xdKEyTPWgsbIOpYmGdzST5mA=; b=C6JD04JyeBKrKDlExyoJRk8o+CR04xUEzl4TgFLU77ZFdXk+oidhnta/EFIR30uHve AGyykgYmx4kknAkphAwJrx8JjPnySmCPUmkXewN09i6pDpvqH6j0eSanqFfyJGR6fXai geZ5hIjnh4UkrkBX7LH80/nfkSbUL1TDxmtkWuAoNHvqNJWHwMNEd4HAbZNR7njHTQus ezvs8eo+2hcb8c7q3pKhdxpjGt28pfTYhO/Y4H1kOJniC5b/M7gwYjgkG2DucYG+KVLa +XruyIRS0Ai+38CnznzsrkTwciJAaT8KI68LjsPdsaaq5qeQWwROMNBD+anigpe9HpDm TxYA== X-Forwarded-Encrypted: i=1; AJvYcCWHDPaljAz9A629kuZdPoLyShheyjDLeMxz6Bgn1gilDV00XRrPURC9rm5H2U04egWrLZXc7y31jDOHOXM=@vger.kernel.org X-Gm-Message-State: AOJu0YzcK6+BObXo1f2Mad6ubWWsxMIHLS9v5CMg1W6TFAaMPQRidk7W qdW5VWf+DywN6959BBrB2RYUR96khPW6/EAYaRETqSwEYaw72n2OUsMAHS97dLFLzg== X-Gm-Gg: ATEYQzyy7VXVr28CCwrX4O25WIgm/j97CLJhEATsy230b7y4j7nT5SUeuYmNK8MGfZK K9eCgiwI/nAZ0DYX6MpXr+HVfNy1nBnVOroz/Bo873OLNcuu8aoGBfDt+c8QbeUrcDmUxX/OsEZ gByjfPHVi/eiAdMOA9+o2pQmi326za97Gw7qLOpVrVpYQVRHwMzUzlUjQrxh/ZnEfAKLyZYcOwR Xw9i4xTbiwEVK+F7n7rBCAscg8dE6i83tuP/LC8SgH354xVFxVqzyvlaaewXVRYrcQziuEukLgv OHX2jp0pgruSQzm2NNNwGcGCpzoo7mO5NUYGPcNptxK05OTB6cn1L6SkWfcqYxLgOdhGL/kPRqL aeyNYX94AUgYy3CbgXSak+1kCGGn0jRlpPMGWu5YzZU6PjysNXFXNoqVfr3tyH/M7GbIz2+vGlC KUYlaldeTILP7YpMogmT0I+2g3JW87GCmy4L2+WyEVhFanNUeyKHQZfgWp X-Received: by 2002:a05:690e:e11:b0:64c:b44e:dfe0 with SMTP id 956f58d0204a3-64d1407f8c9mr9466801d50.13.1773078961107; Mon, 09 Mar 2026 10:56:01 -0700 (PDT) Received: from um773-cachyos.sd.ncsu.edu ([152.7.255.206]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64d176e70e7sm4992535d50.20.2026.03.09.10.56.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 10:56:00 -0700 (PDT) From: Zecheng Li To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim Cc: Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Zecheng Li , xliuprof@google.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 09/11] perf annotate-data: Invalidate caller-saved regs for all calls Date: Mon, 9 Mar 2026 13:55:22 -0400 Message-ID: <20260309175546.916039-10-zli94@ncsu.edu> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309175546.916039-1-zli94@ncsu.edu> References: <20260309175546.916039-1-zli94@ncsu.edu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Previously, the x86 call handler returned early without invalidating caller-saved registers when the call target symbol could not be resolved (func =3D=3D NULL). This violated the ABI which requires caller-saved registers to be considered clobbered after any call instruction. Fix this by: 1. Always invalidating caller-saved registers for any call instruction (except __fentry__ which preserves registers) 2. Using dl->ops.target.name as fallback when func->name is unavailable, allowing return type lookup for more call targets This is a conservative change that may reduce type coverage for indirect calls (e.g., callq *(%rax)) where we cannot determine the return type but it ensures correctness. Signed-off-by: Zecheng Li --- tools/perf/util/annotate-arch/annotate-x86.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/tools/perf/util/annotate-arch/annotate-x86.c b/tools/perf/util= /annotate-arch/annotate-x86.c index eb390a253d71..df9fc0a51b39 100644 --- a/tools/perf/util/annotate-arch/annotate-x86.c +++ b/tools/perf/util/annotate-arch/annotate-x86.c @@ -229,24 +229,31 @@ static void update_insn_state_x86(struct type_state *= state, =20 if (ins__is_call(&dl->ins)) { struct symbol *func =3D dl->ops.target.sym; + const char *call_name; =20 - if (func =3D=3D NULL) - return; + /* Try to resolve the call target name */ + if (func) + call_name =3D func->name; + else + call_name =3D dl->ops.target.name; =20 /* __fentry__ will preserve all registers */ - if (!strcmp(func->name, "__fentry__")) + if (call_name && !strcmp(call_name, "__fentry__")) return; =20 - pr_debug_dtp("call [%x] %s\n", insn_offset, func->name); + if (call_name) + pr_debug_dtp("call [%x] %s\n", insn_offset, call_name); + else + pr_debug_dtp("call [%x] \n", insn_offset); =20 - /* Otherwise invalidate caller-saved registers after call */ + /* Invalidate caller-saved registers after call (ABI requirement) */ for (unsigned i =3D 0; i < ARRAY_SIZE(state->regs); i++) { if (state->regs[i].caller_saved) invalidate_reg_state(&state->regs[i]); } =20 /* Update register with the return type (if any) */ - if (die_find_func_rettype(cu_die, func->name, &type_die)) { + if (call_name && die_find_func_rettype(cu_die, call_name, &type_die)) { tsr =3D &state->regs[state->ret_reg]; tsr->type =3D type_die; tsr->kind =3D TSR_KIND_TYPE; --=20 2.53.0