From nobody Thu Apr 9 10:30:35 2026 Received: from mail-yx1-f42.google.com (mail-yx1-f42.google.com [74.125.224.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E13931AAAA for ; Mon, 9 Mar 2026 16:55:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773075328; cv=none; b=G+2DugMuPh6E4BGHO+0eeh/ZxRAl/pedsNi1BkPGAEpM1oUoD8jN2YABW0qxrNFooVgT35nQSYujYEp76+bQCEPf6zzR7H0DItaGwyk7yJYMoKXIxurSN0rx6pi6dGvt9sDxUAKIE5uHcXHbSoGS7LylA3af636CyXk6WmKA+qU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773075328; c=relaxed/simple; bh=txkFDzhkAuXn4Y/B9Q37wQHuNsIAMI8pitGZnqd1az8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=W+0IuBHDe4bhMDMVoZtCEUIjkDfK9mwPTTw+exaik25dbbevztNuEWTe8I9BXT/h1x3DszmygPAiVoClTtJEQ1PLPSVZDbT2Aj/j9mm3XcGpQLjySmjP9XCwWmoukcZvyKm4SiZAMBCnMEqfNqGBk19MCK3lN4EFdt+SLByR39A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jAXHQSUr; arc=none smtp.client-ip=74.125.224.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jAXHQSUr" Received: by mail-yx1-f42.google.com with SMTP id 956f58d0204a3-64c9707fc11so8774242d50.2 for ; Mon, 09 Mar 2026 09:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773075326; x=1773680126; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LaWZMdjFEQ20IaqsZlhzMluUuWd0tbi4PXrKIMmPnEc=; b=jAXHQSUr/n6rZUv5vK4oI62uIZCNz7uYKxrlOIULuNN8rnSQg53biecokXQSxwmwOC Gs0zC5WMSefjjhk2WY8skSUV5yzhIo+fsrizS3E+fM4WFRxNFUIphfJBqx2mZeROhXip Pwdwv13JpmIaG8juuZA51DBiJAGXlWbl9fC/XD8Xj9HguLp/hpqUWK8biGwfveeAJwM1 a5suVbgYNYizyYhlQFH5/bW7qSMmUB55mpK0RNDA88Um2rC12KWSJVHQnsy8Lb1FK4zq yNa8OBeUzCw3S6ywQt9AoUMMciY9QoKI7nd7xBAR1J2OCdRKV+tKVBb5pHpSVbaaVkve gL/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773075326; x=1773680126; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LaWZMdjFEQ20IaqsZlhzMluUuWd0tbi4PXrKIMmPnEc=; b=SME5cZNWwXyRSdR146M0PF9LoJie1Dn8J5apRlOTH+L7NDqbyiLlaCXAL8yGKlMWC7 IzoIkAUTBhER9pwsPfgFbqWA6yaaiEfR5x9Nh281EUQ6a0F4PQpHJicrl52BwFKLp7SC 1Y7l99bedKvYB8pTqjoPUv+VNXn8FtFkkNn+9eum/7bq4lGeKSw9QGJvrJFoWgmjpNYY GfW+MTsIqVWH074Su0GN3seklOw3DgNKtuMEjU7fdilqS58abM/GFU/NPbbQUTjoxl6M fNrI4t3cDE7ulJIM71BaKX96vs8GLM0eoGyvnw1em+MWm7YjypvT+hoYixsaZvGhDncp OV5g== X-Forwarded-Encrypted: i=1; AJvYcCX4yJ7ch7IgI8kRNML7xGIYLG1mAVQXoP7nBaOD5y3KoUuH/oiJfLd9IADMfvlSa93DdRcph4W1dRoGst8=@vger.kernel.org X-Gm-Message-State: AOJu0YwduNfn6glgCJfyid0ioMceFg8BPgSylqynQMNg++2Gc6m0bbfC A8ykn27njspXah6sFTZgHoIw1N/DI8pKfjOa/nX7AdhachlDKCtDDwBM X-Gm-Gg: ATEYQzzbuLnXHOdwrvpLweit9gakwFjOpsiiedF9/8MWcDyDB5AvUM3PFTfe5NkYvLY 2qpbn5CTH5tYSGfK2V0y3UUv8ac3FjAf/2cA7rThDpuWLR6kw6J+OG6ZX5vv3AtWV8vKb1Jv/iC 7AQJ/c5GUtm6WndRz0JFikwuh/uN2cS/inn1Zsi4xPvvl1sN//CnE5g+6YwmzEnIP4IeprkKoV1 iCdgfVWDzEzIo0FSPPJWlSfP2Ml56I3HDusL6BrJviRrXX7y4Ys/LGOKZRjn03Wc3BlFoOUHTlo n9nJKMuDRW8SyDPXdgrOuGUu8OGR+5gNWHYfxfG2F+czDi2nezVWTnT1gOmMXNlENNBPEub5LOC h/02QC+4W3Qe73hl9LrRcXUZPJx5gdYSzXPGqud11NVe3YQdiAwPer47mIdW14s+jbpezKfuKt0 4NtwDPI+EAdjJdyQ== X-Received: by 2002:a53:b1a4:0:b0:64c:c34c:60ea with SMTP id 956f58d0204a3-64d1429cc22mr8177078d50.54.1773075326224; Mon, 09 Mar 2026 09:55:26 -0700 (PDT) Received: from horus ([138.97.160.237]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64d175d325dsm4910307d50.4.2026.03.09.09.55.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 09:55:25 -0700 (PDT) From: Luis Soza Rodriguez X-Google-Original-From: Luis Soza Rodriguez To: pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luis Soza Rodriguez Subject: [PATCH] staging: greybus: loopback: use sysfs_emit in sysfs show functions Date: Mon, 9 Mar 2026 10:55:22 -0600 Message-ID: <20260309165522.26388-1-contact@sluisr.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the kernel's documentation, sysfs_emit() is the preferred way to format strings for sysfs attributes. It handles buffer overruns safely. Replace sprintf calls with sysfs_emit across all loopback sysfs show macros. Signed-off-by: Luis Soza Rodriguez --- drivers/staging/greybus/loopback.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/l= oopback.c index aa9c73cb0..3a502d89d 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -125,7 +125,7 @@ static ssize_t field##_show(struct device *dev, \ char *buf) \ { \ struct gb_loopback *gb =3D dev_get_drvdata(dev); \ - return sprintf(buf, "%u\n", gb->field); \ + return sysfs_emit(buf, "%u\n", gb->field); \ } \ static DEVICE_ATTR_RO(field) =20 @@ -137,8 +137,8 @@ static ssize_t name##_##field##_show(struct device *dev= , \ struct gb_loopback *gb =3D dev_get_drvdata(dev); \ /* Report 0 for min and max if no transfer succeeded */ \ if (!gb->requests_completed) \ - return sprintf(buf, "0\n"); \ - return sprintf(buf, "%" #type "\n", gb->name.field); \ + return sysfs_emit(buf, "0\n"); \ + return sysfs_emit(buf, "%" #type "\n", gb->name.field); \ } \ static DEVICE_ATTR_RO(name##_##field) =20 @@ -158,7 +158,7 @@ static ssize_t name##_avg_show(struct device *dev, \ rem =3D do_div(avg, count); \ rem *=3D 1000000; \ do_div(rem, count); \ - return sprintf(buf, "%llu.%06u\n", avg, (u32)rem); \ + return sysfs_emit(buf, "%llu.%06u\n", avg, (u32)rem); \ } \ static DEVICE_ATTR_RO(name##_avg) =20 @@ -173,7 +173,7 @@ static ssize_t field##_show(struct device *dev, \ char *buf) \ { \ struct gb_loopback *gb =3D dev_get_drvdata(dev); \ - return sprintf(buf, "%" #type "\n", gb->field); \ + return sysfs_emit(buf, "%" #type "\n", gb->field); \ } \ static ssize_t field##_store(struct device *dev, \ struct device_attribute *attr, \ @@ -199,7 +199,7 @@ static ssize_t field##_show(struct device *dev, \ char *buf) \ { \ struct gb_loopback *gb =3D dev_get_drvdata(dev); \ - return sprintf(buf, "%u\n", gb->field); \ + return sysfs_emit(buf, "%u\n", gb->field); \ } \ static DEVICE_ATTR_RO(field) =20 @@ -209,7 +209,7 @@ static ssize_t field##_show(struct device *dev, \ char *buf) \ { \ struct gb_loopback *gb =3D dev_get_drvdata(dev); \ - return sprintf(buf, "%" #type "\n", gb->field); \ + return sysfs_emit(buf, "%" #type "\n", gb->field); \ } \ static ssize_t field##_store(struct device *dev, \ struct device_attribute *attr, \ --=20 2.53.0