From nobody Thu Apr 9 10:36:11 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45CA73E3DA0 for ; Mon, 9 Mar 2026 15:59:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773071961; cv=none; b=tnwIXZt5q0RsR+du3MH5pn652qlYIksjohTBdRmlNd94UB2G+kCrZsn8y2matSI/zxPPOIis0Sr+KCB3Azd07nlUeHr0Ax3ZnzH+cVGQw760LHO9ldBHzllmnuQ4Qn63mLPoMR4awtJZQx37iRJp25yE9DU2B+OopNG4eNCpcXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773071961; c=relaxed/simple; bh=lPqkw/giSEVhhB4XxhbF67RO08+rKdZ8faKS90IIt2w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rkpGplHxY+WRitXR9gYuqbozwn6m/gUpJhdbGu595bF+XVngNHei/XuiQ7U8Xtl5Yxfn5IWZqEbv1i7S7WRI75QAa01Fv0J9CU5XRJQZS8aNbCJ76FdEh+2lNIV5R/ozePSNqkpcAeHeVcNi0e9N9HzHnuoOWgcwmcHtmqco3Uk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dHAbe4aY; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dHAbe4aY" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ae43042ea7so94957005ad.0 for ; Mon, 09 Mar 2026 08:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773071960; x=1773676760; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7PxMDgkvJf2sOnKzb29tD1hrzKH7WJBADnay5nniLmY=; b=dHAbe4aYkqRqqtca2dK8qPI9OXgK9jgkFP/Zox285yN9FGxWTZc/0qe5a95oM9av/Q Bvfckb54U9e93mxzppwVR1QlSJZ/XRrW38bzMoCXMmfYYg9sHvZ/SWNvNkXItQal4RnT YvyHWxwneKlL7i+twMqn2kzpQrQCEoe/2ej3EoFyfGHnHAd1EUfmwEj27pnXuMtg++CM VX2hfdctoH4KBE4mYuWC9pwgKYknC5uHPc0EzSuRuAiRtAyw0jrQS0znPS9jgoXHfwl6 DT+YblALdjacoM23bvM74B7N6iL7Je7D5K/8ylnr09z9WVxrWyKIj6brAO9hBh3EfroE HEQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773071960; x=1773676760; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7PxMDgkvJf2sOnKzb29tD1hrzKH7WJBADnay5nniLmY=; b=kdFbPh5jhkvi4afsEw1dXJ+SGwt2eNdrw4NJXeApeieXOeYrxUs+nIgEYrvWgM4MrQ 3oW9BqofiIMPMXQVHWOA+NN5WKY3Kl+zVK30sgfAnjFB9VOa2IXKaG6qPjHP+Kp3k1Tw cwwzDWQ0cdj+I0Q1upk6onwtMd01hYxPfIVsGjWKyq+1TApTXaJ4yEqWubaKAUMw7aEF 5CfpckhNfv9boXvGHQcW8rJicZi1Y/78g+tknszWgPjz5Xdcdw+/kXrBEwVxwRRjp024 3uFmg46WqNs4/hSsSXKOoU5bPSW5eFZeTM6ROe0mQsCyb+1GLh4s1Ag+B2vQT5zO8edA A6zQ== X-Forwarded-Encrypted: i=1; AJvYcCX+Wqx8+KDs9q2amLIZRRR41nN6XIAav2y+qSh+xeY6v1YdN213/KWP8ofaO541DO7TudsEKhgSqSgkRns=@vger.kernel.org X-Gm-Message-State: AOJu0YyB6Mk12IspFJAk2tPfEVMglBDF9634KdeJ4vyv+YIoP0PM4GcA 7E+/xtwUB26Cv5BJ+8iX/4BCHAKn4YU0UOgmP7OuCWS5xlfED+0cK6Nr X-Gm-Gg: ATEYQzy9gcwboTj/K5kYdVqshkqKVYmHr/YOzEVj2qPHrXXOO/2rW7YRSSPIXC9Ur2t CL20iyxtBD6+cTWBKCy03bldm72Zii+uCwK+f1mmsp/GNBNztFV5972wWfhHainju2u8SZTzHO6 9D0J9Yvi+JI3Onc35r/f3FFlDzcCDgHn9D9e+d+Lew+jwaJsHrpG1IG+SaiOjL1EOtsxHU0rUp6 K3BpDwIPEUiYtfpIbMnAWpmwuO1zr/w3QOAmbiiMftzTLkuES37Bm4IBm4mpt3DNV3CbYvY67AH 8PeQA9k4v+qd3BtAQbzNh/WUDW7biC4MRktBceYQ1q3W1zMxQJkuKMT+j+9VWDTk5KK0ex87BF/ LYzm1Ny8N62mfKCpuS8BpwxMvmO+7n1OgU50XqJ/fetqkPfwoz7+2ezR9MlT3Nk0Q1GbgQXmRYw D3iPCMAnG6UQWdpi8M7FqWC+0GI584Pn7Ap2JrLZaK614++QqBBOurcZXQCrKQt8hNegC6xfNZL KK6MKU= X-Received: by 2002:a17:902:e545:b0:2ae:5c3d:b07d with SMTP id d9443c01a7336-2ae824bd5b7mr114036545ad.57.1773071959398; Mon, 09 Mar 2026 08:59:19 -0700 (PDT) Received: from deepanshu-kernel-hacker.. ([2405:201:682f:389d:9c3b:4864:d890:cdd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f74e4fsm122403265ad.58.2026.03.09.08.59.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 08:59:18 -0700 (PDT) From: Deepanshu Kartikey To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org Cc: mingo@kernel.org, tglx@kernel.org, jiayuan.chen@shopee.com, kees@kernel.org, netdev@vger.kernel.org, dan.carpenter@linaro.org, linux-kernel@vger.kernel.org, Deepanshu Kartikey , syzbot+f50072212ab792c86925@syzkaller.appspotmail.com Subject: [PATCH v2] atm: lec: fix use-after-free in sock_def_readable() Date: Mon, 9 Mar 2026 21:29:08 +0530 Message-ID: <20260309155908.508768-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A race condition exists between lec_atm_close() setting priv->lecd to NULL and concurrent access to priv->lecd in send_to_lecd(), lec_handle_bridge(), and lec_atm_send(). When the socket is freed via RCU while another thread is still using it, a use-after-free occurs in sock_def_readable() when accessing the socket's wait queue. The root cause is that lec_atm_close() clears priv->lecd without any synchronization, while callers dereference priv->lecd without any protection against concurrent teardown. Fix this by converting priv->lecd to an RCU-protected pointer: - Mark priv->lecd as __rcu in lec.h - Use rcu_assign_pointer() in lec_atm_close() and lecd_attach() for safe pointer assignment - Use rcu_access_pointer() for NULL checks that do not dereference the pointer in lec_start_xmit(), lec_push(), send_to_lecd() and lecd_attach() - Use rcu_read_lock/rcu_dereference/rcu_read_unlock in send_to_lecd(), lec_handle_bridge() and lec_atm_send() to safely access lecd - Use rcu_assign_pointer() followed by synchronize_rcu() in lec_atm_close() to ensure all readers have completed before proceeding. This is safe since lec_atm_close() is called from vcc_release() which holds lock_sock(), a sleeping lock. - Remove the manual sk_receive_queue drain from lec_atm_close() since vcc_destroy_socket() already drains it after lec_atm_close() returns. v2: Switch from spinlock + sock_hold/put approach to RCU to properly fix the race. The v1 spinlock approach had two issues pointed out by Eric Dumazet: 1. priv->lecd was still accessed directly after releasing the lock instead of using a local copy. 2. The spinlock did not prevent packets being queued after lec_atm_close() drains sk_receive_queue since timer and workqueue paths bypass netif_stop_queue(). Note: Syzbot patch testing was attempted but the test VM terminated unexpectedly with "Connection to localhost closed by remote host", likely due to a QEMU AHCI emulation issue unrelated to this fix. Compile testing with "make W=3D1 net/atm/lec.o" passes cleanly. Reported-by: syzbot+f50072212ab792c86925@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3Df50072212ab792c86925 Link: https://lore.kernel.org/all/20260309093614.502094-1-kartikey406@gmail= .com/T/ [v1] Signed-off-by: Deepanshu Kartikey Reviewed-by: Eric Dumazet --- net/atm/lec.c | 70 +++++++++++++++++++++++++++++++++------------------ net/atm/lec.h | 2 +- 2 files changed, 46 insertions(+), 26 deletions(-) diff --git a/net/atm/lec.c b/net/atm/lec.c index fb93c6e1c329..32adf28663a0 100644 --- a/net/atm/lec.c +++ b/net/atm/lec.c @@ -154,10 +154,19 @@ static void lec_handle_bridge(struct sk_buff *skb, st= ruct net_device *dev) /* 0x01 is topology change */ =20 priv =3D netdev_priv(dev); - atm_force_charge(priv->lecd, skb2->truesize); - sk =3D sk_atm(priv->lecd); - skb_queue_tail(&sk->sk_receive_queue, skb2); - sk->sk_data_ready(sk); + struct atm_vcc *vcc; + + rcu_read_lock(); + vcc =3D rcu_dereference(priv->lecd); + if (vcc) { + atm_force_charge(vcc, skb2->truesize); + sk =3D sk_atm(vcc); + skb_queue_tail(&sk->sk_receive_queue, skb2); + sk->sk_data_ready(sk); + } else { + dev_kfree_skb(skb2); + } + rcu_read_unlock(); } } #endif /* IS_ENABLED(CONFIG_BRIDGE) */ @@ -216,7 +225,7 @@ static netdev_tx_t lec_start_xmit(struct sk_buff *skb, int is_rdesc; =20 pr_debug("called\n"); - if (!priv->lecd) { + if (!rcu_access_pointer(priv->lecd)) { pr_info("%s:No lecd attached\n", dev->name); dev->stats.tx_errors++; netif_stop_queue(dev); @@ -449,10 +459,19 @@ static int lec_atm_send(struct atm_vcc *vcc, struct s= k_buff *skb) break; skb2->len =3D sizeof(struct atmlec_msg); skb_copy_to_linear_data(skb2, mesg, sizeof(*mesg)); - atm_force_charge(priv->lecd, skb2->truesize); - sk =3D sk_atm(priv->lecd); - skb_queue_tail(&sk->sk_receive_queue, skb2); - sk->sk_data_ready(sk); + struct atm_vcc *vcc; + + rcu_read_lock(); + vcc =3D rcu_dereference(priv->lecd); + if (vcc) { + atm_force_charge(vcc, skb2->truesize); + sk =3D sk_atm(vcc); + skb_queue_tail(&sk->sk_receive_queue, skb2); + sk->sk_data_ready(sk); + } else { + dev_kfree_skb(skb2); + } + rcu_read_unlock(); } } #endif /* IS_ENABLED(CONFIG_BRIDGE) */ @@ -468,23 +486,16 @@ static int lec_atm_send(struct atm_vcc *vcc, struct s= k_buff *skb) =20 static void lec_atm_close(struct atm_vcc *vcc) { - struct sk_buff *skb; struct net_device *dev =3D (struct net_device *)vcc->proto_data; struct lec_priv *priv =3D netdev_priv(dev); =20 - priv->lecd =3D NULL; + rcu_assign_pointer(priv->lecd, NULL); + synchronize_rcu(); /* Do something needful? */ =20 netif_stop_queue(dev); lec_arp_destroy(priv); =20 - if (skb_peek(&sk_atm(vcc)->sk_receive_queue)) - pr_info("%s closing with messages pending\n", dev->name); - while ((skb =3D skb_dequeue(&sk_atm(vcc)->sk_receive_queue))) { - atm_return(vcc, skb->truesize); - dev_kfree_skb(skb); - } - pr_info("%s: Shut down!\n", dev->name); module_put(THIS_MODULE); } @@ -510,12 +521,14 @@ send_to_lecd(struct lec_priv *priv, atmlec_msg_type t= ype, const unsigned char *mac_addr, const unsigned char *atm_addr, struct sk_buff *data) { + struct atm_vcc *vcc; struct sock *sk; struct sk_buff *skb; struct atmlec_msg *mesg; =20 - if (!priv || !priv->lecd) + if (!priv || !rcu_access_pointer(priv->lecd)) return -1; + skb =3D alloc_skb(sizeof(struct atmlec_msg), GFP_ATOMIC); if (!skb) return -1; @@ -532,18 +545,27 @@ send_to_lecd(struct lec_priv *priv, atmlec_msg_type t= ype, if (atm_addr) memcpy(&mesg->content.normal.atm_addr, atm_addr, ATM_ESA_LEN); =20 - atm_force_charge(priv->lecd, skb->truesize); - sk =3D sk_atm(priv->lecd); + rcu_read_lock(); + vcc =3D rcu_dereference(priv->lecd); + if (!vcc) { + rcu_read_unlock(); + kfree_skb(skb); + return -1; + } + + atm_force_charge(vcc, skb->truesize); + sk =3D sk_atm(vcc); skb_queue_tail(&sk->sk_receive_queue, skb); sk->sk_data_ready(sk); =20 if (data !=3D NULL) { pr_debug("about to send %d bytes of data\n", data->len); - atm_force_charge(priv->lecd, data->truesize); + atm_force_charge(vcc, data->truesize); skb_queue_tail(&sk->sk_receive_queue, data); sk->sk_data_ready(sk); } =20 + rcu_read_unlock(); return 0; } =20 @@ -618,7 +640,7 @@ static void lec_push(struct atm_vcc *vcc, struct sk_buf= f *skb) =20 atm_return(vcc, skb->truesize); if (*(__be16 *) skb->data =3D=3D htons(priv->lecid) || - !priv->lecd || !(dev->flags & IFF_UP)) { + !rcu_access_pointer(priv->lecd) || !(dev->flags & IFF_UP)) { /* * Probably looping back, or if lecd is missing, * lecd has gone down @@ -753,12 +775,12 @@ static int lecd_attach(struct atm_vcc *vcc, int arg) priv =3D netdev_priv(dev_lec[i]); } else { priv =3D netdev_priv(dev_lec[i]); - if (priv->lecd) + if (rcu_access_pointer(priv->lecd)) return -EADDRINUSE; } lec_arp_init(priv); priv->itfnum =3D i; /* LANE2 addition */ - priv->lecd =3D vcc; + rcu_assign_pointer(priv->lecd, vcc); vcc->dev =3D &lecatm_dev; vcc_insert_socket(sk_atm(vcc)); =20 diff --git a/net/atm/lec.h b/net/atm/lec.h index be0e2667bd8c..ec85709bf818 100644 --- a/net/atm/lec.h +++ b/net/atm/lec.h @@ -91,7 +91,7 @@ struct lec_priv { */ spinlock_t lec_arp_lock; struct atm_vcc *mcast_vcc; /* Default Multicast Send VCC */ - struct atm_vcc *lecd; + struct atm_vcc __rcu *lecd; struct delayed_work lec_arp_work; /* C10 */ unsigned int maximum_unknown_frame_count; /* --=20 2.43.0