From nobody Thu Apr 9 12:06:46 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1C5731B83B for ; Mon, 9 Mar 2026 15:34:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773070494; cv=none; b=UGK495YkmCU73a8ihbH/ugiyqD4XM/U4C732xDbLNiT1wGlpu0WdIB16I/Q6ova20sjJ8rSFMCykpCWHeBioBoK9hnSttlHJLZ5yWp/I2bSdz9pYydWyPhrtmy6k9XyHp84uhfDfXUOi/X0IyWWGItU6J+YHAiFCh+YrcApSk5s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773070494; c=relaxed/simple; bh=F3cLyKU+aCEV8LPCrPgFgnGx7rxodlQMavEUkf2SfO0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j3+oehbzecmwjQ3/bItZWJiqTzSHyhrFoSx5qD5a2TOztpnMzG/6+YEWiXElYnQOWUV1zgh03qFVzDiCcn2PhXVKjVbO+JkOaFkGdol3mgHcs06t4Qif5eTnBW7YFwforSxCXr80rkuHgF36g28tctm0O7t9ouzz3QGCDhG8Qs8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JP7dtz0I; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JP7dtz0I" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c70ea5e9e9dso4436241a12.1 for ; Mon, 09 Mar 2026 08:34:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773070493; x=1773675293; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2aTy0R+XTQKbHXXKr9Mnyna9OWj3RkjcnoZQYJLkb9g=; b=JP7dtz0Ig3QyfxodVaVQNmu3oJk5iKQPmqk0Mef4BqQUnzmBJyt7cowPOikhJ0qwOr VfspcYEz8odxAX9UxplZcB7zWNGFgswde2ixgT4o8OIN9odG9uJUuB+0Q/mWEetX+7vW md5+Nj/yEJY2scRE52AkAoQNc3V/muba4nwDX9514zNsvkpKvNRK1hbIx+Yfh9bslFKs VrYtFIA0yt9yiH29Ar+ga25qEZj78+DbjuNIrJnsUyaN9zE8joQfMoOSECnPL76D/POg jeUZ86eV9Ng1jdQflclib96LYtcNVrZhfNDHGG1mrpYghIKon5KKiNAg1rCGx9YAjIt0 yTSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773070493; x=1773675293; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2aTy0R+XTQKbHXXKr9Mnyna9OWj3RkjcnoZQYJLkb9g=; b=wEnCawifN88LH7E3XKSpof8Ig24rx0UTaq7xj/45qt9uPjtMLb2nSg0DduyNrNpAG9 1hR9ZdumUMiQPf0X+1ZeBGXz5EwVhInXIF0ZtEeBT55zgfGcJ5bTzan0IWJrpDta8lcd 5C2Wg5aBTwfqWb2/Bs1W4HI+bxqJVtWxAQqQnqlZU0wWIBbGPx9EkNkvJpMoufBTGmRh TG/nwk3mDUu1ehjbKSCVoN8+rF2tKGTv6TNMJT8cYxZBdzRPL5JSN1pZxWEqBMjM5YwM iVLKOgnjV9fqKpXoMmZ1o6VxAB4Hsx3kQdJiRjZyzTiUXuwA4Ig7XfAv+Rw/CbwCuNSe rldA== X-Forwarded-Encrypted: i=1; AJvYcCWTH6hQ8h4QavgjL15QF7xk9PYrDt/4zMJQjBVVYqmb9t0IJeR3uPTIodjrn0kCUMIPlhq3yeLdZRJP2ZM=@vger.kernel.org X-Gm-Message-State: AOJu0YwaxPYIG0nnxCvV9Akax3RFltDht+S8YZWUL5CByUIuo6v3EbYn Gm+qkxsZtXVzP9gCL3O38xZscvPDUfXeDsV4Lc45Kq5JaEyoj2ZvLIDq X-Gm-Gg: ATEYQzzKCmvz5zqQMKguDk7e4Cll8K38IZwCax4roWEr9dicd+VFQ9gCLrR3lesfPcR pJ92wkLGnrYWM0jDtAWCjHRuoxONn3jVKaUJVQKLSGfsnGrnhRMremwAFu4cCTR2t6I5Id8gL9W d48Tk30rvdhcdp65XY8d2kX3/QqWfexhDE2j4gk8LitM0iVOTVDczDUzW3x1rn4tAnUdQbJmRec cs7PpGLp0MMehgHct4bnLszs+AIYDo5ZG0ibUbTQFCoVCKU/WxhfvOZc/cxYiTMt0wzrZGq2ENF OSiBmL3aztspptQ/arWrf5rAQrhQgrBpDPozfI9gja7q8WMfJny74HAL26NbgOu4lXuMV/X6YTm NTbEokfZLgIsrR9H9tUnVdOeZOKs1WvS3V5Xqx/CXBb4l4rrBUsIGo7YY6yxrhiGSWxawa/yEnz aCuzWTonMdTlcVfCdvtfXBLyhUztNGwxKwytuEcCJJlupMhGOlARSeAxngu3cE57pWylCQFgT05 sVjAdxVH62jkFNQhp66xuYq6P48y22fSeC6NA== X-Received: by 2002:a05:6a20:ce4d:b0:35d:5d40:6d79 with SMTP id adf61e73a8af0-39858fb5ea9mr11500525637.12.1773070493270; Mon, 09 Mar 2026 08:34:53 -0700 (PDT) Received: from fedora ([2401:4900:1c80:20f6:77bf:3a75:33cb:748c]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e16cebbsm9316563a12.16.2026.03.09.08.34.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 08:34:52 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v2 3/4] iio: accel: mma9551: convert to guard(mutex) Date: Mon, 9 Mar 2026 21:04:07 +0530 Message-ID: <20260309153408.71512-4-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309153408.71512-1-rajveer.chaudhari.linux@gmail.com> References: <20260309153408.71512-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in mma9551_event_handler(). This ensures the mutex is released on all return paths and allows returning directly without a goto label. Signed-off-by: Rajveer Chaudhari --- v2: Dropped Header alignment change --- drivers/iio/accel/mma9551.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c index 02195deada49..65a913972ce2 100644 --- a/drivers/iio/accel/mma9551.c +++ b/drivers/iio/accel/mma9551.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include @@ -337,7 +338,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) u16 reg; u8 val; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); =20 for (i =3D 0; i < 3; i++) if (irq =3D=3D data->irqs[i]) { @@ -349,7 +350,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) /* IRQ was triggered on 4th line, which we don't use. */ dev_warn(&data->client->dev, "irq triggered on unused line %d\n", data->irqs[3]); - goto out; + return IRQ_HANDLED; } =20 switch (mma_axis) { @@ -373,7 +374,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) if (ret < 0) { dev_err(&data->client->dev, "error %d reading tilt register in IRQ\n", ret); - goto out; + return IRQ_HANDLED; } =20 iio_push_event(indio_dev, @@ -381,9 +382,6 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) IIO_EV_TYPE_ROC, IIO_EV_DIR_RISING), iio_get_time_ns(indio_dev)); =20 -out: - mutex_unlock(&data->mutex); - return IRQ_HANDLED; } =20 --=20 2.53.0