From nobody Thu Apr 9 12:00:47 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 795CB3D4100 for ; Mon, 9 Mar 2026 15:34:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773070488; cv=none; b=UVcszVQ9dwYsCaoSbA2uoAcIq1P5gLvu12x4H9D4rqAhc7kg56pYRpYEFK0xmnG6I1gjnCoY4EyPmX/tt3dazKroQlTVc80U31VsBMmLNDekJXkXPZBBjd+6awU7Pc8sxs39buMLkSemV5V50MvM6nks5/fYRyie6L58OZaf3Ik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773070488; c=relaxed/simple; bh=HGqw1CGl9UHWHkuaYJ5XBx19Rw+kwr2m6DgIvwtTuuc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZBwMHhu2ewZhRrR1vwjr9abOvdpwgtpn0cH5ZaWEyaUTrWUpIqqS2ttYR2ZDsXWejjRMDVO4pxP6IqyTqk3xYqo181rWK/Rkl8mVwa14KWYDiRQdvtwLU8IXRw1jQMU2/yuUWxe7cCLVXBdGVP3YlZitEp8lrQO4mbHttDBwaYY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ngZUh4Oc; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ngZUh4Oc" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c70f91776fcso4943216a12.0 for ; Mon, 09 Mar 2026 08:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773070487; x=1773675287; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ndt3vIv2zGaRlQuL9zR0zjbGPoGP608g1cvLrbOVtFc=; b=ngZUh4OcyK6zcm3snFf7eMo9Su3q/tFX+kgiRtfmjDK7zRnhLGo+FHE1MZ6HGEU/Dj JOleJquYutiAT45cpV8Z3P/qm7j3gaYJ7+MS0vV3f1YddhhSXj3keRArBzmmXFqKmpZP j4lqbzcwYkP0fZyX4UJgDRHWkYrQ6isKMyA5vHOm8oudyI8wz1l1ISojT8TJ+93d+wKx hiJp9gQxhrmAIvw2LDraBo+fRyVTmyIxaa0DkKPehcfHvuqCj284/hDQco/hDj8d1yKi NZKoMHEgAtKbVFPXBgsBoQImVZNnixKaA0Z9lM9+4aBFOS8VMzQBObNnvkMeq6ljR648 n/bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773070487; x=1773675287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ndt3vIv2zGaRlQuL9zR0zjbGPoGP608g1cvLrbOVtFc=; b=G6gT1t4Osz/eCWn9DfU/dpnLgG2gi9wTuyBQmiCrM+5ZyCo6BDBAkz7bV5eqNYlyZO S2hVP311gRxiHpG/hnP8DemnmFPP7hBwK9iBiSQ/CJitSxAxU9lAafTyqhZq5ZkLzLBa Hfcf6Xu1vnlggFyL92S2u96xB01qqaVyBg/u62II73UIdpNxSzm+C6/qtTIzcQC3/bRB H40oJPdxtrUlkqCnuGtK+pV/jNKrJRR5rI7ZEhVBRB9NXfMN2o6eg+bPkopL/2LQ4kUr e7WumQvwevgumTaEnONyDQ6jNtIk/7QJD3Tp/P8XuoXqZVDvWZYRX1CAEFj+huyPYCON fRDA== X-Forwarded-Encrypted: i=1; AJvYcCXSOu3q0cs+VZcS9jobl8APmRNS0CLFdeHBf9STl/30Y+kGOl6JsPEaUpMRLOvL7+0mkzeaqBpC1U8/lqA=@vger.kernel.org X-Gm-Message-State: AOJu0YyuzoYNDS9yzf+ys26yuPTC6wE3kTRqdeshsvtdivTszhpD573r IfPrBCQyUc8G2QBNGmarqNKIK88F5H96Wh75Ld5COdL9IhjV9WlADDHX X-Gm-Gg: ATEYQzzpDU97WjxuQbhduIuKYOTAnZtxbmzxJNS19DSZ9gXl90fAZl/PZQaYmC0MOLH MUIr50i2dkhsbGUKB53E6+lZdP1oSu1zQoq4dIuxYUN14WbsHE+n6Zjj8MhZF3e23L+Mp9ucw55 KPWlpIB30LWqvXzDMT9f3KfYyyYNjRoDI/tQUDCa2rbprrESu9G7Yx4nQI1HwUv1aKrkklq3B3V FFRs8KMrwneyW1iAJ899od3YvMs8cunA3Mo2jAzOdTtWTHzvO4TWM5aiIV7ikmu8tY2NqHI1p5j FWEh55e6S09CeU8KJFHKy9X4iggCgmPYPBMnFte+Q3o4F0N1Zj7czOvgnQUY9dtkm/flFRGr9ci ovfxQuJ4ujmrHm/DJYM6rMYveIO4KXOgbXY9AzE8Jyt0FJ4kqhXMtoX/F7WhKZhFHIaq5cwATRK fif1oh5ZNBLcOet80TEW08c8sOFPyAfxjD8893QoDjx+8kUvYTf6y2kcoRLsW/+5oS2E4t5NExI xAbrxvzJjkzwkFsOSFlYaxMVsQ= X-Received: by 2002:a05:6a21:2293:b0:35f:4e9d:d28b with SMTP id adf61e73a8af0-39858fd8a8fmr10759904637.18.1773070486764; Mon, 09 Mar 2026 08:34:46 -0700 (PDT) Received: from fedora ([2401:4900:1c80:20f6:77bf:3a75:33cb:748c]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e16cebbsm9316563a12.16.2026.03.09.08.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 08:34:46 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v2 2/4] iio: accel: mma8452: convert to guard(mutex) Date: Mon, 9 Mar 2026 21:04:06 +0530 Message-ID: <20260309153408.71512-3-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309153408.71512-1-rajveer.chaudhari.linux@gmail.com> References: <20260309153408.71512-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in mma8452_change_config(). This ensures the mutex is released on all return paths and allows returning directly without a goto label. Signed-off-by: Rajveer Chaudhari --- v2 : Dropped Header alignment change --- drivers/iio/accel/mma8452.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 15172ba2972c..09bb205a1b8f 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -20,6 +20,7 @@ =20 #include #include +#include #include #include #include @@ -597,36 +598,30 @@ static int mma8452_change_config(struct mma8452_data = *data, u8 reg, u8 val) int ret; int is_active; =20 - mutex_lock(&data->lock); + guard(mutex)(&data->lock); =20 is_active =3D mma8452_is_active(data); - if (is_active < 0) { - ret =3D is_active; - goto fail; - } + if (is_active < 0) + return is_active; =20 /* config can only be changed when in standby */ if (is_active > 0) { ret =3D mma8452_standby(data); if (ret < 0) - goto fail; + return ret; } =20 ret =3D i2c_smbus_write_byte_data(data->client, reg, val); if (ret < 0) - goto fail; + return ret; =20 if (is_active > 0) { ret =3D mma8452_active(data); if (ret < 0) - goto fail; + return ret; } =20 - ret =3D 0; -fail: - mutex_unlock(&data->lock); - - return ret; + return 0; } =20 static int mma8452_set_power_mode(struct mma8452_data *data, u8 mode) --=20 2.53.0