From nobody Thu Apr 9 11:55:51 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98D453D9057 for ; Mon, 9 Mar 2026 15:34:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773070482; cv=none; b=KAOXuZrzt3Ljrh9VzVel2E3UctfKAMPi46R6E9i9VJ5rRToKNoZJNnO5zuTlKGQKVI7NP/os6Ss6LSJXM9sQaBwB6fWG+lP9u6R2kkWgfXV1L6FfmNILLSrTlP08+oKbyJw8fSq/T91sVfl6kvrr+aHKiMQiDnFVYwtMvVQjdJw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773070482; c=relaxed/simple; bh=PPcH7gq7zegC4ms1+4zc5u6TowItE1iBiFKCzoS1KW0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ru9jXbexxQUrLOvANOcOEZ7zRQ34eXh17nMutjfrXNQ6Z9wubfpxwQCKByt9Fq50m8WJ1i5G+yvMAjWKeTQbnH+aocOyQIkcPo+6LCbOsmreyj5HXxJW2MVvU2V1OyoyckgRxBIgT8rVucoLemiKk12h7QPkzYP2GLHVqz3opDs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M1kRqLm7; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M1kRqLm7" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-c70fb6aa323so4161783a12.3 for ; Mon, 09 Mar 2026 08:34:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773070480; x=1773675280; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/bK0WqhpBZ+pZa4H+CeTkJHxMvrxbA/FN+llhWOAZnc=; b=M1kRqLm7teVpYG/kikqcDYUxWvQen/S9zDHJxB8sWZrBQ+zZq90UNc9+A4aWxp1wRO XizjPczFJP1VwjxgsTvgVv/c8jSXb1gEUqnioZ90WLfGYpIiTCaFojF0uEuAi0ZuyeSE srPlvaz8m/GqzkYAd1Pyh4rxyM0fYNydk26K+X8GpUONxgsUMpVSJmZfcRTtPF1MvkyT 0LPs61mKfMOmlIDBaOI7G5RHb9jOrCeB38bJjywaHyeWEerQmf2iIWoRbVw3+X0VKGIP /6+tQVd9MZC4FaeOKGu9wMJnPxYWN4Ss8qrmeGpr/J+cdXf1kMwEtVeVO8BiVa1y1YE6 ef+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773070480; x=1773675280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/bK0WqhpBZ+pZa4H+CeTkJHxMvrxbA/FN+llhWOAZnc=; b=Llc1q7JzwBQ5KG/pTSn/a1eeByKEs38RQYjg/jlscG3k+T5jEd08t1u5b6isyZAG15 TjWV8HYrX+Fe6Iq3hbmXqvuPXsfOKZFBydbfMOFkR+Ij0S6peVDysXDQV6kCZwpg1+lq TrrKXs19gyQCeapJY7Hz7dPAooqnrJGrHWKDH0V61vqUh4W8x7njZTp2bNyxkd8TtMRf WzgmdLTWJM1n8dVW63QO3AzmZFbYk1iZYBo9nyijEwp3biMt1MwxGfZQvrwZO8EYbvPq Q+/bgTgoZiQ8h1fO1KSa8/PPEBgou+l5vgiXzLcEyUOZs8Qd3ByzdaMJ//41I+bjNAb1 f5vA== X-Forwarded-Encrypted: i=1; AJvYcCWH6S7sex9zAdMFWmrE2vpJTavNl95PqYqE4z4BuNJPUrYE+hViiSetQzRftcbsohWMfIulz4ghM27Mg4I=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5rOBr7ZVBJ5x9HYl+p2bcxxxYBq0r5ElhYabGRwCTJAUqcZoO fFR63q1DQ9gmLuzjagXvEGoDVtu9in35r/I4EcCNU8qHVXyRMJddQlo3 X-Gm-Gg: ATEYQzyuwrRMVj/yPwxNH5Dd4gp8n8PmT3U+bcFT/FI5hKU1dpz76Pl/Ne2w/OE1RKK iigZzoze2Jd0HHweYzaB7wLLlvI9/Xx/FQCDvyy3Ada6Wt7HEECKXzYv1PbRU4+9CXulP5uE/a6 692nrYcyi4dMfJMhVrS72v8az4x7B89QcLh5HjG1Vf1IcMGWkQ0JUFtqyOOQagQ1VkQ+XZxCfcB 18aycYnnLtuuhm7L3wh1fgtrdtsr0zRB6mLWA2DV9NAhFE5QyEhfbIbhVVHMTCXNBNd2Tv4Qu/8 n4pW191seWz4nK4tCKZjvWRXPPc/kiGpNhWvG7eZI0T79YAqnxcE4ywR9epfq18C/spgl+FuQVZ GlvuWZVkpLTSgEo08mlsJgyrbUBhSK9jdnnDDXnqjkqHfIX2TxhwJCelpEGDIZwlvLw9IU4tPgT klF91n+jLL78AhLF6LS9c/c4tVkmaWOirqZBZAFn16aKK66zQr1/ta/XfSy9LaT0keFs94smCMV ZtIqtLpo6MO/tjbCsM0q2HxzJI= X-Received: by 2002:a05:6300:408a:b0:366:14af:9bd1 with SMTP id adf61e73a8af0-398590ff382mr10268050637.71.1773070479847; Mon, 09 Mar 2026 08:34:39 -0700 (PDT) Received: from fedora ([2401:4900:1c80:20f6:77bf:3a75:33cb:748c]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e16cebbsm9316563a12.16.2026.03.09.08.34.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 08:34:39 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v2 1/4] iio: accel: bmc150: convert to guard(mutex) Date: Mon, 9 Mar 2026 21:04:05 +0530 Message-ID: <20260309153408.71512-2-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309153408.71512-1-rajveer.chaudhari.linux@gmail.com> References: <20260309153408.71512-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in bmc150_accel_buffer_predisable() and bmc150_accel_buffer_postenable(). This ensures the mutex is released on all return paths and allows returning directly without a goto label. Signed-off-by: Rajveer Chaudhari --- v2: Cleaned mutex_unlock and goto in bmc150_accel_buffer_postenable(), Dropped Header alignment change. --- drivers/iio/accel/bmc150-accel-core.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc1= 50-accel-core.c index 42ccf0316ce5..bd9791c9fcf7 100644 --- a/drivers/iio/accel/bmc150-accel-core.c +++ b/drivers/iio/accel/bmc150-accel-core.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -1485,15 +1486,15 @@ static int bmc150_accel_buffer_postenable(struct ii= o_dev *indio_dev) if (iio_device_get_current_mode(indio_dev) =3D=3D INDIO_BUFFER_TRIGGERED) return 0; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); =20 if (!data->watermark) - goto out; + return ret; =20 ret =3D bmc150_accel_set_interrupt(data, BMC150_ACCEL_INT_WATERMARK, true); if (ret) - goto out; + return ret; =20 data->fifo_mode =3D BMC150_ACCEL_FIFO_MODE_FIFO; =20 @@ -1504,9 +1505,6 @@ static int bmc150_accel_buffer_postenable(struct iio_= dev *indio_dev) false); } =20 -out: - mutex_unlock(&data->mutex); - return ret; } =20 @@ -1517,19 +1515,16 @@ static int bmc150_accel_buffer_predisable(struct ii= o_dev *indio_dev) if (iio_device_get_current_mode(indio_dev) =3D=3D INDIO_BUFFER_TRIGGERED) return 0; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); =20 if (!data->fifo_mode) - goto out; + return 0; =20 bmc150_accel_set_interrupt(data, BMC150_ACCEL_INT_WATERMARK, false); __bmc150_accel_fifo_flush(indio_dev, BMC150_ACCEL_FIFO_LENGTH, false); data->fifo_mode =3D 0; bmc150_accel_fifo_set_mode(data); =20 -out: - mutex_unlock(&data->mutex); - return 0; } =20 --=20 2.53.0