From nobody Thu Apr 9 10:30:00 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 327BE3D9056 for ; Mon, 9 Mar 2026 15:35:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773070501; cv=none; b=tBnFZXf4s/XWZBXBLMLGfRFDBpdJ3BbKm5MipFRF1lXHflVwJEk6phLfJlLOq/2OxmX1+yRNvMfIBSxkR8ocFv0FVcgpLUSxYtLIROtrs+dIkyWPTN2LrZFrauTVv1bFqNzmsdKJRJ3JlQvEFJivq6RdcUSXzfoJGkLQauLl+1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773070501; c=relaxed/simple; bh=a6G6wn6wB8ltuvjLAlw0AHaT2dZ2G/WUjD3hQ9WHQGw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=s+dK07m9JY/aEQrR3OMEmG1hCwc2n6C1PLmXhso8TanngiDrkdxAb5EJIHjG7rtLuS+RNw0UwbZYpXhVg1eiX1iUGVhXZ17F3Ay+vPh4kIBA3zRKCG10u94lMOV+v8izHanjUymgDWQZA0GmF9xOxo6Ne4CDvWJQmJGke+1XA9c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nxj0TjJK; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nxj0TjJK" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ae5636ab04so84265835ad.3 for ; Mon, 09 Mar 2026 08:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773070499; x=1773675299; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GyPGkVOEzuOj++oEdOrxAUPo+L6IspicUK5SJ/430lI=; b=Nxj0TjJK5GjVZb1R1Acsoxr9JYwRD0M/TH3/Bt3udxmKVOF/pK33WE6m6XCEP4d6vE TGnImTUnm1UNco4oQQ8enhgaa+tRfOYDOPr5l/vTmnab9ePxDg6sGKatEA6fXjTNq3jx /q9qNKsROWgabpPs+5A1y8uDozI06I7X/J4gqBYDloGGZDLenRwEvbbLve1VUpzJnPUp 9hZZQFeTQPXO7N062bdAqc8wOb5u1wAP/N3U9AcSXl9pBPiHv+VizBQzpYg7sjdzaK6y K1b1UNwzxlp1nb5e0aUridJol5oi+brCeXw1r75YQUB9jJU1sxQW9fFgZAIA31lY+dm+ 6/ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773070499; x=1773675299; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GyPGkVOEzuOj++oEdOrxAUPo+L6IspicUK5SJ/430lI=; b=fYDzrgdOMF2NlU3RwSn98TmDR8BXG9ixCpZb/vQ2fXv41Ar/yrtltPGjRsvEpxuLNx VBshxfhuMmPKsGY6urRbvQharUKgdRT9/eM84rMVJrp+nuXSBlEDsgfgpAtMD0d88F4v 8rubljV4oCSlDBW5UCmActnaE/adQNzboSqkgHmly36StEBx6a9jn70KG8S1f1ichTl8 xX5CEiAMoRwGZj8QQjZBhQ4ztl8qWkwm5rZyqsb103AUijq8jeCAkDlfTrT49egskgwP iGPu3GT4gnnLoLwcw4n460fS/oX8LyhDoSdLWvNY84mqR2IRP54KN0134nGjNyNsOmRu BGkg== X-Forwarded-Encrypted: i=1; AJvYcCVXPZY6w+6FchxA8oNkabYqCz0QKWHY6DZUNMQwAJEmGKBbT5+nTMBRgrxq//PPon/eYmMqInZOZLfLluM=@vger.kernel.org X-Gm-Message-State: AOJu0YzTvF1lNLjn9fcvi/MK7riIjpjHgCvQDLO8Km7xSo0ogC1aE/Fj dJX0XMWr5O0OId50wQCFtGhcLRLO5KEhmtOYXkG8RFy7v8SGyFLs5zvu X-Gm-Gg: ATEYQzyB7RQsDIonpbpcIx1LFGba347jgRfgQzVrfGYegq/eli5gMawAWTXmkDIkIkm hic0emhHt8ZGoe5I3Fb8eD1IoXsvFRFDhUPewxfoMo62co33tm4nQAYbJVpzTgsPUqlzDcXUODO o4EEFeWy17oHTwIrp0rKSDHpd36orPjTnpcVxSRo0XLlfUELf431Rpl3ksWsLZQ48YUl+dl1toT w6JeOnQVVm2T2+4bGyLcLAI6VdO0sBOkBkkXyZwCKZ6LPiACw6X8gNldgZw34eWoYyzwRwm2Fbt /+3PdHdOv1xqtye0aGjxRuzgM/myAfHhJihKJWI9IiGbb8oFxDGny7aEKAEWdY1CuSzMwKRhLq1 pVErawXC1t4LQRsIkDwpUa5/AGLBhQJg7PZI3TOS5N1LghWdrp1TFxIExEZ/jnwU54f54AkEHYU cZimZqQjm4+4c+5IJUb66rdzMkh4ZvkyD49Ra2ee+6YuY= X-Received: by 2002:a17:903:198c:b0:2ae:683d:12b8 with SMTP id d9443c01a7336-2ae82443b5amr113592925ad.29.1773070499404; Mon, 09 Mar 2026 08:34:59 -0700 (PDT) Received: from DESKTOP-3LEPQG8.localdomain ([119.28.20.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae840be379sm118342985ad.87.2026.03.09.08.34.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 08:34:58 -0700 (PDT) From: Xie Yuanbin To: rppt@kernel.org, david.laight.linux@gmail.com, akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org, surenb@google.com, mhocko@suse.com, nathan@kernel.org, nick.desaulniers+lkml@gmail.com, morbo@google.com, justinstitt@google.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Xie Yuanbin Subject: [PATCH] mm/debug: optimize once judgment with clang Date: Mon, 9 Mar 2026 23:34:05 +0800 Message-ID: <20260309153405.20130-1-qq570070308@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" commit 242b872239f6a7deacbc ("include/linux/once_lite.h: fix judgment in WARN_ONCE with clang") helps optimize performance and size under the clang compiler, but the modification is not complete. Port the modification to VM_WARN_ON_ONCE_PAGE(), VM_WARN_ON_ONCE_FOLIO(), VM_WARN_ON_ONCE_MM() and VM_WARN_ON_ONCE_VMA(). Cc: Mike Rapoport Cc: David Laight Cc: Andrew Morton Signed-off-by: Xie Yuanbin --- include/linux/mmdebug.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h index ab60ffba08f5..a167c5aa525e 100644 --- a/include/linux/mmdebug.h +++ b/include/linux/mmdebug.h @@ -60,7 +60,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi); static bool __section(".data..once") __warned; \ int __ret_warn_once =3D !!(cond); \ \ - if (unlikely(__ret_warn_once && !__warned)) { \ + if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \ dump_page(page, "VM_WARN_ON_ONCE_PAGE(" __stringify(cond)")");\ __warned =3D true; \ WARN_ON(1); \ @@ -80,7 +80,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi); static bool __section(".data..once") __warned; \ int __ret_warn_once =3D !!(cond); \ \ - if (unlikely(__ret_warn_once && !__warned)) { \ + if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \ dump_page(&folio->page, "VM_WARN_ON_ONCE_FOLIO(" __stringify(cond)")");\ __warned =3D true; \ WARN_ON(1); \ @@ -91,7 +91,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi); static bool __section(".data..once") __warned; \ int __ret_warn_once =3D !!(cond); \ \ - if (unlikely(__ret_warn_once && !__warned)) { \ + if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \ dump_mm(mm); \ __warned =3D true; \ WARN_ON(1); \ @@ -102,7 +102,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi); static bool __section(".data..once") __warned; \ int __ret_warn_once =3D !!(cond); \ \ - if (unlikely(__ret_warn_once && !__warned)) { \ + if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \ dump_vma(vma); \ __warned =3D true; \ WARN_ON(1); \ --=20 2.53.0