From nobody Thu Apr 9 12:00:48 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7953C3B7B6B for ; Mon, 9 Mar 2026 14:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773066290; cv=none; b=bqkqBFKbKzC7raI9L26oeHYiXlgxnrJrNuZDQZJPs/w4Rry0dRRxAFdwQ6wkutJMiJhgJJlMPU7F3rQXxsz9yQZICYxit2UtTrcT9GS7KdVMNl5j99FQzkuNNqia8h3I0gtwpekAYt4h1Eu4TAcwr5lkZcNyrztIQCENrzXaKzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773066290; c=relaxed/simple; bh=OeumYQcWod62VsS2S8b+iZBWRuL6oFtKHJEN73VsxSE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fK2IJC6D991fHAWIeBbyjq3rLtxctM+9XE2XuIvvoSdbQ7+9M9rHr5ToFSzig3802ZnxVV0T/h8Lyy2Aj4HdIfaYp+kWuYyqoIr+nVwZk48FSHmHIMuIhNQVqSYEAm1yEikkir3QWgP6xPFKiSXlS6S7rPH7dXdbUG7msrVXIjM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iV6kLA1y; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iV6kLA1y" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3597df496f6so5054184a91.1 for ; Mon, 09 Mar 2026 07:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773066288; x=1773671088; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jO6elfLV0A9oqUoZI+t2ZUKkK5BDK6w1X39syVG7a9s=; b=iV6kLA1yZta/nAGnxbfARZh2WeyjqljmgBCOfSZwl50A7KZprNBALqV5QTqGaiLiSg OWivvAQSBDbRlKgruQaga65gSsCvz5JIUbMAtjt4d5s7YQkqlSMq6lq5GZllXaTP1Xhq 9bV8Pvn6OUTNZPMVG0bjgLTdekTRG3BK7qXdv7pzUl61wL/GyEs0wvAoZtDR9Y8IxC+k sZrch88oYqxMCByEj49BDpFI2mA8AByz9YnovELzIbNvAH4XT8s8ZNz51u2w0nWtnbRU QvLkaUGF0jBRWcXvY7jo3REmTCjgJXVD97uNWYaaWzAsWBSwHFOCZAWd5WoCcOyFRzcb mgnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773066288; x=1773671088; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jO6elfLV0A9oqUoZI+t2ZUKkK5BDK6w1X39syVG7a9s=; b=nCcCILhNpP1at8fF5OvPMOeZXZEDPpu0KhaofKKGY6OT2CO3kcjtZkKJin9HHb6V1L 1uYJCGvxwEOeUMjLCzYIwvEv5difBItj4s1o7mStJV5RlcZB5EXbQ8I/NjSWb1ASjNO5 Ge7yObvpjJOHKSK7e39w7xLACBudLOLxipr8nhrCPxefCctzJGxJL61NIYKkyDv2hX/2 FMyzOxgbS2g/F91SCI67ODZjPF9+xouKIm69a7O6reRcJGDzYQAAvUHAkl/YXRWj68u0 z8BuIjsVRUwBYaxOryomiDhJa2MasC6gEhJARJ92XV30yL44bl3eFjau+esHJ2qZBtCC CvnA== X-Forwarded-Encrypted: i=1; AJvYcCXX7xoucqlbmf/OFNCqpNlySVxVj/1CC+CBs2b1dhSi9f02Rs/OmDulCR77Cbitz1ghO2eENyVe85fFFj4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxw2EOB6L33p5o28KpAzFqWfAZ15mpYDR+6HnadcVik8c5qAefc dnjkH02TDvRGz9vL0H4kVugayQPUOQYIcBOkIfemWhs+D0C2gTDdaPi4 X-Gm-Gg: ATEYQzzCnCewnCJ94kj+1hQ0INwZOxNvgv7JYmMe50nLjM8sxOnG9p4H8iKFGXqkMws 0JqAI61AF27BhIx7Ngf+BjRG6dEz+cxXayzPpN6m7q/lETmFQoDGt+wgpVD9xybZR2LkECC/YiK mGQRgSCVwNUNY+uvUhD46GbEujBpiNj4KStRnuUTecpLQ2oKE/36Gm515qgKMAAFKNsmCMSOsqK lQjXZ4mz+Iba5t0Wo0C8zN7Ttn+CG984DDpDeLMocGeOQ6XVrTpGFnHY+m/x1D1DnBpQRmkClg3 qhojBQ1A3viZ7u3WagjW0Vp1XHAArvfPBzl0+VHw8GC2YKK/DMSWo22/7IAXqkqh5CLPTedUujZ ycZMebN1yzqf4nd2j5c4EKY8UCZPOthcBpJtFmljebFkF2G+b6eBkpAD26k/oHo8/IvawViEJeq xnWMAeLD8Cs2IQd4pgebbmJniJM5b9YOdgzxeMwXDOXNMacnxbIwILkHnzNPWwB1VQn23ZFvYpA yLeErK9vUmeHzvVkjZJsaxPF69BDvO25iWwZA== X-Received: by 2002:a17:90b:4c0b:b0:340:bfcd:6af8 with SMTP id 98e67ed59e1d1-359be21cbe3mr9605797a91.4.1773066287816; Mon, 09 Mar 2026 07:24:47 -0700 (PDT) Received: from fedora ([2401:4900:1c80:20f6:77bf:3a75:33cb:748c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359b2e0e1aasm18985311a91.15.2026.03.09.07.24.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 07:24:47 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH 3/4] iio: accel: mma9551: convert to guard(mutex) Date: Mon, 9 Mar 2026 19:53:51 +0530 Message-ID: <20260309142352.57407-4-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309142352.57407-1-rajveer.chaudhari.linux@gmail.com> References: <20260309142352.57407-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in mma9551_event_handler(). This ensures the mutex is released on all return paths and allows returning directly without a goto label. Aligned headers in alphabatical order. Signed-off-by: Rajveer Chaudhari --- drivers/iio/accel/mma9551.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c index 02195deada49..0936b148e424 100644 --- a/drivers/iio/accel/mma9551.c +++ b/drivers/iio/accel/mma9551.c @@ -4,17 +4,21 @@ * Copyright (c) 2014, Intel Corporation. */ =20 +#include +#include #include #include #include #include +#include #include -#include + #include + +#include #include #include -#include -#include + #include "mma9551_core.h" =20 #define MMA9551_GPIO_COUNT 4 @@ -337,7 +341,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) u16 reg; u8 val; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); =20 for (i =3D 0; i < 3; i++) if (irq =3D=3D data->irqs[i]) { @@ -349,7 +353,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) /* IRQ was triggered on 4th line, which we don't use. */ dev_warn(&data->client->dev, "irq triggered on unused line %d\n", data->irqs[3]); - goto out; + return IRQ_HANDLED; } =20 switch (mma_axis) { @@ -373,7 +377,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) if (ret < 0) { dev_err(&data->client->dev, "error %d reading tilt register in IRQ\n", ret); - goto out; + return IRQ_HANDLED; } =20 iio_push_event(indio_dev, @@ -381,9 +385,6 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) IIO_EV_TYPE_ROC, IIO_EV_DIR_RISING), iio_get_time_ns(indio_dev)); =20 -out: - mutex_unlock(&data->mutex); - return IRQ_HANDLED; } =20 --=20 2.53.0