From nobody Thu Apr 9 12:06:24 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF3E539E176 for ; Mon, 9 Mar 2026 14:24:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773066276; cv=none; b=k1OVo3dPGonlAmUYNzIuiTkz7214I1R6QTALW3ImJaaj3tsEWd9zlfJE1yAHymNjHp2rU+S2eap06VfzM/IiOU8J63IebhrBNOhEltazs/+y3TOM1Acg1c/g2MC+Y4oa1PcoiJ5DhWbyzzb0SONbfOwNOVyZoFaq0DpjQZtoNTg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773066276; c=relaxed/simple; bh=CLI9Tm1/iHPRkfpythGWyrB52NK/CNiw9SacNMZjIS0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WSSzQCC0SaweP5lqQ79q16KTAfAeqcracOzB6A6wAXbURG14xUwF23XGUk6iQMennNcx3bE8/ajpG/zMT4LVsCI+uMtuHfS9m8LRXm5etZBR2zPpRM3xzKL/E0atQHuHTeXeoBtQ2t9tOVdOFcAue3hfCToSho7Ea9LFoR+sNuo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K4CU5VHZ; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K4CU5VHZ" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-358ed696623so4856083a91.0 for ; Mon, 09 Mar 2026 07:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773066275; x=1773671075; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bgyeu6qwDJxvPvHbOAbXi+4MEkb/h61SteASe+ruxqw=; b=K4CU5VHZxuTKL6cp5UwMYNe658NAjSeDt7YTzZre2yDAFFwwxuYk/4WbEEr9r7HFR5 JZ6KXpIuJ+bovhtgTb6YEt0tHyaJ/WWzKm1nQ6viO8bj6UYRU/agZhPaLaY9cwQ1cvAU 4G7U5dCaEsOotiKmJljCeSE2dQkZQRKcfaPCedEal7GhsxoVGYYM2uIb4tsM4WqnkOG/ OQKa6v85OcysLi5obvuYxSUbkosHixCZaKegNQkseQg2O/yoEE74diE8Lc5zxrZG/0qS vDFmZW/4nqP4j/j0Yq3pGjHJ7tN33PD30u9xxU1TGi7ZAGBqrHy5bhjRSCEv1pyEf1Ic 7zZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773066275; x=1773671075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Bgyeu6qwDJxvPvHbOAbXi+4MEkb/h61SteASe+ruxqw=; b=pRhwQa1TnTgzS8sya/QQjzbC/8c+y01b/pV3IubYk+0r97EN5E3z49BEu3LRDwVT1l EdLqzHDy6bhlTzsMSpfVlp+vH52sAnN8IlSbIhgjURP3FxiUOqkSOdYAuuQPGXMyAL7j jNFPc+i+/RehdzZ5TAOBk+IWp1GWzPmy7r4jhzHy66iWCqNXdgLFDv3uraJjcVDcDKsT H3S3kPyHSnVyQ4/Fi/bI6vXSKGSJNX9VBoUD9CfsZK03Mce8V0ct6H0Jwk52wKM3z9nm hrWnWsqAHW2hTAr1lQdB+V/YECBs9xQ/ac2OS+vHViIMSqOznIbRpggfctwGuOud/O3Y UaHA== X-Forwarded-Encrypted: i=1; AJvYcCVZie0+jisMmu+nirit7Mvvcw6IqlZ3lJfXUZB8+WOMxUdoaIROJmRwKH3w95diY+zfkCb331sD4EbFxq0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4xzYa1PcainZ+3JYcZxi/CsUdkb/O0f545ck6otsIsrCrpfNu t5AhKFzd8jfwDg77OUhJJBRCBzOCW1GZbHVui7R59PerQeXhwBjXwWNI X-Gm-Gg: ATEYQzyC3tkSAKtCRI7sIspvG8H4dLfzXwXTirw9zcV7DQtM2NdVqhM3upbKP6WFBb7 OYolvFA/MKKw7naraIl5vMjVOfRWytYaQ0eZfICnD6XQtvnLw2rgX8zCB9nBmcNUZo2HgyNwvUB H4F5+M/i8E0MZ1zYf0Xh9WGZGEbDXC+SFt0Stoq4tREjA1ABdYPLcMQZND1KPTc0stPzVycB3al QP4ySOpjKk4Ht99qVQQa8Tnm+J9TPcl0ZRXVhNKokyQKTZZKeZVpjSJdk5Y6S1M78m+Gt6FNwWw JSN5RHbhv37MvSAmQixyUe9bT6Ym3tEQB3jgseMZcz7Aj4x8nVB8BZHIOydm1s8wgBIF0an3nZI AFifjzgUnbmkSYrbEkDWOOR2e1lLmTd4pZZowb73hStiJlCE9hSAr1go6t7M9YV3HCZYNti3edj Ml4R+jJtI5h/UNQKfPNQfiAuxvpdV4E+MFpvCYcRqo0cPzc5JBwX4oocOMJuTJ55RG1eOLbZ5Oy ncdwB0om37lsOodZxQPVCGaH8o= X-Received: by 2002:a17:90b:4f4d:b0:343:6108:1712 with SMTP id 98e67ed59e1d1-359be34987cmr10184664a91.18.1773066274989; Mon, 09 Mar 2026 07:24:34 -0700 (PDT) Received: from fedora ([2401:4900:1c80:20f6:77bf:3a75:33cb:748c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359b2e0e1aasm18985311a91.15.2026.03.09.07.24.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 07:24:34 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH 1/4] iio: accel: bmc150: convert to guard(mutex) Date: Mon, 9 Mar 2026 19:53:49 +0530 Message-ID: <20260309142352.57407-2-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309142352.57407-1-rajveer.chaudhari.linux@gmail.com> References: <20260309142352.57407-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in bmc150_accel_buffer_predisable(). This ensures the mutex is released on all return paths and allows returning directly without a goto label. Aligned headers in alphabatical order. Signed-off-by: Rajveer Chaudhari --- drivers/iio/accel/bmc150-accel-core.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc1= 50-accel-core.c index 42ccf0316ce5..9ae325cdfdd3 100644 --- a/drivers/iio/accel/bmc150-accel-core.c +++ b/drivers/iio/accel/bmc150-accel-core.c @@ -4,23 +4,26 @@ * Copyright (c) 2014, Intel Corporation. */ =20 -#include +#include +#include +#include #include #include -#include -#include -#include +#include #include #include #include -#include -#include +#include +#include + #include #include +#include +#include #include #include #include -#include + #include =20 #include "bmc150-accel.h" @@ -1485,7 +1488,7 @@ static int bmc150_accel_buffer_postenable(struct iio_= dev *indio_dev) if (iio_device_get_current_mode(indio_dev) =3D=3D INDIO_BUFFER_TRIGGERED) return 0; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); =20 if (!data->watermark) goto out; @@ -1517,19 +1520,16 @@ static int bmc150_accel_buffer_predisable(struct ii= o_dev *indio_dev) if (iio_device_get_current_mode(indio_dev) =3D=3D INDIO_BUFFER_TRIGGERED) return 0; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); =20 if (!data->fifo_mode) - goto out; + return 0; =20 bmc150_accel_set_interrupt(data, BMC150_ACCEL_INT_WATERMARK, false); __bmc150_accel_fifo_flush(indio_dev, BMC150_ACCEL_FIFO_LENGTH, false); data->fifo_mode =3D 0; bmc150_accel_fifo_set_mode(data); =20 -out: - mutex_unlock(&data->mutex); - return 0; } =20 --=20 2.53.0