From nobody Thu Apr 9 10:29:59 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29C253B8D46 for ; Mon, 9 Mar 2026 14:17:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065862; cv=none; b=psT7K0ku2Xm9jukhIqxecgnaRO3ncsECDmrdbPd5150rbcGpWs1aq2f9iP/jTv7H7teyLGwHwW+UHku+VhTela13P5g/ke+a8Uu+oEJhQ92eyKg5BHWIPAU8G2g8PL0bhSYmWvDOanEER/WFAOXnM+anPomGFwCBIzsm16+V0r0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065862; c=relaxed/simple; bh=U5t7FfpI8bDIXdRv4UUiGN9veQB5PuFRipOiFyXYXrQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R4zV2EkGCRwMJDrg1HiTowRRjBuLo4J2euIN2x44sMcKCx8jxVY+u+XCvrSQfGocDayV9BV/fdyw7qrpuzbW5HNqNsb8+vhwFtOwJA30SelEKLwZsVpuDVX9NQk5UfJOrBZ7f743c7d/7UWy2UjmjpDp38Upa7igUSZV2Rf15Es= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=z1lNPRY6; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=+nY6u89s; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=z1lNPRY6; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=+nY6u89s; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="z1lNPRY6"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="+nY6u89s"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="z1lNPRY6"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="+nY6u89s" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C97E24D23B; Mon, 9 Mar 2026 14:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065849; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hgO/vBjxEvbCUOOxusElmoEUhXTpiDO+udaq2KN88TI=; b=z1lNPRY6aauv39VaYZ30UzAnsTdjqhYjFoWaC8Ap8RDUM/AE1ilJFNzocv2ayIYZtS6Q4c 1aW/C1eZNns/l9IvzQzPRVglQoWj1fvc2xMsX4cCI5ptGJHicGaBtqNGUiwOqgWGX1HHxY cWuhNJ8i28vYit9yVTmEtYj4me2lTWk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065849; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hgO/vBjxEvbCUOOxusElmoEUhXTpiDO+udaq2KN88TI=; b=+nY6u89sMmENVICi9ocD9A73pkLplyWtYKdec7kYlnU8ojfbb5sgKLnIv6Ts8C2djqafWf 7rG/byN75vSvfdAw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065849; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hgO/vBjxEvbCUOOxusElmoEUhXTpiDO+udaq2KN88TI=; b=z1lNPRY6aauv39VaYZ30UzAnsTdjqhYjFoWaC8Ap8RDUM/AE1ilJFNzocv2ayIYZtS6Q4c 1aW/C1eZNns/l9IvzQzPRVglQoWj1fvc2xMsX4cCI5ptGJHicGaBtqNGUiwOqgWGX1HHxY cWuhNJ8i28vYit9yVTmEtYj4me2lTWk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065849; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hgO/vBjxEvbCUOOxusElmoEUhXTpiDO+udaq2KN88TI=; b=+nY6u89sMmENVICi9ocD9A73pkLplyWtYKdec7kYlnU8ojfbb5sgKLnIv6Ts8C2djqafWf 7rG/byN75vSvfdAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9008C3EF3B; Mon, 9 Mar 2026 14:17:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SHbFIXnWrmldPAAAD6G6ig (envelope-from ); Mon, 09 Mar 2026 14:17:29 +0000 From: Thomas Zimmermann To: gregkh@linuxfoundation.org, deller@gmx.de, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v3 01/13] fbdev: Declare src parameter of fb_pad_ helpers as constant Date: Mon, 9 Mar 2026 15:14:43 +0100 Message-ID: <20260309141723.137364-2-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309141723.137364-1-tzimmermann@suse.de> References: <20260309141723.137364-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.80 X-Spam-Level: X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[linuxfoundation.org,gmx.de,ravnborg.org]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Spam-Flag: NO Content-Type: text/plain; charset="utf-8" Fbdev's padding helpers do not modify the source buffer. Declare the parameter as 'const'. Fbcon's font-rendering code calls these helpers with the font data. Declaring src as const will allow for making the font data constant as well. While at it, also remove the extern qualifier from the function declarations in the header file. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fbmem.c | 6 +++--- include/linux/fb.h | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fb= mem.c index cf199038f069..30f2b59c47bf 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -91,14 +91,14 @@ EXPORT_SYMBOL(fb_get_color_depth); /* * Data padding functions. */ -void fb_pad_aligned_buffer(u8 *dst, u32 d_pitch, u8 *src, u32 s_pitch, u32= height) +void fb_pad_aligned_buffer(u8 *dst, u32 d_pitch, const u8 *src, u32 s_pitc= h, u32 height) { __fb_pad_aligned_buffer(dst, d_pitch, src, s_pitch, height); } EXPORT_SYMBOL(fb_pad_aligned_buffer); =20 -void fb_pad_unaligned_buffer(u8 *dst, u32 d_pitch, u8 *src, u32 idx, u32 h= eight, - u32 shift_high, u32 shift_low, u32 mod) +void fb_pad_unaligned_buffer(u8 *dst, u32 d_pitch, const u8 *src, u32 idx,= u32 height, + u32 shift_high, u32 shift_low, u32 mod) { u8 mask =3D (u8) (0xff << shift_high), tmp; int i, j; diff --git a/include/linux/fb.h b/include/linux/fb.h index 6d4a58084fd5..324b0fd5f617 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -605,9 +605,9 @@ extern int register_framebuffer(struct fb_info *fb_info= ); extern void unregister_framebuffer(struct fb_info *fb_info); extern int devm_register_framebuffer(struct device *dev, struct fb_info *f= b_info); extern char* fb_get_buffer_offset(struct fb_info *info, struct fb_pixmap *= buf, u32 size); -extern void fb_pad_unaligned_buffer(u8 *dst, u32 d_pitch, u8 *src, u32 idx, - u32 height, u32 shift_high, u32 shift_low, u32 mod); -extern void fb_pad_aligned_buffer(u8 *dst, u32 d_pitch, u8 *src, u32 s_pit= ch, u32 height); +void fb_pad_unaligned_buffer(u8 *dst, u32 d_pitch, const u8 *src, u32 idx,= u32 height, + u32 shift_high, u32 shift_low, u32 mod); +void fb_pad_aligned_buffer(u8 *dst, u32 d_pitch, const u8 *src, u32 s_pitc= h, u32 height); extern void fb_set_suspend(struct fb_info *info, int state); extern int fb_get_color_depth(struct fb_var_screeninfo *var, struct fb_fix_screeninfo *fix); @@ -633,8 +633,8 @@ static inline struct device *dev_of_fbinfo(const struct= fb_info *info) #endif } =20 -static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch, - u8 *src, u32 s_pitch, u32 height) +static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch, const u8 = *src, u32 s_pitch, + u32 height) { u32 i, j; =20 --=20 2.53.0 From nobody Thu Apr 9 10:29:59 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88EAC212542 for ; Mon, 9 Mar 2026 14:17:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065867; cv=none; b=M8MDvbXuDgocxYt/w8C13MtDUYWI3QCIHh8uGsnKOwmKRNS/F5d+R4H/MbafZ6p1zxe1betgGe4WBtTGb8t8z5dBA98yxp9t+AWNvrULvDItKc1ZPI1TsGwtoOO3mUTJJc5FpEoyaRNgh4IF76DwGyGPDJHNZ5h6B1ZiUWEmeFg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065867; c=relaxed/simple; bh=X7ZXt/Tvldpttx1rTGbhAfIensbsUVb6ys+73i6I5kg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aiIw2PQOabO0xmDo2TXR5zISmq1yEe5M6Ugh20s9TYZKKF+0PFv6nIqJaT5rmolESdEfSDljeLx/THtWgIefRONKOKotzdR0Ij5izJnfTqUBjfrYcJ8KwxliTCKNaY9O6vzr+OL1YLUSt/MvN5sinqgwYgnxDKdjjNL9jbj64oQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=gc+vRF31; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=ahWOs3Hf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=gc+vRF31; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=ahWOs3Hf; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="gc+vRF31"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ahWOs3Hf"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="gc+vRF31"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ahWOs3Hf" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 157534D240; Mon, 9 Mar 2026 14:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jDdFaZ33ivCVSgFIvrCH2YTfOSd7wSVCMvjOyrWj3aI=; b=gc+vRF31JuC9HYI6e+4f+cTPYtMoJQtzKt2VJ/8KxsgYY0dj/Bv9HMQitirhq+BODlZTqF x2cnwUqOxQ0uuMyrdW5tPdChFRg+gzZh8RhBlDhOCPztsCi3cxDRItgZWGK65Ov3f1Nyus XeUdTXSyvMjFq/juiQQInFtRd/ujBz0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jDdFaZ33ivCVSgFIvrCH2YTfOSd7wSVCMvjOyrWj3aI=; b=ahWOs3HfUZeTv7C/4gW65AMbtrIc9x13oZgLixlbxtHIF6xLGwI5M/w7uIWp2XlFlkwN4J tg+TROozh4PWvNAQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gc+vRF31; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ahWOs3Hf DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jDdFaZ33ivCVSgFIvrCH2YTfOSd7wSVCMvjOyrWj3aI=; b=gc+vRF31JuC9HYI6e+4f+cTPYtMoJQtzKt2VJ/8KxsgYY0dj/Bv9HMQitirhq+BODlZTqF x2cnwUqOxQ0uuMyrdW5tPdChFRg+gzZh8RhBlDhOCPztsCi3cxDRItgZWGK65Ov3f1Nyus XeUdTXSyvMjFq/juiQQInFtRd/ujBz0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jDdFaZ33ivCVSgFIvrCH2YTfOSd7wSVCMvjOyrWj3aI=; b=ahWOs3HfUZeTv7C/4gW65AMbtrIc9x13oZgLixlbxtHIF6xLGwI5M/w7uIWp2XlFlkwN4J tg+TROozh4PWvNAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CF8C93EF3C; Mon, 9 Mar 2026 14:17:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8Nx5MXnWrmldPAAAD6G6ig (envelope-from ); Mon, 09 Mar 2026 14:17:29 +0000 From: Thomas Zimmermann To: gregkh@linuxfoundation.org, deller@gmx.de, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v3 02/13] vt: Remove trailing whitespaces Date: Mon, 9 Mar 2026 15:14:44 +0100 Message-ID: <20260309141723.137364-3-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309141723.137364-1-tzimmermann@suse.de> References: <20260309141723.137364-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_TO(0.00)[linuxfoundation.org,gmx.de,ravnborg.org]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_COUNT_TWO(0.00)[2]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,suse.de:email]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; FROM_EQ_ENVFROM(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Rspamd-Queue-Id: 157534D240 X-Spam-Flag: NO X-Spam-Score: -3.01 X-Spam-Level: Content-Type: text/plain; charset="utf-8" Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann --- include/linux/console_struct.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/console_struct.h b/include/linux/console_struct.h index 13b35637bd5a..ebdb9750d348 100644 --- a/include/linux/console_struct.h +++ b/include/linux/console_struct.h @@ -120,7 +120,7 @@ struct vc_data { unsigned short vc_complement_mask; /* [#] Xor mask for mouse pointer */ unsigned short vc_s_complement_mask; /* Saved mouse pointer mask */ unsigned long vc_pos; /* Cursor address */ - /* fonts */=09 + /* fonts */ unsigned short vc_hi_font_mask; /* [#] Attribute set for upper 256 chars = of font or 0 if not supported */ struct console_font vc_font; /* Current VC font set */ unsigned short vc_video_erase_char; /* Background erase character */ --=20 2.53.0 From nobody Thu Apr 9 10:29:59 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 861DA3B7B6B for ; Mon, 9 Mar 2026 14:17:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065874; cv=none; b=nAdbQuDcNRHAx8AHzcGGSd06o9DAXtg+rE/CQqt80BX+lJczJ5AkLMHMoWXUTlvy8jUgYmRYmAe/tpsk8Uyp/R+0jB5OpuQQpqyldTe8jU8eJjpvF8GQ+a8fGajPwa5vLtwEYfqQTwhnGrM1B4JPSdVv5Zm1Kzse2C5Y5WfHOHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065874; c=relaxed/simple; bh=SPMtHsartbmoAkf2ZKCxIiqmvk0T2sL/YD7WM4Q909g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dp8t/ZDT5egCufQY4uUpA1CE+Q8N9B+Vv52+Vx/7xFztNrd0ipnO5GANAcxuk6+qy+Z5o2s5AvnkAoYzv/amw/DgEi3l0BT45WJ0m5/2E71GpHGdjKUZuWCf7srpn+XYwZpg1p/ZwEKo7/xbZ29O6IAHRtq/TJ2SHEnfmnT4DJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=IApIuFeF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=0nhlei8o; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=IApIuFeF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=0nhlei8o; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="IApIuFeF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="0nhlei8o"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="IApIuFeF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="0nhlei8o" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 52D654D243; Mon, 9 Mar 2026 14:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W87QsD52fexHhLihb7ZBj35HU6wFyK6TjGFCrQ4J8YU=; b=IApIuFeFWJeqg8hHe/x1wuBV5ThST3+RLhkxJ+/LjrMlZEXLAwQ7mkGv/4OBr6hmV1RWx9 wbvXrhCMSP1VdVch7orh1D9SU5f67e3cCAilMq01wD4r2M7SiIUwsSG1jJZhjZsPtFNHpy oMf2bQnG8Hz9lmjCo6tezRwPNjugJiw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W87QsD52fexHhLihb7ZBj35HU6wFyK6TjGFCrQ4J8YU=; b=0nhlei8oAyylxhCR+fNiZWvX5SgtIYtiYDn15LDazN+mWTBpsRsf8rePSAksGrpdZSs8Bg S+R1d3XfW6Qaz/Cw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=IApIuFeF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0nhlei8o DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W87QsD52fexHhLihb7ZBj35HU6wFyK6TjGFCrQ4J8YU=; b=IApIuFeFWJeqg8hHe/x1wuBV5ThST3+RLhkxJ+/LjrMlZEXLAwQ7mkGv/4OBr6hmV1RWx9 wbvXrhCMSP1VdVch7orh1D9SU5f67e3cCAilMq01wD4r2M7SiIUwsSG1jJZhjZsPtFNHpy oMf2bQnG8Hz9lmjCo6tezRwPNjugJiw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W87QsD52fexHhLihb7ZBj35HU6wFyK6TjGFCrQ4J8YU=; b=0nhlei8oAyylxhCR+fNiZWvX5SgtIYtiYDn15LDazN+mWTBpsRsf8rePSAksGrpdZSs8Bg S+R1d3XfW6Qaz/Cw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1BE5B3EF3A; Mon, 9 Mar 2026 14:17:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yMqZBXrWrmldPAAAD6G6ig (envelope-from ); Mon, 09 Mar 2026 14:17:30 +0000 From: Thomas Zimmermann To: gregkh@linuxfoundation.org, deller@gmx.de, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v3 03/13] vt: Store font in struct vc_font Date: Mon, 9 Mar 2026 15:14:45 +0100 Message-ID: <20260309141723.137364-4-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309141723.137364-1-tzimmermann@suse.de> References: <20260309141723.137364-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[linuxfoundation.org,gmx.de,ravnborg.org]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[7]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -3.01 X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 52D654D243 Content-Type: text/plain; charset="utf-8" Replace struct console_font with struct vc_font for the type of the vc_font field of struct vc_data. Struct console_font is UAPI, which prevents further changes. Hence a new data type is required. Struct console_font has a documented vertical pitch of 32 bytes. This is not the case after the font data has been loaded into the kernel. Changing the type of vc_font addresses this inconsistency. The font data is now declared as constant, as it might come from the kernel's read-only section. There's some fallout throughout the console code where non-const variables refer to it. Fix them. A later update will declare the font data to a dedicated data type. v3: - fix typos Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/bitblit.c | 11 +++++------ drivers/video/fbdev/core/fbcon.c | 4 ++-- drivers/video/fbdev/core/fbcon.h | 4 ++-- include/linux/console_struct.h | 29 +++++++++++++++++++++++++++-- 4 files changed, 36 insertions(+), 12 deletions(-) diff --git a/drivers/video/fbdev/core/bitblit.c b/drivers/video/fbdev/core/= bitblit.c index 085ffb44c51a..7478accea8ec 100644 --- a/drivers/video/fbdev/core/bitblit.c +++ b/drivers/video/fbdev/core/bitblit.c @@ -22,8 +22,7 @@ /* * Accelerated handlers. */ -static void update_attr(u8 *dst, u8 *src, int attribute, - struct vc_data *vc) +static void update_attr(u8 *dst, const u8 *src, int attribute, struct vc_d= ata *vc) { int i, offset =3D (vc->vc_font.height < 10) ? 1 : 2; int width =3D DIV_ROUND_UP(vc->vc_font.width, 8); @@ -81,7 +80,7 @@ static inline void bit_putcs_aligned(struct vc_data *vc, = struct fb_info *info, u16 charmask =3D vc->vc_hi_font_mask ? 0x1ff : 0xff; unsigned int charcnt =3D vc->vc_font.charcount; u32 idx =3D vc->vc_font.width >> 3; - u8 *src; + const u8 *src; =20 while (cnt--) { u16 ch =3D scr_readw(s++) & charmask; @@ -120,7 +119,7 @@ static inline void bit_putcs_unaligned(struct vc_data *= vc, u32 shift_low =3D 0, mod =3D vc->vc_font.width % 8; u32 shift_high =3D 8; u32 idx =3D vc->vc_font.width >> 3; - u8 *src; + const u8 *src; =20 while (cnt--) { u16 ch =3D scr_readw(s++) & charmask; @@ -267,7 +266,7 @@ static void bit_cursor(struct vc_data *vc, struct fb_in= fo *info, bool enable, int y =3D real_y(par->p, vc->state.y); int attribute, use_sw =3D vc->vc_cursor_type & CUR_SW; int err =3D 1; - char *src; + const u8 *src; =20 cursor.set =3D 0; =20 @@ -278,7 +277,7 @@ static void bit_cursor(struct vc_data *vc, struct fb_in= fo *info, bool enable, attribute =3D get_attribute(info, c); src =3D vc->vc_font.data + ((c & charmask) * (w * vc->vc_font.height)); =20 - if (par->cursor_state.image.data !=3D src || + if (par->cursor_state.image.data !=3D (const char *)src || par->cursor_reset) { par->cursor_state.image.data =3D src; cursor.set |=3D FB_CUR_SETIMAGE; diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fb= con.c index 666261ae59d8..247bb90c08d3 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -2286,7 +2286,7 @@ static bool fbcon_blank(struct vc_data *vc, enum vesa= _blank_mode blank, =20 static int fbcon_get_font(struct vc_data *vc, struct console_font *font, u= nsigned int vpitch) { - u8 *fontdata =3D vc->vc_font.data; + const u8 *fontdata =3D vc->vc_font.data; u8 *data =3D font->data; int i, j; =20 @@ -2417,7 +2417,7 @@ static int fbcon_do_set_font(struct vc_data *vc, int = w, int h, int charcount, struct fbcon_par *par =3D info->fbcon_par; struct fbcon_display *p =3D &fb_display[vc->vc_num]; int resize, ret, old_userfont, old_width, old_height, old_charcount; - u8 *old_data =3D vc->vc_font.data; + const u8 *old_data =3D vc->vc_font.data; =20 resize =3D (w !=3D vc->vc_font.width) || (h !=3D vc->vc_font.height); vc->vc_font.data =3D (void *)(p->fontdata =3D data); diff --git a/drivers/video/fbdev/core/fbcon.h b/drivers/video/fbdev/core/fb= con.h index fca14e9b729b..3f4386a40237 100644 --- a/drivers/video/fbdev/core/fbcon.h +++ b/drivers/video/fbdev/core/fbcon.h @@ -82,8 +82,8 @@ struct fbcon_par { int rotate; int cur_rotate; char *cursor_data; - u8 *fontbuffer; - u8 *fontdata; + u8 *fontbuffer; + const u8 *fontdata; u8 *cursor_src; u32 cursor_size; u32 fd_size; diff --git a/include/linux/console_struct.h b/include/linux/console_struct.h index ebdb9750d348..ea0cdf4278a3 100644 --- a/include/linux/console_struct.h +++ b/include/linux/console_struct.h @@ -13,8 +13,9 @@ #ifndef _LINUX_CONSOLE_STRUCT_H #define _LINUX_CONSOLE_STRUCT_H =20 -#include +#include #include +#include #include =20 struct uni_pagedict; @@ -58,6 +59,30 @@ struct vc_state { bool reverse; }; =20 +/** + * struct vc_font - Describes a font + * @width: The width of a single glyph in bits + * @height: The height of a single glyph in scanlines + * @charcount: The number of glyphs in the font + * @data: The raw font data + * + * Font data is organized as an array of glyphs. Each glyph is a bitmap wi= th + * set bits indicating the foreground color. Unset bits indicate background + * color. The fields @width and @height store a single glyph's number of + * horizontal bits and vertical scanlines. If width is not a multiple of 8, + * there are trailing bits to fill up the byte. These bits should not be d= rawn. + * + * The field @data points to the first glyph's first byte. The value @char= count + * gives the number of glyphs in the font. There are no empty scanlines be= tween + * two adjacent glyphs. + */ +struct vc_font { + unsigned int width; + unsigned int height; + unsigned int charcount; + const unsigned char *data; +}; + /* * Example: vc_data of a console that was scrolled 3 lines down. * @@ -122,7 +147,7 @@ struct vc_data { unsigned long vc_pos; /* Cursor address */ /* fonts */ unsigned short vc_hi_font_mask; /* [#] Attribute set for upper 256 chars = of font or 0 if not supported */ - struct console_font vc_font; /* Current VC font set */ + struct vc_font vc_font; /* Current VC font set */ unsigned short vc_video_erase_char; /* Background erase character */ /* VT terminal data */ unsigned int vc_state; /* Escape sequence parser state */ --=20 2.53.0 From nobody Thu Apr 9 10:29:59 2026 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9970217A305 for ; Mon, 9 Mar 2026 14:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065857; cv=none; b=mquxMBlprRiexeYVThozbYIrB9WUI8itftpeOOlR1s1NBRozNVMxuQn3TdItfRLGBfEZgz6vkqKeXsViMow8NzcRhmtOujmIVo7jVzdQh3tmG2/mi5b316lrKojW9B+ZjuyW/Q6FQ8cUelBonrdukgUOAk0rZOSRLMBHI2dH5JA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065857; c=relaxed/simple; bh=irufchddwo5YqDSW6oJwIedSRSzEXvSvW1In0pC7uFI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T4ec/m2d+4pEz8636/kis0Ur5WjTUyE33HaTnSVKSJhzvBTYYE6DDv/yCPQevr9G3V3C+qSLa2Iq2aGO0NZaz/fEaCsd0qz0VL5vboJ7H6WwzR6jil/EZo7oyAxUhyy2GfXHYA7gCDpOckAnhylwYmdl0rPpX7rY8tuuDfY7hKI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=L6BJzNpw; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=X8bPw+zT; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=L6BJzNpw; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=X8bPw+zT; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="L6BJzNpw"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="X8bPw+zT"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="L6BJzNpw"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="X8bPw+zT" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9383D5BE12; Mon, 9 Mar 2026 14:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CojlbhE18m4XtJrMFeXMaWQypY+aZWF/H0r2IOFVDiU=; b=L6BJzNpwPmoexBDfHbbpkO8Sl6sObsxyx5jDshG6pG6x/36oNllEGnitbaszJwOe6U3Jci /jzIYA3DuTOlX6kns+JwzODYlZYEh+Ch3fV8JXgB9r67JQxpbLdBQB5ED4fYT7O2t/ipQF Kski2qUz1ViLqvgqYmBnIHiudRcLe1Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CojlbhE18m4XtJrMFeXMaWQypY+aZWF/H0r2IOFVDiU=; b=X8bPw+zT3MiHribCG/SDrRyYO0Gl6Fp6ylxC6m9fmQUDDN9ZdeveLAkqTnSikLQ7QDmGXM o4Fk6BwTzNntZfDQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CojlbhE18m4XtJrMFeXMaWQypY+aZWF/H0r2IOFVDiU=; b=L6BJzNpwPmoexBDfHbbpkO8Sl6sObsxyx5jDshG6pG6x/36oNllEGnitbaszJwOe6U3Jci /jzIYA3DuTOlX6kns+JwzODYlZYEh+Ch3fV8JXgB9r67JQxpbLdBQB5ED4fYT7O2t/ipQF Kski2qUz1ViLqvgqYmBnIHiudRcLe1Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CojlbhE18m4XtJrMFeXMaWQypY+aZWF/H0r2IOFVDiU=; b=X8bPw+zT3MiHribCG/SDrRyYO0Gl6Fp6ylxC6m9fmQUDDN9ZdeveLAkqTnSikLQ7QDmGXM o4Fk6BwTzNntZfDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 595ED3EF3B; Mon, 9 Mar 2026 14:17:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cF2gFHrWrmldPAAAD6G6ig (envelope-from ); Mon, 09 Mar 2026 14:17:30 +0000 From: Thomas Zimmermann To: gregkh@linuxfoundation.org, deller@gmx.de, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v3 04/13] vt: Calculate font-buffer size with vc_font_size() Date: Mon, 9 Mar 2026 15:14:46 +0100 Message-ID: <20260309141723.137364-5-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309141723.137364-1-tzimmermann@suse.de> References: <20260309141723.137364-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[7]; FREEMAIL_TO(0.00)[linuxfoundation.org,gmx.de,ravnborg.org]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; URIBL_BLOCKED(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Spam-Flag: NO X-Spam-Score: -2.80 X-Spam-Level: Content-Type: text/plain; charset="utf-8" In fbcon, fbcon_resize() computes the size of the font buffer from the values stored in vc_font. Move these calculations to the dedicated helpers vc_font_pitch() and vc_font_size(). Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fbcon.c | 9 ++------- include/linux/console_struct.h | 28 ++++++++++++++++++++++++++++ 2 files changed, 30 insertions(+), 7 deletions(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fb= con.c index 247bb90c08d3..103e91c8d874 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -2037,7 +2037,6 @@ static void updatescrollmode(struct fbcon_display *p, } =20 #define PITCH(w) (((w) + 7) >> 3) -#define CALC_FONTSZ(h, p, c) ((h) * (p) * (c)) /* size =3D height * pitch = * charcount */ =20 static int fbcon_resize(struct vc_data *vc, unsigned int width, unsigned int height, bool from_user) @@ -2049,8 +2048,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned = int width, int x_diff, y_diff, virt_w, virt_h, virt_fw, virt_fh; =20 if (p->userfont && FNTSIZE(vc->vc_font.data)) { - int size; - int pitch =3D PITCH(vc->vc_font.width); + unsigned int size =3D vc_font_size(&vc->vc_font); =20 /* * If user font, ensure that a possible change to user font @@ -2059,10 +2057,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned= int width, * charcount can change and cannot be used to determine the * font data allocated size. */ - if (pitch <=3D 0) - return -EINVAL; - size =3D CALC_FONTSZ(vc->vc_font.height, pitch, vc->vc_font.charcount); - if (size > FNTSIZE(vc->vc_font.data)) + if (!size || size > FNTSIZE(vc->vc_font.data)) return -EINVAL; } =20 diff --git a/include/linux/console_struct.h b/include/linux/console_struct.h index ea0cdf4278a3..771cba16cb54 100644 --- a/include/linux/console_struct.h +++ b/include/linux/console_struct.h @@ -83,6 +83,34 @@ struct vc_font { const unsigned char *data; }; =20 +/** + * vc_font_pitch - Calculates the number of bytes between two adjacent sca= nlines + * @font: The VC font + * + * Returns: + * The number of bytes between two adjacent scanlines in the font data + */ +static inline unsigned int vc_font_pitch(const struct vc_font *font) +{ + return DIV_ROUND_UP(font->width, 8); +} + +/** + * vc_font_size - Calculates the size of the font data in bytes + * @font: The VC font + * + * vc_font_size() calculates the number of bytes of font data in the + * font specified by @font. The function calculates the size from the + * font parameters. + * + * Returns: + * The size of the font data in bytes. + */ +static inline unsigned int vc_font_size(const struct vc_font *font) +{ + return font->height * vc_font_pitch(font) * font->charcount; +} + /* * Example: vc_data of a console that was scrolled 3 lines down. * --=20 2.53.0 From nobody Thu Apr 9 10:29:59 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D49B93D3302 for ; Mon, 9 Mar 2026 14:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065880; cv=none; b=YXGkM94duluTpHhCJz/7iYs9fL8ptj3fRhFWS2p6iZbTotTFUYtamRUsw9t8UOCSU2Ln9Efiaks1OMeU1EUskzmR4oXpPfsu9Xv6nlv+N2VGTOVDvbP4gmcBCYLwMQ3FrM5HaAjj88dWhiz4lOkt12kvuqv5wigh69tI4/l41WY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065880; c=relaxed/simple; bh=y5XmvC6gfj9Y6OOeaLySFj7KBmblfrGrs0BAJ/FBFH4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SIHm3hsftYiuT3zoHAhnZLmxjsaEtx0HeQwo9FWF3x0ip7hUA8dJ1sw6rp/gXtDkjOIcMLdU+EZ6nsNdcIWOIw1qcC+xrmCaS2h5XgRgb5+kfCUt43uKn6Wu97uTztWpCfbBk8EVmqN9AqJjb6OkinbUA1qK5ZBXS8CllpcPIwI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=jyP/0uOb; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=YM2m50JT; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=jyP/0uOb; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=YM2m50JT; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="jyP/0uOb"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="YM2m50JT"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="jyP/0uOb"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="YM2m50JT" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D45824D244; Mon, 9 Mar 2026 14:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qDq/cW2yhQBHf4nLvdY7/6+Jg/oVSc5PEO9Oi8OztLE=; b=jyP/0uObNyczhEcc/srSa+nhKgkZ2MlXIgLqJyZYdn/mynAl6dO39P7bUXi6GNdo9WhzMD Ybp4Bkn3tEzj7CC842o5BVtUYOp1nn+78ywcUEfN3QBe7CuoZT0tk4L2PT041WYHCVfEkz 5bnasChPgUwuLWHeNhDSEKWPUEHSTJU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qDq/cW2yhQBHf4nLvdY7/6+Jg/oVSc5PEO9Oi8OztLE=; b=YM2m50JTUFDx0YV0ng/Y0V6LSaRYRCVhYq3C0NcW6vMXHrXLjjCDsw/RTqOVav6if/UPDy lCl3a6YxmEsRJMAA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qDq/cW2yhQBHf4nLvdY7/6+Jg/oVSc5PEO9Oi8OztLE=; b=jyP/0uObNyczhEcc/srSa+nhKgkZ2MlXIgLqJyZYdn/mynAl6dO39P7bUXi6GNdo9WhzMD Ybp4Bkn3tEzj7CC842o5BVtUYOp1nn+78ywcUEfN3QBe7CuoZT0tk4L2PT041WYHCVfEkz 5bnasChPgUwuLWHeNhDSEKWPUEHSTJU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qDq/cW2yhQBHf4nLvdY7/6+Jg/oVSc5PEO9Oi8OztLE=; b=YM2m50JTUFDx0YV0ng/Y0V6LSaRYRCVhYq3C0NcW6vMXHrXLjjCDsw/RTqOVav6if/UPDy lCl3a6YxmEsRJMAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9AD093EF3A; Mon, 9 Mar 2026 14:17:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id iBZgJHrWrmldPAAAD6G6ig (envelope-from ); Mon, 09 Mar 2026 14:17:30 +0000 From: Thomas Zimmermann To: gregkh@linuxfoundation.org, deller@gmx.de, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v3 05/13] lib/fonts: Remove trailing whitespaces Date: Mon, 9 Mar 2026 15:14:47 +0100 Message-ID: <20260309141723.137364-6-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309141723.137364-1-tzimmermann@suse.de> References: <20260309141723.137364-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.80 X-Spam-Level: X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[linuxfoundation.org,gmx.de,ravnborg.org]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Spam-Flag: NO Content-Type: text/plain; charset="utf-8" Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann --- lib/fonts/font_acorn_8x8.c | 2 +- lib/fonts/font_mini_4x6.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/fonts/font_acorn_8x8.c b/lib/fonts/font_acorn_8x8.c index 18755c33d249..af5fa72aa8b7 100644 --- a/lib/fonts/font_acorn_8x8.c +++ b/lib/fonts/font_acorn_8x8.c @@ -68,7 +68,7 @@ static const struct font_data acorndata_8x8 =3D { /* 3A */ 0x00, 0x00, 0x18, 0x18, 0x00, 0x18, 0x18, 0x00, /* : */ /* 3B */ 0x00, 0x00, 0x18, 0x18, 0x00, 0x18, 0x18, 0x30, /* ; */ /* 3C */ 0x0C, 0x18, 0x30, 0x60, 0x30, 0x18, 0x0C, 0x00, /* < */ -/* 3D */ 0x00, 0x00, 0x7E, 0x00, 0x7E, 0x00, 0x00, 0x00, /* =3D */=20 +/* 3D */ 0x00, 0x00, 0x7E, 0x00, 0x7E, 0x00, 0x00, 0x00, /* =3D */ /* 3E */ 0x30, 0x18, 0x0C, 0x06, 0x0C, 0x18, 0x30, 0x00, /* > */ /* 3F */ 0x3C, 0x66, 0x0C, 0x18, 0x18, 0x00, 0x18, 0x00, /* ? */ /* 40 */ 0x3C, 0x66, 0x6E, 0x6A, 0x6E, 0x60, 0x3C, 0x00, /* @ */ diff --git a/lib/fonts/font_mini_4x6.c b/lib/fonts/font_mini_4x6.c index 8d39fd447952..cc21dc70cfd1 100644 --- a/lib/fonts/font_mini_4x6.c +++ b/lib/fonts/font_mini_4x6.c @@ -18,15 +18,15 @@ s{((0x)?[0-9a-fA-F]+)(.*\[([\*\ ]{4})\])}{ =20 ($num,$pat,$bits) =3D ($1,$3,$4); -=09 + $bits =3D~ s/([^\s0])|(.)/ defined($1) + 0 /ge; -=09 + $num =3D ord(pack("B8", $bits)); $num |=3D $num >> 4; $num =3D sprintf("0x%.2x", $num); -=09 + #print "$num,$pat,$bits\n"; -=09 + $num . $pat; }ge; =20 --=20 2.53.0 From nobody Thu Apr 9 10:29:59 2026 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA83C38BF8C for ; Mon, 9 Mar 2026 14:17:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065863; cv=none; b=uipvH/hxqGWYnxD+nlH/g+NAdNbBMlH43oJrW/1AiKmWNzylQa/Mv+Bhi8MFnFWVlfmrbcDf4Zh8j2rkZXgJod76B+APjlUtEIeCNqvZyzksnNPlw1N1omtDktw0A17xJNWmxKLrf8lpkePxHInMADwV//XXokxNXL0aKVlaYbQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065863; c=relaxed/simple; bh=KALZsMCqudWuPmvMe0xoKmUA4AsvvKztti4OCOIbY0w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tTPJ7CFglQuu+RQAm0aRQJ5fGswiBZCGp90Rq4KOizwGKHg3i0EsJ2Ke3c9lhCE+5qBdacIQnO/l6eJa88A+55a0tWw2LARMyax+AQXh265rcRh9CbGrw4ehqxCKze7ohM2FhM1diDYo45QEnt3uqtNLxwU5i3Sao1Bz9cHPy+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=1WdUBwKT; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=OfALJV6F; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=1WdUBwKT; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=OfALJV6F; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="1WdUBwKT"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="OfALJV6F"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="1WdUBwKT"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="OfALJV6F" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2257F5BE1D; Mon, 9 Mar 2026 14:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AkFX7hcGtwsA7uQ5xnjWz1xBCczQKP2Ld4rm28KaAPI=; b=1WdUBwKTpHbscsvZSHd+jpZJdD5cG3cJZjTHMgBoa0K2vy2AdDu2mAiz3cmk1MJpU7N1eS XyLYjndNYaC2mZYdt/qi+xneU2D3JX/WFvZ4qIlGzvXeX2YZnO/pbU8YhegiavgMsPWbuV GVIkRgBCtsfWbqJuthTNtwRuNYDesiE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AkFX7hcGtwsA7uQ5xnjWz1xBCczQKP2Ld4rm28KaAPI=; b=OfALJV6FHBtPLvkz7fsL6Uu6Wndwmka6q3TRJnW+B/E3hRje0xSoJk7nWm2PhWa42HY97s y79FCiGkEqmmcRCA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1WdUBwKT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OfALJV6F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AkFX7hcGtwsA7uQ5xnjWz1xBCczQKP2Ld4rm28KaAPI=; b=1WdUBwKTpHbscsvZSHd+jpZJdD5cG3cJZjTHMgBoa0K2vy2AdDu2mAiz3cmk1MJpU7N1eS XyLYjndNYaC2mZYdt/qi+xneU2D3JX/WFvZ4qIlGzvXeX2YZnO/pbU8YhegiavgMsPWbuV GVIkRgBCtsfWbqJuthTNtwRuNYDesiE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AkFX7hcGtwsA7uQ5xnjWz1xBCczQKP2Ld4rm28KaAPI=; b=OfALJV6FHBtPLvkz7fsL6Uu6Wndwmka6q3TRJnW+B/E3hRje0xSoJk7nWm2PhWa42HY97s y79FCiGkEqmmcRCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DC4583EF3B; Mon, 9 Mar 2026 14:17:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id kEBaNHrWrmldPAAAD6G6ig (envelope-from ); Mon, 09 Mar 2026 14:17:30 +0000 From: Thomas Zimmermann To: gregkh@linuxfoundation.org, deller@gmx.de, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v3 06/13] lib/fonts: Remove FNTCHARCNT() Date: Mon, 9 Mar 2026 15:14:48 +0100 Message-ID: <20260309141723.137364-7-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309141723.137364-1-tzimmermann@suse.de> References: <20260309141723.137364-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,suse.de:email]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_TO(0.00)[linuxfoundation.org,gmx.de,ravnborg.org]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,suse.de:email]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[7]; R_RATELIMIT(0.00)[to_ip_from(RLf7er7x8tqp4b41gsueb7z9k6)]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Rspamd-Queue-Id: 2257F5BE1D X-Spam-Flag: NO X-Spam-Score: -3.01 X-Spam-Level: Content-Type: text/plain; charset="utf-8" The character count in the font data is unused. The internal fonts also do not set it. Remove FNTCHARCNT(). Signed-off-by: Thomas Zimmermann --- drivers/video/console/newport_con.c | 1 - include/linux/font.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/ne= wport_con.c index b178678566e7..e2922caa8685 100644 --- a/drivers/video/console/newport_con.c +++ b/drivers/video/console/newport_con.c @@ -516,7 +516,6 @@ static int newport_set_font(int unit, const struct cons= ole_font *op, =20 new_data +=3D FONT_EXTRA_WORDS * sizeof(int); FNTSIZE(new_data) =3D size; - FNTCHARCNT(new_data) =3D op->charcount; REFCOUNT(new_data) =3D 0; /* usage counter */ FNTSUM(new_data) =3D 0; =20 diff --git a/include/linux/font.h b/include/linux/font.h index fd8625cd76b2..d929c5fa32ca 100644 --- a/include/linux/font.h +++ b/include/linux/font.h @@ -68,7 +68,6 @@ extern const struct font_desc *get_default_font(int xres,= int yres, /* Extra word getters */ #define REFCOUNT(fd) (((int *)(fd))[-1]) #define FNTSIZE(fd) (((int *)(fd))[-2]) -#define FNTCHARCNT(fd) (((int *)(fd))[-3]) #define FNTSUM(fd) (((int *)(fd))[-4]) =20 #define FONT_EXTRA_WORDS 4 --=20 2.53.0 From nobody Thu Apr 9 10:29:59 2026 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4A3A3A4F35 for ; Mon, 9 Mar 2026 14:17:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065869; cv=none; b=psNtGNu8y4UYxozF6T+YlWbamOmc+Zs9DuBbNyfeJqbjPZyDKf9Gpa2V84R1XucCuxTvF/UYWtOob3L+tB2B1PE6IRPxua712sAv16K6fxsvR3coTkkhFpwBs0SRWystO82vxwrrlS980P8aaMl4nlio9gJhmrWrW/nNtyOSLeQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065869; c=relaxed/simple; bh=Ec8uqAPCVVEGOu01wxuxlQrqPf6B5dxNLK0WqdqWUd0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JXvfjF8dt1Tdipn1laejiQ8vlynRWyjkjchR6lQ9C5o+COjh0Ger13JGWFWKjKzRRRMPkK7LGjhFLj/HfFRnt1CRjxlHfXKeWRQDh0uDB0Urb08EGUX1DHQbH1KMxNTscGw+l1NB4ROnwqXQROlqUBSvRNpLp7Ilv4/7kYU9xUM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ugwIkBG/; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=hYJoTqT1; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ugwIkBG/; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=hYJoTqT1; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ugwIkBG/"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="hYJoTqT1"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ugwIkBG/"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="hYJoTqT1" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 635085BE30; Mon, 9 Mar 2026 14:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4GwfyKz1CnzrVU/2lMhApj6XqeXWfO4Wa9M5NaRIfqM=; b=ugwIkBG/JsH6Yh7EbBZHiLvr1QAOlmFMf2mlCj7kYDf2UhI9VEZGOlqoZBmVBBYoU9FV4m FrTY48XDlsdp6XPSMQaFyObtRqc9ipDmsk7Qdsmv5RueAFobGFL7TbFAe4iqJMulIyjacc GeMA3Dt5QPc/F8JT0uQ/wdPmfy19BDA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4GwfyKz1CnzrVU/2lMhApj6XqeXWfO4Wa9M5NaRIfqM=; b=hYJoTqT1L8tqbQL3VoEh9qkGrRr7g6xpZrCmi0MArUEgiYe6rICdlSQG10zaDWEGxGrvmf a/LvDVPj4CVRFsBw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4GwfyKz1CnzrVU/2lMhApj6XqeXWfO4Wa9M5NaRIfqM=; b=ugwIkBG/JsH6Yh7EbBZHiLvr1QAOlmFMf2mlCj7kYDf2UhI9VEZGOlqoZBmVBBYoU9FV4m FrTY48XDlsdp6XPSMQaFyObtRqc9ipDmsk7Qdsmv5RueAFobGFL7TbFAe4iqJMulIyjacc GeMA3Dt5QPc/F8JT0uQ/wdPmfy19BDA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4GwfyKz1CnzrVU/2lMhApj6XqeXWfO4Wa9M5NaRIfqM=; b=hYJoTqT1L8tqbQL3VoEh9qkGrRr7g6xpZrCmi0MArUEgiYe6rICdlSQG10zaDWEGxGrvmf a/LvDVPj4CVRFsBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2A87B3EF3A; Mon, 9 Mar 2026 14:17:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id uGj5CHvWrmldPAAAD6G6ig (envelope-from ); Mon, 09 Mar 2026 14:17:31 +0000 From: Thomas Zimmermann To: gregkh@linuxfoundation.org, deller@gmx.de, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v3 07/13] lib/fonts: Store font data as font_data_t; update consoles Date: Mon, 9 Mar 2026 15:14:49 +0100 Message-ID: <20260309141723.137364-8-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309141723.137364-1-tzimmermann@suse.de> References: <20260309141723.137364-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.80 X-Spam-Level: X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[linuxfoundation.org,gmx.de,ravnborg.org]; RCVD_TLS_ALL(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RL4936hw7dbgk3hb39jfn1xy19)]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Spam-Flag: NO Content-Type: text/plain; charset="utf-8" Store font data as pointer to font_data_t instead of unsigned char. Update consoles. Pointers to font data refer to the raw data. There is a hidden header before the data that contains additional state. Document the existing layout and semantics of font_data_t. The data field in struct vc_font can be used by any console. Therefore it still points to plain data without the additional header. Fbcon sets its value from struct fbcon_display.fontdata. Hence, update the size test in fbcon_resize() to use struct fbcon_display.fontdata instead of struct vc_font.data. v3: - fix typos (Helge) v2: - 'Font lookup' -> 'Font description' in Signed-off-by: Thomas Zimmermann --- drivers/video/console/newport_con.c | 17 ++++++----- drivers/video/fbdev/core/fbcon.c | 44 ++++++++++++++++----------- drivers/video/fbdev/core/fbcon.h | 3 +- include/linux/font.h | 47 ++++++++++++++++++++++++++++- 4 files changed, 84 insertions(+), 27 deletions(-) diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/ne= wport_con.c index e2922caa8685..9b9ed1940404 100644 --- a/drivers/video/console/newport_con.c +++ b/drivers/video/console/newport_con.c @@ -33,9 +33,9 @@ =20 #define NEWPORT_LEN 0x10000 =20 -#define FONT_DATA ((unsigned char *)font_vga_8x16.data) +#define FONT_DATA font_vga_8x16.data =20 -static unsigned char *font_data[MAX_NR_CONSOLES]; +static font_data_t *font_data[MAX_NR_CONSOLES]; =20 static struct newport_regs *npregs; static unsigned long newport_addr; @@ -370,9 +370,9 @@ static void newport_clear(struct vc_data *vc, unsigned = int sy, unsigned int sx, static void newport_putc(struct vc_data *vc, u16 charattr, unsigned int yp= os, unsigned int xpos) { - unsigned char *p; + const unsigned char *p; =20 - p =3D &font_data[vc->vc_num][(charattr & 0xff) << 4]; + p =3D &font_data_buf(font_data[vc->vc_num])[(charattr & 0xff) << 4]; charattr =3D (charattr >> 8) & 0xff; xpos <<=3D 3; ypos <<=3D 4; @@ -400,7 +400,7 @@ static void newport_putcs(struct vc_data *vc, const u16= *s, unsigned int count, unsigned int ypos, unsigned int xpos) { - unsigned char *p; + const unsigned char *p; unsigned int i; u16 charattr; =20 @@ -424,7 +424,7 @@ static void newport_putcs(struct vc_data *vc, const u16= *s, NPORT_DMODE0_L32); =20 for (i =3D 0; i < count; i++, xpos +=3D 8) { - p =3D &font_data[vc->vc_num][(scr_readw(s++) & 0xff) << 4]; + p =3D &font_data_buf(font_data[vc->vc_num])[(scr_readw(s++) & 0xff) << 4= ]; =20 newport_wait(npregs); =20 @@ -503,7 +503,8 @@ static int newport_set_font(int unit, const struct cons= ole_font *op, int h =3D op->height; int size =3D h * op->charcount; int i; - unsigned char *new_data, *data =3D op->data, *p; + font_data_t *new_data; + unsigned char *data =3D op->data, *p; =20 /* ladis: when I grow up, there will be a day... and more sizes will * be supported ;-) */ @@ -519,7 +520,7 @@ static int newport_set_font(int unit, const struct cons= ole_font *op, REFCOUNT(new_data) =3D 0; /* usage counter */ FNTSUM(new_data) =3D 0; =20 - p =3D new_data; + p =3D (unsigned char *)font_data_buf(new_data); for (i =3D 0; i < op->charcount; i++) { memcpy(p, data, h); data +=3D 32; diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fb= con.c index 103e91c8d874..8d7840b9ebad 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -1019,8 +1019,10 @@ static const char *fbcon_startup(void) info->pixmap.blit_y); vc->vc_font.width =3D font->width; vc->vc_font.height =3D font->height; - vc->vc_font.data =3D (void *)(p->fontdata =3D font->data); + vc->vc_font.data =3D font_data_buf(font->data); vc->vc_font.charcount =3D font->charcount; + + p->fontdata =3D font->data; } =20 cols =3D FBCON_SWAP(par->rotate, info->var.xres, info->var.yres); @@ -1078,11 +1080,12 @@ static void fbcon_init(struct vc_data *vc, bool ini= t) if (t->fontdata) { struct vc_data *fvc =3D vc_cons[fg_console].d; =20 - vc->vc_font.data =3D (void *)(p->fontdata =3D - fvc->vc_font.data); + vc->vc_font.data =3D fvc->vc_font.data; vc->vc_font.width =3D fvc->vc_font.width; vc->vc_font.height =3D fvc->vc_font.height; vc->vc_font.charcount =3D fvc->vc_font.charcount; + + p->fontdata =3D t->fontdata; p->userfont =3D t->userfont; =20 if (p->userfont) @@ -1097,8 +1100,10 @@ static void fbcon_init(struct vc_data *vc, bool init) info->pixmap.blit_y); vc->vc_font.width =3D font->width; vc->vc_font.height =3D font->height; - vc->vc_font.data =3D (void *)(p->fontdata =3D font->data); + vc->vc_font.data =3D font_data_buf(font->data); vc->vc_font.charcount =3D font->charcount; + + p->fontdata =3D font->data; } } =20 @@ -1409,11 +1414,12 @@ static void fbcon_set_disp(struct fb_info *info, st= ruct fb_var_screeninfo *var, svc =3D *default_mode; t =3D &fb_display[svc->vc_num]; =20 - if (!vc->vc_font.data) { - vc->vc_font.data =3D (void *)(p->fontdata =3D t->fontdata); + if (!p->fontdata) { + vc->vc_font.data =3D font_data_buf(t->fontdata); vc->vc_font.width =3D (*default_mode)->vc_font.width; vc->vc_font.height =3D (*default_mode)->vc_font.height; vc->vc_font.charcount =3D (*default_mode)->vc_font.charcount; + p->fontdata =3D t->fontdata; p->userfont =3D t->userfont; if (p->userfont) REFCOUNT(p->fontdata)++; @@ -2047,7 +2053,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned = int width, struct fb_var_screeninfo var =3D info->var; int x_diff, y_diff, virt_w, virt_h, virt_fw, virt_fh; =20 - if (p->userfont && FNTSIZE(vc->vc_font.data)) { + if (p->userfont && FNTSIZE(p->fontdata)) { unsigned int size =3D vc_font_size(&vc->vc_font); =20 /* @@ -2057,7 +2063,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned = int width, * charcount can change and cannot be used to determine the * font data allocated size. */ - if (!size || size > FNTSIZE(vc->vc_font.data)) + if (!size || size > FNTSIZE(p->fontdata)) return -EINVAL; } =20 @@ -2281,7 +2287,8 @@ static bool fbcon_blank(struct vc_data *vc, enum vesa= _blank_mode blank, =20 static int fbcon_get_font(struct vc_data *vc, struct console_font *font, u= nsigned int vpitch) { - const u8 *fontdata =3D vc->vc_font.data; + struct fbcon_display *p =3D &fb_display[vc->vc_num]; + font_data_t *fontdata =3D p->fontdata; u8 *data =3D font->data; int i, j; =20 @@ -2406,16 +2413,18 @@ static void set_vc_hi_font(struct vc_data *vc, bool= set) } =20 static int fbcon_do_set_font(struct vc_data *vc, int w, int h, int charcou= nt, - const u8 * data, int userfont) + font_data_t *data, int userfont) { struct fb_info *info =3D fbcon_info_from_console(vc->vc_num); struct fbcon_par *par =3D info->fbcon_par; struct fbcon_display *p =3D &fb_display[vc->vc_num]; int resize, ret, old_userfont, old_width, old_height, old_charcount; + font_data_t *old_fontdata =3D p->fontdata; const u8 *old_data =3D vc->vc_font.data; =20 resize =3D (w !=3D vc->vc_font.width) || (h !=3D vc->vc_font.height); - vc->vc_font.data =3D (void *)(p->fontdata =3D data); + p->fontdata =3D data; + vc->vc_font.data =3D font_data_buf(p->fontdata); old_userfont =3D p->userfont; if ((p->userfont =3D userfont)) REFCOUNT(data)++; @@ -2448,12 +2457,12 @@ static int fbcon_do_set_font(struct vc_data *vc, in= t w, int h, int charcount, update_screen(vc); } =20 - if (old_userfont && (--REFCOUNT(old_data) =3D=3D 0)) - kfree(old_data - FONT_EXTRA_WORDS * sizeof(int)); + if (old_userfont && (--REFCOUNT(old_fontdata) =3D=3D 0)) + kfree(old_fontdata - FONT_EXTRA_WORDS * sizeof(int)); return 0; =20 err_out: - p->fontdata =3D old_data; + p->fontdata =3D old_fontdata; vc->vc_font.data =3D old_data; =20 if (userfont) { @@ -2483,7 +2492,8 @@ static int fbcon_set_font(struct vc_data *vc, const s= truct console_font *font, int h =3D font->height; int size, alloc_size; int i, csum; - u8 *new_data, *data =3D font->data; + font_data_t *new_data; + u8 *data =3D font->data; int pitch =3D PITCH(font->width); =20 /* Is there a reason why fbconsole couldn't handle any charcount >256? @@ -2522,13 +2532,13 @@ static int fbcon_set_font(struct vc_data *vc, const= struct console_font *font, if (!new_data) return -ENOMEM; =20 - memset(new_data, 0, FONT_EXTRA_WORDS * sizeof(int)); + memset((u8 *)new_data, 0, FONT_EXTRA_WORDS * sizeof(int)); =20 new_data +=3D FONT_EXTRA_WORDS * sizeof(int); FNTSIZE(new_data) =3D size; REFCOUNT(new_data) =3D 0; /* usage counter */ for (i=3D0; i< charcount; i++) { - memcpy(new_data + i*h*pitch, data + i*vpitch*pitch, h*pitch); + memcpy((u8 *)new_data + i * h * pitch, data + i * vpitch * pitch, h * pi= tch); } =20 /* Since linux has a nice crc32 function use it for counting font diff --git a/drivers/video/fbdev/core/fbcon.h b/drivers/video/fbdev/core/fb= con.h index 3f4386a40237..d26ee7860cf5 100644 --- a/drivers/video/fbdev/core/fbcon.h +++ b/drivers/video/fbdev/core/fbcon.h @@ -11,6 +11,7 @@ #ifndef _VIDEO_FBCON_H #define _VIDEO_FBCON_H =20 +#include #include #include #include @@ -25,7 +26,7 @@ =20 struct fbcon_display { /* Filled in by the low-level console driver */ - const u_char *fontdata; + font_data_t *fontdata; int userfont; /* !=3D 0 if fontdata kmalloc()ed */ #ifdef CONFIG_FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION u_short scrollmode; /* Scroll Method, use fb_scrollmode() = */ diff --git a/include/linux/font.h b/include/linux/font.h index d929c5fa32ca..746a0996a018 100644 --- a/include/linux/font.h +++ b/include/linux/font.h @@ -13,12 +13,57 @@ =20 #include =20 +/* + * font_data_t and helpers + */ + +/** + * font_data_t - Raw font data + * + * Values of type font_data_t store a pointer to raw font data. The format + * is monochrome. Each bit sets a pixel of a stored glyph. Font data does + * not store geometry information for the individual glyphs. Users of the + * font have to store glyph size, pitch and character count separately. + * + * Font data in font_data_t is not equivalent to raw u8. Each pointer stor= es + * an additional hidden header before the font data. The layout is + * + * +------+-----------------------------+ + * | -16 | CRC32 Checksum (optional) | + * | -12 | | + * | -8 | Number of data bytes | + * | -4 | Reference count | + * +------+-----------------------------+ + * | 0 | Data buffer | + * | ... | | + * +------+-----------------------------+ + * + * Use helpers to access font_data_t. Use font_data_buf() to get the store= d data. + */ +typedef const unsigned char font_data_t; + +/** + * font_data_buf() - Returns the font data as raw bytes + * @fd: The font data + * + * Returns: + * The raw font data. The provided buffer is read-only. + */ +static inline const unsigned char *font_data_buf(font_data_t *fd) +{ + return (const unsigned char *)fd; +} + +/* + * Font description + */ + struct font_desc { int idx; const char *name; unsigned int width, height; unsigned int charcount; - const void *data; + font_data_t *data; int pref; }; =20 --=20 2.53.0 From nobody Thu Apr 9 10:29:59 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC3D43D3336 for ; Mon, 9 Mar 2026 14:18:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065886; cv=none; b=VMR6WbFRSq8wB5tYi+W9lweJJfmkKffz6M+sFGhdTjUQsO6DsgHOdGTxlvDn1KUlYzBNdSr8XyWTDw30J6LbMuXz7G/ZELU0xdN3IVGYquDXriMk0uhvMeL7IHsiJo8cMUO1dD0wwDO20SAmpIdPRMlxelba/dZaP97EvUQsN6I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065886; c=relaxed/simple; bh=DmpTcq1/gxch4hqVZJqYD+vTMvsSzi539GjU63Ijs5A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tU5rjiEC8sraOsrQbesSWagwYlPgr24aVe4x8AueSgkBKkNqiXXF9J+wnVAJxpSP37nMD5HY5LNbheASBXQhAtm+2fhP8Wz8tp0fDzobgG2M+Tgm1ccB6zcD0vOMKF7n660Y7j+6O9C7KHgaiQ5YRBpJZMwGfCJjbKKPnaBdVL8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=HEsInjqY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=O8A0LMo3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=HEsInjqY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=O8A0LMo3; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="HEsInjqY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="O8A0LMo3"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="HEsInjqY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="O8A0LMo3" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A40CA4D245; Mon, 9 Mar 2026 14:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oUC2mIo4tUrTZUNX2EfkauQqCIcqtkYNh5yqtKngBf8=; b=HEsInjqYCTKEo4z4d9mY2cJhNEfJJkWhXkZ7ptc1Ulu6dG2CObZ825r3TxOhjs4hyYCv+u WxsqaYePES2vds7XoQeQuh/KVVsgQLUPPJblrIqKw1G5l29QcTWwzEhKZYdWPTdgskXy7w ZqJPdVuQeOrXXvLF2LLJcpzkcqjYeHw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oUC2mIo4tUrTZUNX2EfkauQqCIcqtkYNh5yqtKngBf8=; b=O8A0LMo3Em+lCAZJEKtnOuq4Vi4AQTmrsDfiJzPGWQWumQV573BAfgFpAOyTVdGjssUVJj b5iYE4qSb4SCjACw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=HEsInjqY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=O8A0LMo3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oUC2mIo4tUrTZUNX2EfkauQqCIcqtkYNh5yqtKngBf8=; b=HEsInjqYCTKEo4z4d9mY2cJhNEfJJkWhXkZ7ptc1Ulu6dG2CObZ825r3TxOhjs4hyYCv+u WxsqaYePES2vds7XoQeQuh/KVVsgQLUPPJblrIqKw1G5l29QcTWwzEhKZYdWPTdgskXy7w ZqJPdVuQeOrXXvLF2LLJcpzkcqjYeHw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oUC2mIo4tUrTZUNX2EfkauQqCIcqtkYNh5yqtKngBf8=; b=O8A0LMo3Em+lCAZJEKtnOuq4Vi4AQTmrsDfiJzPGWQWumQV573BAfgFpAOyTVdGjssUVJj b5iYE4qSb4SCjACw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6AF213EF3B; Mon, 9 Mar 2026 14:17:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CKivGHvWrmldPAAAD6G6ig (envelope-from ); Mon, 09 Mar 2026 14:17:31 +0000 From: Thomas Zimmermann To: gregkh@linuxfoundation.org, deller@gmx.de, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v3 08/13] lib/fonts: Read font size with font_data_size() Date: Mon, 9 Mar 2026 15:14:50 +0100 Message-ID: <20260309141723.137364-9-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309141723.137364-1-tzimmermann@suse.de> References: <20260309141723.137364-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,suse.de:email]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FREEMAIL_TO(0.00)[linuxfoundation.org,gmx.de,ravnborg.org]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,suse.de:email]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[7]; R_RATELIMIT(0.00)[to_ip_from(RLf7er7x8tqp4b41gsueb7z9k6)]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Rspamd-Queue-Id: A40CA4D245 X-Spam-Flag: NO X-Spam-Score: -3.01 X-Spam-Level: Content-Type: text/plain; charset="utf-8" Add font_data_size() and update consoles to use it. Signed-off-by: Thomas Zimmermann --- drivers/video/console/newport_con.c | 2 +- drivers/video/fbdev/core/fbcon.c | 14 +++++++------- include/linux/font.h | 2 ++ lib/fonts/fonts.c | 21 +++++++++++++++++++++ 4 files changed, 31 insertions(+), 8 deletions(-) diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/ne= wport_con.c index 9b9ed1940404..1198c6bc2777 100644 --- a/drivers/video/console/newport_con.c +++ b/drivers/video/console/newport_con.c @@ -530,7 +530,7 @@ static int newport_set_font(int unit, const struct cons= ole_font *op, /* check if font is already used by other console */ for (i =3D 0; i < MAX_NR_CONSOLES; i++) { if (font_data[i] !=3D FONT_DATA - && FNTSIZE(font_data[i]) =3D=3D size + && font_data_size(font_data[i]) =3D=3D size && !memcmp(font_data[i], new_data, size)) { kfree(new_data - FONT_EXTRA_WORDS * sizeof(int)); /* current font is the same as the new one */ diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fb= con.c index 8d7840b9ebad..fa8f3e4196de 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -2053,7 +2053,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned = int width, struct fb_var_screeninfo var =3D info->var; int x_diff, y_diff, virt_w, virt_h, virt_fw, virt_fh; =20 - if (p->userfont && FNTSIZE(p->fontdata)) { + if (p->userfont && font_data_size(p->fontdata)) { unsigned int size =3D vc_font_size(&vc->vc_font); =20 /* @@ -2063,7 +2063,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned = int width, * charcount can change and cannot be used to determine the * font data allocated size. */ - if (!size || size > FNTSIZE(p->fontdata)) + if (!size || size > font_data_size(p->fontdata)) return -EINVAL; } =20 @@ -2302,7 +2302,7 @@ static int fbcon_get_font(struct vc_data *vc, struct = console_font *font, unsigne =20 if (font->width <=3D 8) { j =3D vc->vc_font.height; - if (font->charcount * j > FNTSIZE(fontdata)) + if (font->charcount * j > font_data_size(fontdata)) return -EINVAL; =20 for (i =3D 0; i < font->charcount; i++) { @@ -2313,7 +2313,7 @@ static int fbcon_get_font(struct vc_data *vc, struct = console_font *font, unsigne } } else if (font->width <=3D 16) { j =3D vc->vc_font.height * 2; - if (font->charcount * j > FNTSIZE(fontdata)) + if (font->charcount * j > font_data_size(fontdata)) return -EINVAL; =20 for (i =3D 0; i < font->charcount; i++) { @@ -2323,7 +2323,7 @@ static int fbcon_get_font(struct vc_data *vc, struct = console_font *font, unsigne fontdata +=3D j; } } else if (font->width <=3D 24) { - if (font->charcount * (vc->vc_font.height * sizeof(u32)) > FNTSIZE(fontd= ata)) + if (font->charcount * (vc->vc_font.height * sizeof(u32)) > font_data_siz= e(fontdata)) return -EINVAL; =20 for (i =3D 0; i < font->charcount; i++) { @@ -2338,7 +2338,7 @@ static int fbcon_get_font(struct vc_data *vc, struct = console_font *font, unsigne } } else { j =3D vc->vc_font.height * 4; - if (font->charcount * j > FNTSIZE(fontdata)) + if (font->charcount * j > font_data_size(fontdata)) return -EINVAL; =20 for (i =3D 0; i < font->charcount; i++) { @@ -2553,7 +2553,7 @@ static int fbcon_set_font(struct vc_data *vc, const s= truct console_font *font, if (fb_display[i].userfont && fb_display[i].fontdata && FNTSUM(fb_display[i].fontdata) =3D=3D csum && - FNTSIZE(fb_display[i].fontdata) =3D=3D size && + font_data_size(fb_display[i].fontdata) =3D=3D size && tmp->vc_font.width =3D=3D w && !memcmp(fb_display[i].fontdata, new_data, size)) { kfree(new_data - FONT_EXTRA_WORDS * sizeof(int)); diff --git a/include/linux/font.h b/include/linux/font.h index 746a0996a018..5b8557813c5c 100644 --- a/include/linux/font.h +++ b/include/linux/font.h @@ -54,6 +54,8 @@ static inline const unsigned char *font_data_buf(font_dat= a_t *fd) return (const unsigned char *)fd; } =20 +unsigned int font_data_size(font_data_t *fd); + /* * Font description */ diff --git a/lib/fonts/fonts.c b/lib/fonts/fonts.c index a7f118b30171..8c9a6762061c 100644 --- a/lib/fonts/fonts.c +++ b/lib/fonts/fonts.c @@ -20,6 +20,27 @@ #endif #include =20 +/* + * Helpers for font_data_t + */ + +/** + * font_data_size - Return size of the font data in bytes + * @fd: Font data + * + * Returns: + * The number of bytes in the given font data. + */ +unsigned int font_data_size(font_data_t *fd) +{ + return FNTSIZE(fd); +} +EXPORT_SYMBOL_GPL(font_data_size); + +/* + * Font lookup + */ + static const struct font_desc *fonts[] =3D { #ifdef CONFIG_FONT_8x8 &font_vga_8x8, --=20 2.53.0 From nobody Thu Apr 9 10:29:59 2026 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3537E212542 for ; Mon, 9 Mar 2026 14:17:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065876; cv=none; b=STNkv9lWdyWUTk0S5ppmBhQ3+P0GtzNtKU98PpLwbT9F/fbcGetJbhIK6wudx+IeEBYOUKYw+5xnuOfIEQi8wB8v1g7RTbNqF5zj+kkxwvmKi9JEyoUSND4/TLHizQVQzvFbxdeYLWYqBxfKR9qnZ/1SZPRCRvZU6U3nA9R27cY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065876; c=relaxed/simple; bh=WewjjtXdKQpTembo/e0yO53K4zOxy/gJfLBXdGE2cnE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jh43ApIPfjKRGiZbLJzMZRMI0QeKulWvmewkinvaDjUcma8RKdoYFjkY6YoyZ5aAwIYrvGtm0NIIueTOCdEf/xIj4hLCncKzWAxwwyRYi8z+1C9ZxjjX9iHOEGGiSZ8lZLG/JhF5WpnsBOt/UxSHLHcGo82O3mlnMEVuCo0wIi4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ooO3toEs; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Puy1AAXl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=A0+AzUWT; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=i95zCBre; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ooO3toEs"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Puy1AAXl"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="A0+AzUWT"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="i95zCBre" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E6DD55BE46; Mon, 9 Mar 2026 14:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o1BEAZBgrs3tl2TzVltJUpqKLE0TELI4Ye8XVbDaUKU=; b=ooO3toEsjHFOuCS3UgWUXP4zAzNFcOjPAMGmWdwHWt/WxkzGwrcVLe2wql9TrwJJP9Cbaz GJ9X3O+Qu9fvtneqE0UmQfQNeTLU4dPQzoqXrfM5FM9rgYKbxxWUslHQMHlcq6qstC6TLK +MIwDStQydbdbFAW0ll0e0AboBWrwtQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o1BEAZBgrs3tl2TzVltJUpqKLE0TELI4Ye8XVbDaUKU=; b=Puy1AAXlvhJ+vK2ubgiehAWXe1hrbM7mFmKAAwRVrp40NAKwmLvoQo+6HPmJc5i8NWdjQR N/GR98du9aFxd1AQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o1BEAZBgrs3tl2TzVltJUpqKLE0TELI4Ye8XVbDaUKU=; b=A0+AzUWTKeS+4VckWYuuvHbs16HU5DldQpIkusvS34hF8UusQsxfiKKVFCpgX/FcsqVE/p bvDQTn3Sz7sWrym9MGvAEzIVW4jIGyW1tT+8AIHwWVLnhCTQ86G9vuzIT6El3gh++Jgn+W Via9EgOKJSd3lZq4N8V1hBFpWT8/438= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o1BEAZBgrs3tl2TzVltJUpqKLE0TELI4Ye8XVbDaUKU=; b=i95zCBreoZ9FKrGmKh2KHBNoe1AucAavtlIcJa1rbeOJ3VmYXbl04x3fmv3AB4UzNJKpcH 9Q7n6rPQczR5aEAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AC7EA3EF3A; Mon, 9 Mar 2026 14:17:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +MOsKHvWrmldPAAAD6G6ig (envelope-from ); Mon, 09 Mar 2026 14:17:31 +0000 From: Thomas Zimmermann To: gregkh@linuxfoundation.org, deller@gmx.de, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v3 09/13] lib/fonts: Manage font-data lifetime with font_data_get/_put() Date: Mon, 9 Mar 2026 15:14:51 +0100 Message-ID: <20260309141723.137364-10-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309141723.137364-1-tzimmermann@suse.de> References: <20260309141723.137364-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.80 X-Spam-Level: X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[linuxfoundation.org,gmx.de,ravnborg.org]; RCVD_TLS_ALL(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RL4936hw7dbgk3hb39jfn1xy19)]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Spam-Flag: NO Content-Type: text/plain; charset="utf-8" Add font_data_get() and font_data_put(). Update consoles to use them over REFCOUNT() and plain kfree(). Newly allocated font data starts with a reference count of 1. Loading the font puts the previously loaded font. If the reference count reaches zero, font_data_put() frees the font data. The kernel stores a refcount of zero for internal font data. Invoking font_data_get() and font_data_put() tests this internally and returns success without further operation. From the caller's perspective, getting and putting works the same for all font data. Fbcon used the userfont flag distinguish between internal fonts and fonts loaded by user space. Only the latter where refcounted. With the new helper's automatic handling of internal font data, remove the userfont flag from fbcon. Newport_con uses a default font, FONT_DATA, until user space loads custom font data. Remove all special cases for FONT_DATA, as the get and put calls' read-only handling also covers this case. v3: - fix module linker error wrt font symbols (Nathan, Arnd) - fix typos Signed-off-by: Thomas Zimmermann --- drivers/video/console/newport_con.c | 23 +++------ drivers/video/fbdev/core/fbcon.c | 65 +++++++++++------------- drivers/video/fbdev/core/fbcon.h | 1 - include/linux/font.h | 2 + lib/fonts/fonts.c | 77 ++++++++++++++++++++++++++++- 5 files changed, 115 insertions(+), 53 deletions(-) diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/ne= wport_con.c index 1198c6bc2777..43a1a4f41057 100644 --- a/drivers/video/console/newport_con.c +++ b/drivers/video/console/newport_con.c @@ -517,7 +517,7 @@ static int newport_set_font(int unit, const struct cons= ole_font *op, =20 new_data +=3D FONT_EXTRA_WORDS * sizeof(int); FNTSIZE(new_data) =3D size; - REFCOUNT(new_data) =3D 0; /* usage counter */ + REFCOUNT(new_data) =3D 1; /* usage counter */ FNTSUM(new_data) =3D 0; =20 p =3D (unsigned char *)font_data_buf(new_data); @@ -532,21 +532,17 @@ static int newport_set_font(int unit, const struct co= nsole_font *op, if (font_data[i] !=3D FONT_DATA && font_data_size(font_data[i]) =3D=3D size && !memcmp(font_data[i], new_data, size)) { - kfree(new_data - FONT_EXTRA_WORDS * sizeof(int)); + font_data_put(new_data); /* current font is the same as the new one */ if (i =3D=3D unit) return 0; new_data =3D font_data[i]; + font_data_get(new_data); break; } } - /* old font is user font */ - if (font_data[unit] !=3D FONT_DATA) { - if (--REFCOUNT(font_data[unit]) =3D=3D 0) - kfree(font_data[unit] - - FONT_EXTRA_WORDS * sizeof(int)); - } - REFCOUNT(new_data)++; + + font_data_put(font_data[unit]); font_data[unit] =3D new_data; =20 return 0; @@ -554,12 +550,9 @@ static int newport_set_font(int unit, const struct con= sole_font *op, =20 static int newport_set_def_font(int unit, struct console_font *op) { - if (font_data[unit] !=3D FONT_DATA) { - if (--REFCOUNT(font_data[unit]) =3D=3D 0) - kfree(font_data[unit] - - FONT_EXTRA_WORDS * sizeof(int)); - font_data[unit] =3D FONT_DATA; - } + font_data_put(font_data[unit]); + font_data[unit] =3D FONT_DATA; + font_data_get(font_data[unit]); =20 return 0; } diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fb= con.c index fa8f3e4196de..ac59480c98cb 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -1023,6 +1023,7 @@ static const char *fbcon_startup(void) vc->vc_font.charcount =3D font->charcount; =20 p->fontdata =3D font->data; + font_data_get(p->fontdata); } =20 cols =3D FBCON_SWAP(par->rotate, info->var.xres, info->var.yres); @@ -1086,10 +1087,7 @@ static void fbcon_init(struct vc_data *vc, bool init) vc->vc_font.charcount =3D fvc->vc_font.charcount; =20 p->fontdata =3D t->fontdata; - p->userfont =3D t->userfont; - - if (p->userfont) - REFCOUNT(p->fontdata)++; + font_data_get(p->fontdata); } else { const struct font_desc *font =3D NULL; =20 @@ -1104,6 +1102,7 @@ static void fbcon_init(struct vc_data *vc, bool init) vc->vc_font.charcount =3D font->charcount; =20 p->fontdata =3D font->data; + font_data_get(p->fontdata); } } =20 @@ -1194,10 +1193,10 @@ static void fbcon_init(struct vc_data *vc, bool ini= t) =20 static void fbcon_free_font(struct fbcon_display *p) { - if (p->userfont && p->fontdata && (--REFCOUNT(p->fontdata) =3D=3D 0)) - kfree(p->fontdata - FONT_EXTRA_WORDS * sizeof(int)); - p->fontdata =3D NULL; - p->userfont =3D 0; + if (p->fontdata) { + font_data_put(p->fontdata); + p->fontdata =3D NULL; + } } =20 static void set_vc_hi_font(struct vc_data *vc, bool set); @@ -1420,9 +1419,7 @@ static void fbcon_set_disp(struct fb_info *info, stru= ct fb_var_screeninfo *var, vc->vc_font.height =3D (*default_mode)->vc_font.height; vc->vc_font.charcount =3D (*default_mode)->vc_font.charcount; p->fontdata =3D t->fontdata; - p->userfont =3D t->userfont; - if (p->userfont) - REFCOUNT(p->fontdata)++; + font_data_get(p->fontdata); } =20 var->activate =3D FB_ACTIVATE_NOW; @@ -2053,7 +2050,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned = int width, struct fb_var_screeninfo var =3D info->var; int x_diff, y_diff, virt_w, virt_h, virt_fw, virt_fh; =20 - if (p->userfont && font_data_size(p->fontdata)) { + if (font_data_size(p->fontdata)) { unsigned int size =3D vc_font_size(&vc->vc_font); =20 /* @@ -2413,21 +2410,20 @@ static void set_vc_hi_font(struct vc_data *vc, bool= set) } =20 static int fbcon_do_set_font(struct vc_data *vc, int w, int h, int charcou= nt, - font_data_t *data, int userfont) + font_data_t *data) { struct fb_info *info =3D fbcon_info_from_console(vc->vc_num); struct fbcon_par *par =3D info->fbcon_par; struct fbcon_display *p =3D &fb_display[vc->vc_num]; - int resize, ret, old_userfont, old_width, old_height, old_charcount; + int resize, ret, old_width, old_height, old_charcount; font_data_t *old_fontdata =3D p->fontdata; const u8 *old_data =3D vc->vc_font.data; =20 + font_data_get(data); + resize =3D (w !=3D vc->vc_font.width) || (h !=3D vc->vc_font.height); p->fontdata =3D data; vc->vc_font.data =3D font_data_buf(p->fontdata); - old_userfont =3D p->userfont; - if ((p->userfont =3D userfont)) - REFCOUNT(data)++; =20 old_width =3D vc->vc_font.width; old_height =3D vc->vc_font.height; @@ -2457,24 +2453,20 @@ static int fbcon_do_set_font(struct vc_data *vc, in= t w, int h, int charcount, update_screen(vc); } =20 - if (old_userfont && (--REFCOUNT(old_fontdata) =3D=3D 0)) - kfree(old_fontdata - FONT_EXTRA_WORDS * sizeof(int)); + if (old_fontdata) + font_data_put(old_fontdata); + return 0; =20 err_out: p->fontdata =3D old_fontdata; vc->vc_font.data =3D old_data; - - if (userfont) { - p->userfont =3D old_userfont; - if (--REFCOUNT(data) =3D=3D 0) - kfree(data - FONT_EXTRA_WORDS * sizeof(int)); - } - vc->vc_font.width =3D old_width; vc->vc_font.height =3D old_height; vc->vc_font.charcount =3D old_charcount; =20 + font_data_put(data); + return ret; } =20 @@ -2491,9 +2483,9 @@ static int fbcon_set_font(struct vc_data *vc, const s= truct console_font *font, int w =3D font->width; int h =3D font->height; int size, alloc_size; - int i, csum; + int i, csum, ret; font_data_t *new_data; - u8 *data =3D font->data; + const u8 *data =3D font->data; int pitch =3D PITCH(font->width); =20 /* Is there a reason why fbconsole couldn't handle any charcount >256? @@ -2536,7 +2528,7 @@ static int fbcon_set_font(struct vc_data *vc, const s= truct console_font *font, =20 new_data +=3D FONT_EXTRA_WORDS * sizeof(int); FNTSIZE(new_data) =3D size; - REFCOUNT(new_data) =3D 0; /* usage counter */ + REFCOUNT(new_data) =3D 1; /* usage counter */ for (i=3D0; i< charcount; i++) { memcpy((u8 *)new_data + i * h * pitch, data + i * vpitch * pitch, h * pi= tch); } @@ -2550,18 +2542,21 @@ static int fbcon_set_font(struct vc_data *vc, const= struct console_font *font, for (i =3D first_fb_vc; i <=3D last_fb_vc; i++) { struct vc_data *tmp =3D vc_cons[i].d; =20 - if (fb_display[i].userfont && - fb_display[i].fontdata && + if (fb_display[i].fontdata && FNTSUM(fb_display[i].fontdata) =3D=3D csum && font_data_size(fb_display[i].fontdata) =3D=3D size && tmp->vc_font.width =3D=3D w && !memcmp(fb_display[i].fontdata, new_data, size)) { - kfree(new_data - FONT_EXTRA_WORDS * sizeof(int)); - new_data =3D (u8 *)fb_display[i].fontdata; + font_data_get(fb_display[i].fontdata); + font_data_put(new_data); + new_data =3D fb_display[i].fontdata; break; } } - return fbcon_do_set_font(vc, font->width, font->height, charcount, new_da= ta, 1); + ret =3D fbcon_do_set_font(vc, font->width, font->height, charcount, new_d= ata); + font_data_put(new_data); + + return ret; } =20 static int fbcon_set_def_font(struct vc_data *vc, struct console_font *fon= t, @@ -2578,7 +2573,7 @@ static int fbcon_set_def_font(struct vc_data *vc, str= uct console_font *font, =20 font->width =3D f->width; font->height =3D f->height; - return fbcon_do_set_font(vc, f->width, f->height, f->charcount, f->data, = 0); + return fbcon_do_set_font(vc, f->width, f->height, f->charcount, f->data); } =20 static u16 palette_red[16]; diff --git a/drivers/video/fbdev/core/fbcon.h b/drivers/video/fbdev/core/fb= con.h index d26ee7860cf5..1e3c1ef84762 100644 --- a/drivers/video/fbdev/core/fbcon.h +++ b/drivers/video/fbdev/core/fbcon.h @@ -27,7 +27,6 @@ struct fbcon_display { /* Filled in by the low-level console driver */ font_data_t *fontdata; - int userfont; /* !=3D 0 if fontdata kmalloc()ed */ #ifdef CONFIG_FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION u_short scrollmode; /* Scroll Method, use fb_scrollmode() = */ #endif diff --git a/include/linux/font.h b/include/linux/font.h index 5b8557813c5c..dd319d0f0201 100644 --- a/include/linux/font.h +++ b/include/linux/font.h @@ -54,6 +54,8 @@ static inline const unsigned char *font_data_buf(font_dat= a_t *fd) return (const unsigned char *)fd; } =20 +void font_data_get(font_data_t *fd); +bool font_data_put(font_data_t *fd); unsigned int font_data_size(font_data_t *fd); =20 /* diff --git a/lib/fonts/fonts.c b/lib/fonts/fonts.c index 8c9a6762061c..d25efd8d6c31 100644 --- a/lib/fonts/fonts.c +++ b/lib/fonts/fonts.c @@ -12,18 +12,91 @@ * for more details. */ =20 +#include +#include #include -#include +#include #include +#include + #if defined(__mc68000__) #include #endif -#include =20 /* * Helpers for font_data_t */ =20 +static struct font_data *to_font_data_struct(font_data_t *fd) +{ + return container_of(fd, struct font_data, data[0]); +} + +static bool font_data_is_internal(font_data_t *fd) +{ + return !REFCOUNT(fd); /* internal fonts have no reference counting */ +} + +static void font_data_free(font_data_t *fd) +{ + kfree(to_font_data_struct(fd)); +} + +/** + * font_data_get - Acquires a reference on font data + * @fd: Font data + * + * Font data from user space is reference counted. The helper + * font_data_get() increases the reference counter by one. Invoke + * font_data_put() to release the reference. + * + * Internal font data is located in read-only memory. In this case + * the helper returns success without modifying the counter field. + * It is still required to call font_data_put() on internal font data. + */ +void font_data_get(font_data_t *fd) +{ + if (font_data_is_internal(fd)) + return; /* never ref static data */ + + if (WARN_ON(!REFCOUNT(fd))) + return; /* should never be 0 */ + ++REFCOUNT(fd); +} +EXPORT_SYMBOL_GPL(font_data_get); + +/** + * font_data_put - Release a reference on font data + * @fd: Font data + * + * Font data from user space is reference counted. The helper + * font_data_put() decreases the reference counter by one. If this was + * the final reference, it frees the allocated memory. + * + * Internal font data is located in read-only memory. In this case + * the helper returns success without modifying the counter field. + * + * Returns: + * True if the font data's memory buffer has been freed, false otherwise. + */ +bool font_data_put(font_data_t *fd) +{ + unsigned int count; + + if (font_data_is_internal(fd)) + return false; /* never unref static data */ + + if (WARN_ON(!REFCOUNT(fd))) + return false; /* should never be 0 */ + + count =3D --REFCOUNT(fd); + if (!count) + font_data_free(fd); + + return !count; +} +EXPORT_SYMBOL_GPL(font_data_put); + /** * font_data_size - Return size of the font data in bytes * @fd: Font data --=20 2.53.0 From nobody Thu Apr 9 10:29:59 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 827743D1CA7 for ; Mon, 9 Mar 2026 14:18:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065892; cv=none; b=BsZosJcr3lMUWEB4Izx/ryAWvJ6VJBSEHE56EqC6y4LxU0chvtHZ7XMXP0xEK+J0AVzIz+w2YdR4hXb+ZWTBaAQN3/RVVpITTsRJPgZUUbRHOEiZu5SCV8B2SBhCp3W6JCShiAP80YJCnkoFKJDOXkkuHCPshMZHFpnN0ffu4IY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065892; c=relaxed/simple; bh=6zNTsXIKejF86BPCVa9YUibZB6aboUaJIe+852zsNLE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nOgGntFIKQyuLYrpqpn//l2bVzC+/56sRnA3490R6WdXXOHCDzQYMlBv6HRGVv7Gg6X2wq4jMjSC5hA5MJG17X6rXGx/yD/PxDh4OqKNBcxvj2Z71KvUz2hBmaUbyxfYVEEnfEqJXcokl/vPnVjA1cyuialH/cQkvSfHccuadxM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=koGCXSmG; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Xqiys0qg; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=koGCXSmG; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Xqiys0qg; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="koGCXSmG"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Xqiys0qg"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="koGCXSmG"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Xqiys0qg" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 331114D246; Mon, 9 Mar 2026 14:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uWzmPpeiXpnE41gcoTXD2KgTeEwpYCVbgY+rouAHnjs=; b=koGCXSmGU9uGLrsJ6fKCSXVAvSfkW0kpe42ZgugU2XgUHS4JerP8FXYjGYmCg1m308iEpb FXEO/cfuwBHtDZWBZkydRe5L0yuHtqNBB/CS2/gqpXs/jUGyOdb0ygSTRw3kG36zWR6KjQ Lgh2Pie6bMS52bm/SSXY4mT6AyDQ+6o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uWzmPpeiXpnE41gcoTXD2KgTeEwpYCVbgY+rouAHnjs=; b=Xqiys0qgC6VNeeDQ8RhsU+/fcaX8wmzDTRGJV/15+HRbgOJcSasEqcZIly43CoNAkd7GJ9 7xo5enWZW7tv4ZCQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uWzmPpeiXpnE41gcoTXD2KgTeEwpYCVbgY+rouAHnjs=; b=koGCXSmGU9uGLrsJ6fKCSXVAvSfkW0kpe42ZgugU2XgUHS4JerP8FXYjGYmCg1m308iEpb FXEO/cfuwBHtDZWBZkydRe5L0yuHtqNBB/CS2/gqpXs/jUGyOdb0ygSTRw3kG36zWR6KjQ Lgh2Pie6bMS52bm/SSXY4mT6AyDQ+6o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uWzmPpeiXpnE41gcoTXD2KgTeEwpYCVbgY+rouAHnjs=; b=Xqiys0qgC6VNeeDQ8RhsU+/fcaX8wmzDTRGJV/15+HRbgOJcSasEqcZIly43CoNAkd7GJ9 7xo5enWZW7tv4ZCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id ECEA63EF3B; Mon, 9 Mar 2026 14:17:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cIVoOHvWrmldPAAAD6G6ig (envelope-from ); Mon, 09 Mar 2026 14:17:31 +0000 From: Thomas Zimmermann To: gregkh@linuxfoundation.org, deller@gmx.de, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v3 10/13] lib/fonts: Compare font data for equality with font_data_is_equal() Date: Mon, 9 Mar 2026 15:14:52 +0100 Message-ID: <20260309141723.137364-11-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309141723.137364-1-tzimmermann@suse.de> References: <20260309141723.137364-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; URIBL_BLOCKED(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[linuxfoundation.org,gmx.de,ravnborg.org]; RCVD_TLS_ALL(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RL4936hw7dbgk3hb39jfn1xy19)]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Spam-Flag: NO X-Spam-Score: -2.80 X-Spam-Level: Content-Type: text/plain; charset="utf-8" Add font_data_is_equal() and update consoles to use it. Font data is equal if it has the same size and contains the same values on all bytes. Only fbcon uses a crc32 checksum. If set in both operands the checksums have to be equal. The new helper also guarantees to not compare internal fonts against fonts from user space. Internal fonts cannot be ref-counted, so making them equal to user-space fonts with the same byte sequence results in undefined behavior. The test only compares data buffers. Their interpretation is up each console. Therefore remove a width test in fbcon_set_font(). v3: - rebase onto font_data_{get,put}() Signed-off-by: Thomas Zimmermann --- drivers/video/console/newport_con.c | 4 +--- drivers/video/fbdev/core/fbcon.c | 7 +------ include/linux/font.h | 1 + lib/fonts/fonts.c | 26 ++++++++++++++++++++++++++ 4 files changed, 29 insertions(+), 9 deletions(-) diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/ne= wport_con.c index 43a1a4f41057..1bc3cb1ea116 100644 --- a/drivers/video/console/newport_con.c +++ b/drivers/video/console/newport_con.c @@ -529,9 +529,7 @@ static int newport_set_font(int unit, const struct cons= ole_font *op, =20 /* check if font is already used by other console */ for (i =3D 0; i < MAX_NR_CONSOLES; i++) { - if (font_data[i] !=3D FONT_DATA - && font_data_size(font_data[i]) =3D=3D size - && !memcmp(font_data[i], new_data, size)) { + if (font_data_is_equal(font_data[i], new_data)) { font_data_put(new_data); /* current font is the same as the new one */ if (i =3D=3D unit) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fb= con.c index ac59480c98cb..00255ac92e42 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -2540,13 +2540,8 @@ static int fbcon_set_font(struct vc_data *vc, const = struct console_font *font, FNTSUM(new_data) =3D csum; /* Check if the same font is on some other console already */ for (i =3D first_fb_vc; i <=3D last_fb_vc; i++) { - struct vc_data *tmp =3D vc_cons[i].d; - if (fb_display[i].fontdata && - FNTSUM(fb_display[i].fontdata) =3D=3D csum && - font_data_size(fb_display[i].fontdata) =3D=3D size && - tmp->vc_font.width =3D=3D w && - !memcmp(fb_display[i].fontdata, new_data, size)) { + font_data_is_equal(fb_display[i].fontdata, new_data)) { font_data_get(fb_display[i].fontdata); font_data_put(new_data); new_data =3D fb_display[i].fontdata; diff --git a/include/linux/font.h b/include/linux/font.h index dd319d0f0201..58bf3c64cabb 100644 --- a/include/linux/font.h +++ b/include/linux/font.h @@ -57,6 +57,7 @@ static inline const unsigned char *font_data_buf(font_dat= a_t *fd) void font_data_get(font_data_t *fd); bool font_data_put(font_data_t *fd); unsigned int font_data_size(font_data_t *fd); +bool font_data_is_equal(font_data_t *lhs, font_data_t *rhs); =20 /* * Font description diff --git a/lib/fonts/fonts.c b/lib/fonts/fonts.c index d25efd8d6c31..3fb76d185647 100644 --- a/lib/fonts/fonts.c +++ b/lib/fonts/fonts.c @@ -110,6 +110,32 @@ unsigned int font_data_size(font_data_t *fd) } EXPORT_SYMBOL_GPL(font_data_size); =20 +/** + * font_data_is_equal - Compares font data for equality + * @lhs: Left-hand side font data + * @rhs: Right-hand-size font data + * + * Font data is equal if is constain the same sequence of values. The + * helper also use the checksum, if both arguments contain it. Font data + * coming from different origins, internal or from user space, is never + * equal. Allowing this would break reference counting. + * + * Returns: + * True if the given font data is equal, false otherwise. + */ +bool font_data_is_equal(font_data_t *lhs, font_data_t *rhs) +{ + if (font_data_is_internal(lhs) !=3D font_data_is_internal(rhs)) + return false; + if (font_data_size(lhs) !=3D font_data_size(rhs)) + return false; + if (FNTSUM(lhs) && FNTSUM(rhs) && FNTSUM(lhs) !=3D FNTSUM(rhs)) + return false; + + return !memcmp(lhs, rhs, FNTSIZE(lhs)); +} +EXPORT_SYMBOL_GPL(font_data_is_equal); + /* * Font lookup */ --=20 2.53.0 From nobody Thu Apr 9 10:29:59 2026 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC4843D3012 for ; Mon, 9 Mar 2026 14:18:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065882; cv=none; b=F9pihuVQu0R9ClLFoYcvNIEkev+VrmSjKb56ri0MlPwtVie2zNp8nlImqp+jtwBtw83eo8QzG1eYznP7NPMeRvivYDOcsifMdGxXQOK/8QVyAt04cNt/TTp+t/HOcceTtDX2ARBfYeAkr763xZEvCB2ETXVM5Vq9eyjBG2Vhdho= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065882; c=relaxed/simple; bh=7KGDj3XjQRVd0RtpOFER2tC8D6hPyi2FDN6BN7N/YAc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iDWbYAWBEIRuDBbHyFzprx5INTZSs8ByB+yYQ862a5qKwG4+FsV0I16plGeOT22hweA4O/83bU/SI+BnOk0mnHaKv/G2NnU7UGGTs85pIFlUbFbTw7sHKYnbMfIGSpV4fNK2OYydJw9TOn0QwklF40BAyHWVP/THNV473tW/du4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=2CNRxxD1; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Rs08eeny; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=2CNRxxD1; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Rs08eeny; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="2CNRxxD1"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Rs08eeny"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="2CNRxxD1"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Rs08eeny" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 73F325BE4A; Mon, 9 Mar 2026 14:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PBLffO5up+O/dY8DMp/xWz2SoUMqdH180KqinIBqwmw=; b=2CNRxxD1aCbXHU4S0ILm2wXmQgpYNtiEGxp6gIlSdhwQNI7QRKI2RhyZRXvMafqYPCUvGW myStayVo05GqoKKghj9YZZNIntzpUdRF/7TkiUiYdrHEP0M2++2QY6OPUdXTQwnm0BMMpl J7EWLmfopoEEKRRkfrinkxN6uYrVEtA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PBLffO5up+O/dY8DMp/xWz2SoUMqdH180KqinIBqwmw=; b=Rs08eenyht4muJuOOMzMEizOUob9+Zj3yfAnDPbmOMcmOAh3x0sP9tvTlBxs7wjyurMIOc JvjJ9tHzj0dRM0CQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PBLffO5up+O/dY8DMp/xWz2SoUMqdH180KqinIBqwmw=; b=2CNRxxD1aCbXHU4S0ILm2wXmQgpYNtiEGxp6gIlSdhwQNI7QRKI2RhyZRXvMafqYPCUvGW myStayVo05GqoKKghj9YZZNIntzpUdRF/7TkiUiYdrHEP0M2++2QY6OPUdXTQwnm0BMMpl J7EWLmfopoEEKRRkfrinkxN6uYrVEtA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PBLffO5up+O/dY8DMp/xWz2SoUMqdH180KqinIBqwmw=; b=Rs08eenyht4muJuOOMzMEizOUob9+Zj3yfAnDPbmOMcmOAh3x0sP9tvTlBxs7wjyurMIOc JvjJ9tHzj0dRM0CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 394593EF3A; Mon, 9 Mar 2026 14:17:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QK3EDHzWrmldPAAAD6G6ig (envelope-from ); Mon, 09 Mar 2026 14:17:32 +0000 From: Thomas Zimmermann To: gregkh@linuxfoundation.org, deller@gmx.de, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v3 11/13] lib/fonts: Create font_data_t from struct console_font with font_data_import() Date: Mon, 9 Mar 2026 15:14:53 +0100 Message-ID: <20260309141723.137364-12-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309141723.137364-1-tzimmermann@suse.de> References: <20260309141723.137364-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.80 X-Spam-Level: X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[linuxfoundation.org,gmx.de,ravnborg.org]; RCVD_TLS_ALL(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RL4936hw7dbgk3hb39jfn1xy19)]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Spam-Flag: NO Content-Type: text/plain; charset="utf-8" Add font_data_import() and update consoles to use it. The implementation of font_data_import() is based on code from fbcon, which supports overflow checks and crc32 checksums. Fbcon uses the crc32 checksum. Newport_con now implements the same overflow checks as fbcon. As before, this console does not support checksums, which are optional. Newport_con can now also handle input font data with a vertical pitch other than 32 bytes. (The vertical pitch is the offset between two glyphs in the font data.) As an internal change, remove the const qualifier from the data field if struct font_data. This allows font_data_import() to write the data without type casting. For all users of the font data via font_data_t, the stored data is still read only. v3: - fix typos Signed-off-by: Thomas Zimmermann --- drivers/video/console/newport_con.c | 22 ++-------- drivers/video/fbdev/core/fbcon.c | 38 ++---------------- include/linux/font.h | 6 ++- lib/fonts/fonts.c | 62 +++++++++++++++++++++++++++++ 4 files changed, 75 insertions(+), 53 deletions(-) diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/ne= wport_con.c index 1bc3cb1ea116..ecbbe2e4e2a6 100644 --- a/drivers/video/console/newport_con.c +++ b/drivers/video/console/newport_con.c @@ -501,31 +501,17 @@ static int newport_set_font(int unit, const struct co= nsole_font *op, { int w =3D op->width; int h =3D op->height; - int size =3D h * op->charcount; int i; font_data_t *new_data; - unsigned char *data =3D op->data, *p; =20 /* ladis: when I grow up, there will be a day... and more sizes will * be supported ;-) */ - if ((w !=3D 8) || (h !=3D 16) || (vpitch !=3D 32) - || (op->charcount !=3D 256 && op->charcount !=3D 512)) + if (w !=3D 8 || h !=3D 16 || (op->charcount !=3D 256 && op->charcount != =3D 512)) return -EINVAL; =20 - if (!(new_data =3D kmalloc(FONT_EXTRA_WORDS * sizeof(int) + size, - GFP_USER))) return -ENOMEM; - - new_data +=3D FONT_EXTRA_WORDS * sizeof(int); - FNTSIZE(new_data) =3D size; - REFCOUNT(new_data) =3D 1; /* usage counter */ - FNTSUM(new_data) =3D 0; - - p =3D (unsigned char *)font_data_buf(new_data); - for (i =3D 0; i < op->charcount; i++) { - memcpy(p, data, h); - data +=3D 32; - p +=3D h; - } + new_data =3D font_data_import(op, vpitch, NULL); + if (IS_ERR(new_data)) + return PTR_ERR(new_data); =20 /* check if font is already used by other console */ for (i =3D 0; i < MAX_NR_CONSOLES; i++) { diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fb= con.c index 00255ac92e42..53677c09a0ec 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -2039,8 +2039,6 @@ static void updatescrollmode(struct fbcon_display *p, updatescrollmode_accel(p, info, vc); } =20 -#define PITCH(w) (((w) + 7) >> 3) - static int fbcon_resize(struct vc_data *vc, unsigned int width, unsigned int height, bool from_user) { @@ -2424,7 +2422,6 @@ static int fbcon_do_set_font(struct vc_data *vc, int = w, int h, int charcount, resize =3D (w !=3D vc->vc_font.width) || (h !=3D vc->vc_font.height); p->fontdata =3D data; vc->vc_font.data =3D font_data_buf(p->fontdata); - old_width =3D vc->vc_font.width; old_height =3D vc->vc_font.height; old_charcount =3D vc->vc_font.charcount; @@ -2482,11 +2479,8 @@ static int fbcon_set_font(struct vc_data *vc, const = struct console_font *font, unsigned charcount =3D font->charcount; int w =3D font->width; int h =3D font->height; - int size, alloc_size; - int i, csum, ret; + int i, ret; font_data_t *new_data; - const u8 *data =3D font->data; - int pitch =3D PITCH(font->width); =20 /* Is there a reason why fbconsole couldn't handle any charcount >256? * If not this check should be changed to charcount < 256 */ @@ -2510,34 +2504,10 @@ static int fbcon_set_font(struct vc_data *vc, const= struct console_font *font, if (fbcon_invalid_charcount(info, charcount)) return -EINVAL; =20 - /* Check for integer overflow in font size calculation */ - if (check_mul_overflow(h, pitch, &size) || - check_mul_overflow(size, charcount, &size)) - return -EINVAL; - - /* Check for overflow in allocation size calculation */ - if (check_add_overflow(FONT_EXTRA_WORDS * sizeof(int), size, &alloc_size)) - return -EINVAL; - - new_data =3D kmalloc(alloc_size, GFP_USER); - - if (!new_data) - return -ENOMEM; - - memset((u8 *)new_data, 0, FONT_EXTRA_WORDS * sizeof(int)); - - new_data +=3D FONT_EXTRA_WORDS * sizeof(int); - FNTSIZE(new_data) =3D size; - REFCOUNT(new_data) =3D 1; /* usage counter */ - for (i=3D0; i< charcount; i++) { - memcpy((u8 *)new_data + i * h * pitch, data + i * vpitch * pitch, h * pi= tch); - } - - /* Since linux has a nice crc32 function use it for counting font - * checksums. */ - csum =3D crc32(0, new_data, size); + new_data =3D font_data_import(font, vpitch, crc32); + if (IS_ERR(new_data)) + return PTR_ERR(new_data); =20 - FNTSUM(new_data) =3D csum; /* Check if the same font is on some other console already */ for (i =3D first_fb_vc; i <=3D last_fb_vc; i++) { if (fb_display[i].fontdata && diff --git a/include/linux/font.h b/include/linux/font.h index 58bf3c64cabb..3eb4818402c5 100644 --- a/include/linux/font.h +++ b/include/linux/font.h @@ -13,6 +13,8 @@ =20 #include =20 +struct console_font; + /* * font_data_t and helpers */ @@ -54,6 +56,8 @@ static inline const unsigned char *font_data_buf(font_dat= a_t *fd) return (const unsigned char *)fd; } =20 +font_data_t *font_data_import(const struct console_font *font, unsigned in= t vpitch, + u32 (*calc_csum)(u32, const void *, size_t)); void font_data_get(font_data_t *fd); bool font_data_put(font_data_t *fd); unsigned int font_data_size(font_data_t *fd); @@ -124,7 +128,7 @@ extern const struct font_desc *get_default_font(int xre= s, int yres, =20 struct font_data { unsigned int extra[FONT_EXTRA_WORDS]; - const unsigned char data[]; + unsigned char data[]; } __packed; =20 #endif /* _VIDEO_FONT_H */ diff --git a/lib/fonts/fonts.c b/lib/fonts/fonts.c index 3fb76d185647..16e75c3d2a0f 100644 --- a/lib/fonts/fonts.c +++ b/lib/fonts/fonts.c @@ -14,7 +14,9 @@ =20 #include #include +#include #include +#include #include #include #include @@ -23,6 +25,8 @@ #include #endif =20 +#define console_font_pitch(font) DIV_ROUND_UP((font)->width, 8) + /* * Helpers for font_data_t */ @@ -42,6 +46,64 @@ static void font_data_free(font_data_t *fd) kfree(to_font_data_struct(fd)); } =20 +/** + * font_data_import - Allocates and initializes font data from user space + * @font: A font from user space + * @vpitch: The size of a single glyph in @font in bytes + * @calc_csum: An optional helper to calculate a chechsum + * + * Font data from user space must be translated to the kernel's format. The + * font's glyph geometry and data is provided in @font. The parameter @vpi= tch + * gives the number of bytes per glyph, including trailing bytes. + * + * The parameter @calc_csum is optional. Fbcon passes crc32() to calculate= the + * font data's checksum. + * + * Returns: + * Newly initialized font data on success, or a pointer-encoded errno valu= e otherwise. + */ +font_data_t *font_data_import(const struct console_font *font, unsigned in= t vpitch, + u32 (*calc_csum)(u32, const void *, size_t)) +{ + unsigned int pitch =3D console_font_pitch(font); + unsigned int h =3D font->height; + unsigned int charcount =3D font->charcount; + const unsigned char *data =3D font->data; + u32 csum =3D 0; + struct font_data *font_data; + int size, alloc_size; + unsigned int i; + font_data_t *fd; + + /* Check for integer overflow in font-size calculation */ + if (check_mul_overflow(h, pitch, &size) || + check_mul_overflow(size, charcount, &size)) + return ERR_PTR(-EINVAL); + + /* Check for overflow in allocation size calculation */ + if (check_add_overflow(sizeof(*font_data), size, &alloc_size)) + return ERR_PTR(-EINVAL); + + font_data =3D kmalloc(alloc_size, GFP_USER); + if (!font_data) + return ERR_PTR(-ENOMEM); + memset(font_data->extra, 0, sizeof(font_data->extra)); + + for (i =3D 0; i < charcount; ++i) + memcpy(font_data->data + i * h * pitch, data + i * vpitch * pitch, h * p= itch); + + if (calc_csum) + csum =3D calc_csum(0, font_data->data, size); + + fd =3D font_data->data; + REFCOUNT(fd) =3D 1; /* start with reference acquired */ + FNTSIZE(fd) =3D size; + FNTSUM(fd) =3D csum; + + return fd; +} +EXPORT_SYMBOL_GPL(font_data_import); + /** * font_data_get - Acquires a reference on font data * @fd: Font data --=20 2.53.0 From nobody Thu Apr 9 10:29:59 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2391A3D3334 for ; Mon, 9 Mar 2026 14:18:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065898; cv=none; b=IQyUvQLMnjzc4oQfk9pXFaPAU45TcHD4n2KrQcxADZwUmFxM5aJYQv71XhJgKnOW64xnGf3vu89c1A2GgKccXpQZZl2QtKDNAzfOSImrFXfUSvCBQj7K+fi1dBnisb2CWUZNfN2b+/KW2djHgs3s4l7OxtEsjhmFxd4uUVORUBk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065898; c=relaxed/simple; bh=ff+nZuVIjaJYy8EWR0v152iIFXJHx+nTIjWkrWSg54w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JOSdLWv7tovV+gNNKul1xP5/9BowvnomsusaBMTqVevxBTWEsYQeFXnEZwc2d847oPX8Wdbnf6m5f3XzSws1YJndq3CZGjUL6vVKbdk6f7msfnOSca6+NaJCwE2lNJVn65k8YV0Sejqa3g7OWT7X+4RUvXhcBg2XKP1HOnD24yo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=cRRZpnjF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=WQnm4dfE; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=cRRZpnjF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=WQnm4dfE; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="cRRZpnjF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="WQnm4dfE"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="cRRZpnjF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="WQnm4dfE" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B41034D247; Mon, 9 Mar 2026 14:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VD3gHpmdp8P8rU92GmLBwjvNtErqvykFq2ll5j1U+Qc=; b=cRRZpnjFj1njqpgpHGh1rY5lditMLCnEffRXh4OblKUxs937JYoDlJnTC+OTPx7/poe1Pq IOWcLQm+h9hoi5bPFtmWTIxzxELkLu65ve93kRH1Z5nXa28rXLfzlZdYtdaKwk1zPtyBQs hiBgIzssCtU3ZZsxUdHejyzmc4HupmY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VD3gHpmdp8P8rU92GmLBwjvNtErqvykFq2ll5j1U+Qc=; b=WQnm4dfEyq4sgn6Vjtzca+ZZ11oHx1xl4m5j8vvV1bqi/U0MZl6jNpEFN/dODketaHEmme mYzXKXXyqT70I2Dg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=cRRZpnjF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=WQnm4dfE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VD3gHpmdp8P8rU92GmLBwjvNtErqvykFq2ll5j1U+Qc=; b=cRRZpnjFj1njqpgpHGh1rY5lditMLCnEffRXh4OblKUxs937JYoDlJnTC+OTPx7/poe1Pq IOWcLQm+h9hoi5bPFtmWTIxzxELkLu65ve93kRH1Z5nXa28rXLfzlZdYtdaKwk1zPtyBQs hiBgIzssCtU3ZZsxUdHejyzmc4HupmY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VD3gHpmdp8P8rU92GmLBwjvNtErqvykFq2ll5j1U+Qc=; b=WQnm4dfEyq4sgn6Vjtzca+ZZ11oHx1xl4m5j8vvV1bqi/U0MZl6jNpEFN/dODketaHEmme mYzXKXXyqT70I2Dg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7AA5F3EF3B; Mon, 9 Mar 2026 14:17:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gAaFHHzWrmldPAAAD6G6ig (envelope-from ); Mon, 09 Mar 2026 14:17:32 +0000 From: Thomas Zimmermann To: gregkh@linuxfoundation.org, deller@gmx.de, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v3 12/13] lib/fonts: Store font data for user space with font_data_export() Date: Mon, 9 Mar 2026 15:14:54 +0100 Message-ID: <20260309141723.137364-13-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309141723.137364-1-tzimmermann@suse.de> References: <20260309141723.137364-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,suse.de:email]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FREEMAIL_TO(0.00)[linuxfoundation.org,gmx.de,ravnborg.org]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,suse.de:email]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[7]; R_RATELIMIT(0.00)[to_ip_from(RLf7er7x8tqp4b41gsueb7z9k6)]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Rspamd-Queue-Id: B41034D247 X-Spam-Flag: NO X-Spam-Score: -3.01 X-Spam-Level: Content-Type: text/plain; charset="utf-8" Add font_data_export() and update consoles to use it. The helper font_data_export() is based on code in fbcon_get_font(). It extends the size of a single glyph to match the requested vpitch, which us usually 32 bytes for fonts from user space. Internal fonts have a pitch according to the glyph's height. The implementation of font_data_export() differs in several ways from the original code. The original implementation distinguished between different pitches of the font data. This is not necessary as the pitch is a parameter in the copying. There was also special handling for a font pitch of 3 bytes, which got expanded to 4 bytes (with trailing bits on each scanline). The logic originated from long before git history exists even in the historical tree. So it is not clear why this was implemented. It is not what user space expects. The setfont utitlity loads font with 3-bytes pitches and expects to read such fonts with a 3-byte pitch. For any font width, the font pitch is always the width extended to the next multiple of 8. See [1] for the user-space font-reading code. With the changes to handling the font pitches, font_data_export() replaces the original code's various special cases with a single copying logic. v3: - fix typos (Helge) Signed-off-by: Thomas Zimmermann Link: https://github.com/legionus/kbd/blob/v2.9.0/src/libkfont/kdfontop.c#L= 73 # [1] --- drivers/video/fbdev/core/fbcon.c | 57 ++------------------------------ include/linux/font.h | 1 + lib/fonts/fonts.c | 40 ++++++++++++++++++++++ 3 files changed, 43 insertions(+), 55 deletions(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fb= con.c index 53677c09a0ec..8641b0b3edc4 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -2282,68 +2282,15 @@ static bool fbcon_blank(struct vc_data *vc, enum ve= sa_blank_mode blank, =20 static int fbcon_get_font(struct vc_data *vc, struct console_font *font, u= nsigned int vpitch) { - struct fbcon_display *p =3D &fb_display[vc->vc_num]; - font_data_t *fontdata =3D p->fontdata; - u8 *data =3D font->data; - int i, j; + const struct fbcon_display *p =3D &fb_display[vc->vc_num]; =20 font->width =3D vc->vc_font.width; font->height =3D vc->vc_font.height; if (font->height > vpitch) return -ENOSPC; font->charcount =3D vc->vc_hi_font_mask ? 512 : 256; - if (!font->data) - return 0; - - if (font->width <=3D 8) { - j =3D vc->vc_font.height; - if (font->charcount * j > font_data_size(fontdata)) - return -EINVAL; =20 - for (i =3D 0; i < font->charcount; i++) { - memcpy(data, fontdata, j); - memset(data + j, 0, vpitch - j); - data +=3D vpitch; - fontdata +=3D j; - } - } else if (font->width <=3D 16) { - j =3D vc->vc_font.height * 2; - if (font->charcount * j > font_data_size(fontdata)) - return -EINVAL; - - for (i =3D 0; i < font->charcount; i++) { - memcpy(data, fontdata, j); - memset(data + j, 0, 2*vpitch - j); - data +=3D 2*vpitch; - fontdata +=3D j; - } - } else if (font->width <=3D 24) { - if (font->charcount * (vc->vc_font.height * sizeof(u32)) > font_data_siz= e(fontdata)) - return -EINVAL; - - for (i =3D 0; i < font->charcount; i++) { - for (j =3D 0; j < vc->vc_font.height; j++) { - *data++ =3D fontdata[0]; - *data++ =3D fontdata[1]; - *data++ =3D fontdata[2]; - fontdata +=3D sizeof(u32); - } - memset(data, 0, 3 * (vpitch - j)); - data +=3D 3 * (vpitch - j); - } - } else { - j =3D vc->vc_font.height * 4; - if (font->charcount * j > font_data_size(fontdata)) - return -EINVAL; - - for (i =3D 0; i < font->charcount; i++) { - memcpy(data, fontdata, j); - memset(data + j, 0, 4 * vpitch - j); - data +=3D 4 * vpitch; - fontdata +=3D j; - } - } - return 0; + return font_data_export(p->fontdata, font, vpitch); } =20 /* set/clear vc_hi_font_mask and update vc attrs accordingly */ diff --git a/include/linux/font.h b/include/linux/font.h index 3eb4818402c5..d80db66a5c17 100644 --- a/include/linux/font.h +++ b/include/linux/font.h @@ -62,6 +62,7 @@ void font_data_get(font_data_t *fd); bool font_data_put(font_data_t *fd); unsigned int font_data_size(font_data_t *fd); bool font_data_is_equal(font_data_t *lhs, font_data_t *rhs); +int font_data_export(font_data_t *fd, struct console_font *font, unsigned = int vpitch); =20 /* * Font description diff --git a/lib/fonts/fonts.c b/lib/fonts/fonts.c index 16e75c3d2a0f..a861b375e35d 100644 --- a/lib/fonts/fonts.c +++ b/lib/fonts/fonts.c @@ -198,6 +198,46 @@ bool font_data_is_equal(font_data_t *lhs, font_data_t = *rhs) } EXPORT_SYMBOL_GPL(font_data_is_equal); =20 +/** + * font_data_export - Stores font data for user space + * @fd: Font data + * @font: A font for user space + * @vpitch: The size of a single glyph in @font in bytes + * + * Store the font data given in @fd to the font in @font. Values and + * pointers in @font are pre-initialized. This helper mostly checks some + * corner cases and translates glyph sizes according to the value given + * @vpitch. + * + * Returns: + * 0 on success, or a negative errno code otherwise. + */ +int font_data_export(font_data_t *fd, struct console_font *font, unsigned = int vpitch) +{ + const unsigned char *font_data =3D font_data_buf(fd); + unsigned char *data =3D font->data; + unsigned int pitch =3D console_font_pitch(font); + unsigned int glyphsize, i; + + if (!font->width || !font->height || !font->charcount || !font->data) + return 0; + + glyphsize =3D font->height * pitch; + + if (font->charcount * glyphsize > font_data_size(fd)) + return -EINVAL; + + for (i =3D 0; i < font->charcount; i++) { + memcpy(data, font_data, glyphsize); + memset(data + glyphsize, 0, pitch * vpitch - glyphsize); + data +=3D pitch * vpitch; + font_data +=3D glyphsize; + } + + return 0; +} +EXPORT_SYMBOL_GPL(font_data_export); + /* * Font lookup */ --=20 2.53.0 From nobody Thu Apr 9 10:29:59 2026 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B2673D2FEC for ; Mon, 9 Mar 2026 14:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065888; cv=none; b=p86gK4nv5dluvsS4/XXoHooOsuIDI9PR/pbA6I4IWgp5ynt9aHLpfOvn7xcNDP3qeRkzlnjsVMz1zjFKXrEZe3FYxDXotJ9/FM/NZVcSzllr7Uyb7HMrWkZl3GeeWEaYRAeRTomE3jNEICgQym2R/FaCUOE4+xcNpMjBmuHTa/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773065888; c=relaxed/simple; bh=BVXc+0rxoH8qMxVFvqoXSuv4kay4n72quDCpBBAaxyE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aZIUp1YpExBpOq9zpWKOXlBAMdb6icjdACt5/9rCKCArsLb7GeCoFyGZ8TasnCUVCxCX7c+5saeegqiJ6+y09OHdxTiQp4BGuA3IrRdhHNULMIVUnZ88/XVXdHwqnk17sTWJi8AbRCgRCBPq1WZkOToQN1bszYsClUqcbR7PNW4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=1pRIythK; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=UdWw7tGy; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=uNDjDGrq; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=zPDSsS6T; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="1pRIythK"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="UdWw7tGy"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="uNDjDGrq"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zPDSsS6T" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0326B5BE4D; Mon, 9 Mar 2026 14:17:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4w5uwEVSlmlGBAJYoqlWi7ELW6wprbGKGlE9Ql1y72I=; b=1pRIythKvWFSVdxDakfWRVJbDSncEOdW6GvZ40m1WjgcirPJi1sJgrKbv8VWEHmw7+Aq+h 7bJ+VC0TXwQH6jN66F172bWA24sbyd5owpkgK6pInKmBpr0jD3GI3LK8DVzSEpKYmenyOV X9zA/tNH3w2GG3kyp9UAF8xaA2dBjRA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4w5uwEVSlmlGBAJYoqlWi7ELW6wprbGKGlE9Ql1y72I=; b=UdWw7tGy6vpBhkwlgpeP6kFw2yezd+2fOU0vX1axaAubsxzRiSPFnhwDa4qxkFcVIRUw+X OR760zUqFCKJzQCw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uNDjDGrq; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zPDSsS6T DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773065853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4w5uwEVSlmlGBAJYoqlWi7ELW6wprbGKGlE9Ql1y72I=; b=uNDjDGrqcilQXlIHYd7M53hm9ykSd4xnx3IBXp7QbKDkpjic24/PnPFP0AvkeUyM8TtSBv NCZCVbmrMP4fiNiMQq5tQCFPMYC7JqKLLTzp3Xf6qxxRp3cuFjAYu4+5QOmfTOHW4iR3fO mQiTlEpwyXf9IeN7fQjlLdpO8/j+cZ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773065853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4w5uwEVSlmlGBAJYoqlWi7ELW6wprbGKGlE9Ql1y72I=; b=zPDSsS6TVo9qPWp8RMGERynwsSKbeemn71kuHayeAuIoTS91bFDEKQEkH23kEvyvqOMHSR qMsNzE5MLaB4G+DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BB1763EF3C; Mon, 9 Mar 2026 14:17:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aPc8LHzWrmldPAAAD6G6ig (envelope-from ); Mon, 09 Mar 2026 14:17:32 +0000 From: Thomas Zimmermann To: gregkh@linuxfoundation.org, deller@gmx.de, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v3 13/13] lib/fonts: Remove internal symbols and macros from public header file Date: Mon, 9 Mar 2026 15:14:55 +0100 Message-ID: <20260309141723.137364-14-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309141723.137364-1-tzimmermann@suse.de> References: <20260309141723.137364-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,suse.de:email]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_TO(0.00)[linuxfoundation.org,gmx.de,ravnborg.org]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[7]; R_RATELIMIT(0.00)[to_ip_from(RLf7er7x8tqp4b41gsueb7z9k6)]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Rspamd-Queue-Id: 0326B5BE4D X-Spam-Flag: NO X-Spam-Score: -3.01 X-Spam-Level: Content-Type: text/plain; charset="utf-8" Define access macros for font_data_t in fonts.c. Define struct font_data and declare most of the font symbols in the internal header font.h, where they can only be seen by the font code. Also move font indices into internal font.h. They appear to be unused though. There is m86k assembly code that operates on the idx field, so leave them in place for now. List all built-in fonts in a separate section in the public header file. v2: - do not add config guards around font symbols (Helge) - keep declaration of built-in fonts in public header Signed-off-by: Thomas Zimmermann --- include/linux/font.h | 57 ++++++++++++-------------------------- lib/fonts/font.h | 38 +++++++++++++++++++++++++ lib/fonts/font_10x18.c | 2 +- lib/fonts/font_6x10.c | 3 +- lib/fonts/font_6x11.c | 2 +- lib/fonts/font_6x8.c | 3 +- lib/fonts/font_7x14.c | 2 +- lib/fonts/font_8x16.c | 3 +- lib/fonts/font_8x8.c | 2 +- lib/fonts/font_acorn_8x8.c | 2 +- lib/fonts/font_mini_4x6.c | 2 +- lib/fonts/font_pearl_8x8.c | 2 +- lib/fonts/font_sun12x22.c | 3 +- lib/fonts/font_sun8x16.c | 3 +- lib/fonts/font_ter10x18.c | 4 ++- lib/fonts/font_ter16x32.c | 4 ++- lib/fonts/fonts.c | 8 +++++- 17 files changed, 85 insertions(+), 55 deletions(-) create mode 100644 lib/fonts/font.h diff --git a/include/linux/font.h b/include/linux/font.h index d80db66a5c17..5401f07dd6ce 100644 --- a/include/linux/font.h +++ b/include/linux/font.h @@ -77,36 +77,6 @@ struct font_desc { int pref; }; =20 -#define VGA8x8_IDX 0 -#define VGA8x16_IDX 1 -#define PEARL8x8_IDX 2 -#define VGA6x11_IDX 3 -#define FONT7x14_IDX 4 -#define FONT10x18_IDX 5 -#define SUN8x16_IDX 6 -#define SUN12x22_IDX 7 -#define ACORN8x8_IDX 8 -#define MINI4x6_IDX 9 -#define FONT6x10_IDX 10 -#define TER16x32_IDX 11 -#define FONT6x8_IDX 12 -#define TER10x18_IDX 13 - -extern const struct font_desc font_vga_8x8, - font_vga_8x16, - font_pearl_8x8, - font_vga_6x11, - font_7x14, - font_10x18, - font_sun_8x16, - font_sun_12x22, - font_acorn_8x8, - font_mini_4x6, - font_6x10, - font_ter_16x32, - font_6x8, - font_ter_10x18; - /* Find a font with a specific name */ =20 extern const struct font_desc *find_font(const char *name); @@ -120,16 +90,23 @@ extern const struct font_desc *get_default_font(int xr= es, int yres, /* Max. length for the name of a predefined font */ #define MAX_FONT_NAME 32 =20 -/* Extra word getters */ -#define REFCOUNT(fd) (((int *)(fd))[-1]) -#define FNTSIZE(fd) (((int *)(fd))[-2]) -#define FNTSUM(fd) (((int *)(fd))[-4]) - -#define FONT_EXTRA_WORDS 4 +/* + * Built-in fonts + */ =20 -struct font_data { - unsigned int extra[FONT_EXTRA_WORDS]; - unsigned char data[]; -} __packed; +extern const struct font_desc font_10x18; +extern const struct font_desc font_6x10; +extern const struct font_desc font_6x8; +extern const struct font_desc font_7x14; +extern const struct font_desc font_acorn_8x8; +extern const struct font_desc font_mini_4x6; +extern const struct font_desc font_pearl_8x8; +extern const struct font_desc font_sun_12x22; +extern const struct font_desc font_sun_8x16; +extern const struct font_desc font_ter_10x18; +extern const struct font_desc font_ter_16x32; +extern const struct font_desc font_vga_6x11; +extern const struct font_desc font_vga_8x16; +extern const struct font_desc font_vga_8x8; =20 #endif /* _VIDEO_FONT_H */ diff --git a/lib/fonts/font.h b/lib/fonts/font.h new file mode 100644 index 000000000000..4f1adf0b6b54 --- /dev/null +++ b/lib/fonts/font.h @@ -0,0 +1,38 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef _LIB_FONTS_FONT_H +#define _LIB_FONTS_FONT_H + +#include + +/* + * Font data + */ + +#define FONT_EXTRA_WORDS 4 + +struct font_data { + unsigned int extra[FONT_EXTRA_WORDS]; + unsigned char data[]; +} __packed; + +/* + * Built-in fonts + */ + +#define VGA8x8_IDX 0 +#define VGA8x16_IDX 1 +#define PEARL8x8_IDX 2 +#define VGA6x11_IDX 3 +#define FONT7x14_IDX 4 +#define FONT10x18_IDX 5 +#define SUN8x16_IDX 6 +#define SUN12x22_IDX 7 +#define ACORN8x8_IDX 8 +#define MINI4x6_IDX 9 +#define FONT6x10_IDX 10 +#define TER16x32_IDX 11 +#define FONT6x8_IDX 12 +#define TER10x18_IDX 13 + +#endif diff --git a/lib/fonts/font_10x18.c b/lib/fonts/font_10x18.c index 5d940db626e7..10edebc4bb74 100644 --- a/lib/fonts/font_10x18.c +++ b/lib/fonts/font_10x18.c @@ -4,7 +4,7 @@ * by Jurriaan Kalkman 06-2005 * ********************************/ =20 -#include +#include "font.h" =20 #define FONTDATAMAX 9216 =20 diff --git a/lib/fonts/font_6x10.c b/lib/fonts/font_6x10.c index e65df019e0d2..660d3a371b30 100644 --- a/lib/fonts/font_6x10.c +++ b/lib/fonts/font_6x10.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 -#include + +#include "font.h" =20 #define FONTDATAMAX 2560 =20 diff --git a/lib/fonts/font_6x11.c b/lib/fonts/font_6x11.c index bd76b3f6b635..671487ccc172 100644 --- a/lib/fonts/font_6x11.c +++ b/lib/fonts/font_6x11.c @@ -5,7 +5,7 @@ /* */ /**********************************************/ =20 -#include +#include "font.h" =20 #define FONTDATAMAX (11*256) =20 diff --git a/lib/fonts/font_6x8.c b/lib/fonts/font_6x8.c index 06ace7792521..5811ee07f4d8 100644 --- a/lib/fonts/font_6x8.c +++ b/lib/fonts/font_6x8.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 -#include + +#include "font.h" =20 #define FONTDATAMAX 2048 =20 diff --git a/lib/fonts/font_7x14.c b/lib/fonts/font_7x14.c index a2f561c9fa04..0c7475d643c8 100644 --- a/lib/fonts/font_7x14.c +++ b/lib/fonts/font_7x14.c @@ -4,7 +4,7 @@ /* by Jurriaan Kalkman 05-2005 */ /**************************************/ =20 -#include +#include "font.h" =20 #define FONTDATAMAX 3584 =20 diff --git a/lib/fonts/font_8x16.c b/lib/fonts/font_8x16.c index 06ae14088514..523e95c75569 100644 --- a/lib/fonts/font_8x16.c +++ b/lib/fonts/font_8x16.c @@ -5,9 +5,10 @@ /* */ /**********************************************/ =20 -#include #include =20 +#include "font.h" + #define FONTDATAMAX 4096 =20 static const struct font_data fontdata_8x16 =3D { diff --git a/lib/fonts/font_8x8.c b/lib/fonts/font_8x8.c index 69570b8c31af..e5b697fc9675 100644 --- a/lib/fonts/font_8x8.c +++ b/lib/fonts/font_8x8.c @@ -5,7 +5,7 @@ /* */ /**********************************************/ =20 -#include +#include "font.h" =20 #define FONTDATAMAX 2048 =20 diff --git a/lib/fonts/font_acorn_8x8.c b/lib/fonts/font_acorn_8x8.c index af5fa72aa8b7..36c51016769d 100644 --- a/lib/fonts/font_acorn_8x8.c +++ b/lib/fonts/font_acorn_8x8.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Acorn-like font definition, with PC graphics characters */ =20 -#include +#include "font.h" =20 #define FONTDATAMAX 2048 =20 diff --git a/lib/fonts/font_mini_4x6.c b/lib/fonts/font_mini_4x6.c index cc21dc70cfd1..dc919c160dde 100644 --- a/lib/fonts/font_mini_4x6.c +++ b/lib/fonts/font_mini_4x6.c @@ -39,7 +39,7 @@ __END__; MSBit to LSBit =3D left to right. */ =20 -#include +#include "font.h" =20 #define FONTDATAMAX 1536 =20 diff --git a/lib/fonts/font_pearl_8x8.c b/lib/fonts/font_pearl_8x8.c index ae98ca17982e..2438b374acea 100644 --- a/lib/fonts/font_pearl_8x8.c +++ b/lib/fonts/font_pearl_8x8.c @@ -10,7 +10,7 @@ /* */ /**********************************************/ =20 -#include +#include "font.h" =20 #define FONTDATAMAX 2048 =20 diff --git a/lib/fonts/font_sun12x22.c b/lib/fonts/font_sun12x22.c index 91daf5ab8b6b..2afbc144bea8 100644 --- a/lib/fonts/font_sun12x22.c +++ b/lib/fonts/font_sun12x22.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 -#include + +#include "font.h" =20 #define FONTDATAMAX 11264 =20 diff --git a/lib/fonts/font_sun8x16.c b/lib/fonts/font_sun8x16.c index 81bb4eeae04e..2b7b2d8e548a 100644 --- a/lib/fonts/font_sun8x16.c +++ b/lib/fonts/font_sun8x16.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 -#include + +#include "font.h" =20 #define FONTDATAMAX 4096 =20 diff --git a/lib/fonts/font_ter10x18.c b/lib/fonts/font_ter10x18.c index 80356e9d56c7..3f30b4a211ab 100644 --- a/lib/fonts/font_ter10x18.c +++ b/lib/fonts/font_ter10x18.c @@ -1,7 +1,9 @@ // SPDX-License-Identifier: GPL-2.0 -#include + #include =20 +#include "font.h" + #define FONTDATAMAX 9216 =20 static const struct font_data fontdata_ter10x18 =3D { diff --git a/lib/fonts/font_ter16x32.c b/lib/fonts/font_ter16x32.c index 5baedc573dd6..93616cffe642 100644 --- a/lib/fonts/font_ter16x32.c +++ b/lib/fonts/font_ter16x32.c @@ -1,7 +1,9 @@ // SPDX-License-Identifier: GPL-2.0 -#include + #include =20 +#include "font.h" + #define FONTDATAMAX 16384 =20 static const struct font_data fontdata_ter16x32 =3D { diff --git a/lib/fonts/fonts.c b/lib/fonts/fonts.c index a861b375e35d..5938f542906b 100644 --- a/lib/fonts/fonts.c +++ b/lib/fonts/fonts.c @@ -13,7 +13,6 @@ */ =20 #include -#include #include #include #include @@ -25,12 +24,19 @@ #include #endif =20 +#include "font.h" + #define console_font_pitch(font) DIV_ROUND_UP((font)->width, 8) =20 /* * Helpers for font_data_t */ =20 +/* Extra word getters */ +#define REFCOUNT(fd) (((int *)(fd))[-1]) +#define FNTSIZE(fd) (((int *)(fd))[-2]) +#define FNTSUM(fd) (((int *)(fd))[-4]) + static struct font_data *to_font_data_struct(font_data_t *fd) { return container_of(fd, struct font_data, data[0]); --=20 2.53.0