From nobody Fri Apr 3 01:04:25 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81EE536657C for ; Mon, 9 Mar 2026 07:53:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773042795; cv=none; b=pI/1Hp/UriEOhHrhn7AOlovG+QA4+xs0W0l3gZ/rv+0PrbouF2Ye+ec5ESyj39p6yBSTIeAR65PZkgejAGlqUEDTvtbuc+AxlYBqEpO4OMB3rn0BXR5MJqtg7VT/l/ZPMsyGJwW1vjzUDf6e0+bemD3pk+EUsSchtqrIC8U1yxc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773042795; c=relaxed/simple; bh=4lX3jmn6eJjVM3dmJR5K+haSPmZg31vbVjKpyCUuGBU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AkjP5gmo5d6vyCgKN4ibdN8zmVKxTsYAi4maAidpFADLaPcxyPEZYZiLrFZ6fAwAZLr24bc8Q/znV0xHS/4p5Ot1fcsLGVpZ5v3XROpP4CGpw8rUI0lGd3MwNx4r0ubutfDDe7VblwCAs/tQGj+avjfBqR+SaweD7e1aTuzCrck= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CVaUljAg; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CVaUljAg" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4853aec185aso5518595e9.1 for ; Mon, 09 Mar 2026 00:53:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773042792; x=1773647592; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3opfryHfhilZL8PpB6M82lqXji5/jphiotiKFxgDVQo=; b=CVaUljAggjepnXD2c/Lpy9KnyXw79MQ3L+ONI+ZRNma1++DTNNBjWEXRNxSsuweMu4 I+BEftSfZHuikLLcdhCGmxAupOCB9x6iEwDsy5mgjCEcmVOSKfnu/oIZhEByyAB6ppEY GFtZMqMBjQy42cI+13uKVunJ8F/oniNqWaUNEz6sMpcZAKF8hebE3+TQCotWw/EbbAqz XXyZq75fCgqdzydTwqyc5OH6vKMtjdnuGxl4ecXkQqYLpto6gGQVfgzsnDHxtPKb6+4W VfZ72ykz1y8jiFeOQsxcMdgdxmKJNDPMO5f2NN0nsHCk9vYo48tCfDGlZwvXlZTnMFHg cjkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773042792; x=1773647592; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3opfryHfhilZL8PpB6M82lqXji5/jphiotiKFxgDVQo=; b=GfrDPaldH+oHTcguE/O179GqReZmo55VJlBCQx3FmLRP57KBGiU3RI7hjjQR3tb1cF ZG7SWJwEmardA+ZX8OBEZo2bzW2eO2KoBaZxW6osFGCAv8ebmXFK3CKa7QNwzxeUM6Wi 26Dk5+Jj3C4PIe4sRAtMrLXs5fqTSUuF9Q3fdncPGE24AchTovJw/e7e+nqJE3iZmD3V 8e+zyn2jjRPlDmMrNxK1zodFnWERO8jdjqL610d1WM3xKHZiWJzzEcyKEMmH3kam98zq 9MyKKEZCjhSqf3GLiu4nSuT6cEfskOl9i7jwTr2PkauD9Av4OCG1OFxPJDyY2oMtray8 TSLQ== X-Forwarded-Encrypted: i=1; AJvYcCXNeOGTyOkKI6e1ZM8TjufITwdtfT17o2kgDx1gJHinoxiofge4h610FWzsBHZVFDaBQwTmOgf2Qjnx5As=@vger.kernel.org X-Gm-Message-State: AOJu0YywOg73onuryy3XYUwzixmzd7k+CcSg25QwmhhrW9bhv+AiXzWP RZojGd6gLu6skQDicZuo2cIsmra1hUWb0GSWFlk90s/M/xBX/oLfZq1m X-Gm-Gg: ATEYQzx1GNOumdaXu4Zgeqf+McnzmxV1Mw8Ip8/i1Bv1g7PZyrIsCwLQRqhZPU9u1ac QxpVpTtgURwLp/HJh77x9pTp2P81mb8qyyP1sneE5LZxPlEL+5ssWxS4OUXx0Qx5Tr3ULZGuirq cXr0VtUP8ZLXBbZikG7i0Kk3DGudnA5FYdezjW1NrX5yy3ELTnLS7ODXwWLt0jWh5r9MjvOHOyp Oga7NNvKFC4zAFIyNtJUfqT9nhbZ29Mxs39tM0WX8ogHobSaefRn3a8e8F47i0jQuSpjQbg0LkW 0ye2VYheUcg31pki4OpHm1KuqH+hR8LWhRg0kFAa2hSiqTj+dTodXOYbY8ph1JwZuk1xTxuTGRK FvKRlM2UCoSD1c2L8Oks7tQPMZmVDRXFLFdK+XBQCcb0mXquzmbc+oVtRZ/lNDe4r07YoawEYbr mHGGw3E4xVMGBn X-Received: by 2002:a05:600c:4f4a:b0:485:3f58:da6 with SMTP id 5b1f17b1804b1-4853f580fc8mr9422245e9.2.1773042791679; Mon, 09 Mar 2026 00:53:11 -0700 (PDT) Received: from xeon ([188.163.112.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485245dbd87sm97799975e9.16.2026.03.09.00.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 00:53:11 -0700 (PDT) From: Svyatoslav Ryhel To: Thierry Reding , Mikko Perttunen , David Airlie , Simona Vetter , Jonathan Hunter , Diogo Ivo , Svyatoslav Ryhel Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/2] drm/tegra: dsi: add support for Tegra20/Tegra30 Date: Mon, 9 Mar 2026 09:52:47 +0200 Message-ID: <20260309075248.47730-2-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260309075248.47730-1-clamor95@gmail.com> References: <20260309075248.47730-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Tegra20 and Tegra30 are fully compatible with existing Tegra DSI driver apart from clock configuration and pad calibration which are addressed by this patch. Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mikko Perttunen --- drivers/gpu/drm/tegra/drm.c | 2 + drivers/gpu/drm/tegra/dsi.c | 117 ++++++++++++++++++++++++++---------- drivers/gpu/drm/tegra/dsi.h | 10 +++ 3 files changed, 98 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index 1dcef4e7d104..b73d65cd0ac6 100644 --- a/drivers/gpu/drm/tegra/drm.c +++ b/drivers/gpu/drm/tegra/drm.c @@ -1358,10 +1358,12 @@ static SIMPLE_DEV_PM_OPS(host1x_drm_pm_ops, host1x_= drm_suspend, =20 static const struct of_device_id host1x_drm_subdevs[] =3D { { .compatible =3D "nvidia,tegra20-dc", }, + { .compatible =3D "nvidia,tegra20-dsi", }, { .compatible =3D "nvidia,tegra20-hdmi", }, { .compatible =3D "nvidia,tegra20-gr2d", }, { .compatible =3D "nvidia,tegra20-gr3d", }, { .compatible =3D "nvidia,tegra30-dc", }, + { .compatible =3D "nvidia,tegra30-dsi", }, { .compatible =3D "nvidia,tegra30-hdmi", }, { .compatible =3D "nvidia,tegra30-gr2d", }, { .compatible =3D "nvidia,tegra30-gr3d", }, diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index 7f25c50621c9..fbab10bc5c41 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -54,6 +54,11 @@ to_dsi_state(struct drm_connector_state *state) return container_of(state, struct tegra_dsi_state, base); } =20 +struct tegra_dsi_config { + bool has_multiple_pad_controls; + bool has_mux_parent_clk; +}; + struct tegra_dsi { struct host1x_client client; struct tegra_output output; @@ -83,6 +88,8 @@ struct tegra_dsi { /* for ganged-mode support */ struct tegra_dsi *master; struct tegra_dsi *slave; + + const struct tegra_dsi_config *config; }; =20 static inline struct tegra_dsi * @@ -665,39 +672,46 @@ static int tegra_dsi_pad_enable(struct tegra_dsi *dsi) { u32 value; =20 - value =3D DSI_PAD_CONTROL_VS1_PULLDN(0) | DSI_PAD_CONTROL_VS1_PDIO(0); - tegra_dsi_writel(dsi, value, DSI_PAD_CONTROL_0); + if (dsi->config->has_multiple_pad_controls) { + /* + * XXX Is this still needed? The module reset is deasserted right + * before this function is called. + */ + tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_0); + tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_1); + tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_2); + tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_3); + tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_4); + + value =3D DSI_PAD_CONTROL_VS1_PULLDN(0) | DSI_PAD_CONTROL_VS1_PDIO(0); + tegra_dsi_writel(dsi, value, DSI_PAD_CONTROL_0); + + value =3D DSI_PAD_SLEW_UP(0x7) | DSI_PAD_SLEW_DN(0x7) | + DSI_PAD_LP_UP(0x1) | DSI_PAD_LP_DN(0x1) | + DSI_PAD_OUT_CLK(0x0); + tegra_dsi_writel(dsi, value, DSI_PAD_CONTROL_2); + + value =3D DSI_PAD_PREEMP_PD_CLK(0x3) | DSI_PAD_PREEMP_PU_CLK(0x3) | + DSI_PAD_PREEMP_PD(0x03) | DSI_PAD_PREEMP_PU(0x3); + tegra_dsi_writel(dsi, value, DSI_PAD_CONTROL_3); + } else { + value =3D DSI_PAD_CONTROL_LPUPADJ(0x1) | DSI_PAD_CONTROL_LPDNADJ(0x1) | + DSI_PAD_CONTROL_PREEMP_EN(0x1) | DSI_PAD_CONTROL_SLEWDNADJ(0x6) | + DSI_PAD_CONTROL_SLEWUPADJ(0x6) | DSI_PAD_CONTROL_PDIO(0) | + DSI_PAD_CONTROL_PDIO_CLK(0) | DSI_PAD_CONTROL_PULLDN_ENAB(0); + tegra_dsi_writel(dsi, value, DSI_PAD_CONTROL_0); + } =20 return 0; } =20 static int tegra_dsi_pad_calibrate(struct tegra_dsi *dsi) { - u32 value; int err; =20 - /* - * XXX Is this still needed? The module reset is deasserted right - * before this function is called. - */ - tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_0); - tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_1); - tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_2); - tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_3); - tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_4); - /* start calibration */ tegra_dsi_pad_enable(dsi); =20 - value =3D DSI_PAD_SLEW_UP(0x7) | DSI_PAD_SLEW_DN(0x7) | - DSI_PAD_LP_UP(0x1) | DSI_PAD_LP_DN(0x1) | - DSI_PAD_OUT_CLK(0x0); - tegra_dsi_writel(dsi, value, DSI_PAD_CONTROL_2); - - value =3D DSI_PAD_PREEMP_PD_CLK(0x3) | DSI_PAD_PREEMP_PU_CLK(0x3) | - DSI_PAD_PREEMP_PD(0x03) | DSI_PAD_PREEMP_PU(0x3); - tegra_dsi_writel(dsi, value, DSI_PAD_CONTROL_3); - err =3D tegra_mipi_start_calibration(dsi->mipi); if (err < 0) return err; @@ -1174,6 +1188,12 @@ static int tegra_dsi_setup_clocks(struct tegra_dsi *= dsi) struct clk *parent; int err; =20 + /* + * Tegra124+ uses a clock gate, not a mux, so this step + * should be redundant for configuration; yet, DSI refuses + * to work without it. + */ + parent =3D clk_get_parent(dsi->clk); if (!parent) return -EINVAL; @@ -1562,6 +1582,10 @@ static int tegra_dsi_probe(struct platform_device *p= dev) if (!dsi) return -ENOMEM; =20 + dsi->config =3D device_get_match_data(&pdev->dev); + if (!dsi->config) + return -ENODEV; + dsi->output.dev =3D dsi->dev =3D &pdev->dev; dsi->video_fifo_depth =3D 1920; dsi->host_fifo_depth =3D 64; @@ -1600,7 +1624,7 @@ static int tegra_dsi_probe(struct platform_device *pd= ev) goto remove; } =20 - dsi->clk_lp =3D devm_clk_get(&pdev->dev, "lp"); + dsi->clk_lp =3D devm_clk_get_optional(&pdev->dev, "lp"); if (IS_ERR(dsi->clk_lp)) { err =3D dev_err_probe(&pdev->dev, PTR_ERR(dsi->clk_lp), "cannot get low-power clock\n"); @@ -1621,10 +1645,12 @@ static int tegra_dsi_probe(struct platform_device *= pdev) goto remove; } =20 - err =3D tegra_dsi_setup_clocks(dsi); - if (err < 0) { - dev_err(&pdev->dev, "cannot setup clocks\n"); - goto remove; + if (dsi->config->has_mux_parent_clk) { + err =3D tegra_dsi_setup_clocks(dsi); + if (err < 0) { + dev_err(&pdev->dev, "cannot setup clocks\n"); + goto remove; + } } =20 dsi->regs =3D devm_platform_ioremap_resource(pdev, 0); @@ -1688,11 +1714,40 @@ static void tegra_dsi_remove(struct platform_device= *pdev) tegra_mipi_free(dsi->mipi); } =20 +static const struct tegra_dsi_config tegra20_dsi_config =3D { + .has_multiple_pad_controls =3D false, + .has_mux_parent_clk =3D false, +}; + +/* + * Tegra30 allows DSIA/DSIB to be muxed to either PLL_D or PLL_D2; this is + * simply not modeled in the clock driver yet. If this functionality is + * required, the has_mux_parent_clk flag can be set to true once the clock + * driver is patched. + */ +static const struct tegra_dsi_config tegra30_dsi_config =3D { + .has_multiple_pad_controls =3D false, + .has_mux_parent_clk =3D false, +}; + +static const struct tegra_dsi_config tegra114_dsi_config =3D { + .has_multiple_pad_controls =3D true, + .has_mux_parent_clk =3D true, +}; + +/* TODO: figure out why has_mux_parent_clk =3D true is necessary on Tegra1= 24+ */ +static const struct tegra_dsi_config tegra124_dsi_config =3D { + .has_multiple_pad_controls =3D true, + .has_mux_parent_clk =3D true, +}; + static const struct of_device_id tegra_dsi_of_match[] =3D { - { .compatible =3D "nvidia,tegra210-dsi", }, - { .compatible =3D "nvidia,tegra132-dsi", }, - { .compatible =3D "nvidia,tegra124-dsi", }, - { .compatible =3D "nvidia,tegra114-dsi", }, + { .compatible =3D "nvidia,tegra210-dsi", .data =3D &tegra124_dsi_config }, + { .compatible =3D "nvidia,tegra132-dsi", .data =3D &tegra124_dsi_config }, + { .compatible =3D "nvidia,tegra124-dsi", .data =3D &tegra124_dsi_config }, + { .compatible =3D "nvidia,tegra114-dsi", .data =3D &tegra114_dsi_config }, + { .compatible =3D "nvidia,tegra30-dsi", .data =3D &tegra30_dsi_config }, + { .compatible =3D "nvidia,tegra20-dsi", .data =3D &tegra20_dsi_config }, { }, }; MODULE_DEVICE_TABLE(of, tegra_dsi_of_match); diff --git a/drivers/gpu/drm/tegra/dsi.h b/drivers/gpu/drm/tegra/dsi.h index f39594e65e97..d834ac0c47ab 100644 --- a/drivers/gpu/drm/tegra/dsi.h +++ b/drivers/gpu/drm/tegra/dsi.h @@ -95,6 +95,16 @@ #define DSI_TALLY_LRX(x) (((x) & 0xff) << 8) #define DSI_TALLY_HTX(x) (((x) & 0xff) << 0) #define DSI_PAD_CONTROL_0 0x4b +/* Tegra20/Tegra30 */ +#define DSI_PAD_CONTROL_PULLDN_ENAB(x) (((x) & 0x1) << 28) +#define DSI_PAD_CONTROL_SLEWUPADJ(x) (((x) & 0x7) << 24) +#define DSI_PAD_CONTROL_SLEWDNADJ(x) (((x) & 0x7) << 20) +#define DSI_PAD_CONTROL_PREEMP_EN(x) (((x) & 0x1) << 19) +#define DSI_PAD_CONTROL_PDIO_CLK(x) (((x) & 0x1) << 18) +#define DSI_PAD_CONTROL_PDIO(x) (((x) & 0x3) << 16) +#define DSI_PAD_CONTROL_LPUPADJ(x) (((x) & 0x3) << 14) +#define DSI_PAD_CONTROL_LPDNADJ(x) (((x) & 0x3) << 12) +/* Tegra114+ */ #define DSI_PAD_CONTROL_VS1_PDIO(x) (((x) & 0xf) << 0) #define DSI_PAD_CONTROL_VS1_PDIO_CLK (1 << 8) #define DSI_PAD_CONTROL_VS1_PULLDN(x) (((x) & 0xf) << 16) --=20 2.51.0 From nobody Fri Apr 3 01:04:25 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B250363C5C for ; Mon, 9 Mar 2026 07:53:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773042795; cv=none; b=XVWuwTpS9OlEK6D2TcVjDkH7E5eiA9DS7N3N5mdzOPqGpdEFcFx89I+9wcw2W5VNBpuu3QnqARhMwK3gdVXJf3l8BN6tAxlZnBcCEKSGAOgDN6Yr124hgrfgUDS4uzpKysffLEefkkmkMpBJbcBjh8YVYzSPuFLcGTxoYZEHbQA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773042795; c=relaxed/simple; bh=BfCGLduhY9yG7QLq78Hh4dR6ZPzK4zm1QeyS8EzRSxY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EX2l5/XLfuz8e0cCFhQ+2EOjxXFo77nwLqE1MBV3z8n6S9u162jNW7EYHGKq5HwqMGX4wZTgqAHxaUtgCG1C2Jyxe1d2N1BdfSagM/iSGmwuB541b7jlrN+dQ4IIxlOhhDYnpd5zmjF1niRYGG8GJyoBUVP14ZR86zMmOl/jMBs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I8JZtw2L; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I8JZtw2L" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-482f454be5bso113377315e9.0 for ; Mon, 09 Mar 2026 00:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773042793; x=1773647593; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4/vo+yztL0AmH8P24goXzbtezovr3DoQGmWB3EtlnhE=; b=I8JZtw2LZx739So3eBhwattFpRcM/xJeGX48zSgjcbsJ4loHtVOdhw27bOASyxg/QK iTJElJGMR++V4iLgpAZWCW/zXomiigO0SZ8/gMRcK8oxmgIf0kgU+KWmHwsqwJOhUmNl uYkLaZOJ+Bh6Xdp/V43EUH3/gjJev5BuQpLdOQoJxvIAbaQ3Iwl4rcpMfLenllXtPM6A FPYLJqp57ywk/1NyJWBqqIcyxgN7q46YmJOJZYHa8v5TSQ5Gh6n1zA6og5FF05Ilypsk Y2Cf9+Yfc3sAIpH0jsOktB6KCkSTyfEje314ySJM314l/v5k5CrskOmae8XN/rjuXdZ7 4ZPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773042793; x=1773647593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4/vo+yztL0AmH8P24goXzbtezovr3DoQGmWB3EtlnhE=; b=D5ncguNTVTWwvyKbEYRCU0U4O37Wesd+7hxkkkP81lSQAQFYpu5h+TudBQqh6inl4+ 99Yry+6unor+ryNClmOi2afWSHMIDvsCW9zGtb0x8/SatHh5yYvtqU4mTP5cIB0v9Rns aX+mN6nfjE503ifC+2Lz2XL2tWBrWhv9McWfAd9SfsMnPqyAPAKPLZmHUMpPbFxIDqWj F5L34YBOhe9CWr2XdHEUM8GR8VecmpMie0uG2bmmpLJUk6//igaNUuZaAXlh1oIo+Hde CRQ4ap9MAr7IPfcek5oG2AwXG1YwXSCt5cWC25RK4wO5avBKN/6dX3OWyqJEXGS64DHH 5oug== X-Forwarded-Encrypted: i=1; AJvYcCVyr8I/A597SpsI6VSEeDEesJbHVzQwSLKTXkQDBuyVmF/hkKgHrqoltBDVyCuUP0BwzFhwx1Sli7SYqxs=@vger.kernel.org X-Gm-Message-State: AOJu0YwAj459SEk7Ws/Y97BLX48u3JxrTC/bDEC8gOAZM0zWu2T4ooev D+88hq0PPwyhBOhFCGa6koUio7JUJru8+YayuG58Mp3pCzwrqM7P72hR X-Gm-Gg: ATEYQzyYnCwaljMTYEcGhlClRub+tDmCx44l2zcE7sB+SfNu4n103kJzOcDPc9MTyOX PWz0KsA1UvCOZrA3z5x27kUgcpZ+pAT4C1a9aRTAAI7WiwJ21/Z7oQAwd15i1lxzTSwKqgX+ZmT OevWIwm4XCO5y2juySAA8OsugaQwfC4KcBRDwS/KW+Um1NoyEnqTlx687pmnxTDIhFfrD4Z15nE Cq1YxHcclnOT+TYGZ+hCWjCkFfD6HJjoqQGpOAS4j/MOZmdJv8RoCEB6mEZqUnjqCp3AVSxZIVt p9gU2LkcyE1ag10Wl8UCLbpiOqGto7GDcY+t35XzTNVN9q0P9ftnsVX70/cFSpD4QOhP2sXZzyH QVyDydG8M9xpu+OfG1/TNqsbo2f5LnLsKbNsBYZYnRVBNPOCla06haYj9rg+acNIQy6j0NWIGaq rs2c1djuPKRiGG6DsW6OrvnQE= X-Received: by 2002:a05:600c:3f06:b0:485:3e00:944a with SMTP id 5b1f17b1804b1-4853e0094c8mr13491155e9.9.1773042792676; Mon, 09 Mar 2026 00:53:12 -0700 (PDT) Received: from xeon ([188.163.112.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485245dbd87sm97799975e9.16.2026.03.09.00.53.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 00:53:12 -0700 (PDT) From: Svyatoslav Ryhel To: Thierry Reding , Mikko Perttunen , David Airlie , Simona Vetter , Jonathan Hunter , Diogo Ivo , Svyatoslav Ryhel Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 2/2] drm/tegra: dsi: re-add clear enable register if DSI was powered by bootloader Date: Mon, 9 Mar 2026 09:52:48 +0200 Message-ID: <20260309075248.47730-3-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260309075248.47730-1-clamor95@gmail.com> References: <20260309075248.47730-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Original commit b22fd0b9639e ("drm/tegra: dsi: Clear enable register if powered by bootloader") was added to address the issue of DSI being in an unknown state after the bootloader, ensuring correct panel configuration. This worked fairly well under the assumption that the bootloader had set up DSI; however, in cases where it did not, the device would hang because a DSI read was called before the DSI hardware was ready. Removing this workaround results in the issue described in the original fix: the panel initialization sequence fails and the panel gets stuck in an undefined state. This is especially noticeable with command mode panels In order to properly address this issue, the original workaround is restored and placed after the DSI hardware is prepared for R/W operations. This fixes behavior for both cases: where DSI is set by the bootloader and where DSI is untouched. I have tested this change on Tegra20 (Motorola Atrix 4G), Tegra114 (NVIDIA Tegra Note 7 and ASUS Transformer Pad TF701T), and Tegra124 (Xiaomi Mi Pad) with U-Boot, using both bootloader-initialized DSI and untouched DSI. Fixes: b22fd0b9639e ("drm/tegra: dsi: Clear enable register if powered by b= ootloader") Fixes: 660b299bed2a ("Revert "drm/tegra: dsi: Clear enable register if powe= red by bootloader"") Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mikko Perttunen --- drivers/gpu/drm/tegra/dsi.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index fbab10bc5c41..e7fdd8c7ac12 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -936,6 +936,15 @@ static void tegra_dsi_encoder_enable(struct drm_encode= r *encoder) return; } =20 + /* If the bootloader enabled DSI it needs to be disabled + * in order for the panel initialization commands to be + * properly sent. + */ + value =3D tegra_dsi_readl(dsi, DSI_POWER_CONTROL); + + if (value & DSI_POWER_CONTROL_ENABLE) + tegra_dsi_disable(dsi); + state =3D tegra_dsi_get_state(dsi); =20 tegra_dsi_set_timeout(dsi, state->bclk, state->vrefresh); --=20 2.51.0