From nobody Thu Apr 9 04:22:32 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92C6423ABB9; Mon, 9 Mar 2026 07:22:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773040935; cv=none; b=keV5rPc22XJhhrn58he64ISy2T5mUvs0NwSX8XgwC8hBMB60qT5jgazmOWCNfgC0EzKK7CS2Gh+VoMt67K/4gugEr1n4dlarhSaG9HJOc/8ENLe8CGS6h7ELzdrJDUfMvToEUTiYfqgBeBEs1/Vic/C43uoDWoUhIS8hm1ulDu4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773040935; c=relaxed/simple; bh=msN3ZiJEnwDLoCFL3ktp3bf7S5AjPmhNHN71nh2kZjg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=GTlVaKIDVAVgyIZ59A5FmMne5TF7orxy+xgIhkzcAwU/MKLsDwI+hpcaH7CcPl2ApEFQBU7Nk3RGZzADczQxrg3vZsM1ZMKEo+vz4saawOy/Zgg0oBxbX1yE0u2JbnL3A+AqIZOZV+I6KD81x1SFdPocs+kT6Y3iJrLTSmfWu2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=FipDDQ/5; arc=none smtp.client-ip=220.197.31.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="FipDDQ/5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=ST Qwf4PoSneb90M0vtP5ikDTJD5DzHGA/Ui7t+WaGNw=; b=FipDDQ/5Hfe1297mbd 2cShBsiOGj2SnIdBRKQCJNbQ7MA1dLjmI4zzQmJHYgj7HL5831r6ph8ICjboaU/A rMmQAhmDv0S/l8WzqkeDU9XQC/PVNdlghOLIBAgAdamqkLo2ZglfOHvAh3TFbccj wzjETc+4PsybJeEg0+8EFWWhg= Received: from pek-lpg-core5.wrs.com (unknown []) by gzga-smtp-mtada-g1-1 (Coremail) with SMTP id _____wA3bfoPda5p73LiOg--.36932S2; Mon, 09 Mar 2026 15:21:52 +0800 (CST) From: Robert Garcia To: stable@vger.kernel.org, Takashi Iwai Cc: Robert Garcia , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH 5.15.y] ALSA: control: Avoid WARN() for symlink errors Date: Mon, 9 Mar 2026 15:21:51 +0800 Message-Id: <20260309072151.2462506-1-rob_garcia@163.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wA3bfoPda5p73LiOg--.36932S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7CFy7Kr45CF4UJF47Gw4xXrb_yoW8tFy5pF 4jganrt3Zrtr9rJa9rur17Wry3Xan7X3W7Z395KrykArWfAryrurykKrnYqFy3AFZ3JFyU Xr45JF1v934akrUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zR_wIhUUUUU= X-CM-SenderInfo: 5uresw5dufxti6rwjhhfrp/xtbC5RFn0mmudRFzgAAA3R Content-Type: text/plain; charset="utf-8" From: Takashi Iwai [ Upstream commit b2e538a9827dd04ab5273bf4be8eb2edb84357b0 ] Using WARN() for showing the error of symlink creations don't give more information than telling that something goes wrong, since the usual code path is a lregister callback from each control element creation. More badly, the use of WARN() rather confuses fuzzer as if it were serious issues. This patch downgrades the warning messages to use the normal dev_err() instead of WARN(). For making it clearer, add the function name to the prefix, too. Fixes: a135dfb5de15 ("ALSA: led control - add sysfs kcontrol LED marking la= yer") Reported-by: syzbot+4e7919b09c67ffd198ae@syzkaller.appspotmail.com Closes: https://lore.kernel.org/675664c7.050a0220.a30f1.018c.GAE@google.com Link: https://patch.msgid.link/20241209095614.4273-1-tiwai@suse.de Signed-off-by: Takashi Iwai [ Use card->ctl_dev.kobj to keep struct consistent. ] Signed-off-by: Robert Garcia --- sound/core/control_led.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/sound/core/control_led.c b/sound/core/control_led.c index 3eb1c5af82ad..df836ff550f8 100644 --- a/sound/core/control_led.c +++ b/sound/core/control_led.c @@ -693,10 +693,16 @@ static void snd_ctl_led_sysfs_add(struct snd_card *ca= rd) goto cerr; led->cards[card->number] =3D led_card; snprintf(link_name, sizeof(link_name), "led-%s", led->name); - WARN(sysfs_create_link(&card->ctl_dev.kobj, &led_card->dev.kobj, link_na= me), - "can't create symlink to controlC%i device\n", card->number); - WARN(sysfs_create_link(&led_card->dev.kobj, &card->card_dev.kobj, "card"= ), - "can't create symlink to card%i\n", card->number); + if (sysfs_create_link(&card->ctl_dev.kobj, &led_card->dev.kobj, + link_name)) + dev_err(card->dev, + "%s: can't create symlink to controlC%i device\n", + __func__, card->number); + if (sysfs_create_link(&led_card->dev.kobj, &card->card_dev.kobj, + "card")) + dev_err(card->dev, + "%s: can't create symlink to card%i\n", + __func__, card->number); =20 continue; cerr: --=20 2.34.1