From nobody Thu Apr 9 12:06:20 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DE07358388 for ; Mon, 9 Mar 2026 07:14:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773040488; cv=none; b=pVqGy4pULSKaVTMF4KvUTylxNnilMb6uf18FCjCPw+AVbTDABkrOUMzCjVlTG3uaZeFUwalDuwRwl63CpLHPGEwVOSgmfrVnvxrCsLAABnWi+N4WWQudNz6MOo9TNwY7OLyilw3lDc9/FVQONF2hEiLIPcbblVRBl2idrdUhj8I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773040488; c=relaxed/simple; bh=rkC8P++ezNTx6+/pK7aTphkaTcqlYYJAX7IJ7kVb1lI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=e5dbvCnOgA6LVXrpv05DF43CNHL4IDS91JlxUmfNnwLt6UjyeZsuSNH7xo/yQvJAIZHHQlx+h5uzLw/N/X6egLXL7L6rpPYcza5zjf1gzRhqvqcuQk0ntqrgmVeRoQfW4OqiC2GDzDmxCPHR6WJOSdGWe3uFPs6PQnDn5jUqYOA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DpKJ//s+; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DpKJ//s+" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-82990763921so3538445b3a.1 for ; Mon, 09 Mar 2026 00:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773040486; x=1773645286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=G6HUsO3M7ZZ8Ut9rj2caYw8IlrcrpP3M6Iiwk8QM1Y8=; b=DpKJ//s+AXZi2R5MlKiTt5zgJXd/2cR61b/JU1Sj03Cj2RjIxuz+MsarEou9It1ut9 2VRpuCF6ekrwH2CpmLsLX2noj0CoghtMCf7XLdhWCkXkL1LrkIWOdRdAJXQy9xsBIeKz F0w6VRi1k1pAuAJNsjqv7d32Nd/IKyFT8HUAzqwXiy45McdqMlxr8VghKvCPlZhloeUU RDw5fa5MewdSoE3nR5wtGocXBvmmn8KarLDGTvXj0lFlWyAbcRGXvAM5w9INo1NB4tiJ 5W1darsja702o5v7C2VqsecQAUo14gyO7te1gDNquA61KQeEOnhqCEFmAPxlOD3F8Owe YBUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773040486; x=1773645286; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G6HUsO3M7ZZ8Ut9rj2caYw8IlrcrpP3M6Iiwk8QM1Y8=; b=Um3G0worHP4PwbIghte7+Aa5QdKRUf2E1+O4o4JvL9cnOVo+4xaoys8dXPb1e99gP6 Y/p8LDelH5O/Uwv7Lse5/zfQQi7FFq4PsFZnsIkNeX6WVpvqmaCdnRv0Dm2udF/YeUXE KBGexNF2Kxv2ATsE38TcOaLWRd8TeQaAHLZ3X7rHbsWzPXDGfnSk760GF4j0BT9wqVv/ uqTD9BLtTx9kF791UUhefvFurf9zVH/ykvCdzttpJ+fwTLV6kXKt3+9AMbnCnum/9qlG 3OJA+spO9En1waLrgaT6UZskY517/bdhNXMAw6gcesbRHavUi0RGk1D3sKKR4CZFq9HC Qb/A== X-Forwarded-Encrypted: i=1; AJvYcCWw4y4H7BR/LBG4AiJesqHJFfwx/3XgZ0MeKt74Q07P80Th5S4CvmjT3imYjHpTnv97tjyCPDAYs2qQc78=@vger.kernel.org X-Gm-Message-State: AOJu0YzPiSH1BhG/8mRmNPvotj1opmPjwBkWzQh2Yx2b8eFpw0l6fv1Q OBVnxAZWf05fwCcKdxn7RU5ksSFY5zcrtoBr1NB2VLios+zl0ygXEkCM X-Gm-Gg: ATEYQzwe5ihRGPA6FMTyM+xa0YUinCopjurux4u+oQLIBcQkyqhsrBPOTyue4WGTsNI W5oY3UBWl7ZCzWjMrnQlImqxZMYhx0q090XKj0Od7V204tmPdc77amCR8n1ES20Sq5E1bgOf881 eSXV04esxtkOuvhaioQzZNcdtYp/7WJm6OXMrEt3l3IJ70DE46F4+9PwChzoDRSNLwIsUPvSx4W S45yjuhZN5+SygPtUSPu+0OuoMsZ/8Plzcvi0rWjRigWN8lXd79l0DA4/UUrhjp/54PEJBVoOOz +iW5CyKBJxjy5eyYC3bt6LtqpE29uZXgZ/iGps3hmzC2kbmLf6YA/O4mDKwhZSTznT8nzcj9V6O N74tmf8tGLZqMTG6lU0AniJs50zD5o0/bpWbhzCv/YXHjMB93nRAdKNtQ5Of74HVtAJ5lcXmlpM eGE6earhtYD2uIL+U1yLFvMgBGxC2u0EPYiR5H/LmP5KUCWHjY2j++kFGMlg== X-Received: by 2002:a05:6a00:1827:b0:829:6f37:158a with SMTP id d2e1a72fcca58-829a2e3f823mr9422325b3a.18.1773040486495; Mon, 09 Mar 2026 00:14:46 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829a4636cfbsm9052571b3a.13.2026.03.09.00.14.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 00:14:46 -0700 (PDT) From: phucduc.bui@gmail.com To: dmitry.torokhov@gmail.com Cc: phucduc.bui@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Input: mpr121: Drop redundant wakeup handling Date: Mon, 9 Mar 2026 14:14:13 +0700 Message-ID: <20260309071413.92709-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The driver currently calls device_init_wakeup() and manually toggles IRQ wake in suspend and resume paths. This is unnecessary since the I2C core already handles wakeup configuration when the device is described in Device Tree with the "wakeup-source" property. Note: Compile-tested only, not verified on hardware. Signed-off-by: bui duc phuc --- drivers/input/keyboard/mpr121_touchkey.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/input/keyboard/mpr121_touchkey.c b/drivers/input/keybo= ard/mpr121_touchkey.c index bd1a944ded46..47edc161ec77 100644 --- a/drivers/input/keyboard/mpr121_touchkey.c +++ b/drivers/input/keyboard/mpr121_touchkey.c @@ -295,8 +295,6 @@ static int mpr_touchkey_probe(struct i2c_client *client) return error; =20 i2c_set_clientdata(client, mpr121); - device_init_wakeup(dev, - device_property_read_bool(dev, "wakeup-source")); =20 return 0; } @@ -305,9 +303,6 @@ static int mpr_suspend(struct device *dev) { struct i2c_client *client =3D to_i2c_client(dev); =20 - if (device_may_wakeup(&client->dev)) - enable_irq_wake(client->irq); - i2c_smbus_write_byte_data(client, ELECTRODE_CONF_ADDR, 0x00); =20 return 0; @@ -318,9 +313,6 @@ static int mpr_resume(struct device *dev) struct i2c_client *client =3D to_i2c_client(dev); struct mpr121_touchkey *mpr121 =3D i2c_get_clientdata(client); =20 - if (device_may_wakeup(&client->dev)) - disable_irq_wake(client->irq); - i2c_smbus_write_byte_data(client, ELECTRODE_CONF_ADDR, mpr121->keycount); =20 --=20 2.43.0