From nobody Thu Apr 9 13:32:55 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B200B363C77 for ; Mon, 9 Mar 2026 06:51:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773039109; cv=none; b=H05czv1TEcY4k9IBzRdswXZ1bgkbNFxyy4D003RQzimrdm0vAstndW/uJNXHx//Jf8yIlMMRscLQsuGXQJEROU4bHKlZ0hIfKivNC5LBAkhpS5q2bu2fZf2UuUBCX0QweE58SgDhZb5pp7Lfj46y9hmf1FZsY6AN38qp+NgYqoU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773039109; c=relaxed/simple; bh=KvhN5EIM3XXPaotrLaYPSuOdgBSYq4SNpSPqi8ZqfN8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EMt09cf5nyHV7Ut1l1ky6Po/gxNFEhmAKVPihc5byy2iNBGmCegURW7FfN4rEW0Oh5yS2KiNDTEmRg8Hj9eHESHKlejOsILO5iELcbZuATqwEoLvavEYMkTCh9cWAW6Aax1zgZlWH7rDagOAxyJYkNRVEsphXZEhLucEWLEj+JY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cmFK+nWg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kpqAWjPF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cmFK+nWg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kpqAWjPF" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 628N0S3Q757228 for ; Mon, 9 Mar 2026 06:51:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=K4gYoo9JoJP OJ5mTuliJj+hphclVDgk4+5Zp53bnrEg=; b=cmFK+nWgaDRXEf7HW4kJDJoEKa0 1ycRV0TDgd+0gtsdmZ+4bfDhLlM3XRafP87CNKDp37kDvzXxu24zvDSFjtWqXNqK BjUQtCnXh2ehPKgN7XFpgnLO4XViA69vcuXfrjNbrdTyYl29KI+1dvKDq6iUhkQC AuccxYKMnwUbSkU1rEnD2Rzoq6BBQMEqm5VFRtwAtF6Ilwf5vVPpruEhPC0X1NmR poto8vkAFhAQdEFYP3UlkChMQY0qkTCFKmuBpwt5g5FmihfPSIK8ewurd2h4jED5 OXIgY1svOB20ZiovTNA4me17eYrdnQI3lPnY06yEq+g/lVokHKdz9o56REw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4crb14vbhg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 06:51:46 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd722c1a69so1249113285a.0 for ; Sun, 08 Mar 2026 23:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773039106; x=1773643906; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K4gYoo9JoJPOJ5mTuliJj+hphclVDgk4+5Zp53bnrEg=; b=kpqAWjPFG2FDzh+EOcuQSRskd6a1qNXs5qx0+50lBkXlkPavQm2JyMbKtyat712NaR Q1rA/G4O+lBfiBUP6MigCvrmctMKKtc+pCFKF+Pa/lMLdAcTYkFEDqrH52oHPT3ggCFl 5urxfo4QM6HbnBbyihLiJxTpRHpZTu3dGnOUkgj+zYFB9OP7SHsdWr8vC/IoqxoO80/8 I7VRUB9311qNJdOM1t065zCixOirUJ9hK5+mmBEb3ZjD7H1J0U//ojzjdo5bMbannm8w KgDbYPzs5EqISGiwJzTh602SUHE9qqQbYYJwDposkuXDHfQGB/PMr0+J00lv4ft7p7II Aquw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773039106; x=1773643906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=K4gYoo9JoJPOJ5mTuliJj+hphclVDgk4+5Zp53bnrEg=; b=SXqXt8IDXXRhwnCiZHiIECh/S4A0krX9daxm1rafpPOTfXN6wUD7PhH6CvkFIAJQ1J aoZnQCvH/W9AE856UyW7mmLuTrr5EOPyHX3z214Td1qWUJMN7uI2hYG+UsztMeMgm0df fEr5Yx3nSk9wg5wQtvzVcQe+MpiwlgV5FISG6Zn+GNtXwofNDOkUHy5BCAksbc5qNjNH B4CdhDL/UOpS6SqqxOZhhug/rYGSgOrZZcmh2yNUyiKne/gJP9yYRYKIuz62doF96j7/ tPAL3tlgor3NFIds+PQVkr5lCxn2Jds0zTIyRIjzShM+ZgUQGGUR494YzApYCVJZQjXP PjjQ== X-Forwarded-Encrypted: i=1; AJvYcCVp5ZZKp+oZ7g2Idf6fU70QabFtXdTc625Xm/sT/E7tOjOkye8UVN8V8tNrO4NHp0e09nxsIuAqUPN2zqA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7eRveQLa0LHGfQj1jXT5xc8Jub90JwuiYuWrCO5bpXfc0AadL NYalPcdXADZ6iKQRa5u/e6UPGLAquz+CtvKkP5NLuX7cSXUOcptSGzCoRa+98srWl0PYo4TT9lW 9+uxcXKbbt9EFSsYUgHKtt6MwDH1vHp038aiC7yc4Ms298LGHmoJHjFEMVqchZ4ME/l8= X-Gm-Gg: ATEYQzzDS3MT4i2X4t2KYhijD2e21E9DfOhUboSE6ZCP8p8LFFyYvIZQfFo8TdoyfCB BS2+MdrVZCKWtyV4lt+cj2cXqp0pWAS4JculUCRyyPdEhjVnXs8SYt4LMiid3NFkPZSyttl1swH 3FdYitcOD2vv5BzewG4G0ikP9r2dLe9oiCziGRGryNEyI+SOV72/FUuWux9GAtd4fOxmqE8Gsvx oh2tWYNQljKhIfW7PcRreqFSKqFwnt2avY9kzgBNc9Rxk6Xx1gwdomqGo+91XLPrGqYAgaNuI4N 6cVcsiUMwcT/n+lm+MzgKsQyMuqVx3N0RedH55KqNesSDAGI1+dWFV8LbXN6vU//yJHWXE6rb5N 6QuYYUnj2iEOuTO5rxQBclWpBxzvm8tH8hNXXHhrJmzbTBdXB5jlGmW8= X-Received: by 2002:a05:620a:25cc:b0:8cb:52e0:15e8 with SMTP id af79cd13be357-8cd6d4a9f47mr1282177285a.76.1773039106244; Sun, 08 Mar 2026 23:51:46 -0700 (PDT) X-Received: by 2002:a05:620a:25cc:b0:8cb:52e0:15e8 with SMTP id af79cd13be357-8cd6d4a9f47mr1282175585a.76.1773039105857; Sun, 08 Mar 2026 23:51:45 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48529f01997sm80449975e9.14.2026.03.08.23.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2026 23:51:44 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mailingradian@gmail.com, Srinivas Kandagatla , Stable@vger.kernel.org Subject: [PATCH v5 04/13] ASoC: qcom: q6apm-lpass-dai: Fix multiple graph opens Date: Mon, 9 Mar 2026 06:51:28 +0000 Message-ID: <20260309065137.949053-5-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260309065137.949053-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260309065137.949053-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=IYSKmGqa c=1 sm=1 tr=0 ts=69ae6e02 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=M_mAHeyD2EURj3i0m2kA:9 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: YS9A_LYMv48pIeQ0-oHruq7yr2im5k7C X-Proofpoint-ORIG-GUID: YS9A_LYMv48pIeQ0-oHruq7yr2im5k7C X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDA2MSBTYWx0ZWRfXwr9psQxjs6XS KBY/bZe3GYdgo1mS/uMBZuiiV16HFq2HKxtDHBMiFKlSlrphWaq83VVEN06Ntxgd3HMv19p8B7g HU3leJvrg5w8bFvHYzs/GXbFyCPjOo19hT+FolHoWJinqBzNvBxc6GySP2HlACZKwA+RcmQ9+Ko qS3zhA/69dqJ9Y8s0HbkL6wOrFgoYCUuFzXJblqk4PFU9+szFnjYkRLGD7C5xxFHE0Sznl+UaPE y2k42lTjKvWZgUzayc4NNNr0QlTCf/ovI1rvS6Tv7qYhDWxsKTWPn0lFNQDbIdaQRRnCD2qddr1 Vo06B2RkS5x03QJf5PUVeE8rt6BKNLAjArfH7srq8dVUduK8/IgO11Ove43ZC4d88bNpHitzFGE N+xRmMHr50x7J+UVFLtlBtYVTpK1F8tA8qsWHwmbVoTFBgY3IAOduZDpLNKwxdK8GoI3K0Xsd6d tjjMauoYg5T3f0aMruQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_02,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 phishscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090061 Content-Type: text/plain; charset="utf-8" As prepare can be called mulitple times, this can result in multiple graph opens for playback path. This will result in a memory leaks, fix this by adding a check before opening. Fixes: be1fae62cf25 ("ASoC: q6apm-lpass-dai: close graph on prepare errors") Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6= /q6apm-lpass-dais.c index 528756f1332b..f68d4b4974f3 100644 --- a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c +++ b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c @@ -181,7 +181,7 @@ static int q6apm_lpass_dai_prepare(struct snd_pcm_subst= ream *substream, struct s * It is recommend to load DSP with source graph first and then sink * graph, so sequence for playback and capture will be different */ - if (substream->stream =3D=3D SNDRV_PCM_STREAM_PLAYBACK) { + if (substream->stream =3D=3D SNDRV_PCM_STREAM_PLAYBACK && dai_data->graph= [dai->id] =3D=3D NULL) { graph =3D q6apm_graph_open(dai->dev, NULL, dai->dev, graph_id); if (IS_ERR(graph)) { dev_err(dai->dev, "Failed to open graph (%d)\n", graph_id); --=20 2.47.3