From nobody Thu Apr 9 13:32:56 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5169A363C58 for ; Mon, 9 Mar 2026 06:51:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773039107; cv=none; b=LAZSULPRoPrdzQDtpoRZLvT5Aj0oixygXYNkLoZMjRX6uxUTabFlxn/gdtewwvlGZ3YvlHYM6YjHP0spVQ3a5tnhOXTzGFGLxL2HV/0fcYCT/Fat4hYX9sz2NTdpE9wVf2An5pRnucle4jI6QbgKBc6eNwEKtWXao0dJGowwx0Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773039107; c=relaxed/simple; bh=6jShP5otc7Z/xglFZY5mqaUqDhEckaI1JOm+jwe6kcI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DfbxxHRrY9pbftEuXvBw5+PzHsJK1xmNZoD7cdgDT+9UmZdhglLaoHwbpmc+XLDbs/aKf2ZjRo6fSD5ji9ZOPvl4if9WkUB8BWmRuLBCI8jm9/UwuvqS1e1kOyNc5tEKkFz8cjqT4J+/E7/CA1awojmTVW3XcosiIPJ6NyOWmfs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=b/RFu8QE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XnmKcxMX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="b/RFu8QE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XnmKcxMX" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6295UIdT2631702 for ; Mon, 9 Mar 2026 06:51:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=xKWL+GAYqNp +tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=b/RFu8QEUhQsfImzB+Sa8XC+Dd1 6oNJGDwefPGEG5xw5O423ro2suzPx60HSxzBhBnFYEwFBMj/lBNtlDkuDnd2Af/r /6kMe/vZ24jJIiQoDuDAzJhQiX4fHVhsTbw/egMmfKnxgNgeJR00I9HS3jo85qRy kDe268BsZwnNW0KFGuaYzGXeyRsVh2PND7c0tIEDrlw7IVj9LA6hddh5U7HkTmiy 7moq8VLR17IDhIXLrpbPN83y2iyuSKSqVJWMPfi3leXUoidQfMLg9+JMnbRt1vQl dSVlbDaejYJxc6d5Xt33nM2MrmQ5Gj3Vgy0XAV6La70DSLmvpdtX4U8cDRA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4crd6fc42y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 06:51:45 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd81ce6fdcso1194725885a.3 for ; Sun, 08 Mar 2026 23:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773039105; x=1773643905; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xKWL+GAYqNp+tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=XnmKcxMXjuxTLr9R2Q3VF6/qi9dq99XtwoIGHiAFiEI9GeT2UVRGpVr524wVkpvXik xbKQp6t0Cz+cdbwibFkKxp83glIeFW8Fw42Zfwcp888lRKDmMV13OqVITa8LpZdH7VtW Olg0QCzMIVScOa+ZHXeI5vGmtrNbY/+LIm3Lz3aUKlEzoML9h1DZIjeVLUQCkitQO0KX OstrQ7A73bQW/wKUoTT/618WmlDiYjwvdCesXPsefPru/Ywgp7OB0t0I7VZl8joO5cvV dSkOZN3bEO0jpVQk1Z9m6lCQ2e+Mf/UnKXuFzciDpqzPPY7Zg06Rmv3LDutipr7EQM9e HJLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773039105; x=1773643905; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xKWL+GAYqNp+tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=pSEyYRqvHFUurNZJ92HmY3cy/pvaUzycbmJk66kR2GIE4uD5AXckpcSeLTI7cZxyOG quk2OLAyxy5XGvbFGZQ4gIPy9re/9jccPVsvBe5OdFFYUremUtTFiz0wMpGZCXGzcmsh nTLPvYWhN0H4wYjzYV/c/Z4opVsueh0tjz5VBIr2eYVHi4RxQfwvxYSGOf4mLvjkMcGh Rp1vq8DUXucvmL4YUoKcDVCyN/jnXNb8RF9MUKLlzVOIKaxzXGkx/d/W+C+UXWkfperj LmdILG9MO+oadM3MrOZ2VJpK6sfmixj67BkC/vrlYLk8klJzSgoYIf3Zfm3+wyKMeocq p7Gw== X-Forwarded-Encrypted: i=1; AJvYcCVW+ajGqDiLRmE7Td26DK2/k2zMDf7a8iAYYZxBdGPtQHBGhmr8lL7plt/DW2SerGB5xzAeCZUC8hbrSfY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxujbq4n3u7yXZJUocCsy/NCZe8TYHFVyPJKFImjHMtS6nBWspP cEz8Pj5jwUIBczpx+0gfRw6oSF5GHkoGoSn83MALJ7Z+RG342nWi32yu93Rv9Ke1zobQBytbAse bCtDTW6YQw8vNMGlg4aDxOkS8JfQ1NUx2RtskVJU0MziV6YTP2QBv+mkToKzA86s3sYA= X-Gm-Gg: ATEYQzwKbRrHvWzO3M9AH1KbcmWncYmptTHz/aPsSAVoxkXZ3R3lf48RQzH0y+sIc9x wZijuA7yZFQCRJTifx3L2tNAm09tTzKTBQl8kbKasJ5EZ69Q2qN9/xJaxiMQh/qcr2ExItmIgyc XETadFyhF+oGV2GkXeMNOfNzzWRv4jIrIILkqDNXWDJKy3C/55fBZtPCzuaMgDzfKq+wCjWILeV 2At4PPmTGJe3ZSbG4Gds+7N15tINiFj+TIa3thUOI8yQfdA+YkWaAvVDKCsmxWUuHAQnM3eT2xX YbbHn0ExQ20RJ7p7dxgl1njkHPgCXqv0UlMeuQ9RsdrVPpG+G5PWKJB5e3HLF1jo8CjA3PZ8mvw KHfD8oLjJXAdSn8I/IsD7tiizOLNA3QCA8jjsZz+AsVznrCMkYtD1GNk= X-Received: by 2002:a05:620a:c0b:b0:8cd:8142:b7e6 with SMTP id af79cd13be357-8cd8142c5d9mr413622785a.26.1773039104664; Sun, 08 Mar 2026 23:51:44 -0700 (PDT) X-Received: by 2002:a05:620a:c0b:b0:8cd:8142:b7e6 with SMTP id af79cd13be357-8cd8142c5d9mr413621485a.26.1773039104234; Sun, 08 Mar 2026 23:51:44 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48529f01997sm80449975e9.14.2026.03.08.23.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2026 23:51:43 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mailingradian@gmail.com, Srinivas Kandagatla Subject: [PATCH v5 03/13] ASoC: qcom: qdsp6: topology: check widget type before accessing data Date: Mon, 9 Mar 2026 06:51:27 +0000 Message-ID: <20260309065137.949053-4-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260309065137.949053-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260309065137.949053-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: f7vbThZmxYhCtwZF84MBc4koV2DFp5Sx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDA2MSBTYWx0ZWRfX1mmJNpN8VfO0 6DStdQfpL87CIcuRdPAFfp1hYbRwpCcHKbQMXLQtKoLfqUMX17RRuWvMZrfekteP9WC9iAmu+qX yhZW2zswCOPdRNkoFsDMYq2dXHHKTAKcMi6/0llogppNhbn7jiDnDnZ6D5jgcV+SHLxY6R7puMw VnrZJP5pbSKCn2fKX4wVvOYTJpRHtuBYKaykgjH4LA6lOqe3/iX4JLemwz05DiTLzTspVufRYGB dcwz/pgVeiyRtDETCaCZF/BpVwqKSl6q2Z7EWK+K5gvjQJP3XOxh1VCm9VS3Z/zKEKvhvRnJn5V XyspnAD8fiN/G/u4IYJ/8Zkr6TwUZyUgmCZlAjyoocixlgK9knvZ4Oj/mEaUC+VcNUGJOYCNtod bAFQyQhdH6tQXCbVN3fgUQcyLB2vMK86YcuT6M+lh2cMXRlufyGkOTyqc6ucVI7oXoS7FR0ZS6a fd6oaidHW/coGgrRhCw== X-Proofpoint-GUID: f7vbThZmxYhCtwZF84MBc4koV2DFp5Sx X-Authority-Analysis: v=2.4 cv=RP++3oi+ c=1 sm=1 tr=0 ts=69ae6e01 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=5HTw2GpdgXbBP0wXRk4A:9 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_02,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090061 Content-Type: text/plain; charset="utf-8" Check widget type before accessing the private data, as this could a virtual widget which is no associated with a dsp graph, container and module. Accessing witout check could lead to incorrect memory access. Fixes: 36ad9bf1d93d ("ASoC: qdsp6: audioreach: add topology support") Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/topology.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/qcom/qdsp6/topology.c b/sound/soc/qcom/qdsp6/topolog= y.c index e732fac9b8ca..1f69fba6de26 100644 --- a/sound/soc/qcom/qdsp6/topology.c +++ b/sound/soc/qcom/qdsp6/topology.c @@ -952,9 +952,6 @@ static int audioreach_widget_unload(struct snd_soc_comp= onent *scomp, struct audioreach_container *cont; struct audioreach_module *mod; =20 - mod =3D dobj->private; - cont =3D mod->container; - if (w->id =3D=3D snd_soc_dapm_mixer) { /* virtual widget */ struct snd_ar_control *scontrol =3D dobj->private; @@ -963,6 +960,11 @@ static int audioreach_widget_unload(struct snd_soc_com= ponent *scomp, kfree(scontrol); return 0; } + mod =3D dobj->private; + if (!mod) + return 0; + + cont =3D mod->container; =20 mutex_lock(&apm->lock); idr_remove(&apm->modules_idr, mod->instance_id); --=20 2.47.3