From nobody Thu Apr 9 12:08:32 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC757329391 for ; Mon, 9 Mar 2026 06:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773038255; cv=none; b=jhC4c0aUp5/D5CPhA272LRlMiN0OQutHkhqmeWSOzpbYMbD+pLaq82rlkuUCod7BlJs05HyMcsn/d1Wx4ze8dT+hTNHzR25wFZW//0CE2AVKb78fzjIxSariAXloVxfaSKY350A3lnh/z9VVHrEKh1LvnbGZSbT3MOiMS3Sj1WY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773038255; c=relaxed/simple; bh=BANGpb2pTLYLkExQ0zMnsBgrD8C6VbkTG23KlR+dnak=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=e/pQzdZIrWEe4Rx8zX3V4+QBqK6FbYlL0C4wJ07bEwIKLjRxWC3PZRhvoGhOLllDq7CnjB4BcbcbEBSoz7Ta01pYELnIdkIGnlDeyeg4loGVjBWGqOYuMV563XQjTKP55XxmHlHeaT6dXu5QddeXLX4+LWkqg8F8yBP8LhXW5hM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AkSgjlrX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MYVbhpjs; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AkSgjlrX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MYVbhpjs" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 628KGjiQ3382095 for ; Mon, 9 Mar 2026 06:37:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=75/WaeLRTgLwiigcgIHrvpYwnchz94sWj9/ A9Y0mA1g=; b=AkSgjlrXNbn+wUffsmmd6f+go94gDEr2bj43OEHe82/5M/iAncp 8CGuUIrd9M1BXzqpV74ji7lobUKarCC5lnERETIdLmjj1wlGTrMp5yc42JHHMowv eNVV5Ts32JjrZeksTNYMAI+ovgc/+bUvhh9NfyLDjx6k2zFFpkG+qhW8NHiLQLjf d39rSjprax1PqUj/rRQLDSyoJrc0ZGdDZxDPoq25ceG1OthZTrpfpZYEQGgsggw1 EQjwLP49NgZchsFWkSTe8/EeeN10LhMSsK/bpWdJoT2ZLu67axqKhI2sKopURnK0 Nx+ziYI7HSTF10HF4LdahgpDVrzDbXlzN3w== Received: from mail-dl1-f72.google.com (mail-dl1-f72.google.com [74.125.82.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4crayrma9r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 06:37:32 +0000 (GMT) Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-1270dcd11c1so15313256c88.0 for ; Sun, 08 Mar 2026 23:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773038252; x=1773643052; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=75/WaeLRTgLwiigcgIHrvpYwnchz94sWj9/A9Y0mA1g=; b=MYVbhpjseFB37rQYqEb5gCplXjnNX2mgFx+hWdhfKCzdxfYF/8JzGVxU8R+wtEYysV hTljHdq4PXRqjiNbfxicXFfOqa15y9rcbtJ2XHKGv5JWqV8BlVqHoIJiLGIv4jWsV4iv TPCMFfw72Ar6DFQSHjTe9+B3936Kbzb3nRKiRyJUOm+ZcFPuPR+SfFRECFUCZnaGjOrd N1f8CTvBdCvTznQW+p8fh2/FiFQlnOf1AelTyw19GpoWZE6G4F+EWg3g4OzQELFAcwuU I1rbhLnajiU1/uKZuVQsgC4XHseTwh1vE/IRsPFPtWonNNbQYTHATDa+OuPBkahi/3Mk kjXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773038252; x=1773643052; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=75/WaeLRTgLwiigcgIHrvpYwnchz94sWj9/A9Y0mA1g=; b=Oy9h9Tpqibfw/XLAn0ZMCvswCKJNAuKs0EQEowzI81TDxooIkh3IhEXNeKHJqJu2vJ 4l3m7Hkl2XDYdvGH29LNxH8JCvtkKRDf7JHdWhqPpWW9gB0uz8nd4yv3zU6/2jhZdONi CwrTtsTNXhNlN50aOE9mUTWNZGeZg19ze+Gl5znr0UwQXqDpJ4M5/ncDQ5pp11SEr2B5 vG6YOnhnEm/Tv8FdhLHUpP4GQPH0Y7M6H5e11GucJfTxU+fmF21cbwOG3J1UFwlvIVOl TagVeMaFGs3aNUwXlnSEdnTSTe4pJfXHxqOs4dqw91tuOH9z0VOUiss5H2J+dh5lqfkM NCSg== X-Forwarded-Encrypted: i=1; AJvYcCWdgKYDHo0bR3zXjzJOZNy1vcIINuazpEKnYC8eeENTcSFd+ggxNihGFr6ZvgSyvQrJ6SEE146BYLDMcyc=@vger.kernel.org X-Gm-Message-State: AOJu0YzLpeQByhaTbCSUIxQGyh3n/fCvrmTnPPUXdPYFmfP6Y3Thno9U OcstNo+RENzxTGYi5cXMPRo3lBqKDnX/HYJa+Vta24K03BTOaCQjwUAAaHAhQqcC7oLNmJU0aIB 0FF5cUUFRtSh+We7csNy/IonE3qIk2bB70jLu4wAzWl/z1iVZ7PW2EHLQvXAmBXOz8E4= X-Gm-Gg: ATEYQzxkMLu4KFBwnYfYgH9nHjkFbISgO+pJmFmosL0mVpo3wobYYDV1sB0CwFkEghp sYiNifaLzl00nSgpGwKLJV8aJ0MVO8/ytpU7A90ft0+Ovpi77/bwoCqGRbGnrtyMyfNqTT7KB+j RgInPD79jpzlIoXwDrnhrJLVt2gsFJCn6bMMstO1VEtOLfRB5/0/jMNuPaxt+KU5svM4FEeKI7+ o9mGBVO6U4gHyjQM1NbMd8SvK89Mz4y647n90USkQbTeAPX4I1vgr1tqoN33hfeEC3djjwooINV hrk0v4MpvhfyteoctTF3EyCfN+3/j/yr3uh42yfZ3V67ZSfiGe7KU05CkSaym9zvQpTDoFD99yI IcgEXn+pnuZQUVgK4JpjXBRr9sr4+gRnaxaeBupkZLo2pVc7L7Yq4wC29vGFRhs+cEmvWvShD X-Received: by 2002:a05:7022:628b:b0:128:d55b:a0d0 with SMTP id a92af1059eb24-128d55ba213mr1040226c88.31.1773038252125; Sun, 08 Mar 2026 23:37:32 -0700 (PDT) X-Received: by 2002:a05:7022:628b:b0:128:d55b:a0d0 with SMTP id a92af1059eb24-128d55ba213mr1040213c88.31.1773038251559; Sun, 08 Mar 2026 23:37:31 -0700 (PDT) Received: from yuanjiey.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-128c3f5a102sm8488626c88.13.2026.03.08.23.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2026 23:37:31 -0700 (PDT) From: yuanjie yang To: robin.clark@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, sean@poorly.run, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, neil.armstrong@linaro.org, krzk@kernel.org, abelvesa@kernel.org, konrad.dybcio@oss.qualcomm.com Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, tingwei.zhang@oss.qualcomm.com, aiqun.yu@oss.qualcomm.com Subject: [PATCH v2] drm/msm/dpu: fix mismatch between power and frequency Date: Mon, 9 Mar 2026 14:37:20 +0800 Message-Id: <20260309063720.13572-1-yuanjie.yang@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=U5qfzOru c=1 sm=1 tr=0 ts=69ae6aac cx=c_pps a=bS7HVuBVfinNPG3f6cIo3Q==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=kp0xKC1fNrCP_-QnSFkA:9 a=vBUdepa8ALXHeOFLBtFW:22 X-Proofpoint-ORIG-GUID: Kp6VZIH1QwyoF7AUmBPgL2-hmRrQYKMC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDA2MCBTYWx0ZWRfXxKtJWumD7z8o qGPtBmXJxmhMxCB5BM+wogaTy0Dhy+HkMP6ISzjNja9tT0Anr0r0v4l4YI+6VA4H6hVLBS6/whV 9qrYmYlqhvAxc9DosHJ9OlF7oYwc9MlZTomR4AutTs5+WyBhjGsj6Bx9cUAROLKqEwAtb1N9SHz GK/rrVy6EcXA+S6X1Y4f8pBxU1YaNkMAcvU6yo9kMAfFns48e7sXXDscLN6ojuKaI1yTi2mMEMw NYjdfTmzwdkfE6DfgGLIP2IEnsmpgb0mIPmhA8/JUthakA59VRZYQFm07/OA1rFwf+vXK++dIpJ 4LQy4OqVTOsLJYWpHiy12qpCPuh1NuttQ93MT1Bk7K6uIHKQAldhfXnVUwBFzx/b7khzR+mXywo ss07XDu/Qdcp4t4DuEZAn+1dM6kf66AX3oBS6fEs9YwKxnjkuPwhvmhIEa2Y5+4SmgbcXXeDImF p2V8YAtuSAEvCyuK/ww== X-Proofpoint-GUID: Kp6VZIH1QwyoF7AUmBPgL2-hmRrQYKMC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_02,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090060 Content-Type: text/plain; charset="utf-8" From: Yuanjie Yang During DPU runtime suspend, calling dev_pm_opp_set_rate(dev, 0) drops the MMCX rail to MIN_SVS while the core clock frequency remains at its original (highest) rate. When runtime resume re-enables the clock, this may result in a mismatch between the rail voltage and the clock rate. For example, in the DPU bind path, the sequence could be: cpu0: dev_sync_state -> rpmhpd_sync_state cpu1: dpu_kms_hw_init timeline 0 ------------------------------------------------> t After rpmhpd_sync_state, the voltage performance is no longer guaranteed to stay at the highest level. During dpu_kms_hw_init, calling dev_pm_opp_set_rate(dev, 0) drops the voltage, causing the MMCX rail to fall to MIN_SVS while the core clock is still at its maximum frequency. When the power is re-enabled, only the clock is enabled, leading to a situation where the MMCX rail is at MIN_SVS but the core clock is at its highest rate. In this state, the rail cannot sustain the clock rate, which may cause instability or system crash. Remove the call to dev_pm_opp_set_rate(dev, 0) from dpu_runtime_suspend to ensure the correct vote is restored when DPU resumes. Fixes: b0530eb11913 ("drm/msm/dpu: Use OPP API to set clk/perf state") Signed-off-by: Yuanjie Yang Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/= disp/dpu1/dpu_kms.c index 449552513997..327881056dd1 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c @@ -1463,8 +1463,6 @@ static int __maybe_unused dpu_runtime_suspend(struct = device *dev) struct msm_drm_private *priv =3D platform_get_drvdata(pdev); struct dpu_kms *dpu_kms =3D to_dpu_kms(priv->kms); =20 - /* Drop the performance state vote */ - dev_pm_opp_set_rate(dev, 0); clk_bulk_disable_unprepare(dpu_kms->num_clocks, dpu_kms->clocks); =20 for (i =3D 0; i < dpu_kms->num_paths; i++) --=20 2.43.0