From nobody Thu Apr 9 12:06:47 2026 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8CBD359A68 for ; Mon, 9 Mar 2026 06:27:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773037630; cv=none; b=RzBvqZXPa9qF83kzO98L2X50o2MgX1ULrEroQ1hCen9wE32juCMdULruxj0783d7ijGtP0CZBWYD/khTkjrQf2NC5Hu47cLvELyDinxOu1ZuazIHb4bM2WNYskiCOUcImg7steprH2mLXf8FZre689CmKwaXqgfEWiNPZcpmncI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773037630; c=relaxed/simple; bh=bAzWEdhIzTouH8eIqxT29n5S4nzgSbNiXmw7ZEnfMG0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=jMYOwDNUxIACMoTs0JWDUowQXTAR/MqF7FnXztWI2k+Qo1OBXiyyl85UiLVGztez+uXk+h+lFASUYUU7IG7aE7vVFxXIrMx4QZ1NK17t9AlPv/MaNiJyTbRMyFVqO11yn9EDc1Nzl5mlu7/uA7XOlKY40T8RgZVPMK3zWXxEKCU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WkhNtiUf; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WkhNtiUf" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-4094b31a037so4250629fac.1 for ; Sun, 08 Mar 2026 23:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773037628; x=1773642428; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9+OI56PrY1O188Hy4yE/+s+6VCfrbr9D/8DNyBUaLJs=; b=WkhNtiUfdbrJLp8TleksncRdEyGfPkmwi8hiVrgnvEAem1Yov6iU+352zqAlPDwPpO zPGgvDrEgZJb7yd05FKWLMkSCXUgw0fBEMb76wSiFdaDrXIeUX1VE3fbxKs6HHvnQSTl m1qLOhGCtO9AFl6PCfaxaTpkOSM5AYc5KYXp7ZaLWvX9rvctGzIFAeziFOn64JRgpRxS k95fPVSxI73j425sXoaidU0+AV/gPXfYlE/1WiiLzQ1ump6vCh2m87zPPFuncL5wmxhp A/28e2pEP2wRWa6fCvJZJW9RnkShMrzcT5ss29WFSvvPmKAxJalZrixHbYbM85ML7M3o G12w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773037628; x=1773642428; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9+OI56PrY1O188Hy4yE/+s+6VCfrbr9D/8DNyBUaLJs=; b=snNA9/Mmnn/aRxPANOciLYAbt6XV2smz0jeb9O8prDc85c+4anrADl17l/NgNScR4P vLaMbbgHBHdRCr3S89PgFsNAma1RCHm1QzidUyCQ5VDpTaByJxlek+aAXDBto0ac/4vA QPXawlJV+BGrQJKKoitEX88ZqTpOw9iePIIrbkd54G6Ahotf9sxa20ncq+kXGFggOH4W FQQT5n3jA2n/f8cijt6xNPimuJtYCgQerBU1MZzpIT08FDFsxBsJsIKs4t4DKJQSrPRD BpakGiUzmhdJ8+IAqi5jyAzuXX2gCQdepDR4WOucQCSk+oaFx08Q8u9BOh+WCO+Ht0vz BB3g== X-Forwarded-Encrypted: i=1; AJvYcCXLKIa3f2gEL+TUDBdfkAmJejKWzsbL9OI4g3PdiGv3vMrW8ikO7WsN/QZ7q0QzULBRHyD7zc3zOuid/5o=@vger.kernel.org X-Gm-Message-State: AOJu0YxJYohltchO63SX/PMl6qi2MoW2/P4uS1fBW/SMvbj4P7/FPZ9F ACkbqnXs4sbQNhDhunIbLlUir3Ka/MOHtyNyoLNhlkmKprgKqKKudU4+ X-Gm-Gg: ATEYQzxe380xrunlColwa4tQXdjeiCM/L3NU2jt55KaBWAp6UocKLQJm2Y01oYdwOnU RFnVluHQvxM+hAk51nQPO76x58nYHqED5Y/I0GrOm31G4P10LoNbn7+bhcDpQN4trUoFhyH9b7R fIEyFRPSoBrt2FbdYqxx0nZQxgIorgTiWt0Om2y8lrZvaFezvJY2lYl8ogSYcAlRUK8C/h5PKsU 3mSIuqW/B1fcK3eMyypp2yd5NlCf3xiVgS0wTKmxO1pIib3UflNFjL9n9ULk6C+DQETJNkvAZhu U94902CXgD4+tar9A5ab1LcRFYU0258bB5yvCgGI4IsCCeCR08AtQ1cCTnko4x7/yZpCls6plHU HC+Aq0axFwwsQUV70i4Vtq6IlfdPjTnbebrRk62sJt8rD1i2W/2e0ApmMVm48wfDFdizIraywFU ZIFBeFZ6lHTNOJXZo/fbGo8cAlsXmQwGyz1CBy0N05K9NWgG9ePUttj8+S5p0S/hJ2HJFmgPvQ0 m6cvIRwHbHNqOG2JlqBmvBL2GsY7jNcI6M6o/rpFIvjgD+a X-Received: by 2002:a05:6871:a20e:b0:417:4520:3c85 with SMTP id 586e51a60fabf-4174520559bmr299333fac.42.1773037627654; Sun, 08 Mar 2026 23:27:07 -0700 (PDT) Received: from localhost.localdomain (108-212-132-20.lightspeed.irvnca.sbcglobal.net. [108.212.132.20]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-416e65b1cacsm8479676fac.8.2026.03.08.23.27.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2026 23:27:07 -0700 (PDT) From: Wesley Atwell To: herbert@gondor.apana.org.au, davem@davemloft.net, dhowells@redhat.com Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Wesley Atwell Subject: [PATCH] crypto: krb5enc - fix sleepable flag handling in encrypt dispatch Date: Mon, 9 Mar 2026 00:26:24 -0600 Message-Id: <20260309062624.1848239-1-atwellwea@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" krb5enc_encrypt_ahash_done() continues encryption from an ahash completion callback by calling krb5enc_dispatch_encrypt(). That helper takes a flags argument for this continuation path, but it ignored that argument and reused aead_request_flags(req) when setting up the skcipher subrequest callback. This can incorrectly preserve CRYPTO_TFM_REQ_MAY_SLEEP when the encrypt step is started from callback context. Preserve the original request flags but clear CRYPTO_TFM_REQ_MAY_SLEEP for the callback continuation path, and use the caller-supplied flags when setting up the skcipher subrequest. Fixes: d1775a177f7f ("crypto: Add 'krb5enc' hash and cipher AEAD algorithm") Assisted-by: Codex:GPT-5 Signed-off-by: Wesley Atwell --- crypto/krb5enc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/crypto/krb5enc.c b/crypto/krb5enc.c index a1de55994d92..1bfe8370cf94 100644 --- a/crypto/krb5enc.c +++ b/crypto/krb5enc.c @@ -154,7 +154,7 @@ static int krb5enc_dispatch_encrypt(struct aead_request= *req, dst =3D scatterwalk_ffwd(areq_ctx->dst, req->dst, req->assoclen); =20 skcipher_request_set_tfm(skreq, enc); - skcipher_request_set_callback(skreq, aead_request_flags(req), + skcipher_request_set_callback(skreq, flags, krb5enc_encrypt_done, req); skcipher_request_set_crypt(skreq, src, dst, req->cryptlen, req->iv); =20 @@ -192,7 +192,8 @@ static void krb5enc_encrypt_ahash_done(void *data, int = err) =20 krb5enc_insert_checksum(req, ahreq->result); =20 - err =3D krb5enc_dispatch_encrypt(req, 0); + err =3D krb5enc_dispatch_encrypt(req, + aead_request_flags(req) & ~CRYPTO_TFM_REQ_MAY_SLEEP); if (err !=3D -EINPROGRESS) aead_request_complete(req, err); } base-commit: 1f318b96cc84d7c2ab792fcc0bfd42a7ca890681 --=20 2.34.1