From nobody Thu Apr 9 12:49:12 2026 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A8EA15A86D for ; Mon, 9 Mar 2026 04:32:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773030768; cv=none; b=TSFkOheEzEfpTjNTUCu54keBvh/QgS+iCzemXSfKdU2q2yr0SkmEbSzzLjO7PMDYFZydbXOGkYoOY4Rc3yQ0yYMeSclI4pTpl+k2MXuKn70qk7wpINSJ1tFtCN4kOZ6J1p1VyUgYp1EjB0LLQcDT8D9pQ+6LIYCkC+kzAKFj6dQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773030768; c=relaxed/simple; bh=n8Z8j7J8KeLD2qfumTZTXkIWCn0qIapX8eZLr8l87Wg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=eX0DJiAAnlWtZm86zBXoo0RXGPvEC3arRwhGBbO1VT5vhslBpWLZi1gKYhjKE2JEaaMy13rVtrQEf0Y2CYfsW5rzo+wUBgkMme8MmJbmWev3mDXhSdulxnjh+opQhK+h8/MJ39Luoz1x9O6J15htWcaQRx4/kQc6Q1GO58UcGf4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LE3k+Efo; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LE3k+Efo" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-7d75371d873so38960a34.3 for ; Sun, 08 Mar 2026 21:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773030765; x=1773635565; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tBowd+etvXYQXjEgXm0lJwwl9WFImoPg0SroWZsa4m8=; b=LE3k+EfoyCvyG6RNxso4MpF7ndfZS8rA0NclxFahSJMQDnBUzC6Ti4VaXdCOByTZP+ VvDkoesrBcGssAt5yXijdvLDmJKQfV0aSf+isJ8+LQGFUM9aYESU9Z1ocdbvUp4B2PiA feILIA9LazTSILavzCkJFSlk96Z/VjcEHdqU8q9yJ36VaLYKtg+l1aImrklEKZrk+gpO Lk1P3Q/kYX2ZkDkbzK2gW9oGKEvPQvZkt+a0fJAW80MSV9qD5xSKvWJyoGlr3R1kRGzb 2rwNaxLX26uIHKuqU+eimGXYYswPRDjNKVBPPGWxEEvEtvLn3S+P2+Tq8flcGxgjhwoA a9bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773030765; x=1773635565; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tBowd+etvXYQXjEgXm0lJwwl9WFImoPg0SroWZsa4m8=; b=S4Rq4T/9YRccthXTrG0pHPwzikhGNh9tNLsRVnpsZvj2GmvTl5taVn3C4RUM6qZvFc y5ob7ZJ/7WkEyWhwBUNs01zgJLk56ASCXCxAo7/nxGRwb4sCJX2yyquNOFP+s9ySb/Uf Y064WJi4LHMnt3/0xIUKWtmDNQdoZqn3/Usahr69kwOmsmyZ+Dxl9zgb9y4PxaaVi4uJ /o1h6Kug2py9H5rfCKT/aXQ/Zsvt0zfnpqtLjSD0R6W6FP1gAFErehPFs3YVJWve5TSP bHcsFXNh2Ukak4jiNz2BbMabCfun0UfR5rvDTl+8ojAfUg7weiZhiNOW+IGdxz8cVhED I0mg== X-Forwarded-Encrypted: i=1; AJvYcCVCrpEz3qZi7vP1vTU/vS0QLtyvm/S7IameItramc3ZnkPYaF2cBxEVOUSS3yX/gAkwk2Gld74dUyM3Ay4=@vger.kernel.org X-Gm-Message-State: AOJu0YxF+3T2W9YzTvgaHVBUQJJN380hM1Qo0b9j/qt+gX8vIENExZc6 JibqolfTFIH3sndkMBqmYgygSyw37mtuUrRwLzXmVSo+4pM66QqVrgVN X-Gm-Gg: ATEYQzzW1BomW8ZgSf8zJFbG6Qc1odQI8SUj/Gq+VD7VByL4dH0W/6RXxWpuX61IfqV +zYbai4xMy3/5KGN9EesK51DIxU2eDiYQ6CET1ovzlczt6rw0+5ts90VjDjdm0sglv6mWllx/3h kfADVLck1v8NqOj+qwoM2M1O7GBHJVdb/27pGNxOccIOY48lqR7EAcIiCxcp9mxiSWr9C5mXs7t WhQR39cGrOLCcQeTrkEnybiE60UpIKfGptk4WMO8LUjBIIDS0dqL1Xqbk7UY/api5zy7wB31zQ9 uhCKHvad692NwuhSGXMFBlJ7BMQi2KM8t8t8dX9WHcX/V2LD0uWw43NThp4Q0csIGaue1iQnPCS w0uXHSZzlnlRbb7xm3hUqiQ7LxhjD1lw8qSKkkS2ME+5UCzyLn+8WlQqTW1n5QSHeVwMhzQqktx 9S2qLkJNT0D/IfAJJrwjDE37Vhx+gHqLL+IC+dPjHFVLj4rKNv3eBH0TT4GayIKlLBLyyq9Rm/h 2E/FlER2Qi54KREDa0OzLtHZgjb6Zaz27GpJ4TnL0aLVJZ8 X-Received: by 2002:a05:6830:25c1:b0:7d5:c016:f740 with SMTP id 46e09a7af769-7d727057a56mr6807045a34.29.1773030765411; Sun, 08 Mar 2026 21:32:45 -0700 (PDT) Received: from localhost.localdomain (108-212-132-20.lightspeed.irvnca.sbcglobal.net. [108.212.132.20]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d728c757cdsm5785684a34.11.2026.03.08.21.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2026 21:32:44 -0700 (PDT) From: Wesley Atwell To: herbert@gondor.apana.org.au, davem@davemloft.net, ebiggers@google.com Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Wesley Atwell Subject: [PATCH] crypto: simd - reject compat registrations without __ prefixes Date: Sun, 8 Mar 2026 22:31:43 -0600 Message-Id: <20260309043143.3525376-1-atwellwea@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" simd_register_skciphers_compat() and simd_register_aeads_compat() derive the wrapper algorithm names by stripping the __ prefix from the internal algorithm names. Currently they only WARN if cra_name or cra_driver_name lacks that prefix, but they still continue and unconditionally add 2 to both strings. That registers wrapper algorithms with incorrectly truncated names after a violated precondition. Reject such inputs with -EINVAL before registering anything, while keeping the warning so invalid internal API usage is still visible. Fixes: d14f0a1fc488 ("crypto: simd - allow registering multiple algorithms = at once") Fixes: 1661131a0479 ("crypto: simd - support wrapping AEAD algorithms") Assisted-by: Codex:GPT-5 Signed-off-by: Wesley Atwell --- crypto/simd.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/crypto/simd.c b/crypto/simd.c index f71c4a334c7d..4e6f437e9e77 100644 --- a/crypto/simd.c +++ b/crypto/simd.c @@ -214,13 +214,17 @@ int simd_register_skciphers_compat(struct skcipher_al= g *algs, int count, const char *basename; struct simd_skcipher_alg *simd; =20 + for (i =3D 0; i < count; i++) { + if (WARN_ON(strncmp(algs[i].base.cra_name, "__", 2) || + strncmp(algs[i].base.cra_driver_name, "__", 2))) + return -EINVAL; + } + err =3D crypto_register_skciphers(algs, count); if (err) return err; =20 for (i =3D 0; i < count; i++) { - WARN_ON(strncmp(algs[i].base.cra_name, "__", 2)); - WARN_ON(strncmp(algs[i].base.cra_driver_name, "__", 2)); algname =3D algs[i].base.cra_name + 2; drvname =3D algs[i].base.cra_driver_name + 2; basename =3D algs[i].base.cra_driver_name; @@ -437,13 +441,17 @@ int simd_register_aeads_compat(struct aead_alg *algs,= int count, const char *basename; struct simd_aead_alg *simd; =20 + for (i =3D 0; i < count; i++) { + if (WARN_ON(strncmp(algs[i].base.cra_name, "__", 2) || + strncmp(algs[i].base.cra_driver_name, "__", 2))) + return -EINVAL; + } + err =3D crypto_register_aeads(algs, count); if (err) return err; =20 for (i =3D 0; i < count; i++) { - WARN_ON(strncmp(algs[i].base.cra_name, "__", 2)); - WARN_ON(strncmp(algs[i].base.cra_driver_name, "__", 2)); algname =3D algs[i].base.cra_name + 2; drvname =3D algs[i].base.cra_driver_name + 2; basename =3D algs[i].base.cra_driver_name; base-commit: 1f318b96cc84d7c2ab792fcc0bfd42a7ca890681 --=20 2.34.1