From nobody Thu Apr 9 12:50:36 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C544A1C5F11 for ; Mon, 9 Mar 2026 02:42:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773024173; cv=none; b=i7MRFiimpaWVTNAxfL2n3U3jiSFKj5QYXqfqomWvyBZ124eNQ2pSuW+N+PP33ppCNPW8FUO6bCI2N6PMgi9qstads6feesEEWe1GY4RkuH/mp1B4z4tZzop5e+Rf31G68sKZhBj+oeSZQUzT8LfCB3ktqknXc3TgCzbCZW/iLiA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773024173; c=relaxed/simple; bh=Tzum0cWm6ibNtpLt6wkyBC1cJw7c+L+MtJC9kP9uxpk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=g+CqcqnTiqCEf66z7hwAU/mmyG2t9B97ov6DUxBCh8pIiHzwqYR1l3weY9Xo67FeNpRlCj8r3T7QiJMj82NI7GvMH4jPTkzASR4wMlrCw4Zdg6XqiRANnO2VzShAAybp/Oq/jTwbgdXc8+0KNUG00Cd6SB3ElLfQ9/ZPd/30D0U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hvj9P0sG; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hvj9P0sG" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c6e3e4e7388so4449224a12.1 for ; Sun, 08 Mar 2026 19:42:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773024172; x=1773628972; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kJ4M6dn2E1PjB6XJ3mpN7+gDDgC1ZSCNcwbC5cuTLYg=; b=hvj9P0sGAPItj1RHkd4+9yfXiDnOhEebIMVuzPoWy4Yffw/7SCGUypsP5ID1LSIepM KPz+XvYdSKjy6cUekoO3Fx3OZaRVXrkW/wmOT27/ofX8wiwaLIK0jzIRtCY+U2gi52SO u0P39ik8VdG17+VtxsJhEh9A7mmnqYkbEkAuZMLf/+OFb4jQxVOqIbnvMWUQHdeifkS7 XAVqmtoHOAcTHuKAXIFi3obtkD/FRuXiI7WNy8npkgJwSA4Js4bKhxYQKgIBGmaUYpio 24hMshhTHhD+5UfjrSiIQhtk9rc7AC8Hd9a9aZWOtQyXtjUn8XDEcfC9W3Z2/FAefgFH +YeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773024172; x=1773628972; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kJ4M6dn2E1PjB6XJ3mpN7+gDDgC1ZSCNcwbC5cuTLYg=; b=QxHvCiMMIlH3MS7mwkUytgQftEFBGb97dQx3CThSHsgIdx9eqCTZmUNhIx1L9pJCAG qVIx4w7vI0ZvSACZYwnv8L4vUaa9uyXF6kuQxv/cMH+KkfWscClDGVN903MaWszI3K2T NMQbqTy1y4MwjnHJ8J6ah9ntvW/dPiHTj/zbBIXG/+cNMnwK4iqAQPGgf9qKaWTjSToJ Aec/bxrpoz7crre/NEdKQc1fYn+QNj3s4fd9WtncPrMESPCL7HN//hsSW/JBDUF2fYxa cf3ETLSm9wDsLO81SdhfAIQA3kgL9Qm7fvcoyuJnuHOG9lRrpbicmQ4BjFkYMDDDArRa 0HyQ== X-Gm-Message-State: AOJu0YzswF1VMySeMluwzyKtAN6ZNCxe9qm1E/QFzlWJvHjxQk6TFHSI uk9JDj3GjmcSXMgcFxKrkeVYz1CxN+aGb7sLKjpFaXPyP/BJg9rYhTW5 X-Gm-Gg: ATEYQzw4Qc+80LIKXDgjHiAinCHHKOirv6Z5PnSz+MAV09XvSllCbsOVLBfnF2fsC1q w3bWIC/zHdaSHbrdUw/+9YnX9L4bG2gn5td+gygq1p5lInWeeMWEkGGmos/pIH/K3eXneH57p+s v838V1k0oztCJvukutkMYSCVdOYxHQC1pImHAPQsbSLD+b31K2SEAlAWglWZMC7kqRSBtFqiG2G 8oB3rhz/XtsInsFwxPcaWKplUomKaS8pueNkpmFrwy6nnGD0gd7FuI1GUwqybUCaRVMb0UM2/c6 ZrYYCKAxru/QEgQg0jvc0Q5ZPPWQ4S9QibwqsqIya+KbBr7OrRMuX0HzSJ+EwYDl0gl8iLrqeda RzlLs+AVLH+6nsWL8iZtoxnanR7CIz7fb6Tx33f21iDrYIHVVzxAWQtWWnBvihRg3Kn8ijnVrP3 Ri+QMdFPlyR4v1KJwvCFI7dTru5W4iDkEIdE5RKZQYYKIX7fw= X-Received: by 2002:a17:903:1986:b0:2ae:6629:10a7 with SMTP id d9443c01a7336-2ae82381ee2mr96989225ad.13.1773024172189; Sun, 08 Mar 2026 19:42:52 -0700 (PDT) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83d85a2asm125847805ad.0.2026.03.08.19.42.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2026 19:42:51 -0700 (PDT) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH RESEND] sched/fair: Fix comma operator misuse in NUMA fault accounting Date: Mon, 9 Mar 2026 10:42:47 +0800 Message-ID: <20260309024247.10908-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the comma operator with separate statements when assigning NUMA fault statistics. This improves readability and follows kernel coding style. Signed-off-by: Zhan Xusheng --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index bf948db905ed..1c6c9c9e4696 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -14025,7 +14025,7 @@ void show_numa_stats(struct task_struct *p, struct = seq_file *m) tpf =3D p->numa_faults[task_faults_idx(NUMA_MEM, node, 1)]; } if (ng) { - gsf =3D ng->faults[task_faults_idx(NUMA_MEM, node, 0)], + gsf =3D ng->faults[task_faults_idx(NUMA_MEM, node, 0)]; gpf =3D ng->faults[task_faults_idx(NUMA_MEM, node, 1)]; } print_numa_stats(m, node, tsf, tpf, gsf, gpf); --=20 2.43.0