From nobody Thu Apr 9 14:03:59 2026 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1546234973 for ; Mon, 9 Mar 2026 01:03:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773018192; cv=none; b=Hd2rfvCTkRFSDEBrMg8zGdwwpRvdq0WKweKRSqz4NgZpnRt7z0isxMCxsDcRzuw2+SviEDdosJ+jPvSHZ4xKx8xrJRYNqvTULxnxxar1zEYktytbUJIFysaY2ZV8wJlGC3D9qwpOEglYMijedAyHSKyDGVTztJhDzmK5V6CWBiI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773018192; c=relaxed/simple; bh=4XKDL7/f3y+v0PqXInCYEFuB7xNjjwRcyGFHrczOXVc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AQCyDhtiY7cvs3zXD81G14JftUDl1qkJhIM07UyhG1TIRVdDmuLdd7090UCsXYsV/KlodfwAgIklyuoMufYpsCRc93mOvdvxijzDjZ3bFDXmKeAbtvKa1jrU9QtPplksPR7XCVDTy71eVpsbpO5CiODjWj4v48IpkE/vii5G6II= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool; spf=pass smtp.mailfrom=packett.cool; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b=XFj/qWh8; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=packett.cool Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b="XFj/qWh8" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=packett.cool; s=key1; t=1773018189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=izTakImvKyjjGPCZRwPAdwU7D8IgjDbDL3fvc4uR8JM=; b=XFj/qWh8J9RmBHws/C55BvTQYaPXn8eQPR3JlKYmdeIS2qk74Bs4YUmR0ShGK57FZZJcCU x3xstJeNHj8hFpXeu+ZZjI1np3JsWESbTp++S2wmjW4uCMIqlA0Lv4lRzwWHatH9EEDyKm 4zue2/G5T+ksBp3rrrLeuyo9JhxVjhyp9peyj7cf3+5h27MhWqfbWbSMvdFWN9GGu/kdAB cY/ahxWVitzQYyrkPkwswvGME7V+eY7Hyonsw+HppnYMXb6lHoQM2htsMXg3IcrVj9k576 GhCRvLxYW1++4w/7O79Vq5PMfXncxcHbzakPCT1tMfPzJXJH/DMpNQydez3yhA== From: Val Packett To: Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: Val Packett , Konrad Dybcio , Johan Hovold , Manivannan Sadhasivam , Dmitry Baryshkov , Maximilian Luz , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/7] clk: qcom: gcc-sc8180x: Add missing GDSC flags Date: Sun, 8 Mar 2026 22:00:27 -0300 Message-ID: <20260309010214.224621-6-val@packett.cool> In-Reply-To: <20260309010214.224621-1-val@packett.cool> References: <20260309010214.224621-1-val@packett.cool> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Similarly to sc8280xp, the GCC GDSCs can and should use the retain registers so as not to lose their state when entering lower power modes. Fixes: 4433594bbe5d ("clk: qcom: gcc: Add global clock controller driver fo= r SC8180x") Signed-off-by: Val Packett Reviewed-by: Dmitry Baryshkov --- drivers/clk/qcom/gcc-sc8180x.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/clk/qcom/gcc-sc8180x.c b/drivers/clk/qcom/gcc-sc8180x.c index 4095a1f54a09..365943cd5278 100644 --- a/drivers/clk/qcom/gcc-sc8180x.c +++ b/drivers/clk/qcom/gcc-sc8180x.c @@ -4173,7 +4173,7 @@ static struct gdsc usb30_sec_gdsc =3D { .name =3D "usb30_sec_gdsc", }, .pwrsts =3D PWRSTS_RET_ON, - .flags =3D POLL_CFG_GDSCR, + .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, }; =20 static struct gdsc emac_gdsc =3D { @@ -4182,7 +4182,7 @@ static struct gdsc emac_gdsc =3D { .name =3D "emac_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, - .flags =3D POLL_CFG_GDSCR, + .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, }; =20 static struct gdsc usb30_prim_gdsc =3D { @@ -4191,7 +4191,7 @@ static struct gdsc usb30_prim_gdsc =3D { .name =3D "usb30_prim_gdsc", }, .pwrsts =3D PWRSTS_RET_ON, - .flags =3D POLL_CFG_GDSCR, + .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, }; =20 static struct gdsc pcie_0_gdsc =3D { @@ -4200,7 +4200,7 @@ static struct gdsc pcie_0_gdsc =3D { .name =3D "pcie_0_gdsc", }, .pwrsts =3D PWRSTS_RET_ON, - .flags =3D POLL_CFG_GDSCR, + .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, }; =20 static struct gdsc ufs_card_gdsc =3D { @@ -4209,7 +4209,7 @@ static struct gdsc ufs_card_gdsc =3D { .name =3D "ufs_card_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, - .flags =3D POLL_CFG_GDSCR, + .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, }; =20 static struct gdsc ufs_phy_gdsc =3D { @@ -4218,7 +4218,7 @@ static struct gdsc ufs_phy_gdsc =3D { .name =3D "ufs_phy_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, - .flags =3D POLL_CFG_GDSCR, + .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, }; =20 static struct gdsc pcie_1_gdsc =3D { @@ -4227,7 +4227,7 @@ static struct gdsc pcie_1_gdsc =3D { .name =3D "pcie_1_gdsc", }, .pwrsts =3D PWRSTS_RET_ON, - .flags =3D POLL_CFG_GDSCR, + .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, }; =20 static struct gdsc pcie_2_gdsc =3D { @@ -4236,7 +4236,7 @@ static struct gdsc pcie_2_gdsc =3D { .name =3D "pcie_2_gdsc", }, .pwrsts =3D PWRSTS_RET_ON, - .flags =3D POLL_CFG_GDSCR, + .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, }; =20 static struct gdsc ufs_card_2_gdsc =3D { @@ -4245,7 +4245,7 @@ static struct gdsc ufs_card_2_gdsc =3D { .name =3D "ufs_card_2_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, - .flags =3D POLL_CFG_GDSCR, + .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, }; =20 static struct gdsc pcie_3_gdsc =3D { @@ -4254,7 +4254,7 @@ static struct gdsc pcie_3_gdsc =3D { .name =3D "pcie_3_gdsc", }, .pwrsts =3D PWRSTS_RET_ON, - .flags =3D POLL_CFG_GDSCR, + .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, }; =20 static struct gdsc usb30_mp_gdsc =3D { @@ -4263,7 +4263,7 @@ static struct gdsc usb30_mp_gdsc =3D { .name =3D "usb30_mp_gdsc", }, .pwrsts =3D PWRSTS_RET_ON, - .flags =3D POLL_CFG_GDSCR, + .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, }; =20 static struct gdsc hlos1_vote_mmnoc_mmu_tbu_hf0_gdsc =3D { --=20 2.52.0