From nobody Thu Apr 9 14:09:29 2026 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFCE81D5ABA for ; Mon, 9 Mar 2026 00:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773017187; cv=none; b=k8f9wUKEN3XAVZJ8RnHQHDEBjpbyNh/TDQLTHWNxolvajYALkWPtgy2KCkCttbY7XgoK+tPnWgOlwY8ulFvr4zBP7Jk/+w6C/RXiCsvmSkwyyoVDGGLq/9yFNvI93czXZPSilrSLdMuuN6vUyYNCCdPiTMPCR4MWl8hNUhT4E10= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773017187; c=relaxed/simple; bh=tHoeMFRi6s6I6LRKk8F/SrOG3eKQxuLtAy2rH6tfvWs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=H3+y0+Syf9nyTZcbqhH7OjEIMteM8aQYyDiUhzhF8m34fm8HAk7DijRkAuwFvsDMWiIMQ8mjfyq0AG1XOFRNRpgx94o9qgq7Ob4815MwLJQfw9PDjrbb6tjsJ1MmV7T/0xVVuFkYqK5qvUEtY4xzxHvfA51SH1BKZ19QvF04jE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RA0lnivn; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RA0lnivn" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2be3bdfda8eso4129677eec.1 for ; Sun, 08 Mar 2026 17:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773017185; x=1773621985; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cxW4Is3pvycjCruApvPYUDJnnf0G3HJdKTnyBvELzWs=; b=RA0lnivnhQYoOfESDHVp9EogGPXieqJ5+UYXY0DUuVZmZwV8MMihWaEL08yU3xrKjM u7vScGllQHHsrr03MGXHXA9dJoXhZSDSLABUaLmRrwnKJxAeOlMG2Kk6iUhX38bjaPgU 3zg/LbLF9wJnPGO7TUpEXhG7vXjLmcQKN4XCjQKmuwxHhzbLGsCeyohdqiaAa6GcmlMW jcI47pZyLWYUyNUsS+noA1lVLL6T9+kEBwXqmxrBT/4XvFSHAw58XQBjy2miV+CNQI6i cmcz6LdN8iJLtnuo11qH8a6dofH9CvCYg+ICExjq0QSF57zw5orFEwdTZbm/CtF3jznu nypw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773017185; x=1773621985; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cxW4Is3pvycjCruApvPYUDJnnf0G3HJdKTnyBvELzWs=; b=D4rXKa4wJF/d2+6wFnhguSbWQSF3p1bnWFNxFOsVBBKbz/6Dg4xdGk+SyAYY+tgXDp Veg5KzMfNGownxVNKf/BSWtyykj0i14Fsnay4w0sw58pYmjuUS7+1BjaW6mQ1VqL5i+j 2wcqix0DisBxnd65xMi+M3GH0MK4R8oCPW1rpD6HcWt8PEppnN9LWZpjf7+fpzmPhspY 8f46DdQ9HzJEB+xK4AZKfWOyySTrX5TQ4e2PnDdXmFW2zyxUWwuW5L7RH6KdyjX/Upig 1+kqKBMeACeO0OTaH31jD9qiQf9f/mxYIpKcgCVfCD8KKgQGyKmHyRGeDhhLQnAJ8nTU zN/Q== X-Forwarded-Encrypted: i=1; AJvYcCUu05zzn29iVGtIIuy1mbO7v5YikSijLUbgXdkm/6LXOdaP/xC5t5gNKBb/seM6sV52wnW2FhIvxar6JSQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyrg1/Zrjx7DWPn8bPACuwYC9ebAXa/YBi4SeDOW91g0ZfPe4LC /q8H4r+CQBxtt4nZvLY5f4XzMXI4cHMug3MtMUbsncKV7PIIF8Vi5iCHmFLfM9QX X-Gm-Gg: ATEYQzwNp6A7kuiI1EoORu9r8BLrLzTqDURwzuyjC2A13JjRATW8Yx8R8xBhhB9aCyY 1kbYzKfeYmbBz9dJwCuMJowCTxYROx872jrzibcjLpZJaJj94/ZqYDUaA1D37v3FD3+hXq2j9Qm QrsKJJuyEYXGZhu9dyiE4WqDqJunSvZD2acuwIgJxhdeK234rLjfDYpdjutrCrXZsYxLKYhu4nm uLHbus7Bki/hhMRYvuDV2lmztdxydUp/H6+bfuxNu6jREJcPdzPtxRaWxxqijjxCm8s+zBw/blJ I4L9L2Vh2Li6FK2AaXUMIdyHoaVtG8umNO6sbUf/yQTC6gelYSmPvpfiVYSahVA4TnPhFjIpu+a SRk6u5IMK3emoOLEL9Y/oxs/P/AiQ/DmjK1RprbPT//xeQJcxBG6MDn4HyWUY7WG3TS2R/yYOay YTYq+qrlkIvYwTIFJnHPrvtLxbo4+zvAsFYxtF5Vg19oRLJIIHY/I0qI3fodUZZ7sq6U2hO4xZk Fr2YDI= X-Received: by 2002:a05:7300:cd90:b0:2be:2b16:b99f with SMTP id 5a478bee46e88-2be4de928fcmr3334893eec.13.1773017184928; Sun, 08 Mar 2026 17:46:24 -0700 (PDT) Received: from localhost.localdomain (c-67-164-93-214.hsd1.ca.comcast.net. [67.164.93.214]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be4f948631sm7240105eec.19.2026.03.08.17.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2026 17:46:24 -0700 (PDT) From: Sanman Pradhan To: Sanman Pradhan , Guenter Roeck Cc: Sanman Pradhan , linux-hwmon , linux-kernel Subject: [PATCH v2 1/2] hwmon: (pmbus) export pmbus_wait and pmbus_update_ts Date: Sun, 8 Mar 2026 17:45:07 -0700 Message-Id: <20260309004508.78609-2-sanman.p211993@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260309004508.78609-1-sanman.p211993@gmail.com> References: <20260309004508.78609-1-sanman.p211993@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan Some PMBus devices require strict inter-transaction delays to avoid NACKs or communication faults. The PMBus core manages this automatically for standard PMBus accesses via pmbus_wait() and pmbus_update_ts(). However, when a device driver performs raw I2C/SMBus transfers (e.g., for long reads or custom commands) that bypass the PMBus core, the core's timing state machine is unaware of the transaction. This can cause the next core-mediated PMBus access to violate the device's required delay. Export pmbus_wait() and pmbus_update_ts() to the PMBUS namespace so device-specific drivers can explicitly synchronize their raw transfers with the core's delay management. Additionally, move the PMBUS_OP_WRITE and PMBUS_OP_PAGE_CHANGE bitmasks into the drivers/hwmon/pmbus/pmbus.h header so callers can accurately report the nature of their raw transactions. Signed-off-by: Sanman Pradhan --- drivers/hwmon/pmbus/pmbus.h | 9 +++++++++ drivers/hwmon/pmbus/pmbus_core.c | 13 ++++--------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/hwmon/pmbus/pmbus.h b/drivers/hwmon/pmbus/pmbus.h index d2e9bfb5320f..afd58128b37e 100644 --- a/drivers/hwmon/pmbus/pmbus.h +++ b/drivers/hwmon/pmbus/pmbus.h @@ -424,6 +424,13 @@ enum vrm_version { vr11 =3D 0, vr12, vr13, imvp9, amd6= 25mv }; #define PMBUS_REV_12 0x22 /* PMBus revision 1.2 */ #define PMBUS_REV_13 0x33 /* PMBus revision 1.3 */ =20 +/* + * The type of operation used for picking the delay between + * successive pmbus operations. + */ +#define PMBUS_OP_WRITE BIT(0) +#define PMBUS_OP_PAGE_CHANGE BIT(1) + struct pmbus_driver_info { int pages; /* Total number of pages */ u8 phases[PMBUS_PAGES]; /* Number of phases per page */ @@ -555,6 +562,8 @@ int pmbus_update_byte_data(struct i2c_client *client, i= nt page, u8 reg, void pmbus_clear_faults(struct i2c_client *client); bool pmbus_check_byte_register(struct i2c_client *client, int page, int re= g); bool pmbus_check_word_register(struct i2c_client *client, int page, int re= g); +void pmbus_wait(struct i2c_client *client); +void pmbus_update_ts(struct i2c_client *client, int op); int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *in= fo); const struct pmbus_driver_info *pmbus_get_driver_info(struct i2c_client *client); diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_c= ore.c index be6d05def115..4864a30988bf 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -32,13 +32,6 @@ #define PMBUS_ATTR_ALLOC_SIZE 32 #define PMBUS_NAME_SIZE 24 =20 -/* - * The type of operation used for picking the delay between - * successive pmbus operations. - */ -#define PMBUS_OP_WRITE BIT(0) -#define PMBUS_OP_PAGE_CHANGE BIT(1) - static int wp =3D -1; module_param(wp, int, 0444); =20 @@ -173,7 +166,7 @@ void pmbus_set_update(struct i2c_client *client, u8 reg= , bool update) EXPORT_SYMBOL_NS_GPL(pmbus_set_update, "PMBUS"); =20 /* Some chips need a delay between accesses. */ -static void pmbus_wait(struct i2c_client *client) +void pmbus_wait(struct i2c_client *client) { struct pmbus_data *data =3D i2c_get_clientdata(client); s64 delay =3D ktime_us_delta(data->next_access_backoff, ktime_get()); @@ -181,9 +174,10 @@ static void pmbus_wait(struct i2c_client *client) if (delay > 0) fsleep(delay); } +EXPORT_SYMBOL_NS_GPL(pmbus_wait, "PMBUS"); =20 /* Sets the last operation timestamp for pmbus_wait */ -static void pmbus_update_ts(struct i2c_client *client, int op) +void pmbus_update_ts(struct i2c_client *client, int op) { struct pmbus_data *data =3D i2c_get_clientdata(client); const struct pmbus_driver_info *info =3D data->info; @@ -197,6 +191,7 @@ static void pmbus_update_ts(struct i2c_client *client, = int op) if (delay > 0) data->next_access_backoff =3D ktime_add_us(ktime_get(), delay); } +EXPORT_SYMBOL_NS_GPL(pmbus_update_ts, "PMBUS"); =20 int pmbus_set_page(struct i2c_client *client, int page, int phase) { --=20 2.34.1