From nobody Thu Apr 9 10:29:37 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BE693BE16B for ; Mon, 9 Mar 2026 14:34:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773066893; cv=none; b=pqj9VK9qXvvl7rTqY60PIzeLoBe1uKKtDRASIVT7A4wh1YFNDf7nTpadmO3N4I5b/4xr83gw/RsKY9fYj8YJ4WV0TXOydKFlffak9sU1/WhjwOgeUYAtIZwsA065WAf6TzghvsBSeWsLeeBxADtBSKlfLjhEdSEeti0X3lmYf7c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773066893; c=relaxed/simple; bh=QgwdfBmJtLUH70M5vhjZqONdVk/cg4rv3tFR0/ljb+U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=AW9mzue2md7XiRyu73Wv7rVopNPEQR75gPIctOCgVXoT9qVLPAySTxXRsxnoRM63BSGL7R3KmgHW1YjjNQF5vSrakCoNONJKewbocv5jp4c68waKWXdSveM+dwJYXdax0Q5Bt+Pjv1xw5fVilSwbMyVwSakNSeZ84EUEa1AZlCU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=zhC0I1Rz; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="zhC0I1Rz" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4852af55981so116165e9.0 for ; Mon, 09 Mar 2026 07:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1773066890; x=1773671690; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=dGGuXh0JCx+P2zcPdhk2MDVsfn+ACpfwvVPqCyhcMyk=; b=zhC0I1Rz2CREas4rm33lIRnvYTJiroqRa74OmDTe54NkS9kxYu6fHwDvFiDR71Vqn6 O1Tnjjv3a2bTNt0yZLXGtZDPEp3ANenH/62rQAUyZp4XJH+1jAUnZKXJQnE6xDew4cPd nMVzE8pjHnCMO1icD46iNLQSbccuXzxvw5x7Nn/esIt/cAsf0VSp52iZ5Qen8xEi7EjZ wES7YmjITeFaT7qzmelrHUeHZdwhtYnQDwS7ucrii+AE2s2+tlI4lEeXr/p+JD9ZAV8r GHD4QbFzLddDNm0tU3zeQtkuYBq5cpgBtwYEEit2qLPJrmcfc4SKHAF6RLT44eHXwZwR zHzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773066890; x=1773671690; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dGGuXh0JCx+P2zcPdhk2MDVsfn+ACpfwvVPqCyhcMyk=; b=a2jfOZFPygdGypdBjrggQviEEvzyJEalF3bf4Tssbp+SHz3yxTAlt3s3bObp/17+5c riyVwY8raMaISQ5G38RlTSD31oOzVvrOrBt3FOdOFZTtLIXRMrr5AQ73jWKKU/faPzXc 7WhadYfjuDxBfXiBAV/xaFXj88bPsMnpHmKXVue24az7MxXCaAHkbPzxwAsRQir2AJkH 2iSq6tgCdoWREhY6X0CFE8v2iBQwXPMAbGFUjoH4fJMvwDv5585jGGrP9/feSUgjZ4kh gGd2b8X3opMOuXVw9uK6PnLklqWK/41stWvcJcxK1jrUYSAKbFjXaPSkQK6SnD3R+XjX WShA== X-Forwarded-Encrypted: i=1; AJvYcCU9D9HSX4WVQvTbooblghbKiOrKqqHRKPu+iTQ7efu8AJnoYG5h76aFZoaAoclwaZ2Y3QlEHZqgxlH2rSA=@vger.kernel.org X-Gm-Message-State: AOJu0YzGk4D856TYYE1DJSlhiXOOBRHjsIu7GCAcda7A4J01KYlgqjY9 WYzqBji1vHD1FroB293YUsi4KPCm1EkIU6z1+/Lz07dXSyXw+6vDp5JftP4Wf21cSeBDyXRKfW/ mnWDUHLUi X-Gm-Gg: ATEYQzx66zBbVC1bfMK0YByGFQZOUo6+inYcxcznklko9qM4fCj/bcwRODDX8Dr9YVd 8VsqqPMdlFAJNgPD9garimf29q60Yw5ruegH81H5DozGai1JoQoL96jY/EF+Z3YR7R3auuQbcsf mX2gJoi0H/EyR7nxxIPw1ZEzVctGIbE1Z5V/E4keABdhWqoGKUgTaJcOXb/HUfDnBiJiCu6PBrK zeHgGiq/T6v4jeaVuEQeuJx/XU9jC+SMBsjHnEtYZI5hURVSIvf9i5S+2Rjkq9WM1Va/eL2wADJ /E0NOcrune1OFLC+5HKZ11gO1Qp5+lXwyZW7J836SWKko0qLHiXDTNKlozrRZY3tubApkaRwf8W mUXO4cCEG2Gex4xgLjnJbjdJju+9ETv94E7Av555tT6hZEbeL8+wH1rklq1cDaNP3Q2CSKIfDFa h/p9xceNJNSbvymZ0vkhvfFTURRsUAk3sLgM+XxJpmr03SS9nlKzU= X-Received: by 2002:a05:600c:1554:b0:47e:dc0a:8591 with SMTP id 5b1f17b1804b1-4852cfd758dmr1893135e9.2.1773066889845; Mon, 09 Mar 2026 07:34:49 -0700 (PDT) Received: from localhost ([2a00:79e0:288a:8:bd49:6ea8:9b67:a5eb]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-439dad97da3sm29768749f8f.12.2026.03.09.07.34.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 07:34:49 -0700 (PDT) From: Jann Horn Date: Mon, 09 Mar 2026 15:34:41 +0100 Subject: [PATCH] io_uring/register: fix comment about task_no_new_privs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260309-uring-nnp-comment-fix-v1-1-e7d185527142@google.com> X-B4-Tracking: v=1; b=H4sIAIDarmkC/x2MSQqAMAwAvyI5G+gCBf2KeNA2ag7G0qoIxb9bP M7ATIFMiSlD3xRIdHPmQyrotgG/TbIScqgMRhmnrOrwSiwrikT0x76TnLjwgyZYOzvtidQEtY2 Jqv6/w/i+H1DzedJnAAAA X-Change-ID: 20260309-uring-nnp-comment-fix-2d33b61cee0a To: Jens Axboe Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, Jann Horn X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1773066884; l=1359; i=jannh@google.com; s=20240730; h=from:subject:message-id; bh=QgwdfBmJtLUH70M5vhjZqONdVk/cg4rv3tFR0/ljb+U=; b=4+sekabZaaVT5qrCP74I7jUNKoc0eDeDWPQkf2nfrXpQk7GSSKrYGsclZi6rUTk6YP8pUTPyP vKD9LTUK0LCCog+OR1xDf3+aJ0mayIV0755J8jZC/Zk2ZX97AMC1NBa X-Developer-Key: i=jannh@google.com; a=ed25519; pk=AljNtGOzXeF6khBXDJVVvwSEkVDGnnZZYqfWhP1V+C8= The actual code is right, but the comment is the wrong way around. Fixes: ed82f35b926b ("io_uring: allow registration of per-task restrictions= ") Signed-off-by: Jann Horn --- io_uring/register.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/io_uring/register.c b/io_uring/register.c index 6015a3e9ce69..3378014e51fb 100644 --- a/io_uring/register.c +++ b/io_uring/register.c @@ -202,7 +202,7 @@ static int io_register_restrictions_task(void __user *a= rg, unsigned int nr_args) return -EPERM; /* * Similar to seccomp, disallow setting a filter if task_no_new_privs - * is true and we're not CAP_SYS_ADMIN. + * is false and we're not CAP_SYS_ADMIN. */ if (!task_no_new_privs(current) && !ns_capable_noaudit(current_user_ns(), CAP_SYS_ADMIN)) @@ -238,7 +238,7 @@ static int io_register_bpf_filter_task(void __user *arg= , unsigned int nr_args) =20 /* * Similar to seccomp, disallow setting a filter if task_no_new_privs - * is true and we're not CAP_SYS_ADMIN. + * is false and we're not CAP_SYS_ADMIN. */ if (!task_no_new_privs(current) && !ns_capable_noaudit(current_user_ns(), CAP_SYS_ADMIN)) --- base-commit: 55a6202e7bbea301c06ad1bb0e18f7799cac383e change-id: 20260309-uring-nnp-comment-fix-2d33b61cee0a -- =20 Jann Horn