From nobody Thu Apr 9 09:36:50 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D37043CA4BE for ; Tue, 10 Mar 2026 04:09:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773115762; cv=none; b=HQKtwsyy/j3gxA9FcUflShupVWmuRPSBkulUNKSdvXmrL6ndFA0/+nKUG3W2HtKaadBnYgjPDPFdRTZwTj2hm35ADoshS+qjAm1feFtGdz295mkaoyebe7OwapTNy4eHRkxQS1VCFyYcrng2QRPaSgTlQqztnaInZdIOeII4Fww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773115762; c=relaxed/simple; bh=uTr8Ave//isAJhHfIzcKDULVkXYMBNmtFbD/mSWV4fI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nATlAyrdpBHynFg1/ztafWFyDR/aBkCgE7qZBK85oHdzpF/7MRhR8U7BNL28fNHxjU4aJK5D42M6bYkRZomCj1fXojMMQJlV891ytoy81H5ZcWQLrp+z6mBnob82TpQGa7B6sy4t2lRtyETSb10Y3j3TbdD2uPiXdheDlvlSnC8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pkf4ppJ8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LMCxunJe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pkf4ppJ8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LMCxunJe" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A2En9r111299 for ; Tue, 10 Mar 2026 04:09:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= X4n7Cm+zIgSF9DXpgX4rOaED2hMX3L5ub7hq9cR6BPw=; b=Pkf4ppJ80/hN3+D2 VXLAXWbkYELxbtichDrCeSbTxPVvJ/rd3y95oG3HT8wHAB2n4/XtWqRWLIpSAjCp yDLZDXKVWwEIPgTQjRkVdKBjtnLyEG6sqq2kn1Dzb6/tG5Else7k437mDeUI397n 4S85VPDYEMakSQz+GpMCHIhUc5mqTeXJe/TUWxTRpVklV6kPCiF9NLCEdnUuYD3g vtqvTEVVvJwvEoYY/3NrrREprpHEqedu14EDRQJrn3+rLMkZrgtY53wKwrcz+8ty 9DOvZs88IAa1QlPOyiGghwKvSfzsJYcBt9goPyXaH/7qw48rfAFGiWflBNX7KGxu uN8Mjw== Received: from mail-oa1-f72.google.com (mail-oa1-f72.google.com [209.85.160.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csv5ub688-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 04:09:18 +0000 (GMT) Received: by mail-oa1-f72.google.com with SMTP id 586e51a60fabf-40f09403c56so50861860fac.1 for ; Mon, 09 Mar 2026 21:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773115758; x=1773720558; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=X4n7Cm+zIgSF9DXpgX4rOaED2hMX3L5ub7hq9cR6BPw=; b=LMCxunJe27DjtQe9lgwT5SNn5uE3pQKCdafc5gorSt8GLoj8b3JpVXKHv+G6fPn+30 cgv8cZI6g/Pxw47hc9LKXqbn4QJm+JEAiifV8cHbBsboFoV/q7ysXJ4VPolnW31tmyQn huQuCsQhnAgQRHPnQdEObMAjFGTCRZNTKaAoxFmBTVqlIyWIik+OUDmMVT0PPFD/zCxY 2m+j0Qr2FnV+QBAYKUY8hiGY8Tfq4D1Dqzh4m6QX8R43folaRY917N3qBdQt5bVpCUbu myK6kzzlx0hoAVblWfQGcZXl2xszeWocLWmpKDWPsYc2ALTX6j0wsj+giW/TE/b5NmKF yEIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773115758; x=1773720558; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=X4n7Cm+zIgSF9DXpgX4rOaED2hMX3L5ub7hq9cR6BPw=; b=RnYrofqX9I3FO/qsLDSCibyHur6bZIfT+QXqipbdR9GRircwL7lVxOcOZBKdUvYJu2 bXREI6ONJsMuwesZacFz/uhNIVPCpham+ARF2jg9AnNRv5qBFN6ODC93R4xWwRyKIOHK /NW2tUMobIPcvqF3YFbDL5BMxzbtYd6RR3544pvdiIeUc5bYCxdqUx0ZxJYcMaVIDeDw /wfF8aec3CqoGEzSxdqvKLLaRoXFFyWsxc+0RbjoVRnQDQH3nZmvdmvXsuv/lEhK0oh0 rPPIL3P+j0A86TQ3S5AmX1jZiesguEr4KVcZpf2fcO1PSuA1IzH1/XCy7PazKOCFX6vo j7cA== X-Forwarded-Encrypted: i=1; AJvYcCXV2dG8UOkfXuvCWTUq07FsHUCIzmMa0ScGh3JBk2akZdk+GCyjyzAzEZHLtyTo+WCNUKFTNXbCvLKYmwQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyTcxLcu8Shbh613SbEXWqnX7ejv0JV+sJ92qv4sl7Pwp+WbOX+ kzsz9ClDWgoJTAdHx9BGKhsi+GIF5+VOrgORqnVwjcsa2qhzNbIvCqV2priffoxWflcFKzpK59x 3QLfVrilrCHpqmhDThpqGtGQocHOrLCirhJB9eIZQoEVRPV6yZUJZqEzK7np01dovs8I= X-Gm-Gg: ATEYQzxcrr5HwcYq4WMGeyINwp21MWABqiLbdeRZg1zjRPM9LKIFgUtv1GjRsrfByAd CcpAcsLyif5+fTMCGOMl7no82S/6o5bD4zW5GeCDZKDRPogH74tFf2fLPtYUOJ9phU9vRIyjGxA gQ8RbGQ2kpaWQO1a7zqHpvINJiU+8Opp0fKSk0DuaqMDji5QzjQ/4m1pIyiPkLt5VGWKq/0AlqJ M4JSYsU5lTiPZ/JkXNSQy2k0HuIkQddRvHf/rmt0x3CMlMXfu8blToXtcYYXxYxTmqThs+Dk8fr zTbccVgFEdM5M95tzMkTgYUALps7E1wyX/HGzrJ8SRs8CeeKR4RzQYf/9+osZIC4edqmK/OIhAN 0EgPBmfJ4IZByOn16xQ2pK9ccwxj+Qly5efgN5wUAs+0= X-Received: by 2002:a05:6870:21cb:b0:409:7ba2:c5fb with SMTP id 586e51a60fabf-41756a7eb7cmr1267534fac.17.1773115758334; Mon, 09 Mar 2026 21:09:18 -0700 (PDT) X-Received: by 2002:a05:6870:21cb:b0:409:7ba2:c5fb with SMTP id 586e51a60fabf-41756a7eb7cmr1267520fac.17.1773115757967; Mon, 09 Mar 2026 21:09:17 -0700 (PDT) Received: from [192.168.86.59] ([104.57.184.186]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-41756e24c39sm1595685fac.20.2026.03.09.21.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 21:09:17 -0700 (PDT) From: Bjorn Andersson Date: Mon, 09 Mar 2026 23:09:04 -0500 Subject: [PATCH 3/7] slimbus: qcom-ngd-ctrl: Correct PDR and SSR cleanup ownership Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260309-slim-ngd-dev-v1-3-5843e3ed62a3@oss.qualcomm.com> References: <20260309-slim-ngd-dev-v1-0-5843e3ed62a3@oss.qualcomm.com> In-Reply-To: <20260309-slim-ngd-dev-v1-0-5843e3ed62a3@oss.qualcomm.com> To: Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1557; i=bjorn.andersson@oss.qualcomm.com; h=from:subject:message-id; bh=uTr8Ave//isAJhHfIzcKDULVkXYMBNmtFbD/mSWV4fI=; b=owEBgwJ8/ZANAwAKAQsfOT8Nma3FAcsmYgBpr5lpHTscuk0HN9e86xo4yvw9zmInztm+IWgn5 ekAl1ly/CqJAkkEAAEKADMWIQQF3gPMXzXqTwlm1SULHzk/DZmtxQUCaa+ZaRUcYW5kZXJzc29u QGtlcm5lbC5vcmcACgkQCx85Pw2ZrcUBqhAAp5HJ3HE77j7SFIwR6eSX1rrYLjbZ7FQNtLoDyVm nGVZFsTgjK4L0YTpnTL88O2lAkJmsgwL/VkxTjI/Ord97RTXGTLYW2f7ekJH4k74RzZTPc4Bkss mkE1ma60Te5iPtqFTtP6qVpFJbrOIAswAl/LI7HwGOicQxWleT5CELlu87WnxY4As+wsYmFKaNP y0juECUpoNM8hZEne85QO1qbN9Iu3WMuCS0YMPHnWb/8rcyrVWIuXVIbz7T+dflxzxvxb19l32K AZFX5R9+f0AoBa6FDxbP7azp+BnxMwxC9eVdPGDPBGSeZJQ1m+qN8oefG4AbPfL91WTRh00X4qG A2JCG/cf/28JiZjcKePD7kxJY1Jjh96YhLb6yUIe5An2GHPxVZE7BoBWj+NyriOKn63jE/brdWT 6PaHN6Czyiwp4rZNG30cXDCHuqFVBLkdi49cmWFdj3VFR+W+ElfhDAx/1ZICEYueHf3IjNPwTg+ MNL/mzN86YkxAiN6P2KdJ0Vn1BMtRep0mLIcA2b7ITlkGSf0NXDuBZt8I8ximxJQM/SeSTTEAiU a/5gz2TSKne7thefnfm9llY3QWWGR9Qms/IBFB3nqhMghx3CWjXOUiqvAdxwpW8IK+SDdE4urLB j8FXUYZT4xhooNV8tXEtJf4fLrbCleEwbCPjCt5mqvt4= X-Developer-Key: i=bjorn.andersson@oss.qualcomm.com; a=openpgp; fpr=05DE03CC5F35EA4F0966D5250B1F393F0D99ADC5 X-Proofpoint-GUID: -0iHZTegYlkW6C1UVW0hjquqXZjaANxs X-Proofpoint-ORIG-GUID: -0iHZTegYlkW6C1UVW0hjquqXZjaANxs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDAzMSBTYWx0ZWRfXzwwdz3gx4dQK jFKKO7A+Rp+s0uuVwLOHKWBNwhdsAS4ENKHp3U0kho4/ft/2Fsa053IrM2RBrRJnIT5j8d5gs+h hItBwmPN87xuvEPsc4P8f1lRF17cVz4nWw3Qsxi9WWj8G2R9nxOOREiS2tXO2yQ8e/vP9eNZhzr tjNIyaQwWQtE1J/60cCo2KtEtf8MaJ+RJtJjIakSUvwZUWY08BvEt17e3RkjbR3Yd8n8IM6r6vE TYndQERg5bX9Vl6PLC//wKLcdDgMRZiggirbAtfMmGHz4qA1JMNRsmyjaJX0aIdKAmwTNDSqIiR wV8LyIdEaAsAnKGKqJw15sbisGW/PORzHubcbbR+YLMoXE8TraKzzyAIKjV95jzCpO78g7bge3d W8Qf/hIrqrvbdaYwBnPuO01OEV8UI8muTaDKDGhdKUOO/MdbA+Mdwdrax4yYb5HiGDtYTXF5rc4 W40U0YkINIIsIM6p1ug== X-Authority-Analysis: v=2.4 cv=Xr/3+FF9 c=1 sm=1 tr=0 ts=69af996e cx=c_pps a=Z3eh007fzM5o9awBa1HkYQ==:117 a=DaeiM5VmU20ml6RIjrOvYw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=v7zRpcr-n2crOtZbBgkA:9 a=QEXdDO2ut3YA:10 a=eBU8X_Hb5SQ8N-bgNfv4:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 spamscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100031 PDR and SSR callbacks are registred from the controller probe function, but currently released from the child device's remove function. In the next commit the controller probe function will be modified such that the error path will unregister the child device, resulting in a double free of these resources. Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver") Cc: stable@vger.kernel.org Signed-off-by: Bjorn Andersson Reviewed-by: Dmitry Baryshkov Reviewed-by: Mukesh Ojha --- drivers/slimbus/qcom-ngd-ctrl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index b34e727bab086c95dc7e760bf1141baac9ccf6a7..09ce3299e15c25b1b9cf6b15598= 50adf4aa20737 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1685,6 +1685,9 @@ static void qcom_slim_ngd_ctrl_remove(struct platform= _device *pdev) { struct qcom_slim_ngd_ctrl *ctrl =3D platform_get_drvdata(pdev); =20 + pdr_handle_release(ctrl->pdr); + qcom_unregister_ssr_notifier(ctrl->notifier, &ctrl->nb); + qcom_slim_ngd_unregister(ctrl); } =20 @@ -1693,8 +1696,6 @@ static void qcom_slim_ngd_remove(struct platform_devi= ce *pdev) struct qcom_slim_ngd_ctrl *ctrl =3D platform_get_drvdata(pdev); =20 pm_runtime_disable(&pdev->dev); - pdr_handle_release(ctrl->pdr); - qcom_unregister_ssr_notifier(ctrl->notifier, &ctrl->nb); qcom_slim_ngd_enable(ctrl, false); qcom_slim_ngd_exit_dma(ctrl); qcom_slim_ngd_qmi_svc_event_deinit(&ctrl->qmi); --=20 2.51.0